New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bleadperl v5.21.0-129-g8dab3ba breaks MLEHMANN/Guard-1.022.tar.gz #13903
Comments
From @andkgit bisect commit 8dab3ba Remove deprecated 'PL_sv_objcount' diagnostics cc -c -D_REENTRANT -D_GNU_SOURCE -fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -g -DVERSION=\"1.022\" -DXS_VERSION=\"1.022\" -fPIC "-I/home/sand/src/perl/repoperls/installed-perls/perl/v5.21.0-129-g8dab3ba/9980/lib/5.21.1/x86_64-linux-thread-multi/CORE" Guard.c perl -V Summary of my perl5 (revision 5 version 21 subversion 1) configuration: Commit id: 8dab3ba Platform: osname=linux, osvers=3.13-1-amd64, archname=x86_64-linux-thread-multi uname='linux k83 3.13-1-amd64 #1 smp debian 3.13.7-1 (2014-03-25) x86_64 gnulinux ' config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/perl/v5.21.0-129-g8dab3ba/9980 -Dmyhostname=k83 -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Duseithreads -Uuselongdouble -DDEBUGGING=-g' Characteristics of this binary (from libperl): -- |
From @tseeOn 06/04/2014 03:05 AM, (Andreas J. Koenig) (via RT) wrote:
The fix for this one is literally just to remove that line of code. IIRC --Steffen |
The RT System itself - Status changed from 'new' to 'open' |
From @rjbsI'm happy to pass along any tested patch downstream. -- |
From @andkalso affected: CREAMYG/KinoSearch-0.315.tar.gz |
From @rurbanOn Wed Jun 04 00:40:25 2014, smueller@cpan.org wrote:
Let's explain it like this: Inline Patch--- ./Guard.xs~ 2009-07-18 23:58:41.000000000 -0500
+++ ./Guard.xs 2014-06-27 10:18:45.821008691 -0500
@@ -110,7 +110,9 @@
sv_magicext (guard, cv, PERL_MAGIC_ext, &guard_vtbl, 0, 0);
RETVAL = newRV_noinc (guard);
SvOBJECT_on (guard);
+#if PERL_VERSION < 18
++PL_sv_objcount;
+#endif
SvSTASH_set (guard, (HV*)SvREFCNT_inc ((SV *)guard_stash));
}
OUTPUT:
5.21 removed now the variable at all, so that's why you get this error only now. -- |
From @andkAlso affected: IBB/Acme-Damn-0.05.tar.gz | https://rt.cpan.org/Ticket/Display.html?id=96872 -- |
From @jkeenanOn Tue Jul 01 17:49:10 2014, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
I have submitted a patch for Acme-Damn at https://rt.cpan.org/Ticket/Display.html?id=96872. |
From @karenetheridgeOn Fri, Jun 27, 2014 at 08:25:31AM -0700, Reini Urban via RT wrote:
Having encountered this problem while trying to install |
From @andkPerlpolicy says this about backwards incompatibility: Generally, backward incompatible changes will have deprecation It should be noted that the compilation of Guard.xs did not produce a Are there pressing needs or is it cheap? If the latter, please consider -- |
From @tonycozOn Thu Aug 28 19:54:52 2014, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
It was documented as deprecated in 5.18.0: =head2 PL_sv_objcount This interpreter-global variable used to track the total number of So it did have a deprecation cycle. We could look at adding a mechanism for deprecating interpreter and global variables, but I'm not sure it's worth it for something we've rarely* done. Tony *I think |
From @jkeenanOn Tue Jul 01 19:02:19 2014, jkeenan wrote:
The maintainer of Acme-Damn has corrected the problem. See: https://rt.cpan.org/Ticket/Display.html?id=96872 -- |
From @rjbsThis has been fixed downstream. It would have been nice to have a warning about this during compilation, but as Tony C. said, the cost may have been prohibitive. This is yet more evidence that what we need is a revamped set of compatibility guarantees for the XS layer, which is very much a free-for-all where everybody gets to feel badly about any changes made. -- |
@rjbs - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#122031 (status was 'resolved')
Searchable as RT122031$
The text was updated successfully, but these errors were encountered: