Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl v5.19.7-189-ga2287a1 breaks MARKOV/Log-Report-1.02.tar.gz on German locale #13868

Closed
p5pRT opened this issue May 21, 2014 · 6 comments

Comments

@p5pRT
Copy link

p5pRT commented May 21, 2014

Migrated from rt.perl.org#121941 (status was 'rejected')

Searchable as RT121941$

@p5pRT
Copy link
Author

p5pRT commented May 21, 2014

From @andk

git bisect


commit a2287a1
Author​: Karl Williamson <public@​khwilliamson.com>
Date​: Mon Dec 16 22​:34​:19 2013 -0700

  Use new macros to make sure LC_NUMERIC is correctly set

(As usual, I'm not implying this is a bug in perl, I just want to have
all your eyeballs look at it and come to conclusions)

diagnostics


http​://www.cpantesters.org/cpan/report/41881581

(I could reproduce the fail with LANG=de_DE.UTF-8 on Debian sid)

perl -V


Summary of my perl5 (revision 5 version 19 subversion 11) configuration​:
 
  Platform​:
  osname=freebsd, osvers=9.2-release, archname=amd64-freebsd
  uname='freebsd cvrsnica-freebsd-92-ctps-51911.herceg.de 9.2-release freebsd 9.2-release #0 r255898​: thu sep 26 22​:50​:31 utc 2013 root@​bake.isc.freebsd.org​:usrobjusrsrcsysgeneric amd64 '
  config_args='-ds -e -Uversiononly -Dinstallusrbinperl=n -Dusedevel -Dprefix=/home/eserte/var/ctps/51911/install/perl-5.19.11'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=undef, usemultiplicity=undef
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include',
  optimize='-O',
  cppflags='-DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.2.1 20070831 patched [FreeBSD]', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags ='-Wl,-E -fstack-protector -L/usr/local/lib'
  libpth=/usr/lib /usr/local/lib /usr/include/gcc/4.2 /usr/lib
  libs=-lgdbm -lm -lcrypt -lutil -lc
  perllibs=-lm -lcrypt -lutil -lc
  libc=, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version=''
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags=' '
  cccdlflags='-DPIC -fPIC', lddlflags='-shared -L/usr/local/lib -fstack-protector'

Characteristics of this binary (from libperl)​:
  Compile-time options​: HAS_TIMES PERLIO_LAYERS PERL_DONT_CREATE_GVSV
  PERL_HASH_FUNC_ONE_AT_A_TIME_HARD PERL_MALLOC_WRAP
  PERL_NEW_COPY_ON_WRITE PERL_PRESERVE_IVUV
  PERL_USE_DEVEL USE_64_BIT_ALL USE_64_BIT_INT
  USE_LARGE_FILES USE_LOCALE USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE USE_LOCALE_NUMERIC USE_PERLIO
  USE_PERL_ATOF
  Built under freebsd
  Compiled at Apr 25 2014 08​:05​:33
  %ENV​:
  PERL5LIB=""
  PERL5OPT=""
  PERL5_CPANPLUS_IS_RUNNING="89605"
  PERL5_CPAN_IS_RUNNING="89605"
  PERL5_CPAN_IS_RUNNING_IN_RECURSION="89579,89605"
  PERLDOC="-MPod​::Perldoc​::ToTextOverstrike"
  PERL_BATCH="yes"
  PERL_CPAN_REPORTER_DIR="/home/eserte/var/ctps/51911/config/perl-5.19.11/cpanreporter"
  PERL_EXTUTILS_AUTOINSTALL="--defaultdeps"
  PERL_HTML_DISPLAY_CLASS="HTML​::Display​::Mozilla"
  PERL_PARALLEL_SMOKER="yes"
  @​INC​:
  /home/eserte/var/ctps/51911/install/perl-5.19.11/lib/site_perl/5.19.11/amd64-freebsd
  /home/eserte/var/ctps/51911/install/perl-5.19.11/lib/site_perl/5.19.11
  /home/eserte/var/ctps/51911/install/perl-5.19.11/lib/5.19.11/amd64-freebsd
  /home/eserte/var/ctps/51911/install/perl-5.19.11/lib/5.19.11
  .

--
andreas

@p5pRT
Copy link
Author

p5pRT commented May 22, 2014

From @khwilliamson

On 05/21/2014 03​:01 PM, (Andreas J. Koenig) (via RT) wrote​:

# New Ticket Created by (Andreas J. Koenig)
# Please include the string​: [perl #121941]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=121941 >

git bisect
----------
commit a2287a1
Author​: Karl Williamson <public@​khwilliamson.com>
Date​: Mon Dec 16 22​:34​:19 2013 -0700

 Use new macros to make sure LC\_NUMERIC is correctly set

(As usual, I'm not implying this is a bug in perl, I just want to have
all your eyeballs look at it and come to conclusions)

diagnostics
-----------
http​://www.cpantesters.org/cpan/report/41881581

(I could reproduce the fail with LANG=de_DE.UTF-8 on Debian sid)

With the research I've done, I believe that the test is wrong, and the
blamed commit actually did a bug fix for this module.

What is happening is that the German locale has a comma for a radix, and
the test is testing for a dot. Until this commit, a dot was output, but
I think that the comma is the correct output.

A brief look at the documentation of this module indicates that it is
trying to include language specific things in its output. To do so it
overloads various operators, and the test that is failing is using that
overloading. I set a breakpoint at the place in the Perl core where the
decision is made to output a dot or whatever the locale calls for (a
comma in the German case). Since the blamed commit, it checks to see if
the call is within the scope of 'use locale', and if so uses the locale
radix character. gdb confirmed that CopHINTS_get(PL_curcop) says that
we are considered to be within such scope. Hence we chose the locale
radix character, which is a comma.

I think therefore that this is not a bug in the Perl core, but am
copying the module's maintainer on this email for his reaction.

@p5pRT
Copy link
Author

p5pRT commented May 22, 2014

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Jun 27, 2014

From @khwilliamson

No response in over a month, so I'm closing the ticket--
Karl Williamson

@p5pRT
Copy link
Author

p5pRT commented Jun 27, 2014

@khwilliamson - Status changed from 'open' to 'rejected'

@p5pRT p5pRT closed this as completed Jun 27, 2014
@p5pRT
Copy link
Author

p5pRT commented Jun 27, 2014

From @andk

On Thu, 26 Jun 2014 17​:20​:18 -0700, "Karl Williamson via RT" <perlbug-followup@​perl.org> said​:

  > No response in over a month, so I'm closing the ticket--

Endorsed. Background​: Log-Report had releases 1.03, 1.04, and 1.05 since
then and the locale issue seemd to have been ironed out in the module.

--
andreas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant