[PATCH] add union & bitfield to sv_flags for easier dump analysis #13864
Comments
From @bulk88Created by @bulk88See attached patch. Perl Info |
From @bulk880001-add-union-bitfield-to-sv_flags-for-easier-dump-analy.patchFrom a0d45eb0495c33b3cba0a71c1e67787af30a6352 Mon Sep 17 00:00:00 2001
From: Daniel Dragan <bulk88@hotmail.com>
Date: Tue, 20 May 2014 18:58:22 -0400
Subject: [PATCH] add union & bitfield to sv_flags for easier dump analysis
Calling Perl_dump_sv from a C debugger on demand on a SV* is not always
possible, if all threads in the process are frozen, it segv'ed or is a
dump file (not a process), or PerlIO/interp struct is in a partial state
and can't print to the console. So create this bitfield on compilers that
support anon unions to make looking at the sv head easier.
---
sv.h | 41 ++++++++++++++++++++++++++++++++++++++++-
win32/win32.h | 2 ++
2 files changed, 42 insertions(+), 1 deletions(-)
diff --git a/sv.h b/sv.h
index 6332974..495b315 100644
--- a/sv.h
+++ b/sv.h
@@ -186,10 +186,46 @@ typedef struct hek HEK;
/* Using C's structural equivalence to help emulate C++ inheritance here... */
/* start with 2 sv-head building blocks */
-#define _SV_HEAD(ptrtype) \
+#ifndef HAS_ANONFIELDS
+# define _SV_HEAD(ptrtype) \
ptrtype sv_any; /* pointer to body */ \
U32 sv_refcnt; /* how many references to us */ \
U32 sv_flags /* what we are */
+#else
+# define _SV_HEAD(ptrtype) \
+ ptrtype sv_any; /* pointer to body */ \
+ U32 sv_refcnt; /* how many references to us */ \
+ union {\
+ U32 sv_flags; /* what we are */ \
+ struct { \
+ unsigned long type : 8; \
+ unsigned long f_IOK : 1; \
+ unsigned long f_NOK : 1; \
+ unsigned long f_POK : 1; \
+ unsigned long f_ROK : 1; \
+ unsigned long p_IOK: 1; \
+ unsigned long p_NOK: 1; \
+ unsigned long p_POK : 1; \
+ unsigned long p_SCREAM_phv_CLONEABLE_pgv_GP_prv_PCS_IMPORTED_pad_NAMELIST : 1; \
+ unsigned long f_IsCOW : 1; \
+ unsigned long s_PADTMP_s_PADSTALE_pad_TYPED : 1; \
+ unsigned long s_PADMY_pad_OUR : 1; \
+ unsigned long s_TEMP : 1; \
+ unsigned long s_OBJECT : 1; \
+ unsigned long s_GMG : 1; \
+ unsigned long s_SMG : 1; \
+ unsigned long s_RMG : 1; \
+ unsigned long f_FAKE : 1; \
+ unsigned long f_OOK : 1; \
+ unsigned long f_BREAK: 1; \
+ unsigned long f_READONLY : 1; \
+ unsigned long f_AMAGIC : 1; \
+ unsigned long f_UTF8_phv_SHAREKEYS : 1; \
+ unsigned long pav_REAL_phv_LAZYDEL_pbm_VALID_repl_EVAL : 1; \
+ unsigned long f_IVisUV_pav_REIFY_phv_HASKFLAGS_pbm_TAIL_prv_WEAKREF_pad_STATE : 1; \
+ } flags_dbg; \
+ }
+#endif
#define _SV_HEAD_UNION \
union { \
@@ -346,6 +382,9 @@ perform the upgrade if necessary. See C<svtype>.
#define SvUPGRADE(sv, mt) \
((void)(SvTYPE(sv) >= (mt) || (sv_upgrade(sv, mt),1)))
+
+/* *** If you edit any flags remember to update the bitfield above *** */
+
#define SVf_IOK 0x00000100 /* has valid public integer value */
#define SVf_NOK 0x00000200 /* has valid public numeric value */
#define SVf_POK 0x00000400 /* has valid public pointer value */
diff --git a/win32/win32.h b/win32/win32.h
index 8db0303..bfb276f 100644
--- a/win32/win32.h
+++ b/win32/win32.h
@@ -264,6 +264,8 @@ typedef unsigned short mode_t;
# pragma intrinsic(_rotl64,_rotr64)
#endif
+#define HAS_ANONFIELDS
+
#endif /* _MSC_VER */
#ifdef __MINGW32__ /* Minimal Gnu-Win32 */
--
1.7.9.msysgit.0
|
From @bulk88Better patch attached, purpose of the BF is now in src. -- |
From @bulk880001-add-union-bitfield-to-sv_flags-for-easier-dump-analy.patchFrom 5a929075ff177c67e0597757bd279eb28725f7ae Mon Sep 17 00:00:00 2001
From: Daniel Dragan <bulk88@hotmail.com>
Date: Tue, 20 May 2014 19:14:27 -0400
Subject: [PATCH] add union & bitfield to sv_flags for easier dump analysis
Calling Perl_dump_sv from a C debugger on demand on a SV* is not always
possible, if all threads in the process are frozen, it segv'ed or is a
dump file (not a process), or PerlIO/interp struct is in a partial state
and can't print to the console. So create this bitfield on compilers that
support anon unions to make looking at the sv head easier. I expect more
compiler will enable HAS_ANONFIELDS on them in the future.
---
sv.h | 43 ++++++++++++++++++++++++++++++++++++++++++-
win32/win32.h | 2 ++
2 files changed, 44 insertions(+), 1 deletions(-)
diff --git a/sv.h b/sv.h
index 6332974..1ccb06c 100644
--- a/sv.h
+++ b/sv.h
@@ -186,10 +186,48 @@ typedef struct hek HEK;
/* Using C's structural equivalence to help emulate C++ inheritance here... */
/* start with 2 sv-head building blocks */
-#define _SV_HEAD(ptrtype) \
+#ifndef HAS_ANONFIELDS
+# define _SV_HEAD(ptrtype) \
ptrtype sv_any; /* pointer to body */ \
U32 sv_refcnt; /* how many references to us */ \
U32 sv_flags /* what we are */
+#else
+# define _SV_HEAD(ptrtype) \
+ ptrtype sv_any; /* pointer to body */ \
+ U32 sv_refcnt; /* how many references to us */ \
+ union {\
+ U32 sv_flags; /* what we are */ \
+ /* NEVER USE THE BITFIELD, its strictly for C debugger tools */ \
+ struct { \
+ unsigned long type : 8; \
+ unsigned long f_IOK : 1; \
+ unsigned long f_NOK : 1; \
+ unsigned long f_POK : 1; \
+ unsigned long f_ROK : 1; \
+ unsigned long p_IOK: 1; \
+ unsigned long p_NOK: 1; \
+ unsigned long p_POK : 1; \
+ unsigned long p_SCREAM_phv_CLONEABLE_pgv_GP_prv_PCS_IMPORTED_pad_NAMELIST : 1; \
+ unsigned long f_IsCOW : 1; \
+ unsigned long s_PADTMP_s_PADSTALE_pad_TYPED : 1; \
+ unsigned long s_PADMY_pad_OUR : 1; \
+ unsigned long s_TEMP : 1; \
+ unsigned long s_OBJECT : 1; \
+ unsigned long s_GMG : 1; \
+ unsigned long s_SMG : 1; \
+ unsigned long s_RMG : 1; \
+ unsigned long f_FAKE : 1; \
+ unsigned long f_OOK : 1; \
+ unsigned long f_BREAK: 1; \
+ unsigned long f_READONLY : 1; \
+ unsigned long f_AMAGIC : 1; \
+ unsigned long f_UTF8_phv_SHAREKEYS : 1; \
+ unsigned long pav_REAL_phv_LAZYDEL_pbm_VALID_repl_EVAL : 1; \
+ unsigned long f_IVisUV_pav_REIFY_phv_HASKFLAGS_pbm_TAIL_prv_WEAKREF_pad_STATE : 1; \
+ } flags_dbg; \
+ /* NEVER USE THE BITFIELD, its strictly for C debugger tools */ \
+ }
+#endif
#define _SV_HEAD_UNION \
union { \
@@ -346,6 +384,9 @@ perform the upgrade if necessary. See C<svtype>.
#define SvUPGRADE(sv, mt) \
((void)(SvTYPE(sv) >= (mt) || (sv_upgrade(sv, mt),1)))
+
+/* *** If you edit any flags remember to update the bitfield above *** */
+
#define SVf_IOK 0x00000100 /* has valid public integer value */
#define SVf_NOK 0x00000200 /* has valid public numeric value */
#define SVf_POK 0x00000400 /* has valid public pointer value */
diff --git a/win32/win32.h b/win32/win32.h
index 8db0303..bfb276f 100644
--- a/win32/win32.h
+++ b/win32/win32.h
@@ -264,6 +264,8 @@ typedef unsigned short mode_t;
# pragma intrinsic(_rotl64,_rotr64)
#endif
+#define HAS_ANONFIELDS
+
#endif /* _MSC_VER */
#ifdef __MINGW32__ /* Minimal Gnu-Win32 */
--
1.7.9.msysgit.0
|
From @bulk88On Tue May 20 16:03:31 2014, bulk88 wrote:
Revised patched attached, tests + more features. -- |
From @bulk880001-add-unions-bitfield-to-SV-for-easier-dump-analysis.patchFrom 06d5c566f02a03a0d075e33bf90f137b7bb0d102 Mon Sep 17 00:00:00 2001
From: Daniel Dragan <bulk88@hotmail.com>
Date: Mon, 26 May 2014 04:10:48 -0400
Subject: [PATCH] add unions & bitfield to SV for easier dump analysis
Calling Perl_dump_sv from a C debugger on demand on a SV* is not always
possible, if all threads in the process are frozen, it segv'ed or is a
dump file (not a process), or PerlIO/interp struct is in a partial state
and can't print to the console. So create this bitfield and any union
on compilers that support anon unions to make looking at the sv head
and body easier. I expect more compiler will enable HAS_ANONFIELDS
on them in the future. This code was written to be particularly
useful with MS VS IDE's C debugger.
---
ext/XS-APItest/APItest.pm | 2 +-
ext/XS-APItest/APItest.xs | 24 +++++++++++++++++
ext/XS-APItest/t/svpv.t | 4 ++-
sv.h | 61 ++++++++++++++++++++++++++++++++++++++++++++-
win32/win32.h | 2 +
5 files changed, 90 insertions(+), 3 deletions(-)
diff --git a/ext/XS-APItest/APItest.pm b/ext/XS-APItest/APItest.pm
index 8c72b35..e17e263 100644
--- a/ext/XS-APItest/APItest.pm
+++ b/ext/XS-APItest/APItest.pm
@@ -5,7 +5,7 @@ use strict;
use warnings;
use Carp;
-our $VERSION = '0.60';
+our $VERSION = '0.61';
require XSLoader;
diff --git a/ext/XS-APItest/APItest.xs b/ext/XS-APItest/APItest.xs
index a51924d..5b6d341 100644
--- a/ext/XS-APItest/APItest.xs
+++ b/ext/XS-APItest/APItest.xs
@@ -1777,6 +1777,30 @@ xop_from_custom_op ()
OUTPUT:
RETVAL
+bool
+test_sv_debug_members()
+CODE:
+#ifdef HAS_ANONFIELDS
+ if(STRUCT_OFFSET(SV,sv_any) == STRUCT_OFFSET(SV,any_dbg._1_5iv)) {
+ SV * sv = newSV(0);
+ if(!cBOOL(SvTEMP(sv)) && !sv->flags_dbg.s_TEMP) {
+ sv_2mortal(sv);
+ if(cBOOL(SvTEMP(sv)) && sv->flags_dbg.s_TEMP){
+ RETVAL = TRUE;
+ goto end;
+ }
+ } else { /* has to be freed even if failed */
+ sv_2mortal(sv);
+ }
+ }
+ RETVAL = FALSE;
+#else
+ RETVAL = TRUE; /* nothing to test, members don't exist */
+#endif
+ end:
+OUTPUT:
+ RETVAL
+
BOOT:
{
MY_CXT_INIT;
diff --git a/ext/XS-APItest/t/svpv.t b/ext/XS-APItest/t/svpv.t
index 4602891..45fd71f 100644
--- a/ext/XS-APItest/t/svpv.t
+++ b/ext/XS-APItest/t/svpv.t
@@ -1,9 +1,11 @@
#!perl -w
-use Test::More tests => 19;
+use Test::More tests => 20;
use XS::APItest;
+ok(XS::APItest::test_sv_debug_members(), "debugging SV union members work");
+
for my $func ('SvPVbyte', 'SvPVutf8') {
$g = *glob;
$r = \1;
diff --git a/sv.h b/sv.h
index 6332974..dcbd040 100644
--- a/sv.h
+++ b/sv.h
@@ -186,10 +186,66 @@ typedef struct hek HEK;
/* Using C's structural equivalence to help emulate C++ inheritance here... */
/* start with 2 sv-head building blocks */
-#define _SV_HEAD(ptrtype) \
+#ifndef HAS_ANONFIELDS
+# define _SV_HEAD(ptrtype) \
ptrtype sv_any; /* pointer to body */ \
U32 sv_refcnt; /* how many references to us */ \
U32 sv_flags /* what we are */
+#else
+# define _SV_HEAD(ptrtype) \
+ union { \
+ ptrtype sv_any; /* pointer to body */ \
+ /* for use with a C debugger, numbers correspond to svtype */ \
+ union { \
+ XPVIV * _1_5iv; \
+ XPVNV * _2_6nv; \
+ XPV * _3pv; \
+ XINVLIST * _4invl; \
+ XPVMG * _7mg; \
+ struct regexp *_8rx;\
+ XPVGV * _9gv; \
+ XPVLV * _10lv; \
+ XPVAV * _11av; \
+ XPVHV * _12hv; \
+ XPVCV * _13cv; \
+ XPVFM * _14fm; \
+ XPVIO * _15io; \
+ } any_dbg; \
+ }; \
+ U32 sv_refcnt; /* how many references to us */ \
+ union {\
+ U32 sv_flags; /* what we are */ \
+ /* NEVER USE THE BITFIELD, its strictly for C debugger tools */ \
+ struct { \
+ unsigned long type : 8; \
+ unsigned long f_IOK : 1; \
+ unsigned long f_NOK : 1; \
+ unsigned long f_POK : 1; \
+ unsigned long f_ROK : 1; \
+ unsigned long p_IOK: 1; \
+ unsigned long p_NOK: 1; \
+ unsigned long p_POK : 1; \
+ unsigned long p_SCREAM_phv_CLONEABLE_pgv_GP_prv_PCS_IMPORTED_pad_NAMELIST : 1; \
+ unsigned long f_IsCOW : 1; \
+ unsigned long s_PADTMP_s_PADSTALE_pad_TYPED : 1; \
+ unsigned long s_PADMY_pad_OUR : 1; \
+ unsigned long s_TEMP : 1; \
+ unsigned long s_OBJECT : 1; \
+ unsigned long s_GMG : 1; \
+ unsigned long s_SMG : 1; \
+ unsigned long s_RMG : 1; \
+ unsigned long f_FAKE : 1; \
+ unsigned long f_OOK : 1; \
+ unsigned long f_BREAK: 1; \
+ unsigned long f_READONLY : 1; \
+ unsigned long f_AMAGIC : 1; \
+ unsigned long f_UTF8_phv_SHAREKEYS : 1; \
+ unsigned long pav_REAL_phv_LAZYDEL_pbm_VALID_repl_EVAL : 1; \
+ unsigned long f_IVisUV_pav_REIFY_phv_HASKFLAGS_pbm_TAIL_prv_WEAKREF_pad_STATE : 1; \
+ } flags_dbg; \
+ /* NEVER USE THE BITFIELD, its strictly for C debugger tools */ \
+ }
+#endif
#define _SV_HEAD_UNION \
union { \
@@ -346,6 +402,9 @@ perform the upgrade if necessary. See C<svtype>.
#define SvUPGRADE(sv, mt) \
((void)(SvTYPE(sv) >= (mt) || (sv_upgrade(sv, mt),1)))
+
+/* *** If you edit any flags remember to update the bitfield above *** */
+
#define SVf_IOK 0x00000100 /* has valid public integer value */
#define SVf_NOK 0x00000200 /* has valid public numeric value */
#define SVf_POK 0x00000400 /* has valid public pointer value */
diff --git a/win32/win32.h b/win32/win32.h
index 8db0303..bfb276f 100644
--- a/win32/win32.h
+++ b/win32/win32.h
@@ -264,6 +264,8 @@ typedef unsigned short mode_t;
# pragma intrinsic(_rotl64,_rotr64)
#endif
+#define HAS_ANONFIELDS
+
#endif /* _MSC_VER */
#ifdef __MINGW32__ /* Minimal Gnu-Win32 */
--
1.7.9.msysgit.0
|
From @iabynOn Mon, May 26, 2014 at 01:14:01AM -0700, bulk88 via RT wrote:
Sorry, but I'm going to have to say that I don't like this idea. While I like the idea of debuggers being able to display the bits of -- |
|
The RT System itself - Status changed from 'new' to 'open' |
From @nwc10On Tue, May 27, 2014 at 12:24:16PM +0100, Dave Mitchell wrote:
I can't remember how much flexibility implementations have as to which way This is gcc on Linux: $ ./bitfield This is gcc on Linux: $ ./bitfield (One is x86_64, one is ppc64) So there would need to be (at least) two bitfield layouts provided to match Test program attached. I think that that makes the currently proposed approach a non-starter. There might be a way to do this, with one master source and regen scripts, Nicholas Clark |
From @nwc10#include <stdio.h>
#include <stdint.h>
union test {
int32_t i;
struct {
int low : 1;
int middle : 30;
int high : 1;
} s;
} t;
void state() {
printf("i = 0x%08x, low=%-10u, middle=%-10u, high=%-10u\n",
t.i, t.s.low, t.s.middle, t.s.high);
}
int main() {
t.i = 0;
state();
t.s.low = 1;
state();
t.s.high = 1;
state();
t.s.low = 0;
state();
return 0;
} |
From @TuxOn Wed, 4 Jun 2014 15:37:37 +0100, Nicholas Clark <nick@ccl4.org> wrote:
AIX 5.3.0.0/ML12 IBM,9115-505 PowerPC_POWER5/1898(2) xlc/64 i = 0x00000000, low=0 , middle=0 , high=0 gcc/64 i = 0x00000000, low=0 , middle=0 , high=0 HP-UX 11.31/64 U rx2660/64 Itanium 2 9100/1710(2) ia64 4075 Mb HP C-ANSI-C/64 i = 0x00000000, low=0 , middle=0 , high=0 gcc/64 i = 0x00000000, low=0 , middle=0 , high=0 HP-UX 11.23/64 U rx1620/64 Itanium 2/1600(2) ia64 2037 Mb HP C-ANSI-C/64 i = 0x00000000, low=0 , middle=0 , high=0 gcc/64 i = 0x00000000, low=0 , middle=0 , high=0 HP-UX 11.11/64 U rp3410/64 PA8800/800(2) pa-2.0 4094 Mb HP C-ANSI-C/64 gcc/64 i = 0x00000000, low=0 , middle=0 , high=0
Make that at least three :)
-- |
From @tonycozOn Mon May 26 01:14:00 2014, bulk88 wrote:
Based on the discussion (and I don't like it either), I'm rejecting this patch, and since the ticket is about the patch, the ticket. Tony |
|
@tonycoz - Status changed from 'open' to 'rejected' |
Migrated from rt.perl.org#121932 (status was 'rejected')
Searchable as RT121932$
The text was updated successfully, but these errors were encountered: