--- Storable.xs.orig	2014-05-20 14:35:36.175918558 -0500
+++ Storable.xs	2014-05-20 14:33:14.595919745 -0500
@@ -3011,6 +3011,10 @@
 	 */
 
 	if (!count) {
+		/* free empty list returned by the hook */
+		av_undef(av);
+		sv_free((SV *) av);
+		
 		/*
 		 * They must not change their mind in the middle of a serialization.
 		 */

From 2b8ff1ba4985ae0825effa13c6b14116aaa8919e Mon Sep 17 00:00:00 2001
From: Alex Solovey <a.solovey@gmail.com>
Date: Wed, 21 May 2014 16:27:14 +1000
Subject: [PATCH 1/2] Memory leak in Storable::dclone with STORABLE_freeze
 hook

Storable documentation recommends using dclone shortcut in
STORABLE_freeze hook: "Unless you know better, serializing hook should
always say:
                sub STORABLE_freeze {
                    my ($self, $cloning) = @_;
                    return if $cloning; # Regular default serialization
                    ....
                }

            in order to keep reasonable dclone() semantics."

However, this causes a memory leak which is easy to observe with the
following small script:

=== storable-leak.plx ===
use Storable qw( dclone );

package Foo {
     sub new { return bless {}, __PACKAGE__ }

     sub STORABLE_freeze {
         my( $self, $cloning ) = @_;
         # Switch to regular default serialization results in memory leak
         return if $cloning;
         return 'Foo';
     }
}

my $d = Foo->new();
while(1)
{
     dclone( $d );
}
===

The leak is caused by missing cleanup of empty array value returned by
the hook. I've attached a simple patch for Storable-2.45 which fixes
this issue.

Reported in [perl #121928]
---
 AUTHORS                   |    1 +
 dist/Storable/Storable.xs |    4 ++++
 2 files changed, 5 insertions(+)

diff --git a/AUTHORS b/AUTHORS
index 568c497..c59cefc 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -54,6 +54,7 @@ Alexander Voronov		<alexander-voronov@yandex.ru>
 Alexei Alexandrov		<alexei.alexandrov@gmail.com>
 Alex Davies			<adavies@ptc.com>
 Alex Gough			<alex@rcon.org>
+Alex Solovey			<a.solovey@gmail.com>
 Alex Vandiver			<alexmv@mit.edu>
 Alex Waugh			<alex@alexwaugh.com>
 Alexander Bluhm			<alexander_bluhm@genua.de>
diff --git a/dist/Storable/Storable.xs b/dist/Storable/Storable.xs
index 9b55b50..9c13e33 100644
--- a/dist/Storable/Storable.xs
+++ b/dist/Storable/Storable.xs
@@ -3052,6 +3052,10 @@ static int store_hook(
 	 */
 
 	if (!count) {
+		/* free empty list returned by the hook */
+		av_undef(av);
+		sv_free((SV *) av);
+		
 		/*
 		 * They must not change their mind in the middle of a serialization.
 		 */
-- 
1.7.10.4