Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl breaks NI-S/Math-Rand48-1.00.tar.gz #13839

Closed
p5pRT opened this issue May 15, 2014 · 7 comments
Closed

Bleadperl breaks NI-S/Math-Rand48-1.00.tar.gz #13839

p5pRT opened this issue May 15, 2014 · 7 comments

Comments

@p5pRT
Copy link

p5pRT commented May 15, 2014

Migrated from rt.perl.org#121874 (status was 'resolved')

Searchable as RT121874$

@p5pRT
Copy link
Author

p5pRT commented May 15, 2014

From @andk

left over from


https://rt-archive.perl.org/perl5/Ticket/Display.html?id=115910

discussed also at


https://rt-archive.perl.org/perl5/Ticket/Display.html?id=121853

rt.cpan ticket


https://rt.cpan.org/Ticket/Display.html?id=95350

perl -V


Summary of my perl5 (revision 5 version 19 subversion 2) configuration​:
  Commit id​: 1292fdb21b7be8d5744e209a36ec45853896005b
  Platform​:
  osname=linux, osvers=3.9-1-amd64, archname=x86_64-linux-debug@​1292fdb2
  uname='linux reini 3.9-1-amd64 #1 smp debian 3.9.8-1 x86_64 gnulinux '
  config_args='-de -Dusedevel -Uversiononly -Dinstallman1dir=none -Dinstallman3dir=none -Dinstallsiteman1dir=none -Dinstallsiteman3dir=none -DEBUGGING -Doptimize=-g3 -Uuseithreads -Accflags=''-msse4.2'' -Accflags=''-march=corei7'' -Dcf_email=''rurban@​cpanel.net'' -Dperladmin=''rurban@​cpanel.net'''
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=undef, usemultiplicity=undef
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-msse4.2 -march=corei7 -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
  optimize='-g3',
  cppflags='-msse4.2 -march=corei7 -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.7.3', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /usr/lib
  libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc
  libc=, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.17'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -g3 -L/usr/local/lib -fstack-protector'

Characteristics of this binary (from libperl)​:
  Compile-time options​: DEBUGGING HAS_TIMES PERLIO_LAYERS
  PERL_DONT_CREATE_GVSV
  PERL_HASH_FUNC_ONE_AT_A_TIME_HARD PERL_MALLOC_WRAP
  PERL_NEW_COPY_ON_WRITE PERL_PRESERVE_IVUV
  PERL_USE_DEVEL USE_64_BIT_ALL USE_64_BIT_INT
  USE_LARGE_FILES USE_LOCALE USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE USE_LOCALE_NUMERIC USE_PERLIO
  USE_PERL_ATOF
  Built under linux
  Compiled at Jul 18 2013 14​:57​:48

--
andreas

@p5pRT
Copy link
Author

p5pRT commented May 15, 2014

From @tonycoz

On Wed May 14 19​:05​:14 2014, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

left over from
--------------
https://rt-archive.perl.org/perl5/Ticket/Display.html?id=115910

discussed also at
-----------------
https://rt-archive.perl.org/perl5/Ticket/Display.html?id=121853

rt.cpan ticket
--------------
https://rt.cpan.org/Ticket/Display.html?id=95350

Writes to scalar PVs without making sure they're normal.

Fix attached.

Tony

@p5pRT
Copy link
Author

p5pRT commented May 15, 2014

From @tonycoz

Math-Rand48.diff
diff -ru Math-Rand48-1.00-orig/Rand48.xs Math-Rand48-1.00/Rand48.xs
--- Math-Rand48-1.00-orig/Rand48.xs	1998-12-31 19:30:35.000000000 +1100
+++ Math-Rand48-1.00/Rand48.xs	2014-05-15 14:01:30.000000000 +1000
@@ -23,6 +23,11 @@
 seed_t
 SVtoSeed(SV *sv)
 {
+ /* the return value might be written to, so always clean up any strangeness
+    SvPV_force() isn't appropriate since the IV part might be read.
+ */
+ if (SvTHINKFIRST(sv))
+   sv_force_normal(sv);
  if (!SvPOK(sv) || SvCUR(sv) != 3*sizeof(unsigned short) )
   {
    if (SvPOK(sv) && SvCUR(sv) > 3*sizeof(unsigned short))

@p5pRT
Copy link
Author

p5pRT commented May 15, 2014

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented May 16, 2014

From @rjbs

With this ticket filed at rt.cpan.org with a patch, do we want to keep the ticket here open, or close it?

I would normally close it in this situation.

--
rjbs

@p5pRT
Copy link
Author

p5pRT commented May 16, 2014

From @andk

"Ricardo SIGNES via RT" <perlbug-followup@​perl.org> writes​:

With this ticket filed at rt.cpan.org with a patch, do we want to keep the ticket here open, or close it?

I would normally close it in this situation.

Fine by me!

--
andreas

@p5pRT
Copy link
Author

p5pRT commented May 16, 2014

@rjbs - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant