New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bleadperl breaks NI-S/Math-Rand48-1.00.tar.gz #13839
Comments
From @andkleft over from https://rt-archive.perl.org/perl5/Ticket/Display.html?id=115910 discussed also at https://rt-archive.perl.org/perl5/Ticket/Display.html?id=121853 rt.cpan ticket https://rt.cpan.org/Ticket/Display.html?id=95350 perl -V Summary of my perl5 (revision 5 version 19 subversion 2) configuration: Characteristics of this binary (from libperl): -- |
From @tonycozOn Wed May 14 19:05:14 2014, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
Writes to scalar PVs without making sure they're normal. Fix attached. Tony |
From @tonycozMath-Rand48.diffdiff -ru Math-Rand48-1.00-orig/Rand48.xs Math-Rand48-1.00/Rand48.xs
--- Math-Rand48-1.00-orig/Rand48.xs 1998-12-31 19:30:35.000000000 +1100
+++ Math-Rand48-1.00/Rand48.xs 2014-05-15 14:01:30.000000000 +1000
@@ -23,6 +23,11 @@
seed_t
SVtoSeed(SV *sv)
{
+ /* the return value might be written to, so always clean up any strangeness
+ SvPV_force() isn't appropriate since the IV part might be read.
+ */
+ if (SvTHINKFIRST(sv))
+ sv_force_normal(sv);
if (!SvPOK(sv) || SvCUR(sv) != 3*sizeof(unsigned short) )
{
if (SvPOK(sv) && SvCUR(sv) > 3*sizeof(unsigned short))
|
The RT System itself - Status changed from 'new' to 'open' |
From @rjbsWith this ticket filed at rt.cpan.org with a patch, do we want to keep the ticket here open, or close it? I would normally close it in this situation. -- |
From @andk"Ricardo SIGNES via RT" <perlbug-followup@perl.org> writes:
Fine by me! -- |
@rjbs - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#121874 (status was 'resolved')
Searchable as RT121874$
The text was updated successfully, but these errors were encountered: