Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SvREFCNT_dec_NN in Devel::PPPort in 5.20 is bad #13801

Closed
p5pRT opened this issue May 6, 2014 · 7 comments
Closed

SvREFCNT_dec_NN in Devel::PPPort in 5.20 is bad #13801

p5pRT opened this issue May 6, 2014 · 7 comments

Comments

@p5pRT
Copy link

p5pRT commented May 6, 2014

Migrated from rt.perl.org#121805 (status was 'resolved')

Searchable as RT121805$

@p5pRT
Copy link
Author

p5pRT commented May 6, 2014

From @wolfsage

Howdy folks,

bulk88 pointed out that I added some code to Devel​::PPPort in 3.22 for
SvREFCNT_dec_NN that doesn't free SVs when the refcnt reaches zero.

Since we're in a freeze and so close to release, I'm wondering which
option I should go with. I see three​:

  1. I can downgrade Devel​::PPPort in blead back to the earlier safe
version (reverting 8e5dcc3),

  2. I can attempt to fix Devel​::PPPort and release a new version and include it

  3. I can remove the bad function from Devel​::PPPort until I have
time to implement it properly across all Perls, and release a new
version and include it.

I'm kind of leaning towards 1 here.

This should be a blead blocker.

Thoughts?

Thanks,

-- Matthew Horsfall (alh)

@p5pRT
Copy link
Author

p5pRT commented May 6, 2014

From @khwilliamson

On 05/06/2014 09​:59 AM, Matthew Horsfall (via RT) wrote​:

I'm kind of leaning towards 1 here.

This should be a blead blocker.

Thoughts?

I think 1 is the least risky alternative

@p5pRT
Copy link
Author

p5pRT commented May 6, 2014

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented May 7, 2014

From @rjbs

* Matthew Horsfall <perlbug-followup@​perl.org> [2014-05-06T11​:59​:12]

I'm kind of leaning towards 1 here.

Sounds best.

This should be a blead blocker.

It is so marked.

--
rjbs

@p5pRT
Copy link
Author

p5pRT commented May 8, 2014

From @wolfsage

This should be all set as of f001cc4.

Anything else need reverting? (Delta entry for upgraded module perhaps?)

-- Matthew Horsfall (alh)

@p5pRT
Copy link
Author

p5pRT commented May 12, 2014

From @rjbs

the module deltas are generated automatically just in time; no need to revert things

--
rjbs

@p5pRT p5pRT closed this as completed May 12, 2014
@p5pRT
Copy link
Author

p5pRT commented May 12, 2014

@rjbs - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant