Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporter doc patch. #13749

Closed
p5pRT opened this issue Apr 22, 2014 · 6 comments
Closed

Exporter doc patch. #13749

p5pRT opened this issue Apr 22, 2014 · 6 comments
Labels
distro-darwin type-library

Comments

@p5pRT
Copy link

p5pRT commented Apr 22, 2014

Migrated from rt.perl.org#121698 (status was 'resolved')

Searchable as RT121698$
@p5pRT
Copy link
Author

p5pRT commented Apr 22, 2014

From @toddr

Created by @toddr

This minor patch should sync up Exporter with the new CPAN release.
POD tests showed a minor fixup needed with recent changes.

Perl Info 

Flags:
    category=library
    severity=low
    module=Exporter

Site configuration information for perl 5.18.0:

Configured by todd at Fri Jul 12 12:35:54 CDT 2013.

Summary of my perl5 (revision 5 version 18 subversion 0) configuration:

  Platform:
    osname=darwin, osvers=12.4.0, archname=darwin-ld-2level
    uname='darwin todd-rinaldos-macbook-pro.local 12.4.0 darwin kernel
version 12.4.0: wed may 1 17:57:12 pdt 2013;
root:xnu-2050.24.15~1release_x86_64 x86_64 '
    config_args=''
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=undef, usemultiplicity=undef
    useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
    use64bitint=define, use64bitall=define, uselongdouble=define
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-fno-common -DPERL_DARWIN -fno-strict-aliasing
-pipe -fstack-protector -I/usr/local/include',
    optimize='-O3',
    cppflags='-fno-common -DPERL_DARWIN -fno-strict-aliasing -pipe
-fstack-protector -I/usr/local/include'
    ccversion='', gccversion='4.2.1 Compatible Apple Clang 4.1
((tags/Apple/clang-421.11.65))', gccosandvers=''
    intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
    ivtype='long', ivsize=8, nvtype='long double', nvsize=16,
Off_t='off_t', lseeksize=8
    alignbytes=16, prototype=define
  Linker and Libraries:
    ld='env MACOSX_DEPLOYMENT_TARGET=10.3 cc', ldflags ='
-fstack-protector -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib
    libs=-ldbm -ldl -lm -lutil -lc
    perllibs=-ldl -lm -lutil -lc
    libc=, so=dylib, useshrplib=false, libperl=libperl.a
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=bundle, d_dlsymun=undef, ccdlflags=' '
    cccdlflags=' ', lddlflags=' -bundle -undefined dynamic_lookup
-L/usr/local/lib -fstack-protector'

Locally applied patches:



@INC for perl 5.18.0:
    /usr/local/cpanel/3rdparty/perl/518/lib/site_perl/5.18.0/darwin-ld-2level
    /usr/local/cpanel/3rdparty/perl/518/lib/site_perl/5.18.0
    /usr/local/cpanel/3rdparty/perl/518/lib/5.18.0/darwin-ld-2level
    /usr/local/cpanel/3rdparty/perl/518/lib/5.18.0
    .


Environment for perl 5.18.0:
    DYLD_LIBRARY_PATH (unset)
    HOME=/Users/todd
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/usr/local/git/bin:/usr/local/cpanel/3rdparty/perl/518/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11/bin:/sw/bin
    PERLDB_OPTS=RemotePort=:9000
    PERL_BADLANG (unse

@p5pRT
Copy link
Author

p5pRT commented Apr 22, 2014

From @toddr

0001-Correct-illegal-use-of-in-Exporter-POD.patch 
From 1730d354c8d7ecc8cb1aa41cc9a28e7b4075c9a6 Mon Sep 17 00:00:00 2001
From: Todd Rinaldo <toddr@cpan.org>
Date: Sun, 13 Apr 2014 21:37:42 -0500
Subject: [PATCH] Correct illegal use of >> in Exporter POD

Discovered during POD unit tests on release of 5.70 to CPAN
Also correct AUTHORS email to toddr@cpan.org
---
 AUTHORS                       | 2 +-
 dist/Exporter/lib/Exporter.pm | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/AUTHORS b/AUTHORS
index dc5e8d0..8d3448b 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -1149,7 +1149,7 @@ Tkil				<tkil@reptile.scrye.com>
 Tobias Leich			<email@froggs.de>
 Toby Inkster			<mail@tobyinkster.co.uk>
 Todd C. Miller			<Todd.Miller@courtesan.com>
-Todd Rinaldo			<toddr@cpanel.net>
+Todd Rinaldo			<toddr@cpan.org>
 Todd T. Fries			<todd@fries.int.mrleng.com>
 Todd Vierling			<tv@duh.org>
 Tokuhiro Matsuno		<tokuhirom@gmail.com>
diff --git a/dist/Exporter/lib/Exporter.pm b/dist/Exporter/lib/Exporter.pm
index d77a93d..4930505 100644
--- a/dist/Exporter/lib/Exporter.pm
+++ b/dist/Exporter/lib/Exporter.pm
@@ -163,7 +163,7 @@ try to use C<@EXPORT_OK> in preference to C<@EXPORT> and avoid short or
 common symbol names to reduce the risk of name clashes.
 
 Generally anything not exported is still accessible from outside the
-module using the C<YourModule::item_name> (or C<< $blessed_ref->method>>)
+module using the C<YourModule::item_name> (or C<< $blessed_ref->method >>)
 syntax.  By convention you can use a leading underscore on names to
 informally indicate that they are 'internal' and not for public use.
 
-- 
1.8.4.2

@p5pRT
Copy link
Author

p5pRT commented Apr 28, 2014

From @tonycoz

On Mon Apr 21 22​:22​:36 2014, todd@​rinaldo.us wrote​:

This minor patch should sync up Exporter with the new CPAN release.
POD tests showed a minor fixup needed with recent changes.

Added to the 5.21.1 blockers list.

I'm surprised porting/podcheck.t didn't pick this up.

Tony

@p5pRT
Copy link
Author

p5pRT commented Apr 28, 2014

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented May 31, 2014

From @jkeenan

On Mon Apr 21 22​:22​:36 2014, todd@​rinaldo.us wrote​:

This is a bug report for perl from toddr@​cpan.org,
generated with the help of perlbug 1.39 running under perl 5.18.0.

-----------------------------------------------------------------
[Please describe your issue here]

This minor patch should sync up Exporter with the new CPAN release.
POD tests showed a minor fixup needed with recent changes.

Pushed to blead in commit 2fe8fc1. Todd, note that this required a bump in Exporter.pm's $VERSION.

Thank you very much.
Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented May 31, 2014

@jkeenan - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed May 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
distro-darwin type-library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p5pRT