New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PATCH] move given/when ~~ note below item introducing it #13747
Comments
From madcityzen@gmail.comThe note explaining to use $c ~~ $_ instead of $_ ~~ $c was put under the item pod/perlsyn.pod | 7 +++---- |
From madcityzen@gmail.com0001-move-given-when-note-below-item-introducing-it.patchdiff --git a/pod/perlsyn.pod b/pod/perlsyn.pod
index 9ce8b3c..244372c 100644
--- a/pod/perlsyn.pod
+++ b/pod/perlsyn.pod
@@ -958,6 +958,9 @@ the form C<!/REGEX/>, C<$foo !~ /REGEX/>, or C<$foo !~ EXPR>.
A smart match that uses an explicit C<~~> operator, such as C<EXPR ~~ EXPR>.
+B<NOTE:> You will often have to use C<$c ~~ $_> because the default case
+uses C<$_ ~~ $c> , which is frequentlythe opposite of what you want.
+
=item Z<>4.
A boolean comparison operator such as C<$_ E<lt> 10> or C<$x eq "abc">. The
@@ -965,10 +968,6 @@ relational operators that this applies to are the six numeric comparisons
(C<< < >>, C<< > >>, C<< <= >>, C<< >= >>, C<< == >>, and C<< != >>), and
the six string comparisons (C<lt>, C<gt>, C<le>, C<ge>, C<eq>, and C<ne>).
-B<NOTE:> You will often have to use C<$c ~~ $_> because
-the default case uses C<$_ ~~ $c> , which is frequently
-the opposite of what you want.
-
=item Z<>5.
At least the three builtin functions C<defined(...)>, C<exists(...)>, and
|
From @tonycozOn Sat Apr 19 16:53:43 2014, madcityzen@gmail.com wrote:
Could you supply the patch as an attachment please? The changes look good, and I'll apply them once 5.20 has been released (it will just be simpler with the patch attached.) Tony |
The RT System itself - Status changed from 'new' to 'open' |
From @tonycozOn Sun Apr 27 22:39:12 2014, tonyc wrote:
Oops, the patch was an attachment, just not a format-patch patch, which I've attached. Tony |
From @tonycoz0001-move-given-when-note-below-item-introducing-it.patchFrom 869d423e7fa4754715056c2df6800c96d7f5a890 Mon Sep 17 00:00:00 2001
From: Doug Bell <madcityzen@gmail.com>
Date: Tue, 13 May 2014 10:50:41 +1000
Subject: move given/when ~~ note below item introducing it
The note explaining to use $c ~~ $_ instead of $_ ~~ $c was put under the item
introducing all binary operators, and not the one mentioning the explicit
smartmatch operator.
---
pod/perlsyn.pod | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/pod/perlsyn.pod b/pod/perlsyn.pod
index 9ce8b3c..244372c 100644
--- a/pod/perlsyn.pod
+++ b/pod/perlsyn.pod
@@ -958,6 +958,9 @@ the form C<!/REGEX/>, C<$foo !~ /REGEX/>, or C<$foo !~ EXPR>.
A smart match that uses an explicit C<~~> operator, such as C<EXPR ~~ EXPR>.
+B<NOTE:> You will often have to use C<$c ~~ $_> because the default case
+uses C<$_ ~~ $c> , which is frequentlythe opposite of what you want.
+
=item Z<>4.
A boolean comparison operator such as C<$_ E<lt> 10> or C<$x eq "abc">. The
@@ -965,10 +968,6 @@ relational operators that this applies to are the six numeric comparisons
(C<< < >>, C<< > >>, C<< <= >>, C<< >= >>, C<< == >>, and C<< != >>), and
the six string comparisons (C<lt>, C<gt>, C<le>, C<ge>, C<eq>, and C<ne>).
-B<NOTE:> You will often have to use C<$c ~~ $_> because
-the default case uses C<$_ ~~ $c> , which is frequently
-the opposite of what you want.
-
=item Z<>5.
At least the three builtin functions C<defined(...)>, C<exists(...)>, and
--
1.7.10.4
|
From @tonycozOn Sat Apr 19 16:53:43 2014, madcityzen@gmail.com wrote:
Thanks, applied as e10c9f6. Tony |
@tonycoz - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#121689 (status was 'resolved')
Searchable as RT121689$
The text was updated successfully, but these errors were encountered: