New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PATCH] Avoid double quotes in switchM.t runperl args. #13740
Comments
From @craigberryThe new tests added in 9fdd5a7 were sending runperl a -e N.B. This modifies the same tests touched by the patch in , '-e "print t2::id()"'] with ], prog => 'print t2::id()' in 2 places. $ perl -V Characteristics of this PERLSHR image: ________________________________________ "... getting out of a sonnet is much more |
From @craigberry0001-Avoid-double-quotes-in-switchM.t-runperl-args.patchFrom a352d3163ef6e5b63ec847541ab57d41d179ef77 Mon Sep 17 00:00:00 2001
From: "Craig A. Berry" <craigberry@mac.com>
Date: Tue, 15 Apr 2014 19:30:26 -0500
Subject: [PATCH] Avoid double quotes in switchM.t runperl args.
The new tests added in 9fdd5a7ac74817 were sending runperl a -e
command with double quotes around it, which confuses matters on
VMS where arguments get double quotes added unless they already
have them. The solution is simple: just use the 'prog' parameter
to runperl and let runperl handle the quoting.
---
t/run/switchM.t | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/run/switchM.t b/t/run/switchM.t
index 6a75100..ac2f5de 100644
--- a/t/run/switchM.t
+++ b/t/run/switchM.t
@@ -18,10 +18,10 @@ like(runperl(switches => ['-Irun/flib/', '-Mbroken'], stderr => 1),
qr/^Global symbol "\$x" requires explicit package name at run\/flib\/broken.pm line 6\./,
"Ensure -Irun/flib/ produces correct filename in warnings");
-like(runperl(switches => ['-Irun/flib', '-Mt2', '-e "print t2::id()"'], stderr => 1),
+like(runperl(switches => ['-Irun/flib', '-Mt2'], prog => 'print t2::id()', stderr => 1),
qr/^t2pmc$/,
"Ensure -Irun/flib loads pmc");
-like(runperl(switches => ['-Irun/flib/', '-Mt2', '-e "print t2::id()"'], stderr => 1),
+like(runperl(switches => ['-Irun/flib/', '-Mt2'], prog => 'print t2::id()', stderr => 1),
qr/^t2pmc$/,
"Ensure -Irun/flib/ loads pmc");
--
1.8.4.2
|
From @tonycozOn Wed Apr 16 05:36:32 2014, craigberry wrote:
I think this belongs in blead, and plan to apply it in a couple of days if no-one objects. This fixes a new test introduced during the code freeze which I think makes it fair game. Tony |
The RT System itself - Status changed from 'new' to 'open' |
From @wolfsageOn Sun, Apr 20, 2014 at 8:38 PM, Tony Cook via RT
+1. Thanks! -- Matthew Horsfall (alh) |
From @tonycozOn Wed Apr 16 05:36:32 2014, craigberry wrote:
Thanks, applied as 2a07cc4. Tony |
@tonycoz - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#121672 (status was 'resolved')
Searchable as RT121672$
The text was updated successfully, but these errors were encountered: