Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] perl5182delta fixes #13705

Closed
p5pRT opened this issue Apr 2, 2014 · 7 comments
Closed

[PATCH] perl5182delta fixes #13705

p5pRT opened this issue Apr 2, 2014 · 7 comments

Comments

@p5pRT
Copy link

p5pRT commented Apr 2, 2014

Migrated from rt.perl.org#121570 (status was 'resolved')

Searchable as RT121570$

@p5pRT
Copy link
Author

p5pRT commented Apr 2, 2014

From @Smylers

This is a bug report for perl from smylers@​stripey.com,
generated with the help of perlbug 1.40 running under perl 5.19.11.


Include perl518delta from maint-5.18 into blead, then fix some typos in
it.

The typo fixes, in the second commit, should then be applied to
maint-5.18 as well.



Flags​:
  category=docs
  severity=low
  Type=Patch
  PatchStatus=HasPatch


Site configuration information for perl 5.19.11​:

Configured by smylers at Wed Apr 2 17​:13​:59 BST 2014.

Summary of my perl5 (revision 5 version 19 subversion 11) configuration​:
  Local Commit​: bd38e06d7365851075293fab782e64f9eac5533c
  Ancestor​: a04e6aa
  Platform​:
  osname=linux, osvers=3.11.0-19-generic, archname=x86_64-linux
  uname='linux fozzie 3.11.0-19-generic #33-ubuntu smp tue mar 11 18​:48​:34 utc 2014 x86_64 x86_64 x86_64 gnulinux '
  config_args='-des -Dusedevel'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=undef, usemultiplicity=undef
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
  optimize='-O2',
  cppflags='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.8.1', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/4.8/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lnsl -ldl -lm -lcrypt -lutil -lc
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.17.so, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.17'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector'

Locally applied patches​:
  a62b3d3a465ef61345a0a41097e2f3f8724b4c15
  bd38e06d7365851075293fab782e64f9eac5533c


@​INC for perl 5.19.11​:
  lib
  /usr/local/lib/perl5/site_perl/5.19.11/x86_64-linux
  /usr/local/lib/perl5/site_perl/5.19.11
  /usr/local/lib/perl5/5.19.11/x86_64-linux
  /usr/local/lib/perl5/5.19.11
  .


Environment for perl 5.19.11​:
  HOME=/home/smylers
  LANG=en_GB.utf8
  LANGUAGE=en_GB​:en
  LC_COLLATE=C
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)
  PATH=/home/smylers/bin​:/usr/local/sbin​:/usr/local/bin​:/sbin​:/bin​:/usr/sbin​:/usr/bin​:/usr/X11R6/bin​:/usr/games
  PERL_BADLANG (unset)
  PERL_CPANM_OPT=--sudo --prompt
  SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Apr 2, 2014

From @Smylers

0001-Add-perl5182delta-from-maint-5.18.patch
From a62b3d3a465ef61345a0a41097e2f3f8724b4c15 Mon Sep 17 00:00:00 2001
From: Smylers <Smylers@stripey.com>
Date: Wed, 2 Apr 2014 17:05:31 +0100
Subject: [PATCH 1/2] Add perl5182delta from maint-5.18

---
 pod/perl5182delta.pod | 175 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 175 insertions(+)
 create mode 100644 pod/perl5182delta.pod

diff --git a/pod/perl5182delta.pod b/pod/perl5182delta.pod
new file mode 100644
index 0000000..eacf81c
--- /dev/null
+++ b/pod/perl5182delta.pod
@@ -0,0 +1,175 @@
+=encoding utf8
+
+=head1 NAME
+
+perl5182delta - what is new for perl v5.18.2
+
+=head1 DESCRIPTION
+
+This document describes differences between the 5.18.1 release and the 5.18.2
+release.
+
+If you are upgrading from an earlier release such as 5.18.0, first read
+L<perl5181delta>, which describes differences between 5.18.0 and 5.18.1.
+
+=head1 Modules and Pragmata
+
+=head2 Updated Modules and Pragmata
+
+=over 4
+
+=item *
+
+L<B> has been upgraded from version 1.42_01 to 1.42_02.
+
+The fix for [perl #118525] introduced a regression in the behaviour of
+C<B::CV::GV>, changing the return value from a C<B::SPECIAL> object on
+a C<NULL> C<CvGV> to C<undef>.  C<B::CV::GV> again returns a
+C<B::SPECIAL> object in this case.  [perl #119413]
+
+=item *
+
+L<B::Concise> has been upgraded from version 0.95 to 0.95_01.
+
+This fixes a bug in dumping unexpected SPECIALs.
+
+=item *
+
+L<English> has been upgraded from version 1.06 to 1.06_01.  This fixes an
+error about the performance of C<$`>, C<$&>, and c<$'>.
+
+=item *
+
+L<File::Glob> has been upgraded from version 1.20 to 1.20_01.
+
+=back
+
+=head1 Documentation
+
+=head2 Changes to Existing Documentation
+
+=over 4
+
+=item *
+
+L<perlrepository> has been restored with a pointer to more useful pages.
+
+=item *
+
+L<perlhack> has been updated with the latest changes from blead.
+
+=back
+
+=head1 Selected Bug Fixes
+
+=over 4
+
+=item *
+
+Perl 5.18.1 introduced a regression along with a bugfix for lexical subs.
+Some B::SPECIAL results from B::CV::GV became undefs instead.  This broke
+Devel::Cover among other libraries.  This has been fixed.  [perl #119351]
+
+=item *
+
+Perl 5.18.0 introduced a regression whereby C<[:^ascii:]>, if used in the same
+character class as other qualifiers, would fail to match characters in the
+Latin-1 block.  This has been fixed.  [perl #120799]
+
+=item *
+
+Perl 5.18.0 introduced a regression when using ->SUPER::method with AUTOLOAD
+by looking up AUTOLOAD from the current package, rather than the current
+package’s superclass.  This has been fixed. [perl #120694]
+
+=item *
+
+Perl 5.18.0 introduced a regression whereby C<-bareword> was no longer
+permitted under the C<strict> and C<integer> pragmata when used together.  This
+has been fixed.  [perl #120288]
+
+=item *
+
+Previously PerlIOBase_dup didn't check if pushing the new layer succeeded
+before (optionally) setting the utf8 flag. This could cause
+segfaults-by-nullpointer.  This has been fixed.
+
+=item *
+
+A buffer overflow with very long identifiers has been fixed.
+
+=item *
+
+A regression from 5.16 in the handling of padranges led to assertion failures
+if a keyword plugin declined to handle the second ‘my’, but only after creating
+a padop.
+
+This affected, at least, Devel::CallParser under threaded builds.
+
+This has been fixed
+
+=item *
+
+The construct C<< $r=qr/.../; /$r/p >> is now handled properly, an issue which
+had been worsened by changes 5.18.0. [perl #118213]
+
+=back
+
+=head1 Acknowledgements
+
+Perl 5.18.2 represents approximately 3 months of development since Perl
+5.18.1 and contains approximately 980 lines of changes across 39 files from 4
+authors.
+
+Perl continues to flourish into its third decade thanks to a vibrant
+community of users and developers. The following people are known to have
+contributed the improvements that became Perl 5.18.2:
+
+Craig A. Berry, David Mitchell, Ricardo Signes, Tony Cook.
+
+The list above is almost certainly incomplete as it is automatically
+generated from version control history. In particular, it does not include
+the names of the (very much appreciated) contributors who reported issues to
+the Perl bug tracker.
+
+Many of the changes included in this version originated in the CPAN modules
+included in Perl's core. We're grateful to the entire CPAN community for
+helping Perl to flourish.
+
+For a more complete list of all of Perl's historical contributors, please see
+the F<AUTHORS> file in the Perl source distribution.
+
+=head1 Reporting Bugs
+
+If you find what you think is a bug, you might check the articles recently
+posted to the comp.lang.perl.misc newsgroup and the perl bug database at
+http://rt.perl.org/perlbug/ .  There may also be information at
+http://www.perl.org/ , the Perl Home Page.
+
+If you believe you have an unreported bug, please run the L<perlbug> program
+included with your release.  Be sure to trim your bug down to a tiny but
+sufficient test case.  Your bug report, along with the output of C<perl -V>,
+will be sent off to perlbug@perl.org to be analysed by the Perl porting team.
+
+If the bug you are reporting has security implications, which make it
+inappropriate to send to a publicly archived mailing list, then please send it
+to perl5-security-report@perl.org.  This points to a closed subscription
+unarchived mailing list, which includes all the core committers, who will be
+able to help assess the impact of issues, figure out a resolution, and help
+co-ordinate the release of patches to mitigate or fix the problem across all
+platforms on which Perl is supported.  Please only use this address for
+security issues in the Perl core, not for modules independently distributed on
+CPAN.
+
+=head1 SEE ALSO
+
+The F<Changes> file for an explanation of how to view exhaustive details on
+what changed.
+
+The F<INSTALL> file for how to build Perl.
+
+The F<README> file for general stuff.
+
+The F<Artistic> and F<Copying> files for copyright information.
+
+=cut
-- 
1.8.3.2

@p5pRT
Copy link
Author

p5pRT commented Apr 2, 2014

From @Smylers

0002-perl5182delta-typo-fixes.patch
From bd38e06d7365851075293fab782e64f9eac5533c Mon Sep 17 00:00:00 2001
From: Smylers <Smylers@stripey.com>
Date: Wed, 2 Apr 2014 17:06:09 +0100
Subject: [PATCH 2/2] perl5182delta typo fixes

Escaping fix.

Missing full stop added.
---
 pod/perl5182delta.pod | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pod/perl5182delta.pod b/pod/perl5182delta.pod
index eacf81c..53c5de6 100644
--- a/pod/perl5182delta.pod
+++ b/pod/perl5182delta.pod
@@ -36,7 +36,7 @@ This fixes a bug in dumping unexpected SPECIALs.
 =item *
 
 L<English> has been upgraded from version 1.06 to 1.06_01.  This fixes an
-error about the performance of C<$`>, C<$&>, and c<$'>.
+error about the performance of C<$`>, C<$&>, and C<$'>.
 
 =item *
 
@@ -106,7 +106,7 @@ a padop.
 
 This affected, at least, Devel::CallParser under threaded builds.
 
-This has been fixed
+This has been fixed.
 
 =item *
 
-- 
1.8.3.2

@p5pRT
Copy link
Author

p5pRT commented Apr 4, 2014

From @steve-m-hay

Thanks. I have applied your second patch to blead in commit 2e061f0. I've also added 5.18.2's delta, which your first patch didn't do correctly. (RJBS missed this step from the RMG when making 5.18.2.)

Commit 2e061f0 still needs cherry-picking into maint-5.18 before I close this ticket.

@p5pRT
Copy link
Author

p5pRT commented Apr 4, 2014

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Apr 7, 2014

From @steve-m-hay

Now cherry-picked into maint-5.18 in commit 1d88b12.

@p5pRT
Copy link
Author

p5pRT commented Apr 7, 2014

@steve-m-hay - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant