Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utf8​::upgrade() dies if gets passed a reference, but utf8​::downgrade() just passes it through. #13704

Open
p5pRT opened this issue Apr 2, 2014 · 7 comments
Open

utf8​::upgrade() dies if gets passed a reference, but utf8​::downgrade() just passes it through. #13704

p5pRT opened this issue Apr 2, 2014 · 7 comments
Labels
distro-Linux type-core Wishlist

Comments

@p5pRT
Copy link

p5pRT commented Apr 2, 2014

Migrated from rt.perl.org#121569 (status was 'open')

Searchable as RT121569$
@p5pRT
Copy link
Author

p5pRT commented Apr 2, 2014

From @avar

Created by @avar

See
http​://perl5.git.perl.org/perl.git/commitdiff/64470437fdd8d4178fc69d2d0e3a526d2b7d5262
for a full description of what this is about. The utf8​::* functions
have a very funky way of munging their arguments when they get
references.

Perl Info 

Flags:
    category=core
    severity=wishlist

Site configuration information for perl 5.19.11:

Configured by avar at Wed Apr  2 15:20:31 UTC 2014.

Summary of my perl5 (revision 5 version 19 subversion 11) configuration:
  Local Commit: 64470437fdd8d4178fc69d2d0e3a526d2b7d5262
  Ancestor: a04e6aad3b10787abd99c78eeac04ca9f4b33d0b
  Platform:
    osname=linux, osvers=3.2.0-4-amd64, archname=x86_64-linux-thread-multi
    uname='linux u.nix.is 3.2.0-4-amd64 #1 smp debian 3.2.35-2 x86_64 gnulinux '
    config_args='-DDEBUGGING=both -Doptimize=-ggdb3 -Dusethreads -Dprefix=/home/avar/perl5/installed -Dusedevel -des'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=define, usemultiplicity=define
    use64bitint=define, use64bitall=define, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
    optimize='-ggdb3',
    cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
    ccversion='', gccversion='4.2.1 Compatible Debian Clang 3.3 (branches/release_33)', gccosandvers=''
    intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
    ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
    libpth=/usr/local/lib /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
    libs=-lnsl -ldb -ldl -lm -lcrypt -lutil -lpthread -lc
    perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
    libc=libc-2.18.so, so=so, useshrplib=false, libperl=libperl.a
    gnulibc_version='2.18'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
    cccdlflags='-fPIC', lddlflags='-shared -ggdb3 -L/usr/local/lib -fstack-protector'

Locally applied patches:
    uncommitted-changes


@INC for perl 5.19.11:
    lib
    /home/avar/perl5/installed/lib/site_perl/5.19.11/x86_64-linux-thread-multi
    /home/avar/perl5/installed/lib/site_perl/5.19.11
    /home/avar/perl5/installed/lib/5.19.11/x86_64-linux-thread-multi
    /home/avar/perl5/installed/lib/5.19.11
    .


Environment for perl 5.19.11:
    HOME=/home/avar
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/v-perlbrew/perl5/perlbrew/perls/perl-5.19.6/bin:/home/avar/g/misc-scripts:/home/avar/bin:/usr/local/bin:/usr/bin:/bin:/usr/games
    PERLDOC=-MPod::Text::Ansi
    PERL_BADLANG (unset)
    SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Sep 24, 2014

From @jkeenan

On Wed Apr 02 09​:12​:28 2014, avar wrote​:

This is a bug report for perl from avar@​cpan.org,
generated with the help of perlbug 1.40 running under perl 5.19.11.

-----------------------------------------------------------------
[Please describe your issue here]

See
http​://perl5.git.perl.org/perl.git/commitdiff/64470437fdd8d4178fc69d2d0e3a526d2b7d5262
for a full description of what this is about. The utf8​::* functions
have a very funky way of munging their arguments when they get
references.

It appears this RT was filed as a way of logging the commit cited above. So there's nothing more to be done on this ticket.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Sep 24, 2014

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Sep 24, 2014

@jkeenan - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Sep 24, 2014
@p5pRT
Copy link
Author

p5pRT commented Sep 24, 2014

From @cpansprout

On Tue Sep 23 18​:11​:13 2014, jkeenan wrote​:

On Wed Apr 02 09​:12​:28 2014, avar wrote​:

This is a bug report for perl from avar@​cpan.org,
generated with the help of perlbug 1.40 running under perl 5.19.11.

-----------------------------------------------------------------
[Please describe your issue here]

See
http​://perl5.git.perl.org/perl.git/commitdiff/64470437fdd8d4178fc69d2d0e3a526d2b7d5262
for a full description of what this is about. The utf8​::* functions
have a very funky way of munging their arguments when they get
references.

It appears this RT was filed as a way of logging the commit cited
above. So there's nothing more to be done on this ticket.

I think you missed the last paragraph in the commit message​:

  However I think we should be more consistent here, e.g. we'll die when
  utf8​::upgrade() gets passed a reference, but utf8​::downgrade() just
  passes it through. I'll file a bug for that separately.

And I think this is meant to be the bug report in question.

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Sep 24, 2014

From @jkeenan

Re-opening.

@p5pRT
Copy link
Author

p5pRT commented Sep 24, 2014

@jkeenan - Status changed from 'resolved' to 'open'

@toddr toddr removed the khw label Oct 25, 2019
@khwilliamson khwilliamson reopened this Nov 26, 2019
@khwilliamson khwilliamson changed the title The utf8::*() functions should be more consistent with what they do with references as arguments utf8​::upgrade() dies if gets passed a reference, but utf8​::downgrade() just passes it through. Nov 26, 2019
@xenu xenu removed the affects-5.19 label Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
distro-Linux type-core Wishlist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@toddr @khwilliamson @xenu @p5pRT