Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl v5.19.8-453-g2954a1e breaks ADAMK/Module-Install-1.06.tar.gz #13607

Closed
p5pRT opened this issue Feb 16, 2014 · 12 comments
Closed

Bleadperl v5.19.8-453-g2954a1e breaks ADAMK/Module-Install-1.06.tar.gz #13607

p5pRT opened this issue Feb 16, 2014 · 12 comments

Comments

@p5pRT
Copy link

p5pRT commented Feb 16, 2014

Migrated from rt.perl.org#121262 (status was 'resolved')

Searchable as RT121262$

@p5pRT
Copy link
Author

p5pRT commented Feb 16, 2014

From @andk

git


commit 2954a1e
Author​: Chris 'BinGOs' Williams <chris@​bingosnet.co.uk>
Date​: Fri Feb 14 10​:07​:20 2014 +0000

  Update CPAN-Meta-YAML to CPAN version 0.011

diagnostics


http​://www.cpantesters.org/cpan/report/aa51b0e6-9619-11e3-9bb1-f0615d7e0655

perl -V


Summary of my perl5 (revision 5 version 19 subversion 9) configuration​:
  Commit id​: 38d111e
  Platform​:
  osname=linux, osvers=3.10-3-amd64, archname=x86_64-linux-ld
  uname='linux k83 3.10-3-amd64 #1 smp debian 3.10.11-1 (2013-09-10) x86_64 gnulinux '
  config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/perl/v5.19.8-455-g38d111e/127e -Dmyhostname=k83 -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Uuseithreads -Duselongdouble -DDEBUGGING=-g'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=undef, usemultiplicity=undef
  use64bitint=define, use64bitall=define, uselongdouble=define
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
  optimize='-O2 -g',
  cppflags='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.8.2', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=8, nvtype='long double', nvsize=16, Off_t='off_t', lseeksize=8
  alignbytes=16, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/4.8/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.17.so, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.17'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector'

Characteristics of this binary (from libperl)​:
  Compile-time options​: HAS_TIMES PERLIO_LAYERS PERL_DONT_CREATE_GVSV
  PERL_HASH_FUNC_ONE_AT_A_TIME_HARD PERL_MALLOC_WRAP
  PERL_NEW_COPY_ON_WRITE PERL_PRESERVE_IVUV
  PERL_USE_DEVEL USE_64_BIT_ALL USE_64_BIT_INT
  USE_LARGE_FILES USE_LOCALE USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE USE_LOCALE_NUMERIC USE_LONG_DOUBLE
  USE_PERLIO USE_PERL_ATOF
  Built under linux
  Compiled at Feb 15 2014 00​:06​:05
  %ENV​:
  PERL5LIB=""
  PERL5OPT=""
  PERL5_CPANPLUS_IS_RUNNING="18713"
  PERL5_CPAN_IS_RUNNING="18713"
  PERL_MM_USE_DEFAULT="1"
  @​INC​:
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.19.8-455-g38d111e/127e/lib/site_perl/5.19.9/x86_64-linux-ld
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.19.8-455-g38d111e/127e/lib/site_perl/5.19.9
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.19.8-455-g38d111e/127e/lib/5.19.9/x86_64-linux-ld
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.19.8-455-g38d111e/127e/lib/5.19.9
  .
--
andreas

@p5pRT
Copy link
Author

p5pRT commented Feb 17, 2014

From @jkeenan

On Sun Feb 16 07​:17​:18 2014, andreas.koenig.7os6VVqR@​franz.ak.mind.de wrote​:

git
---
commit 2954a1e
Author​: Chris 'BinGOs' Williams <chris@​bingosnet.co.uk>
Date​: Fri Feb 14 10​:07​:20 2014 +0000

Update CPAN-Meta-YAML to CPAN version 0.011

diagnostics
-----------
http​://www.cpantesters.org/cpan/report/aa51b0e6-9619-11e3-9bb1-
f0615d7e0655

Module-Install has a dependency on CPAN distribution Parse-CPAN-Meta, and specifically on function Parse​::CPAN​::Meta​::LoadFile(). I can reproduce the failure by using that function and the .yml file in Module-Install's test suite which failed.

Accordingly, I have filed a bug in Parse-CPAN-Meta's bug queue​:

https://rt.cpan.org/Ticket/Display.html?id=93072

Thank you very much.
Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented Feb 17, 2014

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Feb 17, 2014

From @xdg

Module-Install has a dependency on CPAN distribution Parse-CPAN-Meta, and specifically on function Parse​::CPAN​::Meta​::LoadFile(). I can reproduce the failure by using that function and the .yml file in Module-Install's test suite which failed.

Module​::Install appears to be generating or testing an invalid YAML
file -- encoded in Latin1 instead of UTF-8. The new, UTF-8 strict
CPAN​::Meta​::YAML which underlies Parse​::CPAN​::Meta throws an error
when reading such a file.

David

--
David Golden <xdg@​xdg.me>
Take back your inbox! → http​://www.bunchmail.com/
Twitter/IRC​: @​xdg

@p5pRT
Copy link
Author

p5pRT commented Feb 17, 2014

From @xdg

On Sun, Feb 16, 2014 at 9​:57 PM, David Golden <xdg@​xdg.me> wrote​:

Module​::Install appears to be generating or testing an invalid YAML
file -- encoded in Latin1 instead of UTF-8. The new, UTF-8 strict
CPAN​::Meta​::YAML which underlies Parse​::CPAN​::Meta throws an error
when reading such a file.

The new Parse​::CPAN​::Meta shipped to CPAN does its own decoding to
replace invalid characters before they reach CPAN​::Meta​::YAML.

Once merged, this ticket can be closed.

--
David Golden <xdg@​xdg.me>
Take back your inbox! → http​://www.bunchmail.com/
Twitter/IRC​: @​xdg

@p5pRT
Copy link
Author

p5pRT commented Feb 17, 2014

From @bingos

On Sun, Feb 16, 2014 at 11​:10​:04PM -0500, David Golden wrote​:

On Sun, Feb 16, 2014 at 9​:57 PM, David Golden <xdg@​xdg.me> wrote​:

Module​::Install appears to be generating or testing an invalid YAML
file -- encoded in Latin1 instead of UTF-8. The new, UTF-8 strict
CPAN​::Meta​::YAML which underlies Parse​::CPAN​::Meta throws an error
when reading such a file.

The new Parse​::CPAN​::Meta shipped to CPAN does its own decoding to
replace invalid characters before they reach CPAN​::Meta​::YAML.

Once merged, this ticket can be closed.

Merged as http​://perl5.git.perl.org/perl.git/commitdiff/f79ce037

Cheers,

--
Chris Williams
aka BinGOs
PGP ID 0x4658671F
http​://www.gumbynet.org.uk

@p5pRT
Copy link
Author

p5pRT commented Feb 17, 2014

From @jkeenan

On Sun Feb 16 20​:10​:57 2014, xdg@​xdg.me wrote​:

On Sun, Feb 16, 2014 at 9​:57 PM, David Golden <xdg@​xdg.me> wrote​:

Module​::Install appears to be generating or testing an invalid YAML
file -- encoded in Latin1 instead of UTF-8. The new, UTF-8 strict
CPAN​::Meta​::YAML which underlies Parse​::CPAN​::Meta throws an error
when reading such a file.

The new Parse​::CPAN​::Meta shipped to CPAN does its own decoding to
replace invalid characters before they reach CPAN​::Meta​::YAML.

Once merged, this ticket can be closed.

That merge has been done -- but could someone test Module​::Install against Perl 5 blead (commit f79ce03 or later)?

Thank you very much.
Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented Feb 17, 2014

From @andk

"James E Keenan via RT" <perlbug-followup@​perl.org> writes​:

The new Parse​::CPAN​::Meta shipped to CPAN does its own decoding to
replace invalid characters before they reach CPAN​::Meta​::YAML.

Once merged, this ticket can be closed.

That merge has been done -- but could someone test Module​::Install against Perl 5 blead (commit f79ce03 or later)?

I did, but I cannot confirm. Fails on
t/20_authors_with_special_characters.t with
v5.19.8-489-gf79ce03..v5.19.8-492-g91e4447

--
andreas

@p5pRT
Copy link
Author

p5pRT commented Feb 18, 2014

From @xdg

On Mon, Feb 17, 2014 at 4​:43 PM, Andreas Koenig > I did, but I cannot
confirm. Fails on

t/20_authors_with_special_characters.t with
v5.19.8-489-gf79ce03..v5.19.8-492-g91e4447

I'm not claiming that the fix makes Module​::install pass. I'm
claiming that Parse​::CPAN​::Meta is no longer fatal when reading an
illegally-encoded file.

The result of decoding an illegal file has changed (illegal sequences
are replaced), so if Module​::Install is expecting a specific result
from decoding an illegal file, it makes sense that its test would
fail.

David

--
David Golden <xdg@​xdg.me>
Take back your inbox! → http​://www.bunchmail.com/
Twitter/IRC​: @​xdg

@p5pRT
Copy link
Author

p5pRT commented Mar 7, 2014

From @rjbs

Resolved by today's Module-Install release, 1.08.

--
rjbs

@p5pRT
Copy link
Author

p5pRT commented Mar 7, 2014

@rjbs - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Mar 7, 2014
@p5pRT
Copy link
Author

p5pRT commented Mar 7, 2014

From manhcuongle@hotmail.com

D
------Original Message------
From​: Ricardo SIGNES via RT
Cc​: perl5-porters@​perl.org
ReplyTo​: perlbug-followup@​perl.org
Subject​: [perl #121262] Bleadperl v5.19.8-453-g2954a1e breaks ADAMK/Module-Install-1.06.tar.gz
Sent​: Mar 7, 2014 9​:53 AM

Resolved by today's Module-Install release, 1.08.

--
rjbs


via perlbug​: queue​: perl5 status​: open
https://rt-archive.perl.org/perl5/Ticket/Display.html?id=121262

Sent via MobiFone network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant