Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bleadperl v5.19.8-301-g1ab48e3 breaks DCONWAY/Perl6-Slurp-0.051004.tar.gz #13586

Closed
p5pRT opened this issue Feb 7, 2014 · 6 comments
Closed

Bleadperl v5.19.8-301-g1ab48e3 breaks DCONWAY/Perl6-Slurp-0.051004.tar.gz #13586

p5pRT opened this issue Feb 7, 2014 · 6 comments
Labels
distro-Linux

Comments

@p5pRT
Copy link

p5pRT commented Feb 7, 2014

Migrated from rt.perl.org#121198 (status was 'resolved')

Searchable as RT121198$
@p5pRT
Copy link
Author

p5pRT commented Feb 7, 2014

From @andk

git

commit 1ab48e3
Author​: Yves Orton <yves.orton@​booking.com>
Date​: Tue Feb 4 18​:48​:42 2014 +0800

  Add tests and fix new fatal errors related to $/

diagnostics

http​://www.cpantesters.org/cpan/report/ccaa8568-8e27-11e3-a199-e46b5d7e0655

perl -V

Summary of my perl5 (revision 5 version 19 subversion 9) configuration​:
  Commit id​: 1ab48e3
  Platform​:
  osname=linux, osvers=3.10-3-amd64, archname=x86_64-linux-thread-multi
  uname='linux k83 3.10-3-amd64 #1 smp debian 3.10.11-1 (2013-09-10) x86_64 gnulinux '
  config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/perl/v5.19.8-301-g1ab48e3/9980 -Dmyhostname=k83 -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Duseithreads -Uuselongdouble -DDEBUGGING=-g'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=define, usemultiplicity=define
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
  optimize='-O2 -g',
  cppflags='-D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.8.2', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/4.8/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lpthread -lc -lgdbm_compat
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
  libc=libc-2.17.so, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.17'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector'

Characteristics of this binary (from libperl)​:
  Compile-time options​: HAS_TIMES MULTIPLICITY PERLIO_LAYERS
  PERL_DONT_CREATE_GVSV
  PERL_HASH_FUNC_ONE_AT_A_TIME_HARD
  PERL_IMPLICIT_CONTEXT PERL_MALLOC_WRAP
  PERL_NEW_COPY_ON_WRITE PERL_PRESERVE_IVUV
  PERL_USE_DEVEL USE_64_BIT_ALL USE_64_BIT_INT
  USE_ITHREADS USE_LARGE_FILES USE_LOCALE
  USE_LOCALE_COLLATE USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC USE_PERLIO USE_PERL_ATOF
  USE_REENTRANT_API
  Built under linux
  Compiled at Feb 4 2014 11​:58​:52
  @​INC​:
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.19.8-301-g1ab48e3/9980/lib/site_perl/5.19.9/x86_64-linux-thread-multi
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.19.8-301-g1ab48e3/9980/lib/site_perl/5.19.9
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.19.8-301-g1ab48e3/9980/lib/5.19.9/x86_64-linux-thread-multi
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.19.8-301-g1ab48e3/9980/lib/5.19.9
  .

--
andreas

@p5pRT
Copy link
Author

p5pRT commented Feb 7, 2014

From @demerphq

Thanks.

So it seems like Perl6​::Slurp is piggybacking on perls $/ and doing
its own thing, which seems slightly dodgy, especially as normal
readline would behave quite differently than slurp would for some of
this piggybacking.

Part of me thinks if you piggy back on core functionality like this
you get to pick up the pieces when it blows up in your face, the other
part of me thinks that we should change the fatal into a warning.

I welcome other opinions,

Yves

On 7 February 2014 11​:59, Andreas J. Koenig via RT
<perlbug-followup@​perl.org> wrote​:

# New Ticket Created by (Andreas J. Koenig)
# Please include the string​: [perl #121198]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=121198 >

git
---
commit 1ab48e3
Author​: Yves Orton <yves.orton@​booking.com>
Date​: Tue Feb 4 18​:48​:42 2014 +0800

Add tests and fix new fatal errors related to $/

diagnostics
-----------
http​://www.cpantesters.org/cpan/report/ccaa8568-8e27-11e3-a199-e46b5d7e0655

perl -V
-------
Summary of my perl5 (revision 5 version 19 subversion 9) configuration​:
Commit id​: 1ab48e3
Platform​:
osname=linux, osvers=3.10-3-amd64, archname=x86_64-linux-thread-multi
uname='linux k83 3.10-3-amd64 #1 smp debian 3.10.11-1 (2013-09-10) x86_64 gnulinux '
config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/perl/v5.19.8-301-g1ab48e3/9980 -Dmyhostname=k83 -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Duseithreads -Uuselongdouble -DDEBUGGING=-g'
hint=recommended, useposix=true, d_sigaction=define
useithreads=define, usemultiplicity=define
use64bitint=define, use64bitall=define, uselongdouble=undef
usemymalloc=n, bincompat5005=undef
Compiler​:
cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
optimize='-O2 -g',
cppflags='-D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
ccversion='', gccversion='4.8.2', gccosandvers=''
intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
alignbytes=8, prototype=define
Linker and Libraries​:
ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/4.8/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lpthread -lc -lgdbm_compat
perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
libc=libc-2.17.so, so=so, useshrplib=false, libperl=libperl.a
gnulibc_version='2.17'
Dynamic Linking​:
dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector'

Characteristics of this binary (from libperl)​:
Compile-time options​: HAS_TIMES MULTIPLICITY PERLIO_LAYERS
PERL_DONT_CREATE_GVSV
PERL_HASH_FUNC_ONE_AT_A_TIME_HARD
PERL_IMPLICIT_CONTEXT PERL_MALLOC_WRAP
PERL_NEW_COPY_ON_WRITE PERL_PRESERVE_IVUV
PERL_USE_DEVEL USE_64_BIT_ALL USE_64_BIT_INT
USE_ITHREADS USE_LARGE_FILES USE_LOCALE
USE_LOCALE_COLLATE USE_LOCALE_CTYPE
USE_LOCALE_NUMERIC USE_PERLIO USE_PERL_ATOF
USE_REENTRANT_API
Built under linux
Compiled at Feb 4 2014 11​:58​:52
@​INC​:
/home/sand/src/perl/repoperls/installed-perls/perl/v5.19.8-301-g1ab48e3/9980/lib/site_perl/5.19.9/x86_64-linux-thread-multi
/home/sand/src/perl/repoperls/installed-perls/perl/v5.19.8-301-g1ab48e3/9980/lib/site_perl/5.19.9
/home/sand/src/perl/repoperls/installed-perls/perl/v5.19.8-301-g1ab48e3/9980/lib/5.19.9/x86_64-linux-thread-multi
/home/sand/src/perl/repoperls/installed-perls/perl/v5.19.8-301-g1ab48e3/9980/lib/5.19.9
.

--
andreas

--
perl -Mre=debug -e "/just|another|perl|hacker/"

@p5pRT
Copy link
Author

p5pRT commented Feb 7, 2014

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Mar 5, 2014

From @rjbs

On Fri Feb 07 01​:12​:51 2014, demerphq wrote​:

Part of me thinks if you piggy back on core functionality like this
you get to pick up the pieces when it blows up in your face, the other
part of me thinks that we should change the fatal into a warning.

I welcome other opinions,

I agree with both parts and think that in this situation we should make it a severe deprecation warning so that it can "fairly" be fatalized in the future. That way, Perl6​::Slurp can work until it's basically replaceable.

--
rjbs

@p5pRT
Copy link
Author

p5pRT commented Mar 24, 2014

From @rjbs

A new release of Perl6-Slurp was made without this problem.

--
rjbs

@p5pRT
Copy link
Author

p5pRT commented Mar 24, 2014

@rjbs - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Mar 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
distro-Linux
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p5pRT