Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.20 blocker? Regexp optimiser overflows in re_intuit_start #13582

Closed
p5pRT opened this issue Feb 6, 2014 · 6 comments
Closed

5.20 blocker? Regexp optimiser overflows in re_intuit_start #13582

p5pRT opened this issue Feb 6, 2014 · 6 comments

Comments

@p5pRT
Copy link

p5pRT commented Feb 6, 2014

Migrated from rt.perl.org#121190 (status was 'resolved')

Searchable as RT121190$

@p5pRT
Copy link
Author

p5pRT commented Feb 6, 2014

From @demerphq

Recently Brian Fraser has been compiling Perl with
-Accflags="-ftrapv", and has been pointing out overlow issues that it
reveals.

Compiling with this option will not even build as it encounters an
error in regexec.c line 745/746 during the build process.

This is reproducable with

./miniperl -Dr -e'"path_sep​:\t8490"=~m/^(\S+)​:\s*(\d+)$/'

Dave M's has a branch in progress to fix/improve the re_intuit_start()
which is the run time part of the regex optimiser, which resolves this
ticket.

This ticket is only a placeholder so we dont forget we need the branch
to be applied in time for 5.20.

See also perl #121182 for an earlier version of this ticket which went
off the rails and which we closed.

--
perl -Mre=debug -e "/just|another|perl|hacker/"

@p5pRT
Copy link
Author

p5pRT commented May 18, 2014

From @jkeenan

On Wed Feb 05 21​:15​:19 2014, demerphq wrote​:

Recently Brian Fraser has been compiling Perl with
-Accflags="-ftrapv", and has been pointing out overlow issues that it
reveals.

Compiling with this option will not even build as it encounters an
error in regexec.c line 745/746 during the build process.

This is reproducable with

./miniperl -Dr -e'"path_sep​:\t8490"=~m/^(\S+)​:\s*(\d+)$/'

Dave M's has a branch in progress to fix/improve the re_intuit_start()
which is the run time part of the regex optimiser, which resolves this
ticket.

This ticket is only a placeholder so we dont forget we need the branch
to be applied in time for 5.20.

I haven't seen this on our list of 5.20.0 blockers (https://rt-archive.perl.org/perl5/Ticket/Display.html?id=116923).  So it would be good to have the ticket's Subject line modified.

Suggestions?

Thank you very much.
Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented May 18, 2014

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented May 19, 2014

From @demerphq

As far as I know Dave's branch was merged, so this ticket can be closed I
think.

On 19 May 2014 00​:37, James E Keenan via RT <perlbug-followup@​perl.org>wrote​:

On Wed Feb 05 21​:15​:19 2014, demerphq wrote​:

Recently Brian Fraser has been compiling Perl with
-Accflags="-ftrapv", and has been pointing out overlow issues that it
reveals.

Compiling with this option will not even build as it encounters an
error in regexec.c line 745/746 during the build process.

This is reproducable with

./miniperl -Dr -e'"path_sep​:\t8490"=~m/^(\S+)​:\s*(\d+)$/'

Dave M's has a branch in progress to fix/improve the re_intuit_start()
which is the run time part of the regex optimiser, which resolves this
ticket.

This ticket is only a placeholder so we dont forget we need the branch
to be applied in time for 5.20.

I haven't seen this on our list of 5.20.0 blockers (
https://rt-archive.perl.org/perl5/Ticket/Display.html?id=116923).  So it would be good
to have the ticket's Subject line modified.

Suggestions?

Thank you very much.
Jim Keenan

---
via perlbug​: queue​: perl5 status​: new
https://rt-archive.perl.org/perl5/Ticket/Display.html?id=121190

--
perl -Mre=debug -e "/just|another|perl|hacker/"

@p5pRT
Copy link
Author

p5pRT commented May 19, 2014

From @jkeenan

On Sun May 18 23​:31​:08 2014, demerphq wrote​:

As far as I know Dave's branch was merged, so this ticket can be
closed I
think.

Okay. As an additional precaution I configured with the following​:

#####
sh ./Configure -des -Dusedevel -Accflags="-ftrapv"
#####

then ran 'make' and 'make -j8 test_harness'. (I don't pretend to understand what the 'ccflags' do.) All tests PASS.

Accordingly, I'm marking ticket resolved.

Thank you very much.
Jim Keenan

@p5pRT p5pRT closed this as completed May 19, 2014
@p5pRT
Copy link
Author

p5pRT commented May 19, 2014

@jkeenan - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant