From @cpansprout

Under PERL_DEBUG_READONLY_COW, these two test files fail​:

  ../cpan/IO-Compress/t/109merge-rawdeflate.t
  ../cpan/IO-Compress/t/cz-03zlib-v1.t

I have submitted a patch to <https://rt.cpan.org/Public/Bug/Display.html?id=91558>.
We really ought to get a new release integrated into bleadperl before 5.20 ships. We
can’t make copy-on-write more prevalent while core modules fail to handle it.

--

Father Chrysostomos

From @pmqs

Sorry for the delay in applying this patch. I tried it over the holidays last month, but it broke with Perl 5.6.* - looked like a ppport issue (I think). Been meaning to look at it again.

If 5.20 is imminent I'll see if I can get a chance to look at it this week.

Paul

-----Original Message-----
From​: Father Chrysostomos (via RT) [mailto​:perlbug-followup@​perl.org]
Sent​: 24 January 2014 06​:12
To​: bugs-bitbucket@​rt.perl.org
Subject​: [perl #121073] IO​::Compress COW problems

# New Ticket Created by Father Chrysostomos # Please include the string​: [perl #121073] # in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=121073 >

Under PERL_DEBUG_READONLY_COW, these two test files fail​:

  ../cpan/IO-Compress/t/109merge-rawdeflate.t
  ../cpan/IO-Compress/t/cz-03zlib-v1.t

I have submitted a patch to <https://rt.cpan.org/Public/Bug/Display.html?id=91558>.
We really ought to get a new release integrated into bleadperl before 5.20 ships. We
can’t make copy-on-write more prevalent while core modules fail to handle it.

--

Father Chrysostomos

The RT System itself - Status changed from 'new' to 'open'

From @khwilliamson

On 01/29/2014 02​:33 AM, Paul Marquess wrote​:

If 5.20 is imminent I'll see if I can get a chance to look at it this week.

5.20 is imminent

From @pmqs

From​: Karl Williamson [mailto​:public@​khwilliamson.com]

On 01/29/2014 02​:33 AM, Paul Marquess wrote​:

If 5.20 is imminent I'll see if I can get a chance to look at it this week.

5.20 is imminent

Thanks for the heads-up Karl.

Regarding the patch, I'm confused why C​::R​::Zlib needs updates, but C​::R​::Bzip2 doesn't. The XS code is practically identical (because I recycled Zlib.xs when I was writing Bzip2.xs), so I don't understand why there isn't a COW issue with both?

Paul

From perl5-porters@perl.org

Paul Marquess wrote​:

Regarding the patch, I'm confused why C​::R​::Zlib needs updates, but
C​::R​::Bzip2 doesn't. The XS code is practically identical (because I
recycled Zlib.xs when I was writing Bzip2.xs), so I don't understand why
there isn't a COW issue with both?

Presumably it does. I only fixed the issues that caused test failures
in the perl core under -Accflags=-DPERL_DEBUG_READONLY_COW. Those
failures were in IO​::Compress's tests, so presumably it tests with
:​:Zlib by default?

If you take the tests I included in the patch and adjust them for
Bzip2, do they fail with it?

From @pmqs

From​: Father Chrysostomos [mailto​:sprout@​cpan.org]

Paul Marquess wrote​:

Regarding the patch, I'm confused why C​::R​::Zlib needs updates, but
C​::R​::Bzip2 doesn't. The XS code is practically identical (because I
recycled Zlib.xs when I was writing Bzip2.xs), so I don't understand
why there isn't a COW issue with both?

Presumably it does. I only fixed the issues that caused test failures in
the perl core under -Accflags=-DPERL_DEBUG_READONLY_COW. Those failures
were in IO​::Compress's tests, so presumably it tests with :​:Zlib by
default?

The IO​::Compress tests use both Compress​::Raw​::Zlib and
Compress​::Raw​::Bzip2.

If you take the tests I included in the patch and adjust them for Bzip2,
do they fail with it?

Yep - they do. Merged the patch into Compress​::Raw​::Bzip2

Uploaded new versions (2.064) of the all the compression modules to CPAN.

Paul

@cpansprout - Status changed from 'open' to 'resolved'