Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blead broke HTML-FormHandler #13549

Closed
p5pRT opened this issue Jan 23, 2014 · 9 comments
Closed

blead broke HTML-FormHandler #13549

p5pRT opened this issue Jan 23, 2014 · 9 comments

Comments

@p5pRT
Copy link

p5pRT commented Jan 23, 2014

Migrated from rt.perl.org#121068 (status was 'resolved')

Searchable as RT121068$

@p5pRT
Copy link
Author

p5pRT commented Jan 23, 2014

From zefram@fysh.org

Created by zefram@fysh.org

On Perl 5.19.7 and 5.19.8, HTML-FormHandler-0.40055 is failing its tests
for me, with memory-related problems. I've seen this on 5.19.7​:

t/fields/repeatable.t ................... 1/? perl​: malloc.c​:4538​: _int_malloc​: Assertion `victim->fd_nextsize->bk_nextsize == victim' failed.
t/fields/repeatable.t ................... All 3 subtests passed

And these two failure modes on 5.19.8​:

t/fields/repeatable.t ................... 1/? perl​: malloc.c​:4636​: _int_malloc​: Assertion `victim->fd_nextsize->bk_nextsize == victim' failed.
t/fields/repeatable.t ................... All 2 subtests passed

panic​: attempt to copy freed scalar 9a07b7c to 9bc935c at /opt/perl-5.19.8/lib/site_perl/5.19.8/i686-linux-64int-ld/Class/MOP/Method/Wrapped.pm line 163.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 255 just after 2.
Attempt to free unreferenced scalar​: SV 0x9a07b7c during global destruction.
t/fields/repeatable.t ...................
Dubious, test returned 255 (wstat 65280, 0xff00)
All 2 subtests passed

5.19.7 introduced a memory bug, which was noted to affect
Test-Without-Module [perl #120657]. I initially thought HTML-FormHandler
was a victim of the same bug. But that bug was supposedly fixed in
5.19.8, and Test-Without-Module duly works again, but HTML-FormHandler
is still broken. It could be a bug in HTML-FormHandler, a different
core bug, or the same core bug having not been properly fixed.

Perl Info

Flags:
    category=core
    severity=medium

Site configuration information for perl 5.19.8:

Configured by root at Tue Jan 21 11:35:11 UTC 2014.

Summary of my perl5 (revision 5 version 19 subversion 8) configuration:
   
  Platform:
    osname=linux, osvers=2.6.32-5-686, archname=i686-linux-64int-ld
    uname='linux beryllium.photobox.priv 2.6.32-5-686 #1 smp fri may 10 08:33:48 utc 2013 i686 gnulinux '
    config_args='-des -Dusedevel -Uversiononly -Duseshrplib -Duse64bitint -Duselongdouble -Uusethreads -Uusemultiplicity -Dprefix=/opt/perl-5.19.8 -Dsiteprefix=/opt/perl-5.19.8 -Dvendorprefix=/opt/perl-5.19.8/vendor -Doptimize=-ggdb -O2 -Dcccdlflags=-fPIC -O2 -pipe'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=undef, usemultiplicity=undef
    use64bitint=define, use64bitall=undef, uselongdouble=define
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
    optimize='-ggdb -O2',
    cppflags='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
    ccversion='', gccversion='4.7.2', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=12345678
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    ivtype='long long', ivsize=8, nvtype='long double', nvsize=12, Off_t='off_t', lseeksize=8
    alignbytes=4, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib/gcc/i486-linux-gnu/4.7/include-fixed /usr/include/i386-linux-gnu /usr/lib /lib/i386-linux-gnu /lib/../lib /usr/lib/i386-linux-gnu /usr/lib/../lib /lib
    libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
    perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc
    libc=, so=so, useshrplib=true, libperl=libperl.so
    gnulibc_version='2.13'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E -Wl,-rpath,/opt/perl-5.19.8/lib/5.19.8/i686-linux-64int-ld/CORE'
    cccdlflags='-fPIC -O2 -pipe', lddlflags='-shared -ggdb -O2 -L/usr/local/lib -fstack-protector'



@INC for perl 5.19.8:
    /opt/perl-5.19.8/lib/site_perl/5.19.8/i686-linux-64int-ld
    /opt/perl-5.19.8/lib/site_perl/5.19.8
    /opt/perl-5.19.8/vendor/lib/vendor_perl/5.19.8/i686-linux-64int-ld
    /opt/perl-5.19.8/vendor/lib/vendor_perl/5.19.8
    /opt/perl-5.19.8/lib/5.19.8/i686-linux-64int-ld
    /opt/perl-5.19.8/lib/5.19.8
    .


Environment for perl 5.19.8:
    HOME=/root
    LANG (unset)
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/root/pub/i686-pc-linux-gnu/bin:/root/pub/common/bin:/usr/bin:/usr/sbin:/bin:/sbin:/usr/local/bin:/usr/local/sbin:/usr/games:/opt/geoip/bin:/opt/httpd/bin:/opt/perl/bin
    PERL_BADLANG (unset)
    SHELL=/usr/bin/zsh

@p5pRT
Copy link
Author

p5pRT commented Jan 25, 2014

From @cpansprout

On Thu Jan 23 07​:34​:24 2014, zefram@​fysh.org wrote​:

This is a bug report for perl from zefram@​fysh.org,
generated with the help of perlbug 1.40 running under perl 5.19.8.

-----------------------------------------------------------------
[Please describe your issue here]

On Perl 5.19.7 and 5.19.8, HTML-FormHandler-0.40055 is failing its
tests
for me, with memory-related problems. I've seen this on 5.19.7​:

t/fields/repeatable.t ................... 1/? perl​: malloc.c​:4538​:
_int_malloc​: Assertion `victim->fd_nextsize->bk_nextsize == victim'
failed.
t/fields/repeatable.t ................... All 3 subtests passed

And these two failure modes on 5.19.8​:

t/fields/repeatable.t ................... 1/? perl​: malloc.c​:4636​:
_int_malloc​: Assertion `victim->fd_nextsize->bk_nextsize == victim'
failed.
t/fields/repeatable.t ................... All 2 subtests passed

panic​: attempt to copy freed scalar 9a07b7c to 9bc935c at /opt/perl-
5.19.8/lib/site_perl/5.19.8/i686-linux-64int-
ld/Class/MOP/Method/Wrapped.pm line 163.
# Tests were run but no plan was declared and done_testing() was not
seen.
# Looks like your test exited with 255 just after 2.
Attempt to free unreferenced scalar​: SV 0x9a07b7c during global
destruction.
t/fields/repeatable.t ...................
Dubious, test returned 255 (wstat 65280, 0xff00)
All 2 subtests passed

5.19.7 introduced a memory bug, which was noted to affect
Test-Without-Module [perl #120657]. I initially thought HTML-
FormHandler
was a victim of the same bug. But that bug was supposedly fixed in
5.19.8, and Test-Without-Module duly works again, but HTML-FormHandler
is still broken. It could be a bug in HTML-FormHandler, a different
core bug, or the same core bug having not been properly fixed.

According to ticket #120626, this was caused by v5.19.6-22-gebdc880.
I cannot reproduce this with current blead (v5.19.7-34-g4922547).
Is it still a problem on your computer?

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Jan 25, 2014

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Jan 25, 2014

From zefram@fysh.org

Father Chrysostomos via RT wrote​:

I cannot reproduce this with current blead (v5.19.7-34-g4922547).

I don't understand how that qualifies as "current blead". As I reported,
I encountered the problem with v5.19.8, hundreds of commits in the future
of v5.19.7-34-g4922547.

Is it still a problem on your computer?

What comparison are you trying to make?

-zefram

@p5pRT
Copy link
Author

p5pRT commented Jan 26, 2014

From perl5-porters@perl.org

Zefram wrote​:

Father Chrysostomos via RT wrote​:

I cannot reproduce this with current blead (v5.19.7-34-g4922547).

I don't understand how that qualifies as "current blead".

Sorry. I copy and pasted the wrong thing. I have just re-confirmed
that it passes for me with v5.19.8-106-g6fbeaf2.

@p5pRT
Copy link
Author

p5pRT commented Jan 27, 2014

From zefram@fysh.org

Father Chrysostomos wrote​:

Sorry. I copy and pasted the wrong thing. I have just re-confirmed
that it passes for me with v5.19.8-106-g6fbeaf2.

Fails for me with both v5.19.8 and v5.19.8-106-g6fbeaf2.

t/fields/repeatable.t ................... 1/? perl​: malloc.c​:4538​: _int_malloc​: Assertion `victim->fd_nextsize->bk_nextsize == victim' failed.
t/fields/repeatable.t ................... All 3 subtests passed

perl -V for the v5.19.8-106-g6fbeaf2​:

===
Summary of my perl5 (revision 5 version 19 subversion 9) configuration​:
  Derived from​:
  Platform​:
  osname=linux, osvers=2.6.32-5-686, archname=i686-linux-64int-ld
  uname='linux beryllium.photobox.priv 2.6.32-5-686 #1 smp fri may 10 08​:33​:48 utc 2013 i686 gnulinux '
  config_args='-des -Dusedevel -Uversiononly -Duseshrplib -Duse64bitint -Duselongdouble -Uusethreads -Uusemultiplicity -Dprefix=/opt/perl-git-v5.19.8-106-g6fbeaf2 -Dsiteprefix=/opt/perl-git-v5.19.8-106-g6fbeaf2 -Dvendorprefix=/opt/perl-git-v5.19.8-106-g6fbeaf2/vendor -Doptimize=-ggdb -O2 -Dcccdlflags=-fPIC -O2 -pipe'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=undef, usemultiplicity=undef
  use64bitint=define, use64bitall=undef, uselongdouble=define
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
  optimize='-ggdb -O2',
  cppflags='-fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.7.2', gccosandvers=''
  intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
  ivtype='long long', ivsize=8, nvtype='long double', nvsize=12, Off_t='off_t', lseeksize=8
  alignbytes=4, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/i486-linux-gnu/4.7/include-fixed /usr/include/i386-linux-gnu /usr/lib /lib/i386-linux-gnu /lib/../lib /usr/lib/i386-linux-gnu /usr/lib/../lib /lib
  libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc
  libc=, so=so, useshrplib=true, libperl=libperl.so
  gnulibc_version='2.13'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E -Wl,-rpath,/opt/perl-git-v5.19.8-106-g6fbeaf2/lib/5.19.9/i686-linux-64int-ld/CORE'
  cccdlflags='-fPIC -O2 -pipe', lddlflags='-shared -ggdb -O2 -L/usr/local/lib -fstack-protector'

Characteristics of this binary (from libperl)​:
  Compile-time options​: HAS_TIMES PERLIO_LAYERS PERL_DONT_CREATE_GVSV
  PERL_HASH_FUNC_ONE_AT_A_TIME_HARD PERL_MALLOC_WRAP
  PERL_NEW_COPY_ON_WRITE PERL_PRESERVE_IVUV
  PERL_USE_DEVEL USE_64_BIT_INT USE_LARGE_FILES
  USE_LOCALE USE_LOCALE_COLLATE USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC USE_LONG_DOUBLE USE_PERLIO
  USE_PERL_ATOF
  Locally applied patches​:
  uncommitted-changes
  Built under linux
  Compiled at Jan 27 2014 11​:28​:13
  @​INC​:
  /opt/perl-git-v5.19.8-106-g6fbeaf2/lib/site_perl/5.19.9/i686-linux-64int-ld
  /opt/perl-git-v5.19.8-106-g6fbeaf2/lib/site_perl/5.19.9
  /opt/perl-git-v5.19.8-106-g6fbeaf2/vendor/lib/vendor_perl/5.19.9/i686-linux-64int-ld
  /opt/perl-git-v5.19.8-106-g6fbeaf2/vendor/lib/vendor_perl/5.19.9
  /opt/perl-git-v5.19.8-106-g6fbeaf2/lib/5.19.9/i686-linux-64int-ld
  /opt/perl-git-v5.19.8-106-g6fbeaf2/lib/5.19.9
  .

-zefram

@p5pRT
Copy link
Author

p5pRT commented Jan 30, 2014

From @cpansprout

As mentioned in #120626, Data​::Clone is at fault here. I have submitted a patch. I have also added mention of HTML​::FormHandler to perl5200delta’s Known Problems section, in commit 67fc615.

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Jan 30, 2014

@cpansprout - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Jan 30, 2014
@p5pRT
Copy link
Author

p5pRT commented Jan 30, 2014

From @wolfsage

On Thu, Jan 30, 2014 at 12​:55 AM, Father Chrysostomos via RT
<perlbug-followup@​perl.org> wrote​:

As mentioned in #120626, Data​::Clone is at fault here. I have submitted a patch. I have also added mention of HTML​::FormHandler to perl5200delta's Known Problems section, in commit 67fc615.

With your patch to Data​::Clone, valgrind reports t/fields/repeatable.t
is clean, and it passes. Thanks!

-- Matthew Horsfall (alh)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant