Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] remove unneeded dependency on Test::More 0.98 (RT#88531) #13387

Closed
p5pRT opened this issue Oct 31, 2013 · 7 comments
Closed

[PATCH] remove unneeded dependency on Test::More 0.98 (RT#88531) #13387

p5pRT opened this issue Oct 31, 2013 · 7 comments
Labels

Comments

@p5pRT
Copy link

p5pRT commented Oct 31, 2013

Migrated from rt.perl.org#120420 (status was 'resolved')

Searchable as RT120420$

@p5pRT
Copy link
Author

p5pRT commented Oct 31, 2013

From @karenetheridge

Attached is a patch to fix https://rt.cpan.org/Ticket/Display.html?id=88531

This is a bug report for perl from ether@​cpan.org,
generated with the help of perlbug 1.39 running under perl 5.19.6.

From 504110ec7939810c28a1cdbb63294392b00be780 Mon Sep 17 00​:00​:00 2001
From​: Karen Etheridge <ether@​cpan.org>
Date​: Wed, 30 Oct 2013 16​:27​:33 -0700
Subject​: [PATCH] remove unneeded dependency on Test​::More 0.98 (RT#88531)
MIME-Version​: 1.0
Content-Type​: multipart/mixed; boundary="------------1.8.4"
Status​: RO
Content-Length​: 822
Lines​: 30

This is a multi-part message in MIME format.
--------------1.8.4
Content-Type​: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding​: 8bit


dist/Carp/t/Carp_overload.t | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--------------1.8.4
Content-Type​: text/x-patch; name="0001-remove-unneeded-dependency-on-Test-More-0.98-RT-8853.patch"
Content-Transfer-Encoding​: 8bit
Content-Disposition​: attachment; filename="0001-remove-unneeded-dependency-on-Test-More-0.98-RT-8853.patch"

Inline Patch
diff --git a/dist/Carp/t/Carp_overload.t b/dist/Carp/t/Carp_overload.t
index 21225fa..6a0dbf9 100644
--- a/dist/Carp/t/Carp_overload.t
+++ b/dist/Carp/t/Carp_overload.t
@@ -1,6 +1,6 @@
 use warnings;
 no warnings 'once';
-use Test::More 0.98 tests => 7;
+use Test::More tests => 7;
 
 use Carp;
 

--------------1.8.4--


---
Flags:   category=library   severity=low   module=Carp

Site configuration information for perl 5.19.6​:

Configured by ether at Wed Oct 30 16​:45​:42 PDT 2013.

Summary of my perl5 (revision 5 version 19 subversion 6) configuration​:
  Commit id​: a9e3f35
  Platform​:
  osname=darwin, osvers=10.8.0, archname=darwin-2level
  uname='darwin tequila 10.8.0 darwin kernel version 10.8.0​: tue jun 7 16​:33​:36 pdt 2011; root​:xnu-1504.15.3~1release_i386 i386 '
  config_args='-des -Dusedevel'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=undef, usemultiplicity=undef
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-fno-common -DPERL_DARWIN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -I/opt/local/include',
  optimize='-O3',
  cppflags='-fno-common -DPERL_DARWIN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -I/opt/local/include'
  ccversion='', gccversion='4.2.1 (Apple Inc. build 5666) (dot 3)', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='env MACOSX_DEPLOYMENT_TARGET=10.3 cc', ldflags =' -fstack-protector -L/usr/local/lib -L/opt/local/lib'
  libpth=/usr/local/lib /opt/local/lib /usr/lib
  libs=-lgdbm -ldbm -ldl -lm -lutil -lc
  perllibs=-ldl -lm -lutil -lc
  libc=, so=dylib, useshrplib=false, libperl=libperl.a
  gnulibc_version=''
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=bundle, d_dlsymun=undef, ccdlflags=' '
  cccdlflags=' ', lddlflags=' -bundle -undefined dynamic_lookup -L/usr/local/lib -L/opt/local/lib -fstack-protector'


@​INC for perl 5.19.6​:
  lib
  /Users/ether/.perlbrew/libs/19.5@​std/lib/perl5/darwin-2level
  /Users/ether/.perlbrew/libs/19.5@​std/lib/perl5
  /usr/local/lib/perl5/site_perl/5.19.6/darwin-2level
  /usr/local/lib/perl5/site_perl/5.19.6
  /usr/local/lib/perl5/5.19.6/darwin-2level
  /usr/local/lib/perl5/5.19.6
  .


Environment for perl 5.19.6​:
  DYLD_LIBRARY_PATH (unset)
  HOME=/Users/ether
  LANG=en_CA.UTF-8
  LANGUAGE (unset)
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)
  PATH=/Users/ether/.perlbrew/libs/19.5@​std/bin​:/Users/ether/perl5/perlbrew/bin​:/Users/ether/perl5/perlbrew/perls/19.5/bin​:/Users/ether/bin​:/Users/ether/git/misc/install/tequila/bin​:/opt/local/bin​:/opt/local/sbin​:/usr/bin​:/bin​:/usr/sbin​:/sbin​:/usr/local/bin​:/usr/X11/bin​:/opt/local/share/git-core/contrib/workdir
  PERL5LIB=/Users/ether/.perlbrew/libs/19.5@​std/lib/perl5
  PERLBREW_BASHRC_VERSION=0.66
  PERLBREW_HOME=/Users/ether/.perlbrew
  PERLBREW_LIB=std
  PERLBREW_MANPATH=/Users/ether/.perlbrew/libs/19.5@​std/man​:/Users/ether/perl5/perlbrew/perls/19.5/man
  PERLBREW_PATH=/Users/ether/.perlbrew/libs/19.5@​std/bin​:/Users/ether/perl5/perlbrew/bin​:/Users/ether/perl5/perlbrew/perls/19.5/bin
  PERLBREW_PERL=19.5
  PERLBREW_ROOT=/Users/ether/perl5/perlbrew
  PERLBREW_VERSION=0.66
  PERLDOC_PAGER=less -sicMr
  PERL_AUTOINSTALL_PREFER_CPAN=1
  PERL_BADLANG (unset)
  PERL_LOCAL_LIB_ROOT=/Users/ether/.perlbrew/libs/19.5@​std
  PERL_MB_OPT=--install_base /Users/ether/.perlbrew/libs/19.5@​std
  PERL_MM_OPT=INSTALL_BASE=/Users/ether/.perlbrew/libs/19.5@​std
  SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Oct 31, 2013

From @karenetheridge

The subject should be​: [PATCH] remove unneeded dependency on Test​::More 0.98 (RT#88531)

@p5pRT
Copy link
Author

p5pRT commented Oct 31, 2013

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Nov 2, 2013

From @karenetheridge

Attached is, I hope, the real patch.

@p5pRT
Copy link
Author

p5pRT commented Nov 2, 2013

From @karenetheridge

0001-remove-unneeded-dependency-on-Test-More-0.98-RT-8853.patch
From 504110ec7939810c28a1cdbb63294392b00be780 Mon Sep 17 00:00:00 2001
From: Karen Etheridge <ether@cpan.org>
Date: Wed, 30 Oct 2013 16:27:33 -0700
Subject: [PATCH] remove unneeded dependency on Test::More 0.98 (RT#88531)

---
 dist/Carp/t/Carp_overload.t | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dist/Carp/t/Carp_overload.t b/dist/Carp/t/Carp_overload.t
index 21225fa..6a0dbf9 100644
--- a/dist/Carp/t/Carp_overload.t
+++ b/dist/Carp/t/Carp_overload.t
@@ -1,6 +1,6 @@
 use warnings;
 no warnings 'once';
-use Test::More 0.98 tests => 7;
+use Test::More tests => 7;
 
 use Carp;
 
-- 
1.8.4

@p5pRT
Copy link
Author

p5pRT commented Nov 2, 2013

From @cpansprout

On Wed Oct 30 21​:31​:55 2013, ether@​cpan.org wrote​:

Attached is a patch to fix
https://rt.cpan.org/Ticket/Display.html?id=88531

This is a bug report for perl from ether@​cpan.org,
generated with the help of perlbug 1.39 running under perl 5.19.6.

From 504110ec7939810c28a1cdbb63294392b00be780 Mon Sep 17 00​:00​:00 2001
From​: Karen Etheridge <ether@​cpan.org>
Date​: Wed, 30 Oct 2013 16​:27​:33 -0700
Subject​: [PATCH] remove unneeded dependency on Test​::More 0.98
(RT#88531)
MIME-Version​: 1.0
Content-Type​: multipart/mixed; boundary="------------1.8.4"
Status​: RO
Content-Length​: 822
Lines​: 30

Thank you. Applied as b82e68e.

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Nov 2, 2013

@cpansprout - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Nov 2, 2013
@p5pRT p5pRT added the hasPatch label Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant