Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleadperl v5.19.3-139-g2537512 breaks TOBYINK/returning-0.001.tar.gz #13243

Closed
p5pRT opened this issue Sep 9, 2013 · 7 comments
Closed

Bleadperl v5.19.3-139-g2537512 breaks TOBYINK/returning-0.001.tar.gz #13243

p5pRT opened this issue Sep 9, 2013 · 7 comments

Comments

@p5pRT
Copy link

p5pRT commented Sep 9, 2013

Migrated from rt.perl.org#119681 (status was 'resolved')

Searchable as RT119681$

@p5pRT
Copy link
Author

p5pRT commented Sep 9, 2013

From @andk

git bisect


commit 2537512
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Mon Aug 26 23​:21​:26 2013 -0700

  [perl #119311] Keep CvDEPTH and savestack in sync

diagnostics


http​://www.cpantesters.org/cpan/report/3db9292c-1474-11e3-9f09-9cca7e66b2dc

perl -V


Summary of my perl5 (revision 5 version 19 subversion 4) configuration​:
  Commit id​: 2537512
  Platform​:
  osname=linux, osvers=3.10-2-amd64, archname=x86_64-linux-thread-multi
  uname='linux k83 3.10-2-amd64 #1 smp debian 3.10.7-1 (2013-08-17) x86_64 gnulinux '
  config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/perl/v5.19.3-139-g2537512/9980 -Dmyhostname=k83 -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Duseithreads -Uuselongdouble -DDEBUGGING=-g'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=define, usemultiplicity=define
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
  optimize='-O2 -g',
  cppflags='-D_REENTRANT -D_GNU_SOURCE -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.8.1', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /usr/lib
  libs=-lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lpthread -lc -lgdbm_compat
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lpthread -lc
  libc=, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.17'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector'

Characteristics of this binary (from libperl)​:
  Compile-time options​: HAS_TIMES MULTIPLICITY PERLIO_LAYERS
  PERL_DONT_CREATE_GVSV
  PERL_HASH_FUNC_ONE_AT_A_TIME_HARD
  PERL_IMPLICIT_CONTEXT PERL_MALLOC_WRAP
  PERL_NEW_COPY_ON_WRITE PERL_PRESERVE_IVUV
  PERL_USE_DEVEL USE_64_BIT_ALL USE_64_BIT_INT
  USE_ITHREADS USE_LARGE_FILES USE_LOCALE
  USE_LOCALE_COLLATE USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC USE_PERLIO USE_PERL_ATOF
  USE_REENTRANT_API
  Built under linux
  Compiled at Sep 9 2013 16​:14​:50
  @​INC​:
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.19.3-139-g2537512/9980/lib/site_perl/5.19.4/x86_64-linux-thread-multi
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.19.3-139-g2537512/9980/lib/site_perl/5.19.4
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.19.3-139-g2537512/9980/lib/5.19.4/x86_64-linux-thread-multi
  /home/sand/src/perl/repoperls/installed-perls/perl/v5.19.3-139-g2537512/9980/lib/5.19.4
  .

--
andreas

@p5pRT
Copy link
Author

p5pRT commented Sep 9, 2013

From perl@profvince.com

On 09/09/2013 16​:46, (Andreas J. Koenig) (via RT) wrote​:

# New Ticket Created by (Andreas J. Koenig)
# Please include the string​: [perl #119681]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=119681 >

git bisect
----------
commit 2537512
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Mon Aug 26 23​:21​:26 2013 -0700

 \[perl \#119311\] Keep CvDEPTH and savestack in sync

diagnostics
-----------
http​://www.cpantesters.org/cpan/report/3db9292c-1474-11e3-9f09-9cca7e66b2dc

This problem can be reduced to :

  $ cat z.t
  use Test​::More tests => 1;
  use Scope​::Upper qw<unwind SUB UP>;
  sub foo {
  my $r = 123;
  unwind $r, UP SUB;
  }
  sub bar { foo() }
  is bar(), 123;

  $ perl5.19.4_g044aa60-shr-mul -Mblib z.t
  1..1
  not ok 1
  # Failed test at z.t line 8.
  # got​: undef
  # expected​: '123'
  # Looks like you failed 1 test of 1.

Scope​::Upper​::unwind used to rely on the stack being preserved when
dounwind() is called. However, starting with change 2537512, dounwind()
can now call leave_scope() which will clean up lexicals in the unwinded
scopes. This causes the loss of $r in the example.

I can fix this on Scope​::Upper's side, but I don't know if this change
can have other naughty implications in pure Perl or reasonably sane XS code.

Vincent

@p5pRT
Copy link
Author

p5pRT commented Sep 9, 2013

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Sep 9, 2013

From @cpansprout

On Mon Sep 09 10​:04​:48 2013, perl@​profvince.com wrote​:

I can fix this on Scope​::Upper's side, but I don't know if this change
can have other naughty implications in pure Perl or reasonably sane XS
code.

I don’t think it will. In any case, we really need to keep CvDEPTH in
synch with the lexicals, which we could accomplish by moving CvDEPTH
into the savestack, but then the reference count on the sub would also
have to go on the savestack. I think that might have greater repercussions.

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Sep 10, 2013

From perl@profvince.com

On 09/09/2013 16​:46, (Andreas J. Koenig) (via RT) wrote​:

# New Ticket Created by (Andreas J. Koenig)
# Please include the string​: [perl #119681]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=119681 >

git bisect
----------
commit 2537512
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Mon Aug 26 23​:21​:26 2013 -0700

 \[perl \#119311\] Keep CvDEPTH and savestack in sync

diagnostics
-----------
http​://www.cpantesters.org/cpan/report/3db9292c-1474-11e3-9f09-9cca7e66b2dc

I've just uploaded Scope​::Upper 0.24 that solves the issue.

Vincent

@p5pRT
Copy link
Author

p5pRT commented Sep 10, 2013

From @cpansprout

On Tue Sep 10 04​:18​:02 2013, perl@​profvince.com wrote​:

On 09/09/2013 16​:46, (Andreas J. Koenig) (via RT) wrote​:

# New Ticket Created by (Andreas J. Koenig)
# Please include the string​: [perl #119681]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=119681 >

git bisect
----------
commit 2537512
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Mon Aug 26 23​:21​:26 2013 -0700

 \[perl \#119311\] Keep CvDEPTH and savestack in sync

diagnostics
-----------
http​://www.cpantesters.org/cpan/report/3db9292c-1474-11e3-9f09-
9cca7e66b2dc

I've just uploaded Scope​::Upper 0.24 that solves the issue.

Thank you.

--

Father Chrysostomos

@p5pRT
Copy link
Author

p5pRT commented Sep 10, 2013

@cpansprout - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant