Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dangerous branch names in the security repository #12791

Open
p5pRT opened this issue Feb 18, 2013 · 4 comments
Open

dangerous branch names in the security repository #12791

p5pRT opened this issue Feb 18, 2013 · 4 comments
Labels
Closable? We might be able to close this ticket, but we need to check with the reporter

Comments

@p5pRT
Copy link

p5pRT commented Feb 18, 2013

Migrated from rt.perl.org#116839 (status was 'open')

Searchable as RT116839$

@p5pRT
Copy link
Author

p5pRT commented Feb 18, 2013

From @nwc10

Right now the branch names for blead and maint-* are the same in the
security repository. This makes it way to easy to push to the wrong one.
(As Yves accidentally demonstrated)

If we don't change this, that won't be the last time :-(

In another message, I suggested​:

1) change the branch names to sec-blead, sec-maint-5.16 etc in the security
  repository
2) put a hook in it to forbid branches that don't start /^sec-/
3) put a hook in the main repository to forbid branches that do start /^sec-/

I think that this will solve the problem, without making life too hard for
anyone working on stuff.

Should we do this?
Is there a better way?

Nicholas Clark

@p5pRT
Copy link
Author

p5pRT commented Feb 18, 2013

From @nwc10

On Mon Feb 18 07​:07​:35 2013, nicholas wrote​:

Forgot the PS - I think that this ticket can go public once
CVE-2013-1667 is public.

Nicholas Clark

@p5pRT
Copy link
Author

p5pRT commented Feb 18, 2013

@nwc10 - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Feb 18, 2013

From @demerphq

On Mon Feb 18 07​:07​:35 2013, nicholas wrote​:

Right now the branch names for blead and maint-* are the same in the
security repository. This makes it way to easy to push to the wrong
one.
(As Yves accidentally demonstrated)

If we don't change this, that won't be the last time :-(

In another message, I suggested​:

1) change the branch names to sec-blead, sec-maint-5.16 etc in the
security
repository
2) put a hook in it to forbid branches that don't start /^sec-/
3) put a hook in the main repository to forbid branches that do start
/^sec-/

I think that this will solve the problem, without making life too hard
for
anyone working on stuff.

Should we do this?
Is there a better way?

Well if people set up their remotes properly, unlike me, then it is less
likely to be an issue, but IMO yes we should.

I think as part of this ticket we should also figure out how to ensure
that certain branches, such as blead, stay up to date in the perlsec.git
repo.

Yves

@toddr toddr added the Closable? We might be able to close this ticket, but we need to check with the reporter label Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closable? We might be able to close this ticket, but we need to check with the reporter
Projects
None yet
Development

No branches or pull requests

2 participants