New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PERLDB_OPTS="Frame=1 veryCompact" apparently broken since before 5.8.9 #12681
Comments
From @kentfredric# 5.8.9 PERLDB_OPTS="Frame=1 NonStop veryCompact" perl -d -e1 Can't use an undefined value as a symbol reference at Compilation failed in require. at -e line 0 main::BEGIN() called at eval {...} called at BEGIN failed--compilation aborted. at -e line 0 # 5.16.2 PERLDB_OPTS="Frame=1 NonStop veryCompact" perl -d -E1 Can't use an undefined value as a symbol reference at Compilation failed in require. at -e line 0. main::BEGIN() called at -e line 0 eval {...} called at -e line 0 BEGIN failed--compilation aborted. at -e line 0. # 5.17.7 PERLDB_OPTS="Frame=1 NonStop veryCompact" perl -d -e1 Variable "$doret" is not imported at (eval at (eval 4)[/home/webadmin/perl5/perlbrew/perls/perl-5.17.7/lib/5.17.7/perl5db.pl:7318] eval ' local $frame = 0; local $doret = -2; require \'dumpvar.pl\'; 1; ' called at /home/webadmin/perl5/perlbrew/perls/perl-5.17.7/lib/5.17.7/perl5db.pl DB::parse_options('Frame=1 NonStop veryCompact') called at require perl5db.pl called at -e line 0 main::BEGIN() called at (eval eval {...} called at (eval Global symbol "$doret" requires explicit package name at (eval Compilation failed in require. at -e line 0. main::BEGIN() called at -e line 0 eval {...} called at -e line 0 BEGIN failed--compilation aborted. at -e line 0. Flags: Site configuration information for perl 5.17.7: Configured by kent at Wed Dec 19 13:06:58 NZDT 2012. Summary of my perl5 (revision 5 version 17 subversion 7) configuration: Platform: Locally applied patches: @INC for perl 5.17.7: Environment for perl 5.17.7: -- |
From kevin@dawson10.plus.com#116264: PERLDB_OPTS="Frame=1 veryCompact" apparently broken since https://rt-archive.perl.org/perl5//Public/Bug/Display.html?id=116264 inc tests: $ LD_LIBRARY_PATH=$PWD ./perl -I$PWD/lib utils/prove -l lib/perl5db.t regards ps if this is the wrong way of submitting this patch please advise: |
From kevin@dawson10.plus.com0001-fix-for-perlbug-116264-bowtie.patchFrom 21b7fd963f35ddd704047e6316dc97bcbd4acd5b Mon Sep 17 00:00:00 2001
From: kevin dawson <bowtie@cpan.org>
Date: Sat, 24 Aug 2013 20:14:34 +0100
Subject: [PATCH] fix for perlbug #116264 (bowtie)
---
lib/perl5db.pl | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/lib/perl5db.pl b/lib/perl5db.pl
index ab82616..68aa492 100644
--- a/lib/perl5db.pl
+++ b/lib/perl5db.pl
@@ -7479,12 +7479,7 @@ sub parse_options {
# Load any module that this option requires.
if ( defined($optionRequire{$option}) && defined($val) ) {
- eval qq{
- local \$frame = 0;
- local \$doret = -2;
- require '$optionRequire{$option}';
- 1;
- } || die $@ # XXX: shouldn't happen
+ eval { require $optionRequire{$option} } || die $@ # XXX: shouldn't happen
}
# Set it.
--
1.8.1.2
|
From @cpansproutOn Sat Aug 24 12:24:21 2013, kevin@dawson10.plus.com wrote:
It’s fine, but if you could put [perl #116264] in the subject line it -- Father Chrysostomos |
The RT System itself - Status changed from 'new' to 'open' |
From kevin@dawson10.plus.comAdded an additional test for previous patch 0002-Add-test-for-116264-bowtie.patch regards |
From kevin@dawson10.plus.com0002-Add-test-for-116264-bowtie.patchFrom 362bdde6fdf6d31294bb38f7ced47cc300f56b74 Mon Sep 17 00:00:00 2001
From: kevin dawson <bowtie@cpan.org>
Date: Sun, 25 Aug 2013 20:23:06 +0100
Subject: [PATCH 2/2] Add test for #116264 (bowtie)
---
lib/perl5db.t | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/lib/perl5db.t b/lib/perl5db.t
index 17fa744..13356f7 100644
--- a/lib/perl5db.t
+++ b/lib/perl5db.t
@@ -29,7 +29,7 @@ BEGIN {
$ENV{PERL_RL} = 'Perl'; # Suppress system Term::ReadLine::Gnu
}
-plan(119);
+plan(121);
my $rc_filename = '.perldb';
@@ -116,7 +116,14 @@ EOF
is( $?, 0, '[perl #41461] frame=2 noTTY does not crash debugger, exit == 0' );
like( $output, 'success' , '[perl #41461] code is run' );
}
-
+# [ perl #116264] frame=1 NonStop veryCompact
+{
+ local $ENV{PERLDB_OPTS} = "frame=1 NonStop veryCompact";
+ rc('');
+ my $output = runperl( switches => [ '-d' ], prog => 'print q{success}' );
+ is( $?, 0, '[perl #116264] frame=1 NonStop veryCompact does not crash debugger, exit == 0' );
+ like( $output, 'success' , '[perl #116264] code is run' );
+}
package DebugWrap;
sub new {
--
1.8.1.2
|
From @jkeenanOn Sat Aug 24 12:24:21 2013, kevin@dawson10.plus.com wrote:
When I apply your first patch to blead, then modify the OP's command to ##### Is that what I *should* be getting? I get that same message after applying your second patch as well, then With one exception, all tests pass, but since I don't know enough about The one test failure suggests that lib/perl5db.pl will need an increment ##### Thank you very much. |
The RT System itself - Status changed from 'new' to 'open' |
From kevin@dawson10.plus.comOn 26/08/13 01:28, James E Keenan via RT wrote:
this was initially tested as: $ PERLDB_OPTS="frame=0 NonStop veryCompact" LD_LIBRARY_PATH=$PWD ./perl so I had another look at lin/perl5db.t hence the additional patch regards |
From kevin@dawson10.plus.com0003-Add-test-for-116264-bowtie.patchFrom dfc6d96955cc65998718e999629585eb989b6926 Mon Sep 17 00:00:00 2001
From: kevin dawson <bowtie@cpan.org>
Date: Mon, 26 Aug 2013 11:18:41 +0100
Subject: [PATCH 3/3] Add test for 116264 (bowtie)
---
lib/perl5db.t | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/perl5db.t b/lib/perl5db.t
index 13356f7..31b9160 100644
--- a/lib/perl5db.t
+++ b/lib/perl5db.t
@@ -111,7 +111,6 @@ EOF
# [ perl #41461] Frame=2 noTTY
{
local $ENV{PERLDB_OPTS} = "frame=2 noTTY nonstop";
- rc('');
my $output = runperl( switches => [ '-d' ], prog => 'print q{success}' );
is( $?, 0, '[perl #41461] frame=2 noTTY does not crash debugger, exit == 0' );
like( $output, 'success' , '[perl #41461] code is run' );
@@ -119,7 +118,6 @@ EOF
# [ perl #116264] frame=1 NonStop veryCompact
{
local $ENV{PERLDB_OPTS} = "frame=1 NonStop veryCompact";
- rc('');
my $output = runperl( switches => [ '-d' ], prog => 'print q{success}' );
is( $?, 0, '[perl #116264] frame=1 NonStop veryCompact does not crash debugger, exit == 0' );
like( $output, 'success' , '[perl #116264] code is run' );
--
1.8.1.2
|
From SmithCW@familysearch.orgUnsubscribe Sent from my iPhone On Aug 25, 2013, at 6:28 PM, "James E Keenan via RT" <perlbug-followup@perl.org> wrote:
NOTICE: This email message is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. |
From @tonycozOn Sun Aug 25 17:28:08 2013, jkeenan wrote:
You shouldn't be getting that, but it doesn't appear to be the fault of For example, blead: tony@mars:.../git/perl2$ PERLDB_OPTS="Frame=15" ./perl -Ilib -d -e1 Loading DB routines from perl5db.pl version 1.42 Enter h or 'h h' for help, or 'man perldebug' for more help. Package -e. 5.14.2: tony@mars:.../git/perl2$ PERLDB_OPTS="Frame=15" perl -d -e1 Loading DB routines from perl5db.pl version 1.33 Enter h or `h h' for help, or `man perldebug' for more help. Package -e. I'm a bit concerned about losing the initializations of $frame and Tony |
Migrated from rt.perl.org#116264 (status was 'open')
Searchable as RT116264$
The text was updated successfully, but these errors were encountered: