Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data::Dumper does not declare deps in META #12633

Closed
p5pRT opened this issue Dec 8, 2012 · 10 comments
Closed

Data::Dumper does not declare deps in META #12633

p5pRT opened this issue Dec 8, 2012 · 10 comments

Comments

@p5pRT
Copy link

p5pRT commented Dec 8, 2012

Migrated from rt.perl.org#116028 (status was 'resolved')

Searchable as RT116028$

@p5pRT
Copy link
Author

p5pRT commented Dec 8, 2012

From @ribasushi

This is a bug report for perl from ribasushi@​cpan.org,
generated with the help of perlbug 1.39 running under perl 5.10.1.


[Please describe your issue here]

Data​::Dumper now requires Test​::More 0.6, but does not say anything
about it in its META[1]. Makes Data​::Dumper non-installable on perls
before 5.8.8.

Also I noticed that your META has dynamic_config=1 while there is
nothing doing dynamic configuration.

Cheers

[1] https://metacpan.org/source/SMUELLER/Data-Dumper-2.136/META.yml

@p5pRT
Copy link
Author

p5pRT commented Dec 8, 2012

From @jkeenan

On Sat Dec 08 10​:10​:34 2012, ribasushi@​cpan.org wrote​:

This is a bug report for perl from ribasushi@​cpan.org,
generated with the help of perlbug 1.39 running under perl 5.10.1.

-----------------------------------------------------------------
[Please describe your issue here]

Data​::Dumper now requires Test​::More 0.6, but does not say anything
about it in its META[1].

True, but perhaps there's a larger problem here, viz., that we don't
have a 'test_requires' entry in any of the YAML files which accompany
modules in the core distribution.

$ find . -type f -name '*.yml' | xargs grep -n test_requires | wc -l
  0

Makes Data​::Dumper non-installable on perls
before 5.8.8.

But I doubt this is a real concern. After all​:

$ corelist Data​::Dumper
Data​::Dumper was first released with perl 5.005

So *a* Data​::Dumper can always be found for Perl 5.6. And I'm sure that
if someone really wanted to install an up-to-date Data​::Dumper on a
14-year-old, no-longer-maintained Perl 5.6, that person could simply
skip the tests which require Test​::More 0.6 (which in itself is a
relatively old version of that module).

Mis dos centavos.

Jim Keenan

@p5pRT
Copy link
Author

p5pRT commented Dec 8, 2012

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Dec 8, 2012

From @ribasushi

On Sat, Dec 08, 2012 at 11​:17​:06AM -0800, James E Keenan via RT wrote​:

On Sat Dec 08 10​:10​:34 2012, ribasushi@​cpan.org wrote​:

This is a bug report for perl from ribasushi@​cpan.org,
generated with the help of perlbug 1.39 running under perl 5.10.1.

-----------------------------------------------------------------
[Please describe your issue here]

Data​::Dumper now requires Test​::More 0.6, but does not say anything
about it in its META[1].

True, but perhaps there's a larger problem here, viz., that we don't
have a 'test_requires' entry in any of the YAML files which accompany
modules in the core distribution.

$ find . -type f -name '*.yml' | xargs grep -n test_requires | wc -l
0

Makes Data​::Dumper non-installable on perls
before 5.8.8.

But I doubt this is a real concern. After all​:

$ corelist Data​::Dumper
Data​::Dumper was first released with perl 5.005

So *a* Data​::Dumper can always be found for Perl 5.6. And I'm sure that
if someone really wanted to install an up-to-date Data​::Dumper on a
14-year-old, no-longer-maintained Perl 5.6, that person could simply
skip the tests which require Test​::More 0.6 (which in itself is a
relatively old version of that module).

It is now a dual-lifed module, and *some* distributions now require a
Data​::Dumper upgrade. Hence why I filed the ticket.

@p5pRT
Copy link
Author

p5pRT commented Dec 9, 2012

From mail@steffen-mueller.net

On 12/08/2012 08​:41 PM, Peter Rabbitson wrote​:

It is now a dual-lifed module, and *some* distributions now require a
Data​::Dumper upgrade. Hence why I filed the ticket.

The ticket is valid, but would you care to submit a patch?

https://github.com/tsee/Data-Dumper

Best regards,
Steffen

@p5pRT
Copy link
Author

p5pRT commented Dec 9, 2012

From @ribasushi

On Sun, Dec 09, 2012 at 01​:21​:36AM -0800, mail@​steffen-mueller.net via RT wrote​:

On 12/08/2012 08​:41 PM, Peter Rabbitson wrote​:

It is now a dual-lifed module, and *some* distributions now require a
Data​::Dumper upgrade. Hence why I filed the ticket.

The ticket is valid, but would you care to submit a patch?

https://github.com/tsee/Data-Dumper

Absolutely. I didn't do it because was unaware of the external-to-p5p repo.
Submitting a separate patch for this as well.

Also is it customary for dual-life modules to have their bug queue pointing
to http​://rt.perl.org/perlbug/ ? I looked around the perldocs for a dual-life
manual of sorts, but couldn't find anything relevant.

Cheers

@p5pRT
Copy link
Author

p5pRT commented Dec 10, 2012

From @iabyn

On Sun, Dec 09, 2012 at 01​:32​:39PM +0100, Leon Timmermans wrote​:

On Sun, Dec 9, 2012 at 12​:26 PM, Peter Rabbitson <ribasushi@​cpan.org> wrote​:

Also is it customary for dual-life modules to have their bug queue pointing
to http​://rt.perl.org/perlbug/ ? I looked around the perldocs for a dual-life
manual of sorts, but couldn't find anything relevant.

If upstream is cpan, it should be reported in its own bugtracker
(typically rt.cpan.org). If upstream is blead it should be reported at
rt.perl.org. This doesn't appear to be documented well, since new
people often do it wrong. The status of a module can be looked up in
Porting/Maintainers.pl, there probably should be an easy to use
website to expose this information to the rest of the world.

perlbug currently prompts for the module name; then if there's an entry
for that module in %Module​::CoreList​::bug_tracker, suggests that the user
submit the bug via the specified tracker.

--
Modern art​:
  "That's easy, I could have done that!"
  "Ah, but you didn't!"

@p5pRT
Copy link
Author

p5pRT commented Dec 12, 2012

From @tsee

Data​::Dumper 2.139 with Peter's patch was just uploaded to PAUSE.

--Steffen

@p5pRT
Copy link
Author

p5pRT commented Dec 12, 2012

From [Unknown Contact. See original ticket]

Data​::Dumper 2.139 with Peter's patch was just uploaded to PAUSE.

--Steffen

@p5pRT
Copy link
Author

p5pRT commented Dec 12, 2012

@tsee - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant