Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort{goto} #12242

Open
p5pRT opened this issue Jul 1, 2012 · 4 comments
Open

sort{goto} #12242

p5pRT opened this issue Jul 1, 2012 · 4 comments

Comments

@p5pRT
Copy link

p5pRT commented Jul 1, 2012

Migrated from rt.perl.org#113938 (status was 'open')

Searchable as RT113938$

@p5pRT
Copy link
Author

p5pRT commented Jul 1, 2012

From @cpansprout

This is related to #113936.

$ perl5.15.9 -e '@​a=sort { goto FOO; FOO​: 1,2,3} 1,2,3; FOO​:'
Can't "goto" out of a pseudo block at -e line 1.

$ perl5.15.9 -e '@​a=sort {;{ goto FOO; FOO​: 1,2,3}} 1,2,3; FOO​:'
<nothing>


Flags​:
  category=core
  severity=low


Site configuration information for perl 5.17.2​:

Configured by sprout at Mon Jun 25 13​:28​:03 PDT 2012.

Summary of my perl5 (revision 5 version 17 subversion 2) configuration​:
  Snapshot of​: 49f4c4e
  Platform​:
  osname=darwin, osvers=10.5.0, archname=darwin-2level
  uname='darwin pint.local 10.5.0 darwin kernel version 10.5.0​: fri nov 5 23​:20​:39 pdt 2010; root​:xnu-1504.9.17~1release_i386 i386 '
  config_args='-de -DDEBUGGING -Dusedevel'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=undef, usemultiplicity=undef
  useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
  use64bitint=undef, use64bitall=undef, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-fno-common -DPERL_DARWIN -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include',
  optimize='-O3 -g',
  cppflags='-fno-common -DPERL_DARWIN -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.2.1 (Apple Inc. build 5664)', gccosandvers=''
  intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='env MACOSX_DEPLOYMENT_TARGET=10.3 cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib
  libs=-ldbm -ldl -lm -lutil -lc
  perllibs=-ldl -lm -lutil -lc
  libc=, so=dylib, useshrplib=false, libperl=libperl.a
  gnulibc_version=''
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=bundle, d_dlsymun=undef, ccdlflags=' '
  cccdlflags=' ', lddlflags=' -bundle -undefined dynamic_lookup -L/usr/local/lib -fstack-protector'

Locally applied patches​:
 


@​INC for perl 5.17.2​:
  /usr/local/lib/perl5/site_perl/5.17.2/darwin-2level
  /usr/local/lib/perl5/site_perl/5.17.2
  /usr/local/lib/perl5/5.17.2/darwin-2level
  /usr/local/lib/perl5/5.17.2
  /usr/local/lib/perl5/site_perl
  .


Environment for perl 5.17.2​:
  DYLD_LIBRARY_PATH (unset)
  HOME=/Users/sprout
  LANG=en_US.UTF-8
  LANGUAGE (unset)
  LD_LIBRARY_PATH (unset)
  LOGDIR (unset)
  PATH=/usr/bin​:/bin​:/usr/sbin​:/sbin​:/usr/local/bin​:/usr/X11/bin​:/usr/local/bin
  PERL_BADLANG (unset)
  SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Jan 23, 2017

From zefram@fysh.org

Similar and related​:

$ perl -lwe 'sub aaa ($$) { goto FOO; FOO​: $_[0] <=> $_[1] } print sort aaa (7, 3, 5, 2)'
Can't "goto" out of a pseudo block at -e line 1.
$ perl -lwe 'sub aaa ($$) { {; goto FOO; FOO​: $_[0] <=> $_[1] } } print sort aaa (7, 3, 5, 2)'
2357

The check for exiting a pseudo block is being applied too soon. It needs
to be postponed until after the check for a goto label at the outermost
layer within the pseudo block. [perl #113936] has the same cause too.

-zefram

@p5pRT
Copy link
Author

p5pRT commented Jan 23, 2017

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Jan 23, 2017

From zefram@fysh.org

I've fixed the multicalled-sub case in
3c157b3.

The original sort-block case is trickier. Deferring the
exiting-pseudo-block test is easy, but actually performing the label
search at the top level of the sort block is impeded by the fact that the
context stack entry doesn't include an appropriate op pointer to identify
the start of the sort block. One could be added as part of the CXt_NULL
behaviour, or we could invent a new CXt_SORTBLOCK type that includes
such a pointer, but each of these approaches has API implications.
I think they're precluded at the present phase of the development cycle.

-zefram

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants