[PATCH] 4497a11 Export DynaLoader symbols from libperl again #11674
Comments
From @rurbanThis is a bug report for perl from rurban@cpan.org, With 5.15.2 and the new xubpp, DynaLoader symbols were XS_INTERNAL, Flags: Site configuration information for perl 5.15.3: Configured by rurban at Wed Sep 21 14:46:58 CEST 2011. Summary of my perl5 (revision 5 version 15 subversion 3) configuration: Locally applied patches: @INC for perl 5.15.3: Environment for perl 5.15.3: |
From @rurban0001-Export-DynaLoader-symbols-from-libperl-again.patchFrom 4497a11a0d2e48af795e0e4d8f8c185e48d87b10 Mon Sep 17 00:00:00 2001
From: Reini Urban <rurban@x-ray.at>
Date: Tue, 27 Sep 2011 06:45:37 -0500
Subject: [PATCH] Export DynaLoader symbols from libperl again
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------1.7.6.1"
This is a multi-part message in MIME format.
--------------1.7.6.1
Content-Type: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding: 8bit
With 5.15.2 and the new xubpp, DynaLoader symbols were XS_INTERNAL, before
they were effectively XS_EXTERNAL. This broke B::C and possibly other
embedded apps which link to DynaLoader functions.
---
ext/DynaLoader/dlutils.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
--------------1.7.6.1
Content-Type: text/x-patch; name="0001-Export-DynaLoader-symbols-from-libperl-again.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment; filename="0001-Export-DynaLoader-symbols-from-libperl-again.patch"
diff --git a/ext/DynaLoader/dlutils.c b/ext/DynaLoader/dlutils.c
index 1ba9a61..574ccad 100644
--- a/ext/DynaLoader/dlutils.c
+++ b/ext/DynaLoader/dlutils.c
@@ -8,6 +8,7 @@
* files when the interpreter exits
*/
+#define PERL_EUPXS_ALWAYS_EXPORT
#ifndef START_MY_CXT /* Some IDEs try compiling this standalone. */
# include "EXTERN.h"
# include "perl.h"
--------------1.7.6.1--
|
From @LeontOn Tue, Sep 27, 2011 at 2:52 PM, Reini Urban <perlbug-followup@perl.org> wrote:
Yeah, if boot_Dynaloader isn't exported then any embedded perl Leon |
|
The RT System itself - Status changed from 'new' to 'open' |
From @rurbanOn Tue, Sep 27, 2011 at 8:03 AM, Leon Timmermans <fawaka@gmail.com> wrote:
boot_DynaLoader is not the problem, this is always exported. Undefined symbols: $ ls /usr/local/lib/perl5/5.15*/darwin-*/CORE/libperl.dylib $ nm /usr/local/lib/perl5/5.15*/darwin-*/CORE/libperl.dylib |grep < 5.15.2 T, since 5.15.2 t DynaLoader is the only XS here with xsubpp mangling, $ nm /usr/local/lib/perl5/5.15.3/darwin-debug/CORE/libperl.dylib |grep _XS_ 000000000034ee60 t _XS_DynaLoader_dl_error -- |
From @tseeOn 09/27/2011 03:40 PM, Reini Urban wrote:
[...]
Makes me wonder whether the exact name of XSUBs is considered an Anyway, on a recentish blead perl at tsee@l3tsee:~/perl/cpan_perl_branch_smoke$ nm In a nutshell, XSUBs should now be exported alright if a) xsubpp is old. Does that give you enough rope to hang anything? Cheers, |
From @rurbanOn Wed, Sep 28, 2011 at 1:31 AM, Steffen Mueller
Didn't you see my patch in the ticket? 5.15.2 and 5.15.3 is already I added #define PERL_EUPXS_ALWAYS_EXPORT to dlutils.c so all The problem is in CORE, all other things I can manage by myself. |
From @rurbanCan someone please apply the patch? |
From @cpansproutOn Tue Sep 27 05:52:30 2011, rurban wrote:
Thank you. I have applied your attached patch as 2e34687. |
|
@cpansprout - Status changed from 'open' to 'resolved' |
From kaffeetisch@gmx.deOn 27.09.2011 14:52, Reini Urban (via RT) wrote:
If I read Steffen's reply and commit |
From @cpansproutOn Fri Sep 30 16:27:52 2011, kaffeetisch@gmx.de wrote:
Does that mean I should revert Reini’s patch which I applied a few hours |
From @rurbanOn Fri Sep 30 16:27:52 2011, kaffeetisch@gmx.de wrote:
Wrong. This change caused the DynaLoader breakage. On Fri, Sep 30, 2011 at 8:10 PM, Father Chrysostomos via RT
No. Thanks for applying. BTW: I've just setup a B::C smoker here at cPanel which tests blead |
From @cpansproutOn Fri Sep 30 18:48:42 2011, rurban wrote:
Thank you. That sort of thing is always helpful. (I test my CPAN modules monthly with blead. I’ve caught quite a few |
From kaffeetisch@gmx.deOn 01.10.2011 03:48, Reini Urban wrote:
While it wasn't actually this commit that changed the visibility of |
From @tseeHi all, this is a mixed response to Reini and Thorsten, sorry about that. On 10/01/2011 11:38 AM, Torsten Schoenfeld wrote:
Sorry for being slow in applying. I had planned to think about a more
Though is it actually DynaLoader breakage or B::C breakage? Either way,
Indeed. It seemed fishy to me that the define in a .c file would do --Steffen |
From @rurbanOn Sat, Oct 1, 2011 at 7:23 AM, Steffen Mueller <smueller@cpan.org> wrote:
DynaLoader works fine. Only perlembed apps which link to DynaLoader broke.
I though the define is explicit enough. And there is also this ticket
|
Migrated from rt.perl.org#100138 (status was 'resolved')
Searchable as RT100138$
The text was updated successfully, but these errors were encountered: