Skip Menu |
Report information
Id: 74006
Status: resolved
Priority: 0/
Queue: perl5

Owner: Nobody
Requestors: zefram [at] fysh.org
Cc:
AdminCc:

Operating System: (no value)
PatchStatus: HasPatch
Severity: low
Type:
  • core
  • parsing
  • Patch
Perl Version: 5.12.0
Fixed In: (no value)



Subject: 5.12.0-RC stuffing bug
Date: Fri, 2 Apr 2010 21:20:38 +0100
To: perlbug [...] perl.org, perl5-porters [...] perl.org
From: Zefram <zefram [...] fysh.org>
Download (untitled) / with headers
text/plain 543b
There's a small bug in lex_stuff_pvn() that causes spurious syntax errors in an obscure situation. It happens if stuffing is performed on the last line of a file, and the line ends with a statement that lacks its terminating semicolon. Attached patch fixes and adds test. Obviously not a regression from 5.10, since the stuffing API was only introduced in 5.11.2. Patch seems very safe to apply, since obviously nothing is using the affected code (except for the module I have under development that led me to discover this bug). -zefram
Download d0
text/plain 5.2k

Message body is not shown because sender requested not to inline it.

Subject: Re: [perl #74006] 5.12.0-RC stuffing bug
Date: Sat, 3 Apr 2010 21:16:11 -0400
To: perl5-porters [...] perl.org
From: Jesse Vincent <jesse [...] fsck.com>
I'd prefer this that this go in for 5.12.1, not 5.12.0
Subject: Re: [perl #74006] 5.12.0-RC stuffing bug
Date: Tue, 13 Apr 2010 19:10:10 +0100
To: perl5-porters [...] perl.org
From: Zefram <zefram [...] fysh.org>
Download (untitled) / with headers
text/plain 124b
Jesse Vincent wrote: Show quoted text
>I'd prefer this that this go in for 5.12.1, not 5.12.0
Would someone please commit it now? -zefram
CC: perl5-porters [...] perl.org
Subject: Re: [perl #74006] 5.12.0-RC stuffing bug
Date: Wed, 14 Apr 2010 09:30:35 +0200
To: Zefram <zefram [...] fysh.org>
From: Rafael Garcia-Suarez <rgs [...] consttype.org>
Download (untitled) / with headers
text/plain 238b
On 13 April 2010 20:10, Zefram <zefram@fysh.org> wrote: Show quoted text
> Jesse Vincent wrote:
>>I'd prefer this that this go in for 5.12.1, not 5.12.0
> > Would someone please commit it now?
Thanks, applied as 255fdf19250671082618dae106a246f12379dbe6


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org