Skip Menu |
 
Report information
Id: 64502
Status: resolved
Priority: 0/
Queue: perl5

Owner: Nobody
Requestors: !--x--
Cc:
AdminCc:

Operating System: (no value)
PatchStatus: (no value)
Severity: low
Type: unknown
Perl Version: (no value)
Fixed In: (no value)



Subject: lib/CGI/t/util-58.t skewed to suppress a bug
Download (untitled) / with headers
text/plain 782b
Hello, as of now, git log lib/CGI/t/util-58.t in blead shows two commits. The latter one, from 2006, is incorrect. The right way to escape a Unicode string is to encode it in UTF-8 and then escape each byte. That test checks that. The output should not depend on whether the platform is ASCII or EBCDIC. Please return to the original version of t/util-58.t, as found in CGI.pm-3.29 or CGI.pm-3.42 tarballs. If the test fails on EBCDIC platforms, skip it, admitting that "CGI does not work with Unicode strings on EBCDIC platforms (yet)." Actually, there is a chance that the test will work on EBCDIC platforms as soon as the following bug gets fixed https://rt.cpan.org/Public/Bug/Display.html?id=34528 (If we are lucky, the patch submitted there might get into CGI.pm-3.43.)
Download (untitled) / with headers
text/plain 689b
On Mon Apr 06 09:21:03 2009, kasal wrote: Show quoted text
> Please return to the original version of t/util-58.t, as found in > CGI.pm-3.29 or CGI.pm-3.42 tarballs
This was reverted when CGI.pm-3.43 was integrated. http://perl5.git.perl.org/perl.git/commit/ ad6402bdb921e482fec0b070a69ca353669e4a93 Upgrade to CGI.pm-3.43 author Steve Peters <steve@fisharerojo.org> Mon, 13 Apr 2009 13:56:36 +0000 (08:56 -0500) committer Steve Peters <steve@fisharerojo.org> Mon, 13 Apr 2009 13:56:36 +0000 (08:56 -0500) commit ad6402bdb921e482fec0b070a69ca353669e4a93 tree ed68a8d978ad55cbc5b60f8f64aa93d2ffba9a2f tree | snapshot parent c14f59c3c1b4192dd6126638d5f8a7214c2dd445 commit | diff Best regards, Bram


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org