Skip Menu |
Report information
Id: 47047
Status: resolved
Priority: 0/
Queue: perl5

Owner: rafael <rgarciasuarez [at] gmail.com>
Requestors: rickdelaney <rick [at] bort.ca>
Cc:
AdminCc:

Operating System: All
PatchStatus: Rejected
Severity: low
Type: core
Perl Version:
  • 5.14.2
  • 5.25.4
Fixed In: (no value)



Subject: Use of inherited AUTOLOAD for non-method is deprecated
Date: Tue, 30 Oct 2007 23:19:02 -0400
To: perlbug [...] perl.org
From: Rick Delaney <rick [...] bort.ca>
Download (untitled) / with headers
text/plain 718b
This warning sometimes comes up for real methods. Attached is a patch to fix this. The patch contains a test case which fails like this before the fix. lib/warnings..................................................PROG: # gv.c sub Other::AUTOLOAD { 1 } sub Other::fred {} @ISA = qw(Other) ; use warnings 'deprecated' ; fred() ; my $x = \&barney; (bless[])->barney; EXPECTED: Use of inherited AUTOLOAD for non-method main::fred() is deprecated at - line 5. GOT: Use of inherited AUTOLOAD for non-method main::fred() is deprecated at - line 5. Use of inherited AUTOLOAD for non-method main::barney() is deprecated at - line 7. # Failed at ../t/lib/common.pl line 190 FAILED at test 285 -- Rick Delaney rick@bort.ca
Download autoload.patch
text/plain 1.2k

Message body is not shown because sender requested not to inline it.

Subject: [PATCH] Re: [perl #47047] Use of inherited AUTOLOAD for non-method is deprecated
Date: Tue, 12 Feb 2008 13:50:02 -0500
To: perl5-porters [...] perl.org
From: Rick Delaney <rick [...] bort.ca>
Download (untitled) / with headers
text/plain 395b
Ping. On Oct 30 2007, Rick Delaney wrote: Show quoted text
> # New Ticket Created by Rick Delaney > # Please include the string: [perl #47047] > # in the subject line of all future correspondence about this issue. > # <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=47047 >
The patch sent with the original message still applies cleanly. Reattached for your convenience. -- Rick Delaney rick@bort.ca
Download autoload.patch
text/plain 1.2k

Message body is not shown because sender requested not to inline it.

CC: perl5-porters [...] perl.org
Subject: Re: [PATCH] Re: [perl #47047] Use of inherited AUTOLOAD for non-method is deprecated
Date: Wed, 13 Feb 2008 12:41:32 -0600
To: "Rick Delaney" <rick [...] bort.ca>
From: "Steve Peters" <steve [...] fisharerojo.org>
Download (untitled) / with headers
text/plain 618b
Sorry, this must have been lost in the freeze. This patch was added with change #33302. Thanks! Steve Peters steve@fisharerojo.org On Feb 12, 2008 12:50 PM, Rick Delaney <rick@bort.ca> wrote: Show quoted text
> Ping. > > On Oct 30 2007, Rick Delaney wrote:
> > # New Ticket Created by Rick Delaney > > # Please include the string: [perl #47047] > > # in the subject line of all future correspondence about this issue. > > # <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=47047 >
> > The patch sent with the original message still applies cleanly. > Reattached for your convenience. > > > -- > Rick Delaney > rick@bort.ca >
CC: "Rick Delaney" <rick [...] bort.ca>, perl5-porters [...] perl.org
Subject: Re: [PATCH] Re: [perl #47047] Use of inherited AUTOLOAD for non-method is deprecated
Date: Thu, 14 Feb 2008 15:42:28 +0100
To: "Steve Peters" <steve [...] fisharerojo.org>
From: "Rafael Garcia-Suarez" <rgarciasuarez [...] gmail.com>
Download (untitled) / with headers
text/plain 511b
On 13/02/2008, Steve Peters <steve@fisharerojo.org> wrote: Show quoted text
> Sorry, this must have been lost in the freeze. This patch was added > with change #33302.
And removed with change #33307. OP_ENTERSUB, as an UNOP, doesn't have an op_last field to be accessed; leading to unpredictable results and other core dumps on many platforms (saw them on FreeBSD). The correct way to get the last child is to navigate all the way through op_sibling pointers, starting with op_first. But do we want that in code that hot ?
CC: Steve Peters <steve [...] fisharerojo.org>, perl5-porters [...] perl.org
Subject: Re: [PATCH] Re: [perl #47047] Use of inherited AUTOLOAD for non-method is deprecated
Date: Thu, 14 Feb 2008 11:06:31 -0500
To: Rafael Garcia-Suarez <rgarciasuarez [...] gmail.com>
From: Rick Delaney <rick [...] bort.ca>
Download (untitled) / with headers
text/plain 662b
On Feb 14 2008, Rafael Garcia-Suarez wrote: Show quoted text
> On 13/02/2008, Steve Peters <steve@fisharerojo.org> wrote:
> > Sorry, this must have been lost in the freeze. This patch was added > > with change #33302.
> > And removed with change #33307. OP_ENTERSUB, as an UNOP, doesn't have > an op_last field to be accessed; leading to unpredictable results and > other core dumps on many platforms (saw them on FreeBSD).
Oops, I always thought it was a LISTOP. Show quoted text
> The correct way to get the last child is to navigate all the way > through op_sibling pointers, starting with op_first. But do we want > that in code that hot ?
Probably not. -- Rick Delaney rick@bort.ca
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 374b
On Thu Feb 14 06:42:54 2008, rafael wrote: Show quoted text
> On 13/02/2008, Steve Peters <steve@fisharerojo.org> wrote:
> > Sorry, this must have been lost in the freeze. This patch was added > > with change #33302.
> > And removed with change #33307.
I have reapplied Rick Delaney’s test in commit 9493dad18463 and fixed the bug another way in 1de22db27a9. -- Father Chrysostomos
Download (untitled) / with headers
text/plain 313b
Thank you for filing this report. You have helped make Perl better. With the release today of Perl 5.26.0, this and 210 other issues have been resolved. Perl 5.26.0 may be downloaded via: https://metacpan.org/release/XSAWYERX/perl-5.26.0 If you find that the problem persists, feel free to reopen this ticket.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org