CC: | support [...] ActiveState.com |
Subject: | [PATCH] v5.8.8. pod2html: <a name="example"> anchor, but <a href="item_example"> link |
Date: | Fri, 28 Sep 2007 06:57:50 +0800 |
To: | perlbug [...] perl.org |
From: | Axel Kollmorgen <axel [...] kollmorgen.net> |
This is a bug report for perl from Axel Kollmorgen <axel@kollmorgen.net>,
generated with the help of perlbug 1.35 running under perl v5.8.8.
-----------------------------------------------------------------
[Please enter your report here]
change 30584 [1] as discussed here [2] removes the string 'item_' from
link anchors. unfortunately, it doesn't simultaneously remove it from
the corresponding links, resulting in loads of them being broken.
attached mini-patch fixes this. includes a fixed test, too.
thanks for considering!
ax
[1] http://public.activestate.com/cgi-bin/perlbrowse/p/30584
[2] http://www.nntp.perl.org/group/perl.perl5.porters/2007/03/msg122205.html
[Please do not change anything below this line]
-----------------------------------------------------------------
---
Flags:
category=library
severity=medium
---
Site configuration information for perl v5.8.8:
Configured by SYSTEM at Tue Jul 31 19:34:29 2007.
Summary of my perl5 (revision 5 version 8 subversion 8) configuration:
Platform:
osname=MSWin32, osvers=5.00, archname=MSWin32-x86-multi-thread
uname=''
config_args='undef'
hint=recommended, useposix=true, d_sigaction=undef
usethreads=define use5005threads=undef useithreads=define
usemultiplicity=define
useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
use64bitint=undef use64bitall=undef uselongdouble=undef
usemymalloc=n, bincompat5005=undef
Compiler:
cc='gcc', ccflags ='-DNDEBUG -DWIN32 -D_CONSOLE -DNO_STRICT
-DHAVE_DES_FCRYPT -DNO_HASH_SEED -DUSE_SITECUSTOMIZE
-DPRIVLIB_LAST_IN_INC -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS
-DUSE_PERLIO -DPERL_MSVCRT_READFIX -DHASATTRIBUTE -fno-strict-aliasing',
optimize='-O2',
cppflags='-DWIN32'
ccversion='', gccversion='3.4.4 (cygming special, gdc 0.12, using
dmd 0.125)', gccosandvers=''
intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=8
ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='__int64',
lseeksize=8
alignbytes=8, prototype=define
Linker and Libraries:
ld='g++', ldflags ='-L"D:\progs\develop\Perl\lib\CORE"'
libpth=\lib
libs=-lkernel32 -luser32 -lgdi32 -lwinspool -lcomdlg32 -ladvapi32
-lshell32 -lole32 -loleaut32 -lnetapi32 -luuid -lws2_32 -lmpr -lwinmm
-lversion -lodbc32 -lodbccp32 -lmsvcrt
perllibs=-lkernel32 -luser32 -lgdi32 -lwinspool -lcomdlg32
-ladvapi32 -lshell32 -lole32 -loleaut32 -lnetapi32 -luuid -lws2_32 -lmpr
-lwinmm -lversion -lodbc32 -lodbccp32 -lmsvcrt
libc=msvcrt.lib, so=dll, useshrplib=true, libperl=perl58.lib
gnulibc_version=''
Dynamic Linking:
dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
cccdlflags=' ', lddlflags='-mdll -L"D:\progs\develop\Perl\lib\CORE"'
Locally applied patches:
ACTIVEPERL_LOCAL_PATCHES_ENTRY
Iin_load_module moved for compatibility with build 806
Avoid signal flag SA_RESTART for older versions of HP-UX
PerlEx support in CGI::Carp
Less verbose ExtUtils::Install and Pod::Find
Patch for CAN-2005-0448 from Debian with modifications
Rearrange @INC so that 'site' is searched before 'perl'
Partly reverted 24733 to preserve binary compatibility
MAINT31223 plus additional changes
31490 Problem bootstraping Win32CORE
31324 Fix DynaLoader::dl_findfile() to locate .so files again
31214 Win32::GetLastError fails when first called
31211 Restore Windows NT support
31188 Problem killing a pseudo-forked child on Win32
29732 ANSIfy the PATH environment variable on Windows
27527,29868 win32_async_check() can loop indefinitely
26970 Make Passive mode the default for Net::FTP
26379 Fix alarm() for Windows 2003
24699 ICMP_UNREACHABLE handling in Net::Ping
---
@INC for perl v5.8.8:
D:/progs/develop/Perl/site/lib
D:/progs/develop/Perl/lib
.
---
Environment for perl v5.8.8:
LANG (unset)
LANGUAGE (unset)
LD_LIBRARY_PATH (unset)
LOGDIR (unset)
PATH=C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;D:\progs\develop\Perl\bin
PERL_BADLANG (unset)
SHELL (unset)
--- lib/Pod/Html.pm.orig 2007-09-28 05:25:42.531250000 +0800
+++ lib/Pod/Html.pm 2007-09-28 05:25:50.187500000 +0800
@@ -2015,7 +2015,7 @@
if( exists $Pages{$page} and $Pages{$page} =~ /([^:.]*)\.[^:]*:/){
$page = $1 . '.html';
}
- my $link = "$Htmlroot/$page#item_" . anchorify($fid);
+ my $link = "$Htmlroot/$page#" . anchorify($fid);
# Here, we take advantage of the knowledge that $Htmlfileurl
# ne '' implies $Htmlroot eq ''.
@@ -2026,7 +2026,7 @@
$url = $link ;
}
} else {
- $url = "#item_" . anchorify($fid);
+ $url = "#" . anchorify($fid);
}
confess "url has space: $url" if $url =~ /"[^"]*\s[^"]*"/;
--- lib/Pod/t/htmllink.t.orig 2007-07-31 19:36:30.000000000 +0800
+++ lib/Pod/t/htmllink.t 2007-09-28 05:05:22.390625000 +0800
@@ -58,39 +58,39 @@
<p><a href="#section1">section1</a></p>
<p><a href="#section_2">section 2</a></p>
<p><a href="#section_three">section three</a></p>
-<p><a href="#item_item1">item1</a></p>
-<p><a href="#item_item_2">item 2</a></p>
-<p><a href="#item_item_three">item three</a></p>
+<p><a href="#item1">item1</a></p>
+<p><a href="#item_2">item 2</a></p>
+<p><a href="#item_three">item three</a></p>
<p><a href="#section1">section1</a></p>
<p><a href="#section_2">section 2</a></p>
<p><a href="#section_three">section three</a></p>
-<p><a href="#item_item1">item1</a></p>
-<p><a href="#item_item_2">item 2</a></p>
-<p><a href="#item_item_three">item three</a></p>
+<p><a href="#item1">item1</a></p>
+<p><a href="#item_2">item 2</a></p>
+<p><a href="#item_three">item three</a></p>
<p><a href="#section1">section1</a></p>
<p><a href="#section_2">section 2</a></p>
<p><a href="#section_three">section three</a></p>
-<p><a href="#item_item1">item1</a></p>
-<p><a href="#item_item_2">item 2</a></p>
-<p><a href="#item_item_three">item three</a></p>
+<p><a href="#item1">item1</a></p>
+<p><a href="#item_2">item 2</a></p>
+<p><a href="#item_three">item three</a></p>
<p><a href="#section1">text</a></p>
<p><a href="#section_2">text</a></p>
<p><a href="#section_three">text</a></p>
-<p><a href="#item_item1">text</a></p>
-<p><a href="#item_item_2">text</a></p>
-<p><a href="#item_item_three">text</a></p>
+<p><a href="#item1">text</a></p>
+<p><a href="#item_2">text</a></p>
+<p><a href="#item_three">text</a></p>
<p><a href="#section1">text</a></p>
<p><a href="#section_2">text</a></p>
<p><a href="#section_three">text</a></p>
-<p><a href="#item_item1">text</a></p>
-<p><a href="#item_item_2">text</a></p>
-<p><a href="#item_item_three">text</a></p>
+<p><a href="#item1">text</a></p>
+<p><a href="#item_2">text</a></p>
+<p><a href="#item_three">text</a></p>
<p><a href="#section1">text</a></p>
<p><a href="#section_2">text</a></p>
<p><a href="#section_three">text</a></p>
-<p><a href="#item_item1">text</a></p>
-<p><a href="#item_item_2">text</a></p>
-<p><a href="#item_item_three">text</a></p>
+<p><a href="#item1">text</a></p>
+<p><a href="#item_2">text</a></p>
+<p><a href="#item_three">text</a></p>
<p>
</p>
<hr />