New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'make' fails during '-Dusemymalloc' and '-Dusethreads' #17011
Comments
From @jkeenanAs first suggested by simcop2387 on #p5p, when you attempt to build ##### malloc.c: Limit malloc size to PTRDIFF_MAX Without doing this, it is possible that the behavior is undefined when See thread beginning at In particular this from Tomasz Konojacki simcop2387's build report is here: However, I was able to reproduce this on both Linux and FreeBSD-11 with Possibly related ticket: Bisection command: perl perl perl |
From @jkeenanOn Wed, 22 May 2019 20:10:14 GMT, jkeenan@pobox.com wrote:
This problem probably went undetected during the perl-5.29 dev cycle because "-Dusemymalloc=y" is rather obscure for a Configure switch and is probably not exercised by any of our smoke-testing rigs. "-Dusethreads", however, is well exercised in the test suite and across smoke-testing rigs. Hence, as a way toward preventing a future regression, if someone were able to write a test in one of the already existing threads-activated test files that tickled this bug, that would be really nifty. Thank you very much. |
From [Unknown Contact. See original ticket]On Wed, 22 May 2019 20:10:14 GMT, jkeenan@pobox.com wrote:
This problem probably went undetected during the perl-5.29 dev cycle because "-Dusemymalloc=y" is rather obscure for a Configure switch and is probably not exercised by any of our smoke-testing rigs. "-Dusethreads", however, is well exercised in the test suite and across smoke-testing rigs. Hence, as a way toward preventing a future regression, if someone were able to write a test in one of the already existing threads-activated test files that tickled this bug, that would be really nifty. Thank you very much. |
@khwilliamson - Status changed from 'new' to 'open' |
From @khwilliamsonFixed by *commit 9629b6d PATCH: [perl #134126] -Dusemymalloc, -Dusethreads Karl Williamson |
@khwilliamson - Status changed from 'open' to 'pending release' |
From jiri.krobot.broz@gmail.comThis is a build failure report for perl from jiri.krobot.broz@gmail.com ----------------------------------------------------------------- MYMALLOC_WRITE2STDERR inherits using 'my_perl' but it is undefined here. It For information only: 'nmake test' failed with these errors: Test Summary Report Perl Info
|
From @jkeenanOn Sun, 07 Jul 2019 21:45:46 GMT, jiri.krobot.broz@gmail.com wrote:
Can you provide the full command you provided for ./Configure (or for its Windows equivalent)? Thank you very much. -- |
The RT System itself - Status changed from 'new' to 'open' |
From @tonycozOn Sun, 07 Jul 2019 14:45:46 -0700, jiri.krobot.broz@gmail.com wrote:
I believe this is fixed in blead at commit 9629b6d PATCH: [perl #134126] -Dusemymalloc, -Dusethreads Inline Patchdiff --git a/malloc.c b/malloc.c
index ed392ee5ba..0c80a0856f 100644
--- a/malloc.c
+++ b/malloc.c
@@ -1239,6 +1239,7 @@ Perl_malloc(size_t nbytes)
* malloc so that pointer subtraction in the same structure is always
* well defined */
if (nbytes > PTRDIFF_MAX) {
+ dTHX;
MYMALLOC_WRITE2STDERR("Memory requests are limited to PTRDIFF_MAX"
" bytes to prevent possible undefined"
" behavior");
Tony |
From @tonycozOn Mon, 08 Jul 2019 23:04:09 -0700, tonyc wrote:
No response, so I'm assuming I'm correct here, merged into 134126 (which is pending release.) Tony |
Migrated from rt.perl.org#134126 (status was 'pending release')
Searchable as RT134126$
The text was updated successfully, but these errors were encountered: