Skip Menu |
Report information
Id: 133658
Status: resolved
Priority: 0/
Queue: perl5

Owner: jkeenan <jkeenan [at] cpan.org>
Requestors: jkeenan [at] pobox.com
Cc:
AdminCc:

Operating System: (no value)
PatchStatus: (no value)
Severity: low
Type: unknown
Perl Version: (no value)
Fixed In: (no value)



To: perlbug [...] perl.org
From: James E Keenan <jkeenan [...] pobox.com>
Date: Wed, 14 Nov 2018 16:21:56 -0500
Subject: 9b0adf19 breaks tests in ext/File-Find/t/ when run in harness
Download (untitled) / with headers
text/plain 4.3k
I am observing new test failures in File::Find in blead. When ext/File-Find/t/taint.t and ext/File-Find/t/find.t are run within the same harness, they fail like this: ##### [perl-current] $ cd t;./perl harness -v ../ext/File-Find/t/find.t ../ext/File-Find/t/taint.t; cd - ===( 4;0 3/238 1/45 )========================================# Failed test 'able to mkdir: for_find' # at t/lib/Testing.pm line 30. Unable to mkdir: for_find at t/lib/Testing.pm line 30. # Looks like your test exited with 17 just after 12. Dubious, test returned 17 (wstat 4352, 0x1100) Failed 227/238 subtests ../ext/File-Find/t/taint.t .. ok 27 - Tainted directory causes death (good) ok 28 - Bad untaint pattern causes death (good) ok 29 - Bad untaint pattern causes death in cwd (good) # Failed test 'Found all files in symlink test' # at t/taint.t line 278. ok 30 - found fa for $_, as expected # got: '3' # expected: '0' ok 31 - found fa/fsl for $_, as expected ok 32 - found fa/fa_ord for $_, as expected ok 33 - found fa/fab for $_, as expected ok 34 - found fa/fab/fab_ord for $_, as expected ok 35 - found fa/fab/faba for $_, as expected ok 36 - found fa/fab/faba/faba_ord for $_, as expected ok 37 - found fa/faa for $_, as expected ok 38 - found fa/faa/faa_ord for $_, as expected not ok 39 - Found all files in symlink test ok 40 - Not untainting causes death (good) # Looks like you planned 45 tests but ran 42. # Looks like you failed 1 test of 42 run. ok 41 - Bat untaint pattern causes death (good) ok 42 - Cwd not untainted with bad pattern (good) Dubious, test returned 1 (wstat 256, 0x100) Failed 4/45 subtests Test Summary Report ------------------- ../ext/File-Find/t/find.t (Wstat: 4352 Tests: 12 Failed: 1) Failed test: 12 Non-zero exit status: 17 Parse errors: Bad plan. You planned 238 tests but ran 12. ../ext/File-Find/t/taint.t (Wstat: 256 Tests: 42 Failed: 1) Failed test: 39 Non-zero exit status: 1 Parse errors: Bad plan. You planned 45 tests but ran 42. Files=2, Tests=54, 0 wallclock secs ( 0.01 usr 0.02 sys + 0.25 cusr 0.03 csys = 0.30 CPU) Result: FAIL /usr/home/jkeenan/learn/perl/test-smoke/rtc-125932/perl-current ##### This is the directory from which the following smoke test report was generated: ##### http://perl5.test-smoke.org/report/74026 ##### But if you run either test by itself, each passes. ##### [perl-current] $ cd t;./perl harness ../ext/File-Find/t/find.t ; cd - ../ext/File-Find/t/find.t .. ok All tests successful. Files=1, Tests=238, 0 wallclock secs ( 0.05 usr 0.01 sys + 0.11 cusr 0.03 csys = 0.20 CPU) Result: PASS /usr/home/jkeenan/learn/perl/test-smoke/rtc-125932/perl-current [perl-current] $ cd t;./perl harness ../ext/File-Find/t/taint.t ; cd - ../ext/File-Find/t/taint.t .. ok All tests successful. Files=1, Tests=45, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.08 cusr 0.02 csys = 0.10 CPU) Result: PASS /usr/home/jkeenan/learn/perl/test-smoke/rtc-125932/perl-current ##### They also run fine when each is run within a harness with any other test file: ##### [perl-current] $ cd t;./perl harness ../ext/File-Find/t/taint.t ../ext/File-Glob/t/basic.t ; cd - ../ext/File-Find/t/taint.t .. ok ../ext/File-Glob/t/basic.t .. ok All tests successful. Files=2, Tests=94, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.17 cusr 0.03 csys = 0.24 CPU) Result: PASS /usr/home/jkeenan/learn/perl/test-smoke/rtc-125932/perl-current [perl-current] $ cd t;./perl harness ../ext/File-Find/t/find.t ../ext/File-Glob/t/basic.t ; cd - ../ext/File-Glob/t/basic.t .. ok ../ext/File-Find/t/find.t ... ok All tests successful. Files=2, Tests=287, 0 wallclock secs ( 0.05 usr 0.02 sys + 0.27 cusr 0.05 csys = 0.39 CPU) Result: PASS /usr/home/jkeenan/learn/perl/test-smoke/rtc-125932/perl-current ##### While the data above is from FreeBSD-11, I also observed this when running 'make test_harness' on blead on Linux earlier today. At the time I did not fully understand what was happening and dismissed it as a transitory resource constraint problem. I suspect the problem arises from this commit: ##### commit 9b0adf193cf9b592bf4162895b7fe90a3aa2aa2b Author: Karl Williamson <khw@cpan.org> AuthorDate: Tue Jul 24 22:26:39 2018 Commit: Karl Williamson <khw@cpan.org> CommitDate: Wed Nov 14 11:04:45 2018 Add more parallelism to t/harness ##### ... because I do not get these errors on the immediately preceding commit. Thank you very much. Jim Keenan
Download perl_V.txt
text/plain 3k

Message body is not shown because sender requested not to inline it.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 4.9k
On Wed, 14 Nov 2018 21:22:07 GMT, jkeenan@pobox.com wrote: Show quoted text
> > I am observing new test failures in File::Find in blead. > > When ext/File-Find/t/taint.t and ext/File-Find/t/find.t are run within > the same harness, they fail like this: > > ##### > [perl-current] $ cd t;./perl harness -v ../ext/File-Find/t/find.t > ../ext/File-Find/t/taint.t; cd - > ===( 4;0 3/238 1/45 > )========================================# Failed test 'able to mkdir: > for_find' > # at t/lib/Testing.pm lineed0ccc61a67a1df17e4187c8ed96ae8f9aa4781a 30. > Unable to mkdir: for_find at t/lib/Testing.pm line 30. > # Looks like your test exited with 17 just after 12. > Dubious, test returned 17 (wstat 4352, 0x1100) > Failed 227/238 subtests > ../ext/File-Find/t/taint.t .. > ok 27 - Tainted directory causes death (good) > ok 28 - Bad untaint pattern causes death (good) > ok 29 - Bad untaint pattern causes death in cwd (good) > # Failed test 'Found all files in symlink test' > # at t/taint.t line 278. > ok 30 - found fa for $_, as expected > # got: '3' > # expected: '0' > ok 31 - found fa/fsl for $_, as expected > ok 32 - found fa/fa_ord for $_, as expected > ok 33 - found fa/fab for $_, as expected > ok 34 - found fa/fab/fab_ord for $_, as expected > ok 35 - found fa/fab/faba for $_, as expected > ok 36 - found fa/fab/faba/faba_ord for $_, as expected > ok 37 - found fa/faa for $_, as expected > ok 38 - found fa/faa/faa_ord for $_, as expected > not ok 39 - Found all files in symlink test > ok 40 - Not untainting causes death (good) > # Looks like you planned 45 tests but ran 42. > # Looks like you failed 1 test of 42 run. > ok 41 - Bat untaint pattern causes death (good) > ok 42 - Cwd not untainted with bad pattern (good) > Dubious, test returned 1 (wstat 256, 0x100) > Failed 4/45 subtests > > Test Summary Report > ------------------- > ../ext/File-Find/t/find.t (Wstat: 4352 Tests: 12 Failed: 1) > Failed test: 12 > Non-zero exit status: 17 > Parse errors: Bad plan. You planned 238 tests but ran 12. > ../ext/File-Find/t/taint.t (Wstat: 256 Tests: 42 Failed: 1) > Failed test: 39 > Non-zero exit status: 1 > Parse errors: Bad plan. You planned 45 tests but ran 42. > Files=2, Tests=54, 0 wallclock secs ( 0.01 usr 0.02 sys + 0.25 cusr > 0.03 csys = 0.30 CPU) > Result: FAIL > /usr/home/jkeenan/learn/perl/test-smoke/rtc-125932/perl-current > ##### > > This is the directory from which the following smoke test report was > generated: > > ##### > http://perl5.test-smoke.org/report/74026 > ##### > > But if you run either test by itself, each passes. > > ##### > [perl-current] $ cd t;./perl harness ../ext/File-Find/t/find.t ; cd - > ../ext/File-Find/t/find.t .. ok > All tests successful. > Files=1, Tests=238, 0 wallclock secs ( 0.05 usr 0.01 sys + 0.11 cusr > 0.03 csys = 0.20 CPU) > Result: PASS > /usr/home/jkeenan/learn/perl/test-smoke/rtc-125932/perl-current > > [perl-current] $ cd t;./perl harness ../ext/File-Find/t/taint.t ; cd - > ../ext/File-Find/t/taint.t .. ok > All tests successful. > Files=1, Tests=45, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.08 cusr > 0.02 csys = 0.10 CPU) > Result: PASS > /usr/home/jkeenan/learn/perl/test-smoke/rtc-125932/perl-current > ##### > > They also run fine when each is run within a harness with any other test > file: > > ##### > [perl-current] $ cd t;./perl harness ../ext/File-Find/t/taint.t > ../ext/File-Glob/t/basic.t ; cd - > ../ext/File-Find/t/taint.t .. ok > ../ext/File-Glob/t/basic.t .. ok > All tests successful. > Files=2, Tests=94, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.17 cusr > 0.03 csys = 0.24 CPU) > Result: PASS > /usr/home/jkeenan/learn/perl/test-smoke/rtc-125932/perl-current > [perl-current] $ cd t;./perl harness ../ext/File-Find/t/find.t > ../ext/File-Glob/t/basic.t ; cd - > ../ext/File-Glob/t/basic.t .. ok > ../ext/File-Find/t/find.t ... ok > All tests successful. > Files=2, Tests=287, 0 wallclock secs ( 0.05 usr 0.02 sys + 0.27 cusr > 0.05 csys = 0.39 CPU) > Result: PASS > /usr/home/jkeenan/learn/perl/test-smoke/rtc-125932/perl-current > ##### > > While the data above is from FreeBSD-11, I also observed this when > running 'make test_harness' on blead on Linux earlier today. At the > time I did not fully understand what was happening and dismissed it as a > transitory resource constraint problem. > > I suspect the problem arises from this commit: > > ##### > commit 9b0adf193cf9b592bf4162895b7fe90a3aa2aa2b > Author: Karl Williamson <khw@cpan.org> > AuthorDate: Tue Jul 24 22:26:39 2018 > Commit: Karl Williamson <khw@cpan.org> > CommitDate: Wed Nov 14 11:04:45 2018 > > Add more parallelism to t/harness > ##### > > ... because I do not get these errors on the immediately preceding commit. >
Fixed in blead by commit ed0ccc61a67a1df17e4187c8ed96ae8f9aa4781a. The commit previously cited gives t/harness an internal list of directories whose tests must not be run in parallel. I added ext/File-Find/t to that list. Thank you very much. -- James E Keenan (jkeenan@cpan.org)
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 6.8k
On Wed, 14 Nov 2018 21:32:44 GMT, jkeenan wrote: Show quoted text
> On Wed, 14 Nov 2018 21:22:07 GMT, jkeenan@pobox.com wrote:
> > > > I am observing new test failures in File::Find in blead. > > > > When ext/File-Find/t/taint.t and ext/File-Find/t/find.t are run > > within > > the same harness, they fail like this: > > > > ##### > > [perl-current] $ cd t;./perl harness -v ../ext/File-Find/t/find.t > > ../ext/File-Find/t/taint.t; cd - > > ===( 4;0 3/238 1/45 > > )========================================# Failed test 'able to > > mkdir: > > for_find' > > # at t/lib/Testing.pm lineed0ccc61a67a1df17e4187c8ed96ae8f9aa4781a > > 30. > > Unable to mkdir: for_find at t/lib/Testing.pm line 30. > > # Looks like your test exited with 17 just after 12. > > Dubious, test returned 17 (wstat 4352, 0x1100) > > Failed 227/238 subtests > > ../ext/File-Find/t/taint.t .. > > ok 27 - Tainted directory causes death (good) > > ok 28 - Bad untaint pattern causes death (good) > > ok 29 - Bad untaint pattern causes death in cwd (good) > > # Failed test 'Found all files in symlink test' > > # at t/taint.t line 278. > > ok 30 - found fa for $_, as expected > > # got: '3' > > # expected: '0' > > ok 31 - found fa/fsl for $_, as expected > > ok 32 - found fa/fa_ord for $_, as expected > > ok 33 - found fa/fab for $_, as expected > > ok 34 - found fa/fab/fab_ord for $_, as expected > > ok 35 - found fa/fab/faba for $_, as expected > > ok 36 - found fa/fab/faba/faba_ord for $_, as expected > > ok 37 - found fa/faa for $_, as expected > > ok 38 - found fa/faa/faa_ord for $_, as expected > > not ok 39 - Found all files in symlink test > > ok 40 - Not untainting causes death (good) > > # Looks like you planned 45 tests but ran 42. > > # Looks like you failed 1 test of 42 run. > > ok 41 - Bat untaint pattern causes death (good) > > ok 42 - Cwd not untainted with bad pattern (good) > > Dubious, test returned 1 (wstat 256, 0x100) > > Failed 4/45 subtests > > > > Test Summary Report > > ------------------- > > ../ext/File-Find/t/find.t (Wstat: 4352 Tests: 12 Failed: 1) > > Failed test: 12 > > Non-zero exit status: 17 > > Parse errors: Bad plan. You planned 238 tests but ran 12. > > ../ext/File-Find/t/taint.t (Wstat: 256 Tests: 42 Failed: 1) > > Failed test: 39 > > Non-zero exit status: 1 > > Parse errors: Bad plan. You planned 45 tests but ran 42. > > Files=2, Tests=54, 0 wallclock secs ( 0.01 usr 0.02 sys + 0.25 > > cusr > > 0.03 csys = 0.30 CPU) > > Result: FAIL > > /usr/home/jkeenan/learn/perl/test-smoke/rtc-125932/perl-current > > ##### > > > > This is the directory from which the following smoke test report was > > generated: > > > > ##### > > http://perl5.test-smoke.org/report/74026 > > ##### > > > > But if you run either test by itself, each passes. > > > > ##### > > [perl-current] $ cd t;./perl harness ../ext/File-Find/t/find.t ; cd - > > ../ext/File-Find/t/find.t .. ok > > All tests successful. > > Files=1, Tests=238, 0 wallclock secs ( 0.05 usr 0.01 sys + 0.11 > > cusr > > 0.03 csys = 0.20 CPU) > > Result: PASS > > /usr/home/jkeenan/learn/perl/test-smoke/rtc-125932/perl-current > > > > [perl-current] $ cd t;./perl harness ../ext/File-Find/t/taint.t ; cd > > - > > ../ext/File-Find/t/taint.t .. ok > > All tests successful. > > Files=1, Tests=45, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.08 > > cusr > > 0.02 csys = 0.10 CPU) > > Result: PASS > > /usr/home/jkeenan/learn/perl/test-smoke/rtc-125932/perl-current > > ##### > > > > They also run fine when each is run within a harness with any other > > test > > file: > > > > ##### > > [perl-current] $ cd t;./perl harness ../ext/File-Find/t/taint.t > > ../ext/File-Glob/t/basic.t ; cd - > > ../ext/File-Find/t/taint.t .. ok > > ../ext/File-Glob/t/basic.t .. ok > > All tests successful. > > Files=2, Tests=94, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.17 > > cusr > > 0.03 csys = 0.24 CPU) > > Result: PASS > > /usr/home/jkeenan/learn/perl/test-smoke/rtc-125932/perl-current > > [perl-current] $ cd t;./perl harness ../ext/File-Find/t/find.t > > ../ext/File-Glob/t/basic.t ; cd - > > ../ext/File-Glob/t/basic.t .. ok > > ../ext/File-Find/t/find.t ... ok > > All tests successful. > > Files=2, Tests=287, 0 wallclock secs ( 0.05 usr 0.02 sys + 0.27 > > cusr > > 0.05 csys = 0.39 CPU) > > Result: PASS > > /usr/home/jkeenan/learn/perl/test-smoke/rtc-125932/perl-current > > ##### > > > > While the data above is from FreeBSD-11, I also observed this when > > running 'make test_harness' on blead on Linux earlier today. At the > > time I did not fully understand what was happening and dismissed it > > as a > > transitory resource constraint problem. > > > > I suspect the problem arises from this commit: > > > > ##### > > commit 9b0adf193cf9b592bf4162895b7fe90a3aa2aa2b > > Author: Karl Williamson <khw@cpan.org> > > AuthorDate: Tue Jul 24 22:26:39 2018 > > Commit: Karl Williamson <khw@cpan.org> > > CommitDate: Wed Nov 14 11:04:45 2018 > > > > Add more parallelism to t/harness > > ##### > > > > ... because I do not get these errors on the immediately preceding > > commit. > >
> > Fixed in blead by commit ed0ccc61a67a1df17e4187c8ed96ae8f9aa4781a. > The commit previously cited gives t/harness an internal list of > directories whose tests must not be run in parallel. I added > ext/File-Find/t to that list. > > Thank you very much.
Unfortunately, the fix doesn't seem to be working consistently, so I have to re-open this ticket. ##### $ cd t;./perl harness ../ext/File-Find/t/*.t; cd - ===( 141;0 140/238 1/45 )======================================== # Failed test 'COMPLETE: Test of 'follow_fast' and 'no_chdir' options together: $File::Find::name case' # at t/find.t line 647. # got: '3' # expected: '0' # Failed test 'able to mkdir: dangling_dir' # at t/lib/Testing.pm line 30. Unable to mkdir: dangling_dir at t/lib/Testing.pm line 30. # Looks like your test exited with 2 just after 151. /bin/pwd: couldn't find directory entry in ‘..’ with matching i-node # Failed test 'able to mkdir: fa' # at t/lib/Testing.pm line 30. Unable to mkdir: fa at t/lib/Testing.pm line 30. # Looks like your test exited with 2 just after 5. ../ext/File-Find/t/find.t ... Dubious, test returned 2 (wstat 512, 0x200) Failed 89/238 subtests ../ext/File-Find/t/taint.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 41/45 subtests Test Summary Report ------------------- ../ext/File-Find/t/find.t (Wstat: 512 Tests: 151 Failed: 2) Failed tests: 150-151 Non-zero exit status: 2 Parse errors: Bad plan. You planned 238 tests but ran 151. ../ext/File-Find/t/taint.t (Wstat: 512 Tests: 5 Failed: 1) Failed test: 5 Non-zero exit status: 2 Parse errors: Bad plan. You planned 45 tests but ran 5. Files=2, Tests=156, 0 wallclock secs ( 0.03 usr 0.00 sys + 0.13 cusr 0.02 csys = 0.18 CPU) Result: FAIL /home/jkeenan/gitwork/perl ##### -- James E Keenan (jkeenan@cpan.org)
Subject: perl_V.3db0bccc.txt
Summary of my perl5 (revision 5 version 29 subversion 5) configuration: Commit id: 3db0bcccf4d9617c94822609f33314fe0df2df3b Platform: osname=linux osvers=4.15.0-39-generic archname=x86_64-linux uname='linux zareason 4.15.0-39-generic #42-ubuntu smp tue oct 23 15:48:01 utc 2018 x86_64 x86_64 x86_64 gnulinux ' config_args='-des -Dusedevel' hint=recommended useposix=true d_sigaction=define useithreads=undef usemultiplicity=undef use64bitint=define use64bitall=define uselongdouble=undef usemymalloc=n default_inc_excludes_dot=define bincompat5005=undef Compiler: cc='cc' ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64' optimize='-O2' cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include' ccversion='' gccversion='7.3.0' gccosandvers='' intsize=4 longsize=8 ptrsize=8 doublesize=8 byteorder=12345678 doublekind=3 d_longlong=define longlongsize=8 d_longdbl=define longdblsize=16 longdblkind=3 ivtype='long' ivsize=8 nvtype='double' nvsize=8 Off_t='off_t' lseeksize=8 alignbytes=8 prototype=define Linker and Libraries: ld='cc' ldflags =' -fstack-protector-strong -L/usr/local/lib' libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/7/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /lib64 /usr/lib64 libs=-lpthread -lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc libc=libc-2.27.so so=so useshrplib=false libperl=libperl.a gnulibc_version='2.27' Dynamic Linking: dlsrc=dl_dlopen.xs dlext=so d_dlsymun=undef ccdlflags='-Wl,-E' cccdlflags='-fPIC' lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong' Characteristics of this binary (from libperl): Compile-time options: HAS_TIMES PERLIO_LAYERS PERL_COPY_ON_WRITE PERL_DONT_CREATE_GVSV PERL_MALLOC_WRAP PERL_OP_PARENT PERL_PRESERVE_IVUV PERL_USE_DEVEL USE_64_BIT_ALL USE_64_BIT_INT USE_LARGE_FILES USE_LOCALE USE_LOCALE_COLLATE USE_LOCALE_CTYPE USE_LOCALE_NUMERIC USE_LOCALE_TIME USE_PERLIO USE_PERL_ATOF Built under linux Compiled at Nov 17 2018 17:14:01 %ENV: PERL2DIR="/home/jkeenan/gitwork/perl2" PERLBREW_HOME="/home/jkeenan/.perlbrew" PERLBREW_MANPATH="/home/jkeenan/perl5/perlbrew/perls/perl-5.28.0/man" PERLBREW_PATH="/home/jkeenan/perl5/perlbrew/bin:/home/jkeenan/perl5/perlbrew/perls/perl-5.28.0/bin" PERLBREW_PERL="perl-5.28.0" PERLBREW_ROOT="/home/jkeenan/perl5/perlbrew" PERLBREW_SHELLRC_VERSION="0.84" PERLBREW_VERSION="0.84" PERL_WORKDIR="/home/jkeenan/gitwork/perl" @INC: lib /usr/local/lib/perl5/site_perl/5.29.5/x86_64-linux /usr/local/lib/perl5/site_perl/5.29.5 /usr/local/lib/perl5/5.29.5/x86_64-linux /usr/local/lib/perl5/5.29.5
From: Dave Mitchell <davem [...] iabyn.com>
CC: perl5-porters [...] perl.org
To: James E Keenan via RT <perlbug-followup [...] perl.org>
Date: Mon, 19 Nov 2018 14:22:41 +0000
Subject: Re: [perl #133658] 9b0adf19 breaks tests in ext/File-Find/t/ when run in harness
Download (untitled) / with headers
text/plain 1.5k
On Sat, Nov 17, 2018 at 02:18:00PM -0800, James E Keenan via RT wrote: Show quoted text
> > > I am observing new test failures in File::Find in blead.
Show quoted text
> > > I suspect the problem arises from this commit: > > > > > > ##### > > > commit 9b0adf193cf9b592bf4162895b7fe90a3aa2aa2b > > > Author: Karl Williamson <khw@cpan.org> > > > AuthorDate: Tue Jul 24 22:26:39 2018 > > > Commit: Karl Williamson <khw@cpan.org> > > > CommitDate: Wed Nov 14 11:04:45 2018 > > > > > > Add more parallelism to t/harness
Show quoted text
> > Fixed in blead by commit ed0ccc61a67a1df17e4187c8ed96ae8f9aa4781a. > > The commit previously cited gives t/harness an internal list of > > directories whose tests must not be run in parallel. I added > > ext/File-Find/t to that list.
Show quoted text
> Unfortunately, the fix doesn't seem to be working consistently, so I have to re-open this ticket.
I've fixed it with the following commit: commit f09dd912ca46cc4e5553da867bc148656110510c Author: David Mitchell <davem@iabyn.com> AuthorDate: Mon Nov 19 14:12:05 2018 +0000 Commit: David Mitchell <davem@iabyn.com> CommitDate: Mon Nov 19 14:12:05 2018 +0000 ext/File-Find: support parallel testing t/harness was recently modified to run tests under ext/ etc in parallel. ext/File-Find/t/ has two test scripts which both use the same temporary directory names. Make taint.t use different names, so that it can run in parallel with the other script. M ext/File-Find/t/taint.t M t/harness -- print+qq&$}$"$/$s$,$a$d$g$s$@$.$q$,$:$.$q$^$,$@$a$~$;$.$q$m&if+map{m,^\d{0\,},,${$::{$'}}=chr($"+=$&||1)}q&10m22,42}6:17a2~2.3@3;^2dg3q/s"&=~m*\d\*.*g
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 1.6k
On Mon, 19 Nov 2018 14:22:52 GMT, davem wrote: Show quoted text
> On Sat, Nov 17, 2018 at 02:18:00PM -0800, James E Keenan via RT wrote:
> > > > I am observing new test failures in File::Find in blead.
> >
> > > > I suspect the problem arises from this commit: > > > > > > > > ##### > > > > commit 9b0adf193cf9b592bf4162895b7fe90a3aa2aa2b > > > > Author: Karl Williamson <khw@cpan.org> > > > > AuthorDate: Tue Jul 24 22:26:39 2018 > > > > Commit: Karl Williamson <khw@cpan.org> > > > > CommitDate: Wed Nov 14 11:04:45 2018 > > > > > > > > Add more parallelism to t/harness
>
> > > Fixed in blead by commit ed0ccc61a67a1df17e4187c8ed96ae8f9aa4781a. > > > The commit previously cited gives t/harness an internal list of > > > directories whose tests must not be run in parallel. I added > > > ext/File-Find/t to that list.
>
> > Unfortunately, the fix doesn't seem to be working consistently, so I > > have to re-open this ticket.
> > I've fixed it with the following commit: > > commit f09dd912ca46cc4e5553da867bc148656110510c > Author: David Mitchell <davem@iabyn.com> > AuthorDate: Mon Nov 19 14:12:05 2018 +0000 > Commit: David Mitchell <davem@iabyn.com> > CommitDate: Mon Nov 19 14:12:05 2018 +0000 > > ext/File-Find: support parallel testing > > t/harness was recently modified to run tests under ext/ etc in > parallel. > ext/File-Find/t/ has two test scripts which both use the same > temporary > directory names. > Make taint.t use different names, so that it can run in parallel with > the other script. > > M ext/File-Find/t/taint.t > M t/harness
I'll monitor this ticket for several days, then re-close it. Thanks. -- James E Keenan (jkeenan@cpan.org)
RT-Send-CC: perl5-porters [...] perl.org
After Dave's change, should it be possible to revert ed0ccc61a67?
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 375b
On Tue, 20 Nov 2018 18:18:37 GMT, ether wrote: Show quoted text
> After Dave's change, should it be possible to revert ed0ccc61a67?
I wouldn't object to it; I have no strong attachment to that commit. But I don't see that it's necessary. I don't have enough understanding of the possible ramifications of 'git revert' to object. Thank you very much. -- James E Keenan (jkeenan@cpan.org)
From: Karl Williamson <public [...] khwilliamson.com>
Date: Tue, 20 Nov 2018 16:59:23 -0700
Subject: Re: [perl #133658] 9b0adf19 breaks tests in ext/File-Find/t/ when run in harness
To: perlbug-followup [...] perl.org
Download (untitled) / with headers
text/plain 440b
On 11/20/18 11:58 AM, James E Keenan via RT wrote: Show quoted text
> On Tue, 20 Nov 2018 18:18:37 GMT, ether wrote:
>> After Dave's change, should it be possible to revert ed0ccc61a67?
> > I wouldn't object to it; I have no strong attachment to that commit. But I don't see that it's necessary. I don't have enough understanding of the possible ramifications of 'git revert' to object. > > Thank you very much. >
Dave's change included the reversion
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 1.8k
On Mon, 19 Nov 2018 23:16:28 GMT, jkeenan wrote: Show quoted text
> On Mon, 19 Nov 2018 14:22:52 GMT, davem wrote:
> > On Sat, Nov 17, 2018 at 02:18:00PM -0800, James E Keenan via RT wrote:
> > > > > I am observing new test failures in File::Find in blead.
> > > >
> > > > > I suspect the problem arises from this commit: > > > > > > > > > > ##### > > > > > commit 9b0adf193cf9b592bf4162895b7fe90a3aa2aa2b > > > > > Author: Karl Williamson <khw@cpan.org> > > > > > AuthorDate: Tue Jul 24 22:26:39 2018 > > > > > Commit: Karl Williamson <khw@cpan.org> > > > > > CommitDate: Wed Nov 14 11:04:45 2018 > > > > > > > > > > Add more parallelism to t/harness
> >
> > > > Fixed in blead by commit ed0ccc61a67a1df17e4187c8ed96ae8f9aa4781a. > > > > The commit previously cited gives t/harness an internal list of > > > > directories whose tests must not be run in parallel. I added > > > > ext/File-Find/t to that list.
> >
> > > Unfortunately, the fix doesn't seem to be working consistently, so I > > > have to re-open this ticket.
> > > > I've fixed it with the following commit: > > > > commit f09dd912ca46cc4e5553da867bc148656110510c > > Author: David Mitchell <davem@iabyn.com> > > AuthorDate: Mon Nov 19 14:12:05 2018 +0000 > > Commit: David Mitchell <davem@iabyn.com> > > CommitDate: Mon Nov 19 14:12:05 2018 +0000 > > > > ext/File-Find: support parallel testing > > > > t/harness was recently modified to run tests under ext/ etc in > > parallel. > > ext/File-Find/t/ has two test scripts which both use the same > > temporary > > directory names. > > Make taint.t use different names, so that it can run in parallel with > > the other script. > > > > M ext/File-Find/t/taint.t > > M t/harness
> > I'll monitor this ticket for several days, then re-close it. Thanks.
No further problems reported; closing ticket. -- James E Keenan (jkeenan@cpan.org)
Download (untitled) / with headers
text/plain 313b
Thank you for filing this report. You have helped make Perl better. With the release today of Perl 5.30.0, this and 160 other issues have been resolved. Perl 5.30.0 may be downloaded via: https://metacpan.org/release/XSAWYERX/perl-5.30.0 If you find that the problem persists, feel free to reopen this ticket.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org