Skip Menu |
Report information
Id: 133458
Status: resolved
Priority: 0/
Queue: perl5

Owner: Nobody
Requestors: jkeenan [at] pobox.com
sbeck <sbeck [at] cpan.org>
Cc:
AdminCc:

Operating System: (no value)
PatchStatus: (no value)
Severity: low
Type: unknown
Perl Version: (no value)
Fixed In: (no value)



From: James E Keenan <jkeenan [...] pobox.com>
Subject: Remove Locale-Codes from core modules
Date: Sat, 18 Aug 2018 22:06:53 -0400
To: perlbug [...] perl.org
Download (untitled) / with headers
text/plain 1.1k
So that we can have a permanent record in RT of this proposed module removal, I am opening this ticket. Sullivan Beck, maintainer of Locale-Codes, originally proposed removal of this module from the core in November 2017. Discussion began here: https://lists.gt.net/perl/porters/338584?search_string=Locale-Codes;#338584 Today (Aug 18 2018), Sullivan Beck wrote: ##### I've got a patch ready that removes Locale-Codes from perl core. It is available at: https://sullybeck.com/0001-Remove-Locale-Codes-from-core.patch.gz I did NOT update any change file to state that the package was no longer distributed in core, so that will need to be done by someone more familiar with keeping the changes recorded. Also, running make on the resulting source gave errors when running: t/porting/podcheck I'm not familiar with the podcheck script, so I'm uncertain of the correct way to resolve this, so I'll leave that to others as well. Let me know if there's anything else that I should do on my end. ##### Sullivan's (gzipped) patch is attached. Once RT gives me a ticket number, I will try to create a smoke-me branch from that patch. Thank you very much. Jim Keenan

Message body not shown because it is not plain text.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 1.5k
On Sun, 19 Aug 2018 02:07:10 GMT, jkeenan@pobox.com wrote: Show quoted text
> So that we can have a permanent record in RT of this proposed module > removal, I am opening this ticket. > > Sullivan Beck, maintainer of Locale-Codes, originally proposed removal > of this module from the core in November 2017. Discussion began here: > > https://lists.gt.net/perl/porters/338584?search_string=Locale-Codes;#338584 > > Today (Aug 18 2018), Sullivan Beck wrote: > > ##### > > I've got a patch ready that removes Locale-Codes from perl core. It is > available at: > > https://sullybeck.com/0001-Remove-Locale-Codes-from-core.patch.gz > > I did NOT update any change file to state that the package was no longer > distributed in core, so that will need to be done by someone more > familiar with keeping the changes recorded. > > Also, running make on the resulting source gave errors when running: > > t/porting/podcheck > > I'm not familiar with the podcheck script, so I'm uncertain of the > correct way to resolve this, so I'll leave that to others as well. > > Let me know if there's anything else that I should do on my end. > > ##### > > Sullivan's (gzipped) patch is attached. Once RT gives me a ticket > number, I will try to create a smoke-me branch from that patch. > > Thank you very much. > Jim Keenan >
Here's the branch: smoke-me/jkeenan/sbeck/133458-remove-locale-codes As Sullivan noted, there were problems with the porting tests. It took me several commits to get all tests PASSing. I'm attaching the 3 commits for code review purposes. Thank you very much. -- James E Keenan (jkeenan@cpan.org)
Subject: 0002-Remove-superseded-links-from-Unicode-UCD.patch
From 6f98fceb19fcd8cd2a2af18f4504c3e2110a9020 Mon Sep 17 00:00:00 2001 From: James E Keenan <jkeenan@cpan.org> Date: Sat, 18 Aug 2018 22:27:50 -0400 Subject: [PATCH 2/4] Remove superseded links from Unicode::UCD. Run regen/regcharclass.pl to update regcharclass.h. --- lib/Unicode/UCD.pm | 12 +++++------- regcharclass.h | 2 +- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/lib/Unicode/UCD.pm b/lib/Unicode/UCD.pm index 0bb9667..e42a188 100644 --- a/lib/Unicode/UCD.pm +++ b/lib/Unicode/UCD.pm @@ -5,7 +5,7 @@ use warnings; no warnings 'surrogate'; # surrogates can be inputs to this use charnames (); -our $VERSION = '0.71'; +our $VERSION = '0.72'; require Exporter; @@ -1611,14 +1611,12 @@ and are returned by L</charinfo()>. Note that when this function does return a value, it will be for the complete set of mappings for a code point, even those whose length is one. -If there are additional casing rules that apply only in certain locales, -an additional key for each will be defined in the returned hash. Each such key +If there are additional casing rules that apply only in certain locales, an +additional key for each will be defined in the returned hash. Each such key will be its locale name, defined as a 2-letter ISO 3166 country code, possibly followed by a "_" and a 2-letter ISO language code (possibly followed by a "_" -and a variant code). You can find the lists of all possible locales, see -L<Locale::Country> and L<Locale::Language>. -(In Unicode 6.0, the only locales returned by this function -are C<lt>, C<tr>, and C<az>.) +and a variant code). (In Unicode 6.0, the only locales returned by this +function are C<lt>, C<tr>, and C<az>.) Each locale key is a reference to a hash that has the form above, and gives the casing rules for that particular locale, which take precedence over the diff --git a/regcharclass.h b/regcharclass.h index 5240fdc..f133b88 100644 --- a/regcharclass.h +++ b/regcharclass.h @@ -1863,7 +1863,7 @@ #endif /* PERL_REGCHARCLASS_H_ */ /* Generated from: - * f0b404b165a72b0aaeca3ce517cd14ea1b501720c98719dadbb990f1952fc568 lib/Unicode/UCD.pm + * 97f567befddc6f431bfc2ed71d1e8fa4d567fe3ed76420743305ecf0445a37eb lib/Unicode/UCD.pm * 0bc5023a4606962114c4eb3775fae072cad8fecef5894d0de06603b1c70cbb47 lib/unicore/ArabicShaping.txt * 2c7e2fb0cb91b378f0fa9301e951946e4de68f2ab6afc68d21bcff57cd2a8ad8 lib/unicore/BidiBrackets.txt * f6d297765469724af523737c80faba3c33518fade4c5dc599e3ab51846f56916 lib/unicore/BidiMirroring.txt -- 2.7.4
Subject: 0003-Changes-from-running-.-perl-Ilib-regen-mk_invlists.p.patch
From f77812129284e32855d3d7098949dc15723d8d73 Mon Sep 17 00:00:00 2001 From: James E Keenan <jkeenan@cpan.org> Date: Sat, 18 Aug 2018 22:38:55 -0400 Subject: [PATCH 3/4] Changes from running: './perl -Ilib regen/mk_invlists.pl' --- charclass_invlists.h | 2 +- uni_keywords.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/charclass_invlists.h b/charclass_invlists.h index 9965fbe..1e459dc 100644 --- a/charclass_invlists.h +++ b/charclass_invlists.h @@ -383371,7 +383371,7 @@ static const U8 WB_table[23][23] = { #endif /* defined(PERL_IN_REGEXEC_C) */ /* Generated from: - * f0b404b165a72b0aaeca3ce517cd14ea1b501720c98719dadbb990f1952fc568 lib/Unicode/UCD.pm + * 97f567befddc6f431bfc2ed71d1e8fa4d567fe3ed76420743305ecf0445a37eb lib/Unicode/UCD.pm * 0bc5023a4606962114c4eb3775fae072cad8fecef5894d0de06603b1c70cbb47 lib/unicore/ArabicShaping.txt * 2c7e2fb0cb91b378f0fa9301e951946e4de68f2ab6afc68d21bcff57cd2a8ad8 lib/unicore/BidiBrackets.txt * f6d297765469724af523737c80faba3c33518fade4c5dc599e3ab51846f56916 lib/unicore/BidiMirroring.txt diff --git a/uni_keywords.h b/uni_keywords.h index 61aa62c..770668c 100644 --- a/uni_keywords.h +++ b/uni_keywords.h @@ -6944,7 +6944,7 @@ MPH_VALt match_uniprop( const unsigned char * const key, const U16 key_len ) { } /* Generated from: - * f0b404b165a72b0aaeca3ce517cd14ea1b501720c98719dadbb990f1952fc568 lib/Unicode/UCD.pm + * 97f567befddc6f431bfc2ed71d1e8fa4d567fe3ed76420743305ecf0445a37eb lib/Unicode/UCD.pm * 0bc5023a4606962114c4eb3775fae072cad8fecef5894d0de06603b1c70cbb47 lib/unicore/ArabicShaping.txt * 2c7e2fb0cb91b378f0fa9301e951946e4de68f2ab6afc68d21bcff57cd2a8ad8 lib/unicore/BidiBrackets.txt * f6d297765469724af523737c80faba3c33518fade4c5dc599e3ab51846f56916 lib/unicore/BidiMirroring.txt -- 2.7.4
Subject: 0004-Run-.-perl-Ilib-regen-lib_cleanup.pl.patch
From 4c9fdf613b231bb5a223114e3c8b774f5fde3b3b Mon Sep 17 00:00:00 2001 From: James E Keenan <jkeenan@cpan.org> Date: Sat, 18 Aug 2018 23:08:34 -0400 Subject: [PATCH 4/4] Run ./perl -Ilib regen/lib_cleanup.pl. --- Makefile.SH | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/Makefile.SH b/Makefile.SH index a98c651..6f33a73 100755 --- a/Makefile.SH +++ b/Makefile.SH @@ -1443,16 +1443,15 @@ _cleaner2: -rmdir lib/Parse/CPAN lib/Parse lib/Params lib/Net/FTP lib/Module/Load -rmdir lib/Module/CoreList lib/Module lib/Memoize lib/Math/BigInt -rmdir lib/Math/BigFloat lib/Math lib/MIME lib/Locale/Maketext - -rmdir lib/Locale/Codes lib/Locale lib/List/Util lib/List lib/JSON/PP - -rmdir lib/JSON lib/IPC lib/IO/Uncompress/Adapter lib/IO/Uncompress - -rmdir lib/IO/Socket lib/IO/Compress/Zlib lib/IO/Compress/Zip - -rmdir lib/IO/Compress/Gzip lib/IO/Compress/Base - -rmdir lib/IO/Compress/Adapter lib/IO/Compress lib/IO - -rmdir lib/I18N/LangTags lib/I18N lib/Hash/Util lib/Hash lib/HTTP - -rmdir lib/Filter/Util lib/Filter lib/File/Spec lib/ExtUtils/Typemaps - -rmdir lib/ExtUtils/ParseXS lib/ExtUtils/MakeMaker/version - -rmdir lib/ExtUtils/MakeMaker lib/ExtUtils/Liblist - -rmdir lib/ExtUtils/Constant lib/ExtUtils/Command + -rmdir lib/Locale lib/List/Util lib/List lib/JSON/PP lib/JSON lib/IPC + -rmdir lib/IO/Uncompress/Adapter lib/IO/Uncompress lib/IO/Socket + -rmdir lib/IO/Compress/Zlib lib/IO/Compress/Zip lib/IO/Compress/Gzip + -rmdir lib/IO/Compress/Base lib/IO/Compress/Adapter lib/IO/Compress + -rmdir lib/IO lib/I18N/LangTags lib/I18N lib/Hash/Util lib/Hash + -rmdir lib/HTTP lib/Filter/Util lib/Filter lib/File/Spec + -rmdir lib/ExtUtils/Typemaps lib/ExtUtils/ParseXS + -rmdir lib/ExtUtils/MakeMaker/version lib/ExtUtils/MakeMaker + -rmdir lib/ExtUtils/Liblist lib/ExtUtils/Constant lib/ExtUtils/Command -rmdir lib/ExtUtils/CBuilder/Platform/Windows -rmdir lib/ExtUtils/CBuilder/Platform lib/ExtUtils/CBuilder -rmdir lib/Exporter lib/Encode/Unicode lib/Encode/MIME/Header -- 2.7.4
To: perlbug-followup [...] perl.org
Subject: Re: [perl #133458] Remove Locale-Codes from core modules
Date: Sat, 18 Aug 2018 22:04:55 -0600
From: Karl Williamson <public [...] khwilliamson.com>
CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 2.3k
On 08/18/2018 09:23 PM, James E Keenan via RT wrote: Show quoted text
> On Sun, 19 Aug 2018 02:07:10 GMT, jkeenan@pobox.com wrote:
>> So that we can have a permanent record in RT of this proposed module >> removal, I am opening this ticket. >> >> Sullivan Beck, maintainer of Locale-Codes, originally proposed removal >> of this module from the core in November 2017. Discussion began here: >> >> https://lists.gt.net/perl/porters/338584?search_string=Locale-Codes;#338584 >> >> Today (Aug 18 2018), Sullivan Beck wrote: >> >> ##### >> >> I've got a patch ready that removes Locale-Codes from perl core. It is >> available at: >> >> https://sullybeck.com/0001-Remove-Locale-Codes-from-core.patch.gz >> >> I did NOT update any change file to state that the package was no longer >> distributed in core, so that will need to be done by someone more >> familiar with keeping the changes recorded. >> >> Also, running make on the resulting source gave errors when running: >> >> t/porting/podcheck >> >> I'm not familiar with the podcheck script, so I'm uncertain of the >> correct way to resolve this, so I'll leave that to others as well. >> >> Let me know if there's anything else that I should do on my end. >> >> ##### >> >> Sullivan's (gzipped) patch is attached. Once RT gives me a ticket >> number, I will try to create a smoke-me branch from that patch. >> >> Thank you very much. >> Jim Keenan >>
> > > Here's the branch: > > smoke-me/jkeenan/sbeck/133458-remove-locale-codes > > As Sullivan noted, there were problems with the porting tests. It took me several commits to get all tests PASSing. I'm attaching the 3 commits for code review purposes. > > Thank you very much. >
Attached is an alternative patch (that might want to be split). There are mentions of Locale::Codes that it removes that are apparently harmless, but maybe we should get rid of them. There is a comment as well that mentions it, but I left it in. More importantly, the podcheck fix doesn't involve removing the links from UCD. 'podcheck --addlink' can be used to say this is a legitimate link. When Locale::Codes was in the distirubtion podceck was able to find it and its links and verify that these were correct. But now it's gone, and podcheck has no current way of checking if these links exist somewhere or not. I believe that the links will work, and so we shouldn't remove them.

Message body is not shown because sender requested not to inline it.

To: perlbug-followup [...] perl.org
CC: perl5-porters [...] perl.org
Date: Sat, 18 Aug 2018 22:04:55 -0600
Subject: Re: [perl #133458] Remove Locale-Codes from core modules
From: Karl Williamson <public [...] khwilliamson.com>
Download (untitled) / with headers
text/plain 2.3k
On 08/18/2018 09:23 PM, James E Keenan via RT wrote: Show quoted text
> On Sun, 19 Aug 2018 02:07:10 GMT, jkeenan@pobox.com wrote:
>> So that we can have a permanent record in RT of this proposed module >> removal, I am opening this ticket. >> >> Sullivan Beck, maintainer of Locale-Codes, originally proposed removal >> of this module from the core in November 2017. Discussion began here: >> >> https://lists.gt.net/perl/porters/338584?search_string=Locale-Codes;#338584 >> >> Today (Aug 18 2018), Sullivan Beck wrote: >> >> ##### >> >> I've got a patch ready that removes Locale-Codes from perl core. It is >> available at: >> >> https://sullybeck.com/0001-Remove-Locale-Codes-from-core.patch.gz >> >> I did NOT update any change file to state that the package was no longer >> distributed in core, so that will need to be done by someone more >> familiar with keeping the changes recorded. >> >> Also, running make on the resulting source gave errors when running: >> >> t/porting/podcheck >> >> I'm not familiar with the podcheck script, so I'm uncertain of the >> correct way to resolve this, so I'll leave that to others as well. >> >> Let me know if there's anything else that I should do on my end. >> >> ##### >> >> Sullivan's (gzipped) patch is attached. Once RT gives me a ticket >> number, I will try to create a smoke-me branch from that patch. >> >> Thank you very much. >> Jim Keenan >>
> > > Here's the branch: > > smoke-me/jkeenan/sbeck/133458-remove-locale-codes > > As Sullivan noted, there were problems with the porting tests. It took me several commits to get all tests PASSing. I'm attaching the 3 commits for code review purposes. > > Thank you very much. >
Attached is an alternative patch (that might want to be split). There are mentions of Locale::Codes that it removes that are apparently harmless, but maybe we should get rid of them. There is a comment as well that mentions it, but I left it in. More importantly, the podcheck fix doesn't involve removing the links from UCD. 'podcheck --addlink' can be used to say this is a legitimate link. When Locale::Codes was in the distirubtion podceck was able to find it and its links and verify that these were correct. But now it's gone, and podcheck has no current way of checking if these links exist somewhere or not. I believe that the links will work, and so we shouldn't remove them.

Message body is not shown because sender requested not to inline it.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 2.7k
On Sun, 19 Aug 2018 04:05:54 GMT, public@khwilliamson.com wrote: Show quoted text
> On 08/18/2018 09:23 PM, James E Keenan via RT wrote:
> > On Sun, 19 Aug 2018 02:07:10 GMT, jkeenan@pobox.com wrote:
> >> So that we can have a permanent record in RT of this proposed module > >> removal, I am opening this ticket. > >> > >> Sullivan Beck, maintainer of Locale-Codes, originally proposed > >> removal > >> of this module from the core in November 2017. Discussion began > >> here: > >> > >> https://lists.gt.net/perl/porters/338584?search_string=Locale- > >> Codes;#338584 > >> > >> Today (Aug 18 2018), Sullivan Beck wrote: > >> > >> ##### > >> > >> I've got a patch ready that removes Locale-Codes from perl core. It > >> is > >> available at: > >> > >> https://sullybeck.com/0001-Remove-Locale-Codes-from-core.patch.gz > >> > >> I did NOT update any change file to state that the package was no > >> longer > >> distributed in core, so that will need to be done by someone more > >> familiar with keeping the changes recorded. > >> > >> Also, running make on the resulting source gave errors when running: > >> > >> t/porting/podcheck > >> > >> I'm not familiar with the podcheck script, so I'm uncertain of the > >> correct way to resolve this, so I'll leave that to others as well. > >> > >> Let me know if there's anything else that I should do on my end. > >> > >> ##### > >> > >> Sullivan's (gzipped) patch is attached. Once RT gives me a ticket > >> number, I will try to create a smoke-me branch from that patch. > >> > >> Thank you very much. > >> Jim Keenan > >>
> > > > > > Here's the branch: > > > > smoke-me/jkeenan/sbeck/133458-remove-locale-codes > > > > As Sullivan noted, there were problems with the porting tests. It > > took me several commits to get all tests PASSing. I'm attaching the > > 3 commits for code review purposes. > > > > Thank you very much. > >
> > Attached is an alternative patch (that might want to be split). There > are mentions of Locale::Codes that it removes that are apparently > harmless, but maybe we should get rid of them. There is a comment as > well that mentions it, but I left it in. > > More importantly, the podcheck fix doesn't involve removing the links > from UCD. 'podcheck --addlink' can be used to say this is a > legitimate > link. When Locale::Codes was in the distirubtion podceck was able to > find it and its links and verify that these were correct. But now > it's > gone, and podcheck has no current way of checking if these links exist > somewhere or not. I believe that the links will work, and so we > shouldn't remove them.
I'm not wedded to my particular choices, so, rather than multiplying branches, I suggest you apply this patch to the smoke-me branch I created yesterday. Thank you very much. -- James E Keenan (jkeenan@cpan.org)
Date: Sun, 19 Aug 2018 10:01:20 -0600
Subject: Re: [perl #133458] Remove Locale-Codes from core modules
To: perlbug-followup [...] perl.org
From: Karl Williamson <public [...] khwilliamson.com>
CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 2.8k
On 08/19/2018 06:47 AM, James E Keenan via RT wrote: Show quoted text
> On Sun, 19 Aug 2018 04:05:54 GMT, public@khwilliamson.com wrote:
>> On 08/18/2018 09:23 PM, James E Keenan via RT wrote:
>>> On Sun, 19 Aug 2018 02:07:10 GMT, jkeenan@pobox.com wrote:
>>>> So that we can have a permanent record in RT of this proposed module >>>> removal, I am opening this ticket. >>>> >>>> Sullivan Beck, maintainer of Locale-Codes, originally proposed >>>> removal >>>> of this module from the core in November 2017. Discussion began >>>> here: >>>> >>>> https://lists.gt.net/perl/porters/338584?search_string=Locale- >>>> Codes;#338584 >>>> >>>> Today (Aug 18 2018), Sullivan Beck wrote: >>>> >>>> ##### >>>> >>>> I've got a patch ready that removes Locale-Codes from perl core. It >>>> is >>>> available at: >>>> >>>> https://sullybeck.com/0001-Remove-Locale-Codes-from-core.patch.gz >>>> >>>> I did NOT update any change file to state that the package was no >>>> longer >>>> distributed in core, so that will need to be done by someone more >>>> familiar with keeping the changes recorded. >>>> >>>> Also, running make on the resulting source gave errors when running: >>>> >>>> t/porting/podcheck >>>> >>>> I'm not familiar with the podcheck script, so I'm uncertain of the >>>> correct way to resolve this, so I'll leave that to others as well. >>>> >>>> Let me know if there's anything else that I should do on my end. >>>> >>>> ##### >>>> >>>> Sullivan's (gzipped) patch is attached. Once RT gives me a ticket >>>> number, I will try to create a smoke-me branch from that patch. >>>> >>>> Thank you very much. >>>> Jim Keenan >>>>
>>> >>> >>> Here's the branch: >>> >>> smoke-me/jkeenan/sbeck/133458-remove-locale-codes >>> >>> As Sullivan noted, there were problems with the porting tests. It >>> took me several commits to get all tests PASSing. I'm attaching the >>> 3 commits for code review purposes. >>> >>> Thank you very much. >>>
>> >> Attached is an alternative patch (that might want to be split). There >> are mentions of Locale::Codes that it removes that are apparently >> harmless, but maybe we should get rid of them. There is a comment as >> well that mentions it, but I left it in. >> >> More importantly, the podcheck fix doesn't involve removing the links >> from UCD. 'podcheck --addlink' can be used to say this is a >> legitimate >> link. When Locale::Codes was in the distirubtion podceck was able to >> find it and its links and verify that these were correct. But now >> it's >> gone, and podcheck has no current way of checking if these links exist >> somewhere or not. I believe that the links will work, and so we >> shouldn't remove them.
> > I'm not wedded to my particular choices, so, rather than multiplying branches, I suggest you apply this patch to the smoke-me branch I created yesterday. > > Thank you very much. >
Done. I reverted your two patches in this regard, and added my own.
Subject: Re: [perl #133458] Remove Locale-Codes from core modules
Date: Sun, 19 Aug 2018 10:01:20 -0600
To: perlbug-followup [...] perl.org
CC: perl5-porters [...] perl.org
From: Karl Williamson <public [...] khwilliamson.com>
Download (untitled) / with headers
text/plain 2.8k
On 08/19/2018 06:47 AM, James E Keenan via RT wrote: Show quoted text
> On Sun, 19 Aug 2018 04:05:54 GMT, public@khwilliamson.com wrote:
>> On 08/18/2018 09:23 PM, James E Keenan via RT wrote:
>>> On Sun, 19 Aug 2018 02:07:10 GMT, jkeenan@pobox.com wrote:
>>>> So that we can have a permanent record in RT of this proposed module >>>> removal, I am opening this ticket. >>>> >>>> Sullivan Beck, maintainer of Locale-Codes, originally proposed >>>> removal >>>> of this module from the core in November 2017. Discussion began >>>> here: >>>> >>>> https://lists.gt.net/perl/porters/338584?search_string=Locale- >>>> Codes;#338584 >>>> >>>> Today (Aug 18 2018), Sullivan Beck wrote: >>>> >>>> ##### >>>> >>>> I've got a patch ready that removes Locale-Codes from perl core. It >>>> is >>>> available at: >>>> >>>> https://sullybeck.com/0001-Remove-Locale-Codes-from-core.patch.gz >>>> >>>> I did NOT update any change file to state that the package was no >>>> longer >>>> distributed in core, so that will need to be done by someone more >>>> familiar with keeping the changes recorded. >>>> >>>> Also, running make on the resulting source gave errors when running: >>>> >>>> t/porting/podcheck >>>> >>>> I'm not familiar with the podcheck script, so I'm uncertain of the >>>> correct way to resolve this, so I'll leave that to others as well. >>>> >>>> Let me know if there's anything else that I should do on my end. >>>> >>>> ##### >>>> >>>> Sullivan's (gzipped) patch is attached. Once RT gives me a ticket >>>> number, I will try to create a smoke-me branch from that patch. >>>> >>>> Thank you very much. >>>> Jim Keenan >>>>
>>> >>> >>> Here's the branch: >>> >>> smoke-me/jkeenan/sbeck/133458-remove-locale-codes >>> >>> As Sullivan noted, there were problems with the porting tests. It >>> took me several commits to get all tests PASSing. I'm attaching the >>> 3 commits for code review purposes. >>> >>> Thank you very much. >>>
>> >> Attached is an alternative patch (that might want to be split). There >> are mentions of Locale::Codes that it removes that are apparently >> harmless, but maybe we should get rid of them. There is a comment as >> well that mentions it, but I left it in. >> >> More importantly, the podcheck fix doesn't involve removing the links >> from UCD. 'podcheck --addlink' can be used to say this is a >> legitimate >> link. When Locale::Codes was in the distirubtion podceck was able to >> find it and its links and verify that these were correct. But now >> it's >> gone, and podcheck has no current way of checking if these links exist >> somewhere or not. I believe that the links will work, and so we >> shouldn't remove them.
> > I'm not wedded to my particular choices, so, rather than multiplying branches, I suggest you apply this patch to the smoke-me branch I created yesterday. > > Thank you very much. >
Done. I reverted your two patches in this regard, and added my own.
CC: perl5-porters [...] perl.org
From: Karl Williamson <public [...] khwilliamson.com>
To: perlbug-followup [...] perl.org
Subject: Re: [perl #133458] Remove Locale-Codes from core modules
Date: Wed, 22 Aug 2018 15:47:21 -0600
Download (untitled) / with headers
text/plain 3.2k
On 08/19/2018 10:01 AM, Karl Williamson wrote: Show quoted text
> On 08/19/2018 06:47 AM, James E Keenan via RT wrote:
>> On Sun, 19 Aug 2018 04:05:54 GMT, public@khwilliamson.com wrote:
>>> On 08/18/2018 09:23 PM, James E Keenan via RT wrote:
>>>> On Sun, 19 Aug 2018 02:07:10 GMT, jkeenan@pobox.com wrote:
>>>>> So that we can have a permanent record in RT of this proposed module >>>>> removal, I am opening this ticket. >>>>> >>>>> Sullivan Beck, maintainer of Locale-Codes, originally proposed >>>>> removal >>>>> of this module from the core in November 2017.  Discussion began >>>>> here: >>>>> >>>>> https://lists.gt.net/perl/porters/338584?search_string=Locale- >>>>> Codes;#338584 >>>>> >>>>> Today (Aug 18 2018), Sullivan Beck wrote: >>>>> >>>>> ##### >>>>> >>>>> I've got a patch ready that removes Locale-Codes from perl core.  It >>>>> is >>>>> available at: >>>>> >>>>> https://sullybeck.com/0001-Remove-Locale-Codes-from-core.patch.gz >>>>> >>>>> I did NOT update any change file to state that the package was no >>>>> longer >>>>> distributed in core, so that will need to be done by someone more >>>>> familiar with keeping the changes recorded. >>>>> >>>>> Also, running make on the resulting source gave errors when running: >>>>> >>>>> t/porting/podcheck >>>>> >>>>> I'm not familiar with the podcheck script, so I'm uncertain of the >>>>> correct way to resolve this, so I'll leave that to others as well. >>>>> >>>>> Let me know if there's anything else that I should do on my end. >>>>> >>>>> ##### >>>>> >>>>> Sullivan's (gzipped) patch is attached.  Once RT gives me a ticket >>>>> number, I will try to create a smoke-me branch from that patch. >>>>> >>>>> Thank you very much. >>>>> Jim Keenan >>>>>
>>>> >>>> >>>> Here's the branch: >>>> >>>> smoke-me/jkeenan/sbeck/133458-remove-locale-codes >>>> >>>> As Sullivan noted, there were problems with the porting tests.  It >>>> took me several commits to get all tests PASSing.  I'm attaching the >>>> 3 commits for code review purposes. >>>> >>>> Thank you very much. >>>>
>>> >>> Attached is an alternative patch (that might want to be split).  There >>> are mentions of Locale::Codes that it removes that are apparently >>> harmless, but maybe we should get rid of them.  There is a comment as >>> well that mentions it, but I left it in. >>> >>> More importantly, the podcheck fix doesn't involve removing the links >>> from UCD.  'podcheck --addlink' can be used to say this is a >>> legitimate >>> link.  When Locale::Codes was in the distirubtion podceck was able to >>> find it and its links and verify that these were correct.  But now >>> it's >>> gone, and podcheck has no current way of checking if these links exist >>> somewhere or not.  I believe that the links will work, and so we >>> shouldn't remove them.
>> >> I'm not wedded to my particular choices, so, rather than multiplying >> branches, I suggest you apply this patch to the smoke-me branch I >> created yesterday. >> >> Thank you very much. >>
> > Done.  I reverted your two patches in this regard, and added my own. >
Locale-Codes is now removed from blead by 56c2c0e80f6e9a947c72adce0301a65176f0ccbe with a followup to get porting tests to pass and remove no longer relevant references to it by f8989c011ff385aa7ff3d8c65483a36fba26b2f1
CC: perl5-porters [...] perl.org
From: Karl Williamson <public [...] khwilliamson.com>
To: perlbug-followup [...] perl.org
Date: Wed, 22 Aug 2018 15:47:21 -0600
Subject: Re: [perl #133458] Remove Locale-Codes from core modules
Download (untitled) / with headers
text/plain 3.2k
On 08/19/2018 10:01 AM, Karl Williamson wrote: Show quoted text
> On 08/19/2018 06:47 AM, James E Keenan via RT wrote:
>> On Sun, 19 Aug 2018 04:05:54 GMT, public@khwilliamson.com wrote:
>>> On 08/18/2018 09:23 PM, James E Keenan via RT wrote:
>>>> On Sun, 19 Aug 2018 02:07:10 GMT, jkeenan@pobox.com wrote:
>>>>> So that we can have a permanent record in RT of this proposed module >>>>> removal, I am opening this ticket. >>>>> >>>>> Sullivan Beck, maintainer of Locale-Codes, originally proposed >>>>> removal >>>>> of this module from the core in November 2017.  Discussion began >>>>> here: >>>>> >>>>> https://lists.gt.net/perl/porters/338584?search_string=Locale- >>>>> Codes;#338584 >>>>> >>>>> Today (Aug 18 2018), Sullivan Beck wrote: >>>>> >>>>> ##### >>>>> >>>>> I've got a patch ready that removes Locale-Codes from perl core.  It >>>>> is >>>>> available at: >>>>> >>>>> https://sullybeck.com/0001-Remove-Locale-Codes-from-core.patch.gz >>>>> >>>>> I did NOT update any change file to state that the package was no >>>>> longer >>>>> distributed in core, so that will need to be done by someone more >>>>> familiar with keeping the changes recorded. >>>>> >>>>> Also, running make on the resulting source gave errors when running: >>>>> >>>>> t/porting/podcheck >>>>> >>>>> I'm not familiar with the podcheck script, so I'm uncertain of the >>>>> correct way to resolve this, so I'll leave that to others as well. >>>>> >>>>> Let me know if there's anything else that I should do on my end. >>>>> >>>>> ##### >>>>> >>>>> Sullivan's (gzipped) patch is attached.  Once RT gives me a ticket >>>>> number, I will try to create a smoke-me branch from that patch. >>>>> >>>>> Thank you very much. >>>>> Jim Keenan >>>>>
>>>> >>>> >>>> Here's the branch: >>>> >>>> smoke-me/jkeenan/sbeck/133458-remove-locale-codes >>>> >>>> As Sullivan noted, there were problems with the porting tests.  It >>>> took me several commits to get all tests PASSing.  I'm attaching the >>>> 3 commits for code review purposes. >>>> >>>> Thank you very much. >>>>
>>> >>> Attached is an alternative patch (that might want to be split).  There >>> are mentions of Locale::Codes that it removes that are apparently >>> harmless, but maybe we should get rid of them.  There is a comment as >>> well that mentions it, but I left it in. >>> >>> More importantly, the podcheck fix doesn't involve removing the links >>> from UCD.  'podcheck --addlink' can be used to say this is a >>> legitimate >>> link.  When Locale::Codes was in the distirubtion podceck was able to >>> find it and its links and verify that these were correct.  But now >>> it's >>> gone, and podcheck has no current way of checking if these links exist >>> somewhere or not.  I believe that the links will work, and so we >>> shouldn't remove them.
>> >> I'm not wedded to my particular choices, so, rather than multiplying >> branches, I suggest you apply this patch to the smoke-me branch I >> created yesterday. >> >> Thank you very much. >>
> > Done.  I reverted your two patches in this regard, and added my own. >
Locale-Codes is now removed from blead by 56c2c0e80f6e9a947c72adce0301a65176f0ccbe with a followup to get porting tests to pass and remove no longer relevant references to it by f8989c011ff385aa7ff3d8c65483a36fba26b2f1
Download (untitled) / with headers
text/plain 239b
Locale-Codes is now removed from blead by 56c2c0e80f6e9a947c72adce0301a65176f0ccbe with a followup to get porting tests to pass and remove no longer relevant references to it by f8989c011ff385aa7ff3d8c65483a36fba26b2f1 -- Karl Williamson
Download (untitled) / with headers
text/plain 313b
Thank you for filing this report. You have helped make Perl better. With the release today of Perl 5.30.0, this and 160 other issues have been resolved. Perl 5.30.0 may be downloaded via: https://metacpan.org/release/XSAWYERX/perl-5.30.0 If you find that the problem persists, feel free to reopen this ticket.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org