Skip Menu |
Report information
Id: 133141
Status: open
Priority: 0/
Queue: perl5

Owner: Nobody
Requestors: me [at] xenu.pl
Cc:
AdminCc:

Operating System: (no value)
PatchStatus: (no value)
Severity: low
Type: unknown
Perl Version: (no value)
Fixed In: (no value)

Attachments
0001-getcwd-doesn-t-fail-on-non-existent-directories-on-D.patch



From: Tomasz Konojacki <me [...] xenu.pl>
Subject: cwd_enoent.t fails on DragonFly BSD
Date: Sun, 22 Apr 2018 23:51:20 +0200
To: perlbug [...] perl.org
Download (untitled) / with headers
text/plain 1.4k
On the latest blead: --- % ./perl -I ../lib ../dist/PathTools/t/cwd_enoent.t 1..8 not ok 1 - regular getcwd result on non-existent directory # Failed test 'regular getcwd result on non-existent directory' # at ../dist/PathTools/t/cwd_enoent.t line 34. # got: '/tmp/LPDQmQvz61/testdir' # expected: undef not ok 2 - regular getcwd errno on non-existent directory # Failed test 'regular getcwd errno on non-existent directory' # at ../dist/PathTools/t/cwd_enoent.t line 35. # got: '0' # expected: '2' not ok 3 - regular abs_path result on non-existent directory # Failed test 'regular abs_path result on non-existent directory' # at ../dist/PathTools/t/cwd_enoent.t line 39. # got: '/tmp/LPDQmQvz61/testdir' # expected: undef not ok 4 - regular abs_path errno on non-existent directory # Failed test 'regular abs_path errno on non-existent directory' # at ../dist/PathTools/t/cwd_enoent.t line 40. # got: '0' # expected: '2' ok 5 - perl getcwd result on non-existent directory ok 6 - perl getcwd errno on non-existent directory ok 7 - perl abs_path result on non-existent directory ok 8 - perl abs_path errno on non-existent directory # Looks like you failed 4 tests of 8. --- The problem is similar to #132733, getcwd() doesn't fail on non-existent directories on DragonFly BSD. I'm sure it's a bug in DragonFly, but I think we should skip failing tests until it's fixed upstream.
To: perl5-porters [...] perl.org
Date: Mon, 23 Apr 2018 00:07:49 +0200
Subject: Re: [perl #133141] cwd_enoent.t fails on DragonFly BSD
From: Tomasz Konojacki <me [...] xenu.pl>
The patch is attached.

Message body is not shown because sender requested not to inline it.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 187b
On Sun, 22 Apr 2018 22:07:52 GMT, me@xenu.pl wrote: Show quoted text
> The patch is attached.
Available for smoke-testing in: smoke-me/jkeenan/xenu/133141-dragonfly -- James E Keenan (jkeenan@cpan.org)
To: perlbug-followup [...] perl.org
CC: perl5-porters [...] perl.org
Subject: Re: [perl #133141] cwd_enoent.t fails on DragonFly BSD
From: Karl Williamson <public [...] khwilliamson.com>
Date: Tue, 24 Apr 2018 14:18:15 -0600
Download (untitled) / with headers
text/plain 821b
On 04/24/2018 12:37 PM, James E Keenan via RT wrote: Show quoted text
> On Sun, 22 Apr 2018 22:07:52 GMT, me@xenu.pl wrote:
>> The patch is attached.
> > Available for smoke-testing in: > smoke-me/jkeenan/xenu/133141-dragonfly >
I support adding skips to tests during the freeze which fix failing smokes. The changes are isolated to the particular .t, and don't affect the functioning of the actual interpreter. But I'm thinking that skips for OS bugs, like this, should have be written so that they don't apply to any future version of the OS, if we have any hope at all that the vendor will eventually fix it. If the OS gets fixed, the test will automatically happen again; if a new version of the OS is released, and is still broken, we would have to update the test, but could then prod the vendor that this is an issue.
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 401b
On Tue, 24 Apr 2018 18:37:20 GMT, jkeenan wrote: Show quoted text
> On Sun, 22 Apr 2018 22:07:52 GMT, me@xenu.pl wrote:
> > The patch is attached.
> > Available for smoke-testing in: > smoke-me/jkeenan/xenu/133141-dragonfly
Xenu: It appears that you are the only person smoking on Dragonfly at the moment. Could you please test this branch on those rigs? Thank you very much. -- James E Keenan (jkeenan@cpan.org)
Subject: Re: [perl #133141] cwd_enoent.t fails on DragonFly BSD
From: Tomasz Konojacki <me [...] xenu.pl>
To: perl5-porters [...] perl.org
Date: Sat, 28 Apr 2018 03:08:53 +0200
Download (untitled) / with headers
text/plain 458b
On Fri, 27 Apr 2018 11:38:17 -0700 "James E Keenan via RT" <perlbug-followup@perl.org> wrote: Show quoted text
> Xenu: It appears that you are the only person smoking on Dragonfly at the moment. Could you please test this branch on those rigs? > > Thank you very much. > > -- > James E Keenan (jkeenan@cpan.org) > > --- > via perlbug: queue: perl5 status: open > https://rt.perl.org/Ticket/Display.html?id=133141
Looks good: http://perl5.test-smoke.org/report/65465
Subject: Re: [perl #133141] cwd_enoent.t fails on DragonFly BSD
CC: perlbug-followup [...] perl.org, perl5-porters [...] perl.org
From: Dave Mitchell <davem [...] iabyn.com>
To: Karl Williamson <public [...] khwilliamson.com>
Date: Mon, 30 Apr 2018 13:27:52 +0100
Download (untitled) / with headers
text/plain 1.3k
On Tue, Apr 24, 2018 at 02:18:15PM -0600, Karl Williamson wrote: Show quoted text
> On 04/24/2018 12:37 PM, James E Keenan via RT wrote:
> > On Sun, 22 Apr 2018 22:07:52 GMT, me@xenu.pl wrote:
> > > The patch is attached.
> > > > Available for smoke-testing in: > > smoke-me/jkeenan/xenu/133141-dragonfly > >
> > I support adding skips to tests during the freeze which fix failing smokes. > The changes are isolated to the particular .t, and don't affect the > functioning of the actual interpreter. > > But I'm thinking that skips for OS bugs, like this, should have be written > so that they don't apply to any future version of the OS, if we have any > hope at all that the vendor will eventually fix it. If the OS gets fixed, > the test will automatically happen again; if a new version of the OS is > released, and is still broken, we would have to update the test, but could > then prod the vendor that this is an issue.
While agree in principle, this late in code freeze, I'm happy for that patch to applies as-is (i.e. skip those tests if $^O eq 'dragonfly', regardless of version). The skip condition can always be softened later. -- "I used to be with it, but then they changed what ‘it’ was, and now what I’m with isn’t it. And what’s ‘it’ seems weird and scary to me." -- Grandpa Simpson (It will happen to you too.)
Date: Mon, 30 Apr 2018 23:53:43 +0300
From: Sawyer X <xsawyerx [...] gmail.com>
Subject: Re: [perl #133141] cwd_enoent.t fails on DragonFly BSD
CC: perlbug-followup [...] perl.org, perl5-porters [...] perl.org
To: Dave Mitchell <davem [...] iabyn.com>, Karl Williamson <public [...] khwilliamson.com>
Download (untitled) / with headers
text/plain 1.1k
On 04/30/2018 03:27 PM, Dave Mitchell wrote: Show quoted text
> On Tue, Apr 24, 2018 at 02:18:15PM -0600, Karl Williamson wrote:
>> On 04/24/2018 12:37 PM, James E Keenan via RT wrote:
>>> On Sun, 22 Apr 2018 22:07:52 GMT, me@xenu.pl wrote:
>>>> The patch is attached.
>>> Available for smoke-testing in: >>> smoke-me/jkeenan/xenu/133141-dragonfly >>>
>> I support adding skips to tests during the freeze which fix failing smokes. >> The changes are isolated to the particular .t, and don't affect the >> functioning of the actual interpreter. >> >> But I'm thinking that skips for OS bugs, like this, should have be written >> so that they don't apply to any future version of the OS, if we have any >> hope at all that the vendor will eventually fix it. If the OS gets fixed, >> the test will automatically happen again; if a new version of the OS is >> released, and is still broken, we would have to update the test, but could >> then prod the vendor that this is an issue.
> While agree in principle, this late in code freeze, I'm happy for that > patch to applies as-is (i.e. skip those tests if $^O eq 'dragonfly', > regardless of version).
Go for it.
To: Sawyer X <xsawyerx [...] gmail.com>
From: Dave Mitchell <davem [...] iabyn.com>
Subject: Re: [perl #133141] cwd_enoent.t fails on DragonFly BSD
CC: Karl Williamson <public [...] khwilliamson.com>, perlbug-followup [...] perl.org, perl5-porters [...] perl.org
Date: Tue, 1 May 2018 09:04:37 +0100
Download (untitled) / with headers
text/plain 1.3k
On Mon, Apr 30, 2018 at 11:53:43PM +0300, Sawyer X wrote: Show quoted text
> > > On 04/30/2018 03:27 PM, Dave Mitchell wrote:
> > On Tue, Apr 24, 2018 at 02:18:15PM -0600, Karl Williamson wrote:
> >> On 04/24/2018 12:37 PM, James E Keenan via RT wrote:
> >>> On Sun, 22 Apr 2018 22:07:52 GMT, me@xenu.pl wrote:
> >>>> The patch is attached.
> >>> Available for smoke-testing in: > >>> smoke-me/jkeenan/xenu/133141-dragonfly > >>>
> >> I support adding skips to tests during the freeze which fix failing smokes. > >> The changes are isolated to the particular .t, and don't affect the > >> functioning of the actual interpreter. > >> > >> But I'm thinking that skips for OS bugs, like this, should have be written > >> so that they don't apply to any future version of the OS, if we have any > >> hope at all that the vendor will eventually fix it. If the OS gets fixed, > >> the test will automatically happen again; if a new version of the OS is > >> released, and is still broken, we would have to update the test, but could > >> then prod the vendor that this is an issue.
> > While agree in principle, this late in code freeze, I'm happy for that > > patch to applies as-is (i.e. skip those tests if $^O eq 'dragonfly', > > regardless of version).
> > Go for it.
Now applied as v5.27.11-25-g02bf4969b4 -- Fire extinguisher (n) a device for holding open fire doors.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org