Skip Menu |
Report information
Id: 133014
Status: open
Priority: 0/
Queue: perl5

Owner: Nobody
Requestors: jkeenan [at] pobox.com
Cc:
AdminCc:

Operating System: All
PatchStatus: (no value)
Severity: low
Type:
Perl Version: 5.27.10
Fixed In: 5.27.11



To: perlbug [...] perl.org
Subject: [BBC]: Commit 1381350 (Time::HiRes synch with CPAN) breaks Catalyst-Runtime and others
From: James E Keenan <jkeenan [...] pobox.com>
Date: Thu, 22 Mar 2018 21:28:15 -0400
Download (untitled) / with headers
text/plain 3.3k
Time-HiRes is a distribution maintained under dist/, so it is supposed to be treated as "blead upstream", i.e., changes go first into blead and then are released to CPAN so as to be available to multiple versions of perl. Recently, however, there have been several releases of Time-HiRes directly to CPAN, leaving blead to play catch-up. One such release to CPAN has broken some code in CPAN distributions Catalyst-Runtime and Devel-TimeStats. Since that release of Time-HiRes was merged into blead prior to this week's release of perl-5.27.10, we now have a potential Blead Breaks CPAN situation -- though the code was broken is possibly sub-optimal, implying that the fix ought to be on CPAN rather than in Time-HiRes in blead. Nonetheless, we have to stay aware of this problem going into the release of perl-5.28.0; hence, this ticket. Details: 1. Recent commit to blead synching Time-HiRes with CPAN: ##### $ git log -- dist/Time-HiRes/HiRes.pm commit 13813507385079199d99d90776780dcd653f6919 Author: Todd Rinaldo <toddr@cpan.org> Date: Sun Mar 18 17:08:21 2018 -0500 Upgrade Time::HiRes from version 1.9753 to 1.9757 [DELTA] 1.9577 [2018-03-15] - fix win32 (and cygwin?) builds which have been broken since 1.9755: problem was that gettimeofday() is a macro and needs to stay such - regenerate ppport.h with Perl 5.26.1 (was previously generated with 5.25.6) and Devel::PPPort 3.35 (previously 3.36) -- this doesn't change the ppport.h, though 1.9756 [2018-03-14] - division by zero in new test tv_interval.t [rt.cpan.org #124775]: made the test pass even if the difference is zero, but also made it practically impossible to ever be zero by adding a sub-second sleep. - remove comments from inside qw [rt.cpan.org #124777], only seemed to be caught by Perl 5.18.4 1.9755 [2018-03-14] - adjust the error messages of tv_interval() - the NV_1EX constants now cast to be NV so that tv_interval() with long double builds does not produce ugly results [rt.cpan.org #106456] - add tests for tv_interval() - centralize the mygettimeofday() logic - make the mygettimeofday() a function instead of macro - add the OS X 10.12+ clock_gettime() constants CLOCK_MONOTONIC_RAW_APPROX CLOCK_UPTIME_RAW_APPROX - regenerate the fallback files 1.9754 [2018-02-16] - unify the gettimeofday() and time() forked code that had near identical code paths for MacOS Classic (which has two unusual features: unsigned time_t, and a special tz struct member), and for non-MacOS Classic - tv_interval should be implemented in XS [rt.cpan.org #106456] thanks to Sergey Aleynikov (suggested implementation simplified by the above-mentioned MacOS Classic simplification) ##### It appears that Time-HiRes version 1.9754 touched off the CPAN test failures. 2. Time-HiRes bug ticket: https://rt.cpan.org/Ticket/Display.html?id=124450 In this ticket both Zefram and JHI argue that the test code in the two CPAN modules is sub-optimal. 3. Catalyst-Runtime bug ticket: https://rt.cpan.org/Ticket/Display.html?id=124459 In this ticket SREZIC has provided a patch. 4. Devel-TimeStats issue: https://github.com/cafe01/Devel-TimeStats/issues/3 Thank you very much. Jim Keenan
Download 18503cb.perl_V.txt
text/plain 509b

Message body is not shown because sender requested not to inline it.

Wasn’t this addressed by 1.9758? https://metacpan.org/release/Time-HiRes
RT-Send-CC: perl5-porters [...] perl.org
On Fri, 23 Mar 2018 04:39:07 GMT, TODDR wrote: Show quoted text
> Wasn’t this addressed by 1.9758? > > https://metacpan.org/release/Time-HiRes
I hadn't seen that commit at the time I filed the bug report. (The bisection that confirmed the breakage point took so long that RL intervened and I got delayed in filing.) However, as correspondence earlier today on list indicates, we still have a big problem on our hands. Craig Berry argues that Time-HiRes 1.9758 merely puts a bandaid on the problem: https://www.nntp.perl.org/group/perl.perl5.porters/2018/03/msg250076.html Jarkko Hietaniemi acknowledges the problem, yields maintenance of Time-HiRes and recommends reversion to 1.9754: https://www.nntp.perl.org/group/perl.perl5.porters/2018/03/msg250077.html But that was the commit that broke the two CPAN distros, so we would still have to negotiate correction of the code in their tests with their maintainers. Since we still have work to do before 5.28.0 with respect to this problem, this ticket should remain open. Thank you very much. -- James E Keenan (jkeenan@cpan.org)
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 778b
On Fri, 23 Mar 2018 04:39:07 GMT, TODDR wrote: Show quoted text
> Wasn’t this addressed by 1.9758? > > https://metacpan.org/release/Time-HiRes
As of commit 3a7f897, I am still getting those test errors in both CPAN distributions. Example: ##### Building and testing Devel-TimeStats-0.04 Building Devel-TimeStats t/00_compile.t .. ok t/percentage.t .. ok # Failed test 'elapsed' # at t/unit_stats.t line 100. # got: '1521816147.59418' # expected: '14' # Looks like you failed 1 test of 13. t/unit_stats.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/13 subtests Test Summary Report ------------------- t/unit_stats.t (Wstat: 256 Tests: 13 Failed: 1) Failed test: 7 Non-zero exit status: 1 ##### Thank you very much. -- James E Keenan (jkeenan@cpan.org)
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 2.5k
On Fri, 23 Mar 2018 05:39:45 -0700, jkeenan wrote: Show quoted text
> > Jarkko Hietaniemi acknowledges the problem, yields maintenance of > Time-HiRes and recommends reversion to 1.9754: > https://www.nntp.perl.org/group/perl.perl5.porters/2018/03/msg250077.html > > But that was the commit that broke the two CPAN distros, so we would > still have to negotiate correction of the code in their tests with > their maintainers.
Yeah he later corrected his suggestion to 1.9753, which is the version we were at before I broke everything. In accordance with his request, I've reverted both of my commits which caused this problem to begin with and then bumped Maintainers.pl so it'd be clear we still need to do a release to CPAN. I also updated the Changelog documenting the decision. commit e77195360c1a2b081a806df017630b3165e2aeac Author: Todd Rinaldo <toddr@cpan.org> Date: Fri Mar 23 11:48:39 2018 -0500 Bump Time-HiRes to 1.9759 to revert changes from 1.9754..1.9758 on CPAN Tag Porting/Maintainers.pl so it is clear that a release to CPAN is outstanding. Porting/Maintainers.pl | 2 +- dist/Time-HiRes/Changes | 5 +++++ dist/Time-HiRes/HiRes.pm | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) commit 727404d09c4fded632bac12ef65a8dd03e4be6a8 Author: Todd Rinaldo <toddr@cpan.org> Date: Fri Mar 23 11:36:08 2018 -0500 Revert "Upgrade Time::HiRes from version 1.9753 to 1.9757" This reverts commit 13813507385079199d99d90776780dcd653f6919. On recommendation of the Author, we are reverting these changes for now in order to stabilize blead. Porting/Maintainers.pl | 2 +- dist/Time-HiRes/Changes | 37 --------- dist/Time-HiRes/HiRes.pm | 14 ++-- dist/Time-HiRes/HiRes.xs | 146 +++++++++++------------------------ dist/Time-HiRes/Makefile.PL | 71 ++++++++--------- dist/Time-HiRes/fallback/const-c.inc | 99 +++++++++--------------- dist/Time-HiRes/t/tv_interval.t | 69 +---------------- 7 files changed, 124 insertions(+), 314 deletions(-) commit 1eb901c28869920ed4d07aaa8a04e90e27c0b2e3 Author: Todd Rinaldo <toddr@cpan.org> Date: Fri Mar 23 11:35:45 2018 -0500 Revert "Upgrade Time::HiRes from version 1.9757 to 1.9758" This reverts commit 554c20fe6eab1dc262c2fb2d036b76fa09153f1c. Porting/Maintainers.pl | 2 +- dist/Time-HiRes/Changes | 11 +---------- dist/Time-HiRes/HiRes.pm | 2 +- dist/Time-HiRes/HiRes.xs | 8 -------- dist/Time-HiRes/t/utime.t | 21 ++------------------- 5 files changed, 5 insertions(+), 39 deletions(-) Short of releasing this to CPAN, I think we're done?
To: Craig Berry via RT <perlbug-followup [...] perl.org>
From: "Craig A. Berry" <craig.a.berry [...] gmail.com>
Date: Fri, 23 Mar 2018 14:01:52 -0500
Subject: Re: [perl #133014] [BBC]: Commit 1381350 (Time::HiRes synch with CPAN) breaks Catalyst-Runtime and others
CC: "Perl5 Porters (E-mail)" <perl5-porters [...] perl.org>
Download (untitled) / with headers
text/plain 4.6k
On Fri, Mar 23, 2018 at 11:59 AM, Todd Rinaldo via RT <perlbug-followup@perl.org> wrote: Show quoted text
> On Fri, 23 Mar 2018 05:39:45 -0700, jkeenan wrote:
>> >> Jarkko Hietaniemi acknowledges the problem, yields maintenance of >> Time-HiRes and recommends reversion to 1.9754: >> https://www.nntp.perl.org/group/perl.perl5.porters/2018/03/msg250077.html >> >> But that was the commit that broke the two CPAN distros, so we would >> still have to negotiate correction of the code in their tests with >> their maintainers.
> > Yeah he later corrected his suggestion to 1.9753, which is the version we were at before I broke everything. > > In accordance with his request, I've reverted both of my commits which caused this problem to begin with and then bumped Maintainers.pl so it'd be clear we still need to do a release to CPAN. I also updated the Changelog documenting the decision. > > commit e77195360c1a2b081a806df017630b3165e2aeac > Author: Todd Rinaldo <toddr@cpan.org> > Date: Fri Mar 23 11:48:39 2018 -0500 > > Bump Time-HiRes to 1.9759 to revert changes from 1.9754..1.9758 on CPAN > > Tag Porting/Maintainers.pl so it is clear that a release to CPAN is > outstanding. > > Porting/Maintainers.pl | 2 +- > dist/Time-HiRes/Changes | 5 +++++ > dist/Time-HiRes/HiRes.pm | 2 +- > 3 files changed, 7 insertions(+), 2 deletions(-) > > commit 727404d09c4fded632bac12ef65a8dd03e4be6a8 > Author: Todd Rinaldo <toddr@cpan.org> > Date: Fri Mar 23 11:36:08 2018 -0500 > > Revert "Upgrade Time::HiRes from version 1.9753 to 1.9757" > > This reverts commit 13813507385079199d99d90776780dcd653f6919. > > On recommendation of the Author, we are reverting these changes for > now in order to stabilize blead. > > Porting/Maintainers.pl | 2 +- > dist/Time-HiRes/Changes | 37 --------- > dist/Time-HiRes/HiRes.pm | 14 ++-- > dist/Time-HiRes/HiRes.xs | 146 +++++++++++------------------------ > dist/Time-HiRes/Makefile.PL | 71 ++++++++--------- > dist/Time-HiRes/fallback/const-c.inc | 99 +++++++++--------------- > dist/Time-HiRes/t/tv_interval.t | 69 +---------------- > 7 files changed, 124 insertions(+), 314 deletions(-) > > commit 1eb901c28869920ed4d07aaa8a04e90e27c0b2e3 > Author: Todd Rinaldo <toddr@cpan.org> > Date: Fri Mar 23 11:35:45 2018 -0500 > > Revert "Upgrade Time::HiRes from version 1.9757 to 1.9758" > > This reverts commit 554c20fe6eab1dc262c2fb2d036b76fa09153f1c. > > Porting/Maintainers.pl | 2 +- > dist/Time-HiRes/Changes | 11 +---------- > dist/Time-HiRes/HiRes.pm | 2 +- > dist/Time-HiRes/HiRes.xs | 8 -------- > dist/Time-HiRes/t/utime.t | 21 ++------------------- > 5 files changed, 5 insertions(+), 39 deletions(-) > > Short of releasing this to CPAN, I think we're done?
Rolling back for 5.28 might be ok, but there were some fixes in there for current macOS that might be necessary -- that needs testing. In any case the compile failure related to the timezone struct that I complained about being fixed on Windows only can be addressed more generally by the following patch, inline and attached. From dfbb2d9bc7c2d1d678db0078f17a6e9a521122e8 Mon Sep 17 00:00:00 2001 From: "Craig A. Berry" <craigberry@mac.com> Date: Fri, 23 Mar 2018 13:48:42 -0500 Subject: [PATCH] Make Time::HiRes check for timezone struct in sys/time.h. Rather than platform-specific workarounds. This is actually pretty easy to do since Time::HiRes has great infrastructure for testing local compiler/header capabilities. --- dist/Time-HiRes/HiRes.xs | 2 +- dist/Time-HiRes/Makefile.PL | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/dist/Time-HiRes/HiRes.xs b/dist/Time-HiRes/HiRes.xs index 39ac3fd8f0..f91fc2f4b1 100644 --- a/dist/Time-HiRes/HiRes.xs +++ b/dist/Time-HiRes/HiRes.xs @@ -40,7 +40,7 @@ extern "C" { } #endif -#ifdef _MSC_VER /* For Visual C */ +#ifndef TIME_HIRES_SYS_TIME_HAS_TIMEZONE struct timezone { int tz_minuteswest; /* of Greenwich */ diff --git a/dist/Time-HiRes/Makefile.PL b/dist/Time-HiRes/Makefile.PL index 8036fbf5cb..17c69eb14c 100644 --- a/dist/Time-HiRes/Makefile.PL +++ b/dist/Time-HiRes/Makefile.PL @@ -880,6 +880,26 @@ EOM } } + print "Trying struct timezone from sys/time.h ..."; + my $sys_time_has_timezone = 0; + if (try_compile_and_link(<<EOM)) { +#include <sys/time.h> + +int main(int argc, char** argv) +{ + struct timezone Tz; +} +EOM + $sys_time_has_timezone++; + DEFINE('TIME_HIRES_SYS_TIME_HAS_TIMEZONE'); #6 + } + + if ($sys_time_has_timezone) { + print "found.\n"; + } else { + print "NOT found.\n"; + } + if ($DEFINE) { $DEFINE =~ s/^\s+//; if (open(XDEFINE, '>', 'xdefine')) { -- 2.14.3 (Apple Git-98)

Message body is not shown because sender requested not to inline it.

To: perl5-porters [...] perl.org
From: Zefram <zefram [...] fysh.org>
Date: Fri, 23 Mar 2018 19:03:55 +0000
Subject: Re: [perl #133014] [BBC]: Commit 1381350 (Time::HiRes synch with CPAN) breaks Catalyst-Runtime and others
Download (untitled) / with headers
text/plain 406b
James E Keenan wrote: Show quoted text
>One such release to CPAN has broken some code in CPAN distributions >Catalyst-Runtime and Devel-TimeStats.
The tests that got broken are at fault, and need to switch to a more robust way of mocking Time::HiRes. It's not difficult: they just need to monkey-patch tv_interval() alongside gettimeofday(). There's no cause for us to revert the XSification of tv_interval(). -zefram
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 164b
Since the last non-core maintainer of this module has stepped down, shouldn't something like this attachment be applied, so no-one would report more bug to CPAN rt?
Subject: 0001-Update-rt-path-for-Time-HiRes.patch
From 35f8345d918e73c070d463c85395a1531b0d8219 Mon Sep 17 00:00:00 2001 From: Sergey Aleynikov <sergey.aleynikov@gmail.com> Date: Mon, 26 Mar 2018 01:49:46 +0300 Subject: [PATCH] Update rt path for Time::HiRes --- dist/Time-HiRes/Makefile.PL | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/dist/Time-HiRes/Makefile.PL b/dist/Time-HiRes/Makefile.PL index e0f7dd9a2f..7b812edc60 100644 --- a/dist/Time-HiRes/Makefile.PL +++ b/dist/Time-HiRes/Makefile.PL @@ -961,6 +961,16 @@ sub doMakefile { push @makefileopts, (LICENSE => 'perl_5'); } + if ($ExtUtils::MakeMaker::VERSION >= 6.46) { + push @makefileopts, ( + resources => { + repository => 'git://perl5.git.perl.org/perl.git', + bugtracker => 'https://rt.perl.org/rt3/', + homepage => "http://dev.perl.org/", + }, + ) + } + WriteMakefile(@makefileopts); } -- 2.14.2
To: perl5-porters [...] perl.org
Subject: Re: [perl #133014] [BBC]: Commit 1381350 (Time::HiRes synch with CPAN) breaks Catalyst-Runtime and others
Date: Mon, 26 Mar 2018 11:49:46 +0300
From: Sawyer X <xsawyerx [...] gmail.com>
Download (untitled) / with headers
text/plain 228b
On 03/26/2018 02:06 AM, Sergey Aleynikov via RT wrote: Show quoted text
> Since the last non-core maintainer of this module has stepped down, shouldn't something like this attachment be applied, so no-one would report more bug to CPAN rt?
+1
To: Sergey Aleynikov via RT <perlbug-followup [...] perl.org>
From: Dave Mitchell <davem [...] iabyn.com>
CC: perl5-porters [...] perl.org
Subject: Re: [perl #133014] [BBC]: Commit 1381350 (Time::HiRes synch with CPAN) breaks Catalyst-Runtime and others
Date: Fri, 20 Apr 2018 11:34:22 +0100
Download (untitled) / with headers
text/plain 1.7k
On Sun, Mar 25, 2018 at 04:06:33PM -0700, Sergey Aleynikov via RT wrote: Show quoted text
> Since the last non-core maintainer of this module has stepped down, shouldn't something like this attachment be applied, so no-one would report more bug to CPAN rt? > > --- > via perlbug: queue: perl5 status: open > https://rt.perl.org/Ticket/Display.html?id=133014
Show quoted text
> >From 35f8345d918e73c070d463c85395a1531b0d8219 Mon Sep 17 00:00:00 2001
> From: Sergey Aleynikov <sergey.aleynikov@gmail.com> > Date: Mon, 26 Mar 2018 01:49:46 +0300 > Subject: [PATCH] Update rt path for Time::HiRes > > --- > dist/Time-HiRes/Makefile.PL | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/dist/Time-HiRes/Makefile.PL b/dist/Time-HiRes/Makefile.PL > index e0f7dd9a2f..7b812edc60 100644 > --- a/dist/Time-HiRes/Makefile.PL > +++ b/dist/Time-HiRes/Makefile.PL > @@ -961,6 +961,16 @@ sub doMakefile { > push @makefileopts, (LICENSE => 'perl_5'); > } > > + if ($ExtUtils::MakeMaker::VERSION >= 6.46) { > + push @makefileopts, ( > + resources => { > + repository => 'git://perl5.git.perl.org/perl.git', > + bugtracker => 'https://rt.perl.org/rt3/', > + homepage => "http://dev.perl.org/", > + }, > + ) > + } > + > WriteMakefile(@makefileopts); > }
This sounds like a good idea, but I don't feel I'm in a position to judge whether all the details are correct. Should we consider applying this or similar as a 5.28 blocker? Otherwise I don't think there's anything else left in this ticket that justifies keeping it as a blocker. -- The warp engines start playing up a bit, but seem to sort themselves out after a while without any intervention from boy genius Wesley Crusher. -- Things That Never Happen in "Star Trek" #17
From: Sawyer X <xsawyerx [...] gmail.com>
Subject: Re: [perl #133014] [BBC]: Commit 1381350 (Time::HiRes synch with CPAN) breaks Catalyst-Runtime and others
CC: perl5-porters [...] perl.org
To: Dave Mitchell <davem [...] iabyn.com>, Sergey Aleynikov via RT <perlbug-followup [...] perl.org>
Date: Fri, 20 Apr 2018 13:10:06 +0200
Download (untitled) / with headers
text/plain 1.7k
On 04/20/2018 12:34 PM, Dave Mitchell wrote: Show quoted text
> On Sun, Mar 25, 2018 at 04:06:33PM -0700, Sergey Aleynikov via RT wrote:
>> Since the last non-core maintainer of this module has stepped down, shouldn't something like this attachment be applied, so no-one would report more bug to CPAN rt? >> >> --- >> via perlbug: queue: perl5 status: open >> https://rt.perl.org/Ticket/Display.html?id=133014
>> >From 35f8345d918e73c070d463c85395a1531b0d8219 Mon Sep 17 00:00:00 2001
>> From: Sergey Aleynikov <sergey.aleynikov@gmail.com> >> Date: Mon, 26 Mar 2018 01:49:46 +0300 >> Subject: [PATCH] Update rt path for Time::HiRes >> >> --- >> dist/Time-HiRes/Makefile.PL | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/dist/Time-HiRes/Makefile.PL b/dist/Time-HiRes/Makefile.PL >> index e0f7dd9a2f..7b812edc60 100644 >> --- a/dist/Time-HiRes/Makefile.PL >> +++ b/dist/Time-HiRes/Makefile.PL >> @@ -961,6 +961,16 @@ sub doMakefile { >> push @makefileopts, (LICENSE => 'perl_5'); >> } >> >> + if ($ExtUtils::MakeMaker::VERSION >= 6.46) { >> + push @makefileopts, ( >> + resources => { >> + repository => 'git://perl5.git.perl.org/perl.git', >> + bugtracker => 'https://rt.perl.org/rt3/', >> + homepage => "http://dev.perl.org/", >> + }, >> + ) >> + } >> + >> WriteMakefile(@makefileopts); >> }
> This sounds like a good idea, but I don't feel I'm in a position to judge > whether all the details are correct.
I think this is correct. Show quoted text
> Should we consider applying this or similar as a 5.28 blocker?
This is metadata. It shouldn't block 5.28. Show quoted text
> Otherwise I don't think there's anything else left in this ticket that > justifies keeping it as a blocker.
Agreed.
To: perlbug-followup [...] perl.org
Subject: Re: [perl #133014] [BBC]: Commit 1381350 (Time::HiRes synch with CPAN) breaks Catalyst-Runtime and others
CC: Perl5 Porters <perl5-porters [...] perl.org>
From: Graham Knop <haarg [...] haarg.org>
Date: Fri, 20 Apr 2018 15:22:07 +0200
Download (untitled) / with headers
text/plain 1.5k
On Mon, Mar 26, 2018 at 1:06 AM, Sergey Aleynikov via RT <perlbug-followup@perl.org> wrote: Show quoted text
> Since the last non-core maintainer of this module has stepped down, shouldn't something like this attachment be applied, so no-one would report more bug to CPAN rt? > > --- > via perlbug: queue: perl5 status: open > https://rt.perl.org/Ticket/Display.html?id=133014 > > From 35f8345d918e73c070d463c85395a1531b0d8219 Mon Sep 17 00:00:00 2001 > From: Sergey Aleynikov <sergey.aleynikov@gmail.com> > Date: Mon, 26 Mar 2018 01:49:46 +0300 > Subject: [PATCH] Update rt path for Time::HiRes > > --- > dist/Time-HiRes/Makefile.PL | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/dist/Time-HiRes/Makefile.PL b/dist/Time-HiRes/Makefile.PL > index e0f7dd9a2f..7b812edc60 100644 > --- a/dist/Time-HiRes/Makefile.PL > +++ b/dist/Time-HiRes/Makefile.PL > @@ -961,6 +961,16 @@ sub doMakefile { > push @makefileopts, (LICENSE => 'perl_5'); > } > > + if ($ExtUtils::MakeMaker::VERSION >= 6.46) { > + push @makefileopts, ( > + resources => { > + repository => 'git://perl5.git.perl.org/perl.git', > + bugtracker => 'https://rt.perl.org/rt3/', > + homepage => "http://dev.perl.org/", > + }, > + ) > + } > + > WriteMakefile(@makefileopts); > } > > -- > 2.14.2 > >
The resources section needs to be in a META_ADD or META_MERGE section, not directly in the WriteMakefile arguments. Attached is a patch that should do that. Also, I have fixed the Catalyst-Runtime test failure in git, and should be putting out a release next week.
Date: Fri, 20 Apr 2018 22:51:36 +0200
From: Graham Knop <haarg [...] haarg.org>
Subject: Re: [perl #133014] [BBC]: Commit 1381350 (Time::HiRes synch with CPAN) breaks Catalyst-Runtime and others
CC: Perl5 Porters <perl5-porters [...] perl.org>
To: perlbug-followup [...] perl.org
Download (untitled) / with headers
text/plain 1.7k
On Fri, Apr 20, 2018 at 3:22 PM, Graham Knop <haarg@haarg.org> wrote: Show quoted text
> On Mon, Mar 26, 2018 at 1:06 AM, Sergey Aleynikov via RT > <perlbug-followup@perl.org> wrote:
>> Since the last non-core maintainer of this module has stepped down, shouldn't something like this attachment be applied, so no-one would report more bug to CPAN rt? >> >> --- >> via perlbug: queue: perl5 status: open >> https://rt.perl.org/Ticket/Display.html?id=133014 >> >> From 35f8345d918e73c070d463c85395a1531b0d8219 Mon Sep 17 00:00:00 2001 >> From: Sergey Aleynikov <sergey.aleynikov@gmail.com> >> Date: Mon, 26 Mar 2018 01:49:46 +0300 >> Subject: [PATCH] Update rt path for Time::HiRes >> >> --- >> dist/Time-HiRes/Makefile.PL | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/dist/Time-HiRes/Makefile.PL b/dist/Time-HiRes/Makefile.PL >> index e0f7dd9a2f..7b812edc60 100644 >> --- a/dist/Time-HiRes/Makefile.PL >> +++ b/dist/Time-HiRes/Makefile.PL >> @@ -961,6 +961,16 @@ sub doMakefile { >> push @makefileopts, (LICENSE => 'perl_5'); >> } >> >> + if ($ExtUtils::MakeMaker::VERSION >= 6.46) { >> + push @makefileopts, ( >> + resources => { >> + repository => 'git://perl5.git.perl.org/perl.git', >> + bugtracker => 'https://rt.perl.org/rt3/', >> + homepage => "http://dev.perl.org/", >> + }, >> + ) >> + } >> + >> WriteMakefile(@makefileopts); >> } >> >> -- >> 2.14.2 >> >>
> > The resources section needs to be in a META_ADD or META_MERGE section, > not directly in the WriteMakefile arguments. Attached is a patch that > should do that. > > > Also, I have fixed the Catalyst-Runtime test failure in git, and > should be putting out a release next week.
And apparently I didn't attach the patch.

Message body is not shown because sender requested not to inline it.

From: Sawyer X <xsawyerx [...] gmail.com>
CC: Perl5 Porters <perl5-porters [...] perl.org>
Subject: Re: [perl #133014] [BBC]: Commit 1381350 (Time::HiRes synch with CPAN) breaks Catalyst-Runtime and others
To: Graham Knop <haarg [...] haarg.org>, perlbug-followup [...] perl.org
Date: Sat, 21 Apr 2018 10:22:42 +0200
Download (untitled) / with headers
text/plain 1.8k
On 04/20/2018 10:51 PM, Graham Knop wrote: Show quoted text
> On Fri, Apr 20, 2018 at 3:22 PM, Graham Knop <haarg@haarg.org> wrote:
>> On Mon, Mar 26, 2018 at 1:06 AM, Sergey Aleynikov via RT >> <perlbug-followup@perl.org> wrote:
>>> Since the last non-core maintainer of this module has stepped down, shouldn't something like this attachment be applied, so no-one would report more bug to CPAN rt? >>> >>> --- >>> via perlbug: queue: perl5 status: open >>> https://rt.perl.org/Ticket/Display.html?id=133014 >>> >>> From 35f8345d918e73c070d463c85395a1531b0d8219 Mon Sep 17 00:00:00 2001 >>> From: Sergey Aleynikov <sergey.aleynikov@gmail.com> >>> Date: Mon, 26 Mar 2018 01:49:46 +0300 >>> Subject: [PATCH] Update rt path for Time::HiRes >>> >>> --- >>> dist/Time-HiRes/Makefile.PL | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/dist/Time-HiRes/Makefile.PL b/dist/Time-HiRes/Makefile.PL >>> index e0f7dd9a2f..7b812edc60 100644 >>> --- a/dist/Time-HiRes/Makefile.PL >>> +++ b/dist/Time-HiRes/Makefile.PL >>> @@ -961,6 +961,16 @@ sub doMakefile { >>> push @makefileopts, (LICENSE => 'perl_5'); >>> } >>> >>> + if ($ExtUtils::MakeMaker::VERSION >= 6.46) { >>> + push @makefileopts, ( >>> + resources => { >>> + repository => 'git://perl5.git.perl.org/perl.git', >>> + bugtracker => 'https://rt.perl.org/rt3/', >>> + homepage => "http://dev.perl.org/", >>> + }, >>> + ) >>> + } >>> + >>> WriteMakefile(@makefileopts); >>> } >>> >>> -- >>> 2.14.2 >>> >>>
>> The resources section needs to be in a META_ADD or META_MERGE section, >> not directly in the WriteMakefile arguments. Attached is a patch that >> should do that. >> >> >> Also, I have fixed the Catalyst-Runtime test failure in git, and >> should be putting out a release next week.
> And apparently I didn't attach the patch.
+1 to the patch.
Date: Mon, 23 Apr 2018 13:43:23 +0100
To: Sawyer X <xsawyerx [...] gmail.com>
From: Dave Mitchell <davem [...] iabyn.com>
CC: Graham Knop <haarg [...] haarg.org>, perlbug-followup [...] perl.org, Perl5 Porters <perl5-porters [...] perl.org>
Subject: Re: [perl #133014] [BBC]: Commit 1381350 (Time::HiRes synch with CPAN) breaks Catalyst-Runtime and others
Download (untitled) / with headers
text/plain 638b
On Sat, Apr 21, 2018 at 10:22:42AM +0200, Sawyer X wrote: Show quoted text
> >> The resources section needs to be in a META_ADD or META_MERGE section, > >> not directly in the WriteMakefile arguments. Attached is a patch that > >> should do that. > >> > >> > >> Also, I have fixed the Catalyst-Runtime test failure in git, and > >> should be putting out a release next week.
> > And apparently I didn't attach the patch.
> > +1 to the patch.
Do want this applying for 5.28, or shall I remove this ticket from the 5.28 blockers? -- Counsellor Troi states something other than the blindingly obvious. -- Things That Never Happen in "Star Trek" #16
Date: Mon, 23 Apr 2018 16:53:55 +0200
To: Dave Mitchell <davem [...] iabyn.com>
CC: Graham Knop <haarg [...] haarg.org>, perlbug-followup [...] perl.org, Perl5 Porters <perl5-porters [...] perl.org>
Subject: Re: [perl #133014] [BBC]: Commit 1381350 (Time::HiRes synch with CPAN) breaks Catalyst-Runtime and others
From: Sawyer X <xsawyerx [...] gmail.com>
Download (untitled) / with headers
text/plain 690b
On 04/23/2018 02:43 PM, Dave Mitchell wrote: Show quoted text
> On Sat, Apr 21, 2018 at 10:22:42AM +0200, Sawyer X wrote:
>>>> The resources section needs to be in a META_ADD or META_MERGE section, >>>> not directly in the WriteMakefile arguments. Attached is a patch that >>>> should do that. >>>> >>>> >>>> Also, I have fixed the Catalyst-Runtime test failure in git, and >>>> should be putting out a release next week.
>>> And apparently I didn't attach the patch.
>> +1 to the patch.
> Do want this applying for 5.28, or shall I remove this ticket from the > 5.28 blockers?
This patch should not be blocking 5.28. I also don't think it should be applied at this moment but I'm open for objections.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org