Skip Menu |
Report information
Id: 133010
Status: resolved
Priority: 0/
Queue: perl5

Owner: Nobody
Requestors: jkeenan [at] pobox.com
Cc:
AdminCc:

Operating System: (no value)
PatchStatus: (no value)
Severity: low
Type: unknown
Perl Version: (no value)
Fixed In: (no value)



Date: Wed, 21 Mar 2018 17:27:17 -0400
From: James E Keenan <jkeenan [...] pobox.com>
Subject: [BBC]: Commit 0740a29 breaks Devel::NYTProf
To: perlbug [...] perl.org
Download (untitled) / with headers
text/plain 1.3k
It has been reported that commit 0740a29d60ebd4ff72090340b0140ec2210e90c7 broke Devel::NYTProf. (I'm currently bisecting to double-confirm the breaking point.) ##### CommitDate: Tue Dec 5 01:21:35 2017 stop using &PL_sv_yes as no-op method Method lookup yields a fake method for ->import or ->unimport if there's actual method, for historical reasons so that "use" doesn't barf if there's no import method. This fake method used to be &PL_sv_yes being used as a magic placeholder, recognised specially by pp_entersub. But &PL_sv_yes is a string, which we'd expect to serve as a symbolic CV ref. Change method lookup to yield an actual CV with a body in this case, and remove the special case from pp_entersub. This fixes the remaining part of [perl #126042]. ##### This was reported by Zefram in https://rt.cpan.org/Ticket/Display.html?id=123846 and receipt acknowledged by author Tim Bunce. A report was subsequently filed by simcop2387 in the module's preferred bug tracker at https://github.com/timbunce/devel-nytprof/issues/113 and confirmed in that issue by me for perl-5.27.9 on Feb 21. In order to show both the warnings and the test failures I'm attaching another recent attempt to build that module. (The perl_V.txt is recent but not from that same attempt; it's just to make RT happier.) Thank you very much. Jim Keenan

Message body is not shown because sender requested not to inline it.

Download perl_V.txt
text/plain 3k

Message body is not shown because sender requested not to inline it.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 375b
On Wed, 21 Mar 2018 21:28:04 GMT, jkeenan@pobox.com wrote: Show quoted text
> It has been reported that commit > 0740a29d60ebd4ff72090340b0140ec2210e90c7 broke Devel::NYTProf. (I'm > currently bisecting to double-confirm the breaking point.) >
Breakage point confirmed by bisection: 0740a29d60ebd4ff72090340b0140ec2210e90c7 is the first bad commit -- James E Keenan (jkeenan@cpan.org)
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 464b
On Thu, 22 Mar 2018 02:49:54 GMT, jkeenan wrote: Show quoted text
> On Wed, 21 Mar 2018 21:28:04 GMT, jkeenan@pobox.com wrote:
> > It has been reported that commit > > 0740a29d60ebd4ff72090340b0140ec2210e90c7 broke Devel::NYTProf. (I'm > > currently bisecting to double-confirm the breaking point.) > >
> > Breakage point confirmed by bisection: > 0740a29d60ebd4ff72090340b0140ec2210e90c7 is the first bad commit >
TIMB is on the case! -- James E Keenan (jkeenan@cpan.org)
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 1.1k
On Fri, 23 Mar 2018 21:34:49 GMT, jkeenan wrote: Show quoted text
> On Thu, 22 Mar 2018 02:49:54 GMT, jkeenan wrote:
> > On Wed, 21 Mar 2018 21:28:04 GMT, jkeenan@pobox.com wrote:
> > > It has been reported that commit > > > 0740a29d60ebd4ff72090340b0140ec2210e90c7 broke Devel::NYTProf. (I'm > > > currently bisecting to double-confirm the breaking point.) > > >
> > > > Breakage point confirmed by bisection: > > 0740a29d60ebd4ff72090340b0140ec2210e90c7 is the first bad commit > >
> > TIMB is on the case!
Confirmation of the correction uploaded to CPAN overnight: ##### $ ./bin/perl -v | head -2 | tail -1 This is perl 5, version 27, subversion 11 (v5.27.11 (v5.27.10-19-ge771953)) built for x86_64-linux-thread-multi $ ./bin/cpanm Devel::NYTProf ... Building and testing Algorithm-Diff-1.1903 ... OK Successfully installed Algorithm-Diff-1.1903 Building and testing Text-Diff-1.45 ... OK Successfully installed Text-Diff-1.45 Building and testing Test-Differences-0.64 ... OK Successfully installed Test-Differences-0.64 Building and testing Devel-NYTProf-6.05 ... OK Successfully installed Devel-NYTProf-6.05 4 distributions installed ##### Thank you very much. -- James E Keenan (jkeenan@cpan.org)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org