Skip Menu |
Report information
Id: 132967
Status: rejected
Priority: 0/
Queue: perl5

Owner: Nobody
Requestors: pali [at] cpan.org
Cc:
AdminCc:

Operating System: (no value)
PatchStatus: (no value)
Severity: low
Type: unknown
Perl Version: (no value)
Fixed In: (no value)

Attachments
0001-Encode-Remove-XS-functions-_bytes_to_utf8-and-_utf8_.patch



To: perlbug [...] perl.org
Subject: [PATCH] Encode: Remove XS functions _bytes_to_utf8() and _utf8_to_bytes()
From: pali [...] cpan.org
Date: Mon, 12 Mar 2018 20:53:44 +0100
Download (untitled) / with headers
text/plain 432b
Those two functions are totally undocumented, not fully implemented, they croak on some usage with "panic_unimplemented" error. They are not used by any module on CPAN. Therefore it is good candidate for removal. As Encode is a Perl Core module, I'm sending this patch to the Perl RT tracker. If you would agree with this change for a Core module, I can then create a official pull request to the maintainer of CPAN Encode module.

Message body is not shown because sender requested not to inline it.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 559b
On Mon, 12 Mar 2018 12:53:54 -0700, pali@cpan.org wrote: Show quoted text
> Those two functions are totally undocumented, not fully implemented, they > croak on some usage with "panic_unimplemented" error. They are not used by > any module on CPAN. Therefore it is good candidate for removal. > > As Encode is a Perl Core module, I'm sending this patch to the Perl RT > tracker. If you would agree with this change for a Core module, I can then > create a official pull request to the maintainer of CPAN Encode module.
I see no reason to keep these stubs -- Karl Williamson
To: perlbug-followup [...] perl.org
From: pali [...] cpan.org
Date: Wed, 14 Mar 2018 21:50:11 +0100
Subject: Re: [perl #132967] [PATCH] Encode: Remove XS functions _bytes_to_utf8() and _utf8_to_bytes()
Download (untitled) / with headers
text/plain 212b
On Wednesday 14 March 2018 09:31:16 Karl Williamson via RT wrote: Show quoted text
> I see no reason to keep these stubs
Ok, I created pull request to the Encode upstream project: https://github.com/dankogai/p5-encode/pull/133
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 123b
Since, this entirely an upstream Encode issue, and a ticket has been opened there, I'm closing this one -- Karl Williamson


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org