Skip Menu |
Report information
Id: 132533
Status: resolved
Priority: 0/
Queue: perl5

Owner: Nobody
Requestors: pali [at] cpan.org
Cc:
AdminCc:

Operating System: (no value)
PatchStatus: (no value)
Severity: low
Type:
Perl Version: (no value)
Fixed In: (no value)

Attachments
0001-Implement-mess.patch
0002-Use-croak_sv-in-threads.patch
0003-Fix-security-problem-CWE-134-Use-of-Externally-Contr.patch
0004-Fix-test-warning-Use-of-uninitialized-value.patch
v2-0001-Implement-mess.patch
v2-0002-Use-croak_sv-in-threads.patch
v2-0003-Fix-security-problem-CWE-134-Use-of-Externally-Contr.patch
v2-0004-Fix-test-warning-Use-of-uninitialized-value.patch



From: pali [...] cpan.org
Subject: [PATCH] Devel::PPPort: Implement croak_sv, die_sv, mess_sv, warn_sv and other mess function
To: perlbug [...] perl.org
Date: Sun, 3 Dec 2017 19:11:27 +0100
Download (untitled) / with headers
text/plain 398b
Attached patches implements more mess functions for Devel::PPPort. For example croak_sv() is useful for throwing object exceptions from XS code or for providing Unicode error message. 3rd patch fixes security related problem in eval_pv implementation. Patches contains also tests for checking that implementation is working correctly. I tested patches with different Perl versions 5.5 - 5.26.

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

From: pali [...] cpan.org
Subject: Re: [perl #132533] [PATCH] Devel::PPPort: Implement croak_sv, die_sv, mess_sv, warn_sv and other mess function
Date: Tue, 2 Jan 2018 12:55:28 +0100
To: perlbug-followup [...] perl.org
Hi! Can somebody look and review these patches?
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 157b
On Tue, 02 Jan 2018 03:55:57 -0800, pali@cpan.org wrote: Show quoted text
> Hi! Can somebody look and review these patches?
Please supply them as patches against perl. Tony
To: perlbug-followup [...] perl.org
Subject: Re: [perl #132533] [PATCH] Devel::PPPort: Implement croak_sv, die_sv, mess_sv, warn_sv and other mess function
Date: Mon, 15 Jan 2018 09:30:33 +0100
From: pali [...] cpan.org
Download (untitled) / with headers
text/plain 261b
On Sunday 14 January 2018 19:58:52 Tony Cook via RT wrote: Show quoted text
> On Tue, 02 Jan 2018 03:55:57 -0800, pali@cpan.org wrote:
> > Hi! Can somebody look and review these patches?
> > Please supply them as patches against perl.
Rebased on top of blead. See attachment.

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 666b
On Mon, 15 Jan 2018 00:31:28 -0800, pali@cpan.org wrote: Show quoted text
> On Sunday 14 January 2018 19:58:52 Tony Cook via RT wrote:
> > On Tue, 02 Jan 2018 03:55:57 -0800, pali@cpan.org wrote:
> > > Hi! Can somebody look and review these patches?
> > > > Please supply them as patches against perl.
> > Rebased on top of blead. See attachment.
Thanks, applied as f87c37b1822dc27ee027ad18a8de36d3ae1999da (which I added a missing MANIFEST update to), 051475ba96b05e8ea21b4fdea8bd58b2644b4d2d, 7ceac2e89b40347b95855c622b9f8f31bd6560f4 and a70a2aeb86bc82dbf40f06ed530a9bbc38916e0f. I regenerated the tests in 6ac0580f186dac6deaf07dbe98b58392fd0a91f7 and bumped the version. Tony
Download (untitled) / with headers
text/plain 317b
Thank you for filing this report. You have helped make Perl better. With the release yesterday of Perl 5.28.0, this and 185 other issues have been resolved. Perl 5.28.0 may be downloaded via: https://metacpan.org/release/XSAWYERX/perl-5.28.0 If you find that the problem persists, feel free to reopen this ticket.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org