Skip Menu |
Report information
Id: 132328
Status: new
Priority: 0/
Queue: perl6

Owner: Nobody
Requestors: alex.jakimenko [at] gmail.com
Cc:
AdminCc:

Severity: (no value)
Tag: testneeded
Platform: (no value)
Patch Status: (no value)
VM: (no value)



Subject: [SEGV][REGRESSION] DBIish tests are failing spectacularly (JIT compilation of native calls)
Download (untitled) / with headers
text/plain 876b
Moar bisected to https://github.com/MoarVM/MoarVM/commit/4eadf94599cc021ec7a9e0e49e198f5861468dc1

On 2017-10-20 07:23:04, alex.jakimenko@gmail.com wrote:
Show quoted text
> DBIish tests started to fail (with segv) after this rakudo commit:
> https://github.com/rakudo/rakudo/commit/ff063e7b53ab41b79279ffc38e1740d3db2eae7d
>
> The bump itself brought these MoarVM changes:
> https://github.com/MoarVM/MoarVM/compare/2017.09.1-602-
> g676723d...2017.09.1-608-ge051ee3
>
>
> Committable output before and after:
> command: commit: ff063e7b53^,ff063e7b53
> https://gist.githubusercontent.com/AlexDaniel/13a57dbb993d624c877befc137c33ee6/raw/a575bf2e04e24ced60b35665a4ec5a3324369c47/dbiish.p6
> output: https://gist.github.com/e25c6a14d6078e99f6bb46de494565b1
>
> Not surprisingly there's no crash with MVM_JIT_DISABLE:
> command: commit: MVM_JIT_DISABLE=1 ff063e7b53^,ff063e7b53
> https://gist.githubusercontent.com/AlexDaniel/13a57dbb993d624c877befc137c33ee6/raw/a575bf2e04e24ced60b35665a4ec5a3324369c47/dbiish.p6
> output: https://gist.github.com/24319e448313c13c16d8b67d7961accb


Offending commit reverted in https://github.com/MoarVM/MoarVM/commit/1a9be0ad487bc6e2d21df54c6a12892e3f9c8259

I tested it with moar HEAD and indeed the issue is no longer there. So it should work fine after moar and nqp bumps.

「testneeded」 ?

On 2017-10-20 07:53:23, alex.jakimenko@gmail.com wrote:
Show quoted text
> Moar bisected to
> https://github.com/MoarVM/MoarVM/commit/4eadf94599cc021ec7a9e0e49e198f5861468dc1
>
> On 2017-10-20 07:23:04, alex.jakimenko@gmail.com wrote:
> > DBIish tests started to fail (with segv) after this rakudo commit:
> >
> https://github.com/rakudo/rakudo/commit/ff063e7b53ab41b79279ffc38e1740d3db2eae7d
> >
> > The bump itself brought these MoarVM changes:
> > https://github.com/MoarVM/MoarVM/compare/2017.09.1-602-
> > g676723d...2017.09.1-608-ge051ee3
> >
> >
> > Committable output before and after:
> > command: commit: ff063e7b53^,ff063e7b53
> >
> https://gist.githubusercontent.com/AlexDaniel/13a57dbb993d624c877befc137c33ee6/raw/a575bf2e04e24ced60b35665a4ec5a3324369c47/dbiish.p6
> > output: https://gist.github.com/e25c6a14d6078e99f6bb46de494565b1
> >
> > Not surprisingly there's no crash with MVM_JIT_DISABLE:
> > command: commit: MVM_JIT_DISABLE=1 ff063e7b53^,ff063e7b53
> >
> https://gist.githubusercontent.com/AlexDaniel/13a57dbb993d624c877befc137c33ee6/raw/a575bf2e04e24ced60b35665a4ec5a3324369c47/dbiish.p6


Honestly, I have no idea how to test this… maybe someone should attempt to golf it, but given that the commit description is “JIT compile native calls”, I guess it'd be a bit complicated.

… I'm fine with just delegating it to the DBIish test suite…

On 2017-10-20 08:12:41, alex.jakimenko@gmail.com wrote:
Show quoted text
> Offending commit reverted in
> https://github.com/MoarVM/MoarVM/commit/1a9be0ad487bc6e2d21df54c6a12892e3f9c8259
>
> I tested it with moar HEAD and indeed the issue is no longer there. So
> it
> should work fine after moar and nqp bumps.
>
> 「testneeded」 ?
>
> On 2017-10-20 07:53:23, alex.jakimenko@gmail.com wrote:
> > Moar bisected to
> >
> https://github.com/MoarVM/MoarVM/commit/4eadf94599cc021ec7a9e0e49e198f5861468dc1
> >
> > On 2017-10-20 07:23:04, alex.jakimenko@gmail.com wrote:
> > > DBIish tests started to fail (with segv) after this rakudo commit:
> > >
> >
> https://github.com/rakudo/rakudo/commit/ff063e7b53ab41b79279ffc38e1740d3db2eae7d
> > >
> > > The bump itself brought these MoarVM changes:
> > > https://github.com/MoarVM/MoarVM/compare/2017.09.1-602-
> > > g676723d...2017.09.1-608-ge051ee3
> > >
> > >
> > > Committable output before and after:
> > > command: commit: ff063e7b53^,ff063e7b53
> > >
> >
> https://gist.githubusercontent.com/AlexDaniel/13a57dbb993d624c877befc137c33ee6/raw/a575bf2e04e24ced60b35665a4ec5a3324369c47/dbiish.p6
> > > output: https://gist.github.com/e25c6a14d6078e99f6bb46de494565b1
> > >
> > > Not surprisingly there's no crash with MVM_JIT_DISABLE:
> > > command: commit: MVM_JIT_DISABLE=1 ff063e7b53^,ff063e7b53
> > >
> >
> https://gist.githubusercontent.com/AlexDaniel/13a57dbb993d624c877befc137c33ee6/raw/a575bf2e04e24ced60b35665a4ec5a3324369c47/dbiish.p6




This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org