Skip Menu |
Report information
Id: 132298
Status: pending release
Priority: 0/
Queue: perl5

Owner: dom <dom [at] earth.li>
Requestors: todd [at] rinaldo.us
TODDR <toddr [at] cpan.org>
Cc:
AdminCc:

Operating System: (no value)
PatchStatus: (no value)
Severity: low
Type: core
Perl Version: 5.26.0
Fixed In: (no value)

Attachments
0001-Provide-a-mechanism-for-distros-to-disable-tests-tha.patch
0001-Skip-various-tests-if-PERL_BUILD_PACKAGING-is-set.patch



Date: Sat, 14 Oct 2017 14:39:55 +0200
Subject: Provide a way for distro maintainers to skip t/porting/customized.t
From: Todd Rinaldo <todd [...] rinaldo.us>
To: perlbug [...] perl.org
This is a bug report for perl from toddr@cpan.org, generated with the help of perlbug 1.40 running under perl 5.26.0. ----------------------------------------------------------------- [Please describe your issue here] Distro maintainers often need to customize files in cpan/. We need a way to easily disable this test. [Please do not change anything below this line] ----------------------------------------------------------------- --- Flags: category=core severity=low --- Site configuration information for perl 5.26.0: Configured by cPanel at Fri Sep 22 11:09:22 CDT 2017. Summary of my perl5 (revision 5 version 26 subversion 0) configuration: Platform: osname=linux osvers=3.10.0-123.20.1.el7.x86_64 archname=x86_64-linux-64int uname='linux rpmbuild-64-centos-7.dev.cpanel.net 3.10.0-123.20.1.el7.x86_64 #1 smp thu jan 29 18:05:33 utc 2015 x86_64 x86_64 x86_64 gnulinux ' config_args='-des -Dusedevel -Darchname=x86_64-linux-64int -Dcc=/usr/bin/gcc -Dcpp=/usr/bin/cpp -Dusemymalloc=n -DDEBUGGING=none -Doptimize=-Os -Accflags=-m64 -Dccflags=-DPERL_DISABLE_PMC -fPIC -DPIC -I/usr/local/cpanel/3rdparty/perl/526/include -I/usr/local/cpanel/3rdparty/include -L/usr/local/cpanel/3rdparty/lib64 -Duseshrplib -Duselargefiles=yes -Duseposix=true -Dhint=recommended -Duseperlio=yes -Dcppflags=-I/usr/local/cpanel/3rdparty/perl/526/include -I/usr/local/cpanel/3rdparty/include -L/usr/local/cpanel/3rdparty/lib64 -Dldflags=-L/usr/local/cpanel/3rdparty/lib64 -Dprefix=/usr/local/cpanel/3rdparty/perl/526 -Dsiteprefix=/opt/cpanel/perl5/526 -Dsitebin=/opt/cpanel/perl5/526/bin -Dsitelib=/opt/cpanel/perl5/526/site_lib -Dusevendorprefix=true -Dvendorbin=/usr/local/cpanel/3rdparty/perl/526/bin -Dvendorprefix=/usr/local/cpanel/3rdparty/perl/526/lib64/perl5 -Dvendorlib=/usr/local/cpanel/3rdparty/perl/526/lib64/perl5/cpanel_lib -Dprivlib=/usr/local/cpanel/3rdparty/perl/526/lib64/perl5/5.26.0 -Dman1dir=none -Dman3dir=none -Dscriptdir=/usr/local/cpanel/3rdparty/perl/526/bin -Dscriptdirexp=/usr/local/cpanel/3rdparty/perl/526/bin -Dsiteman1dir=none -Dsiteman3dir=none -Dinstallman1dir=none -Dversiononly=no -Dinstallusrbinperl=no -Dcf_by=cPanel -Dmyhostname=localhost -Dperladmin=root@localhost -Dcf_email=support@cpanel.net -Di_dbm=/usr/local/cpanel/3rdparty/include -Di_gdbm=/usr/local/cpanel/3rdparty/include -Di_ndbm=/usr/local/cpanel/3rdparty/include -DDB_File=true -Ud_dosuid -Uuserelocatableinc -Umad -Uusethreads -Uusemultiplicity -Uusesocks -Uuselongdouble -Aldflags=-L/usr/local/cpanel/3rdparty/lib64 -L/usr/lib64 -L/lib64 -lgdbm -Dlocincpth=/usr/local/cpanel/3rdparty/perl/526/include /usr/local/cpanel/3rdparty/include /usr/local/include -Duse64bitint -Uuse64bitall -Dlibpth=/usr/local/cpanel/3rdparty/lib64 /usr/local/lib64 /usr/local/lib /lib64 /usr/lib64 ' hint=recommended useposix=true d_sigaction=define useithreads=undef usemultiplicity=undef use64bitint=define use64bitall=undef uselongdouble=undef usemymalloc=n default_inc_excludes_dot=define bincompat5005=undef Compiler: cc='/usr/bin/gcc' ccflags ='-DPERL_DISABLE_PMC -fPIC -DPIC -I/usr/local/cpanel/3rdparty/perl/526/include -I/usr/local/cpanel/3rdparty/include -L/usr/local/cpanel/3rdparty/lib64 -m64 -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2' optimize='-Os' cppflags='-I/usr/local/cpanel/3rdparty/perl/526/include -I/usr/local/cpanel/3rdparty/include -L/usr/local/cpanel/3rdparty/lib64 -DPERL_DISABLE_PMC -fPIC -DPIC -I/usr/local/cpanel/3rdparty/perl/526/include -I/usr/local/cpanel/3rdparty/include -L/usr/local/cpanel/3rdparty/lib64 -m64 -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include' ccversion='' gccversion='4.8.2 20140120 (Red Hat 4.8.2-16)' gccosandvers='' intsize=4 longsize=8 ptrsize=8 doublesize=8 byteorder=12345678 doublekind=3 d_longlong=define longlongsize=8 d_longdbl=define longdblsize=16 longdblkind=3 ivtype='long' ivsize=8 nvtype='double' nvsize=8 Off_t='off_t' lseeksize=8 alignbytes=8 prototype=define Linker and Libraries: ld='/usr/bin/gcc' ldflags ='-L/usr/local/cpanel/3rdparty/lib64 -L/usr/local/cpanel/3rdparty/lib64 -L/usr/lib64 -L/lib64 -lgdbm -fstack-protector-strong -L/usr/local/lib' libpth=/usr/local/cpanel/3rdparty/lib64 /usr/local/lib64 /usr/local/lib /lib64 /usr/lib64 /usr/local/lib /usr/lib /lib/../lib64 /usr/lib/../lib64 /lib libs=-lpthread -lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc libc=libc-2.17.so so=so useshrplib=true libperl=libperl.so gnulibc_version='2.17' Dynamic Linking: dlsrc=dl_dlopen.xs dlext=so d_dlsymun=undef ccdlflags='-Wl,-E -Wl,-rpath,/usr/local/cpanel/3rdparty/perl/526/lib64/perl5/5.26.0/x86_64-linux-64int/CORE' cccdlflags='-fPIC' lddlflags='-shared -Os -L/usr/local/cpanel/3rdparty/lib64 -L/usr/lib64 -L/lib64 -L/usr/local/lib -fstack-protector-strong' Locally applied patches: cPanel patches cPanel INC path changes cPanel performance improvements to modules cPanel Immortal COW cPanel B and O performance fixups cPanel B::C Declare Static Memory malloc patches cPanel Disable XS handshake --- @INC for perl 5.26.0: /usr/local/cpanel /usr/local/cpanel/3rdparty/perl/526/lib64/perl5/cpanel_lib/x86_64-linux-64int /usr/local/cpanel/3rdparty/perl/526/lib64/perl5/cpanel_lib /usr/local/cpanel/3rdparty/perl/526/lib64/perl5/5.26.0/x86_64-linux-64int /usr/local/cpanel/3rdparty/perl/526/lib64/perl5/5.26.0 /opt/cpanel/perl5/526/site_lib/x86_64-linux-64int /opt/cpanel/perl5/526/site_lib --- Environment for perl 5.26.0: HOME=/root LANG=en_US.UTF-8 LANGUAGE (unset) LD_LIBRARY_PATH (unset) LOGDIR (unset) PATH=/usr/local/cpanel/bin:/usr/local/cpanel/3rdparty/bin:/usr/local/cpanel/3rdparty/perl/526/bin:/usr/local/cpanel/3rdparty/perl/524/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/cpanel/perl5/526/bin PERL_BADLANG (unset) SHELL=/bin/zsh
To: perlbug [...] perl.org
Date: Sat, 14 Oct 2017 07:25:56 -0500
Subject: Provide a way for distro maintainers to skip t/porting/customized.t
From: toddr [...] cpan.org
This is a bug report for perl from toddr@cpan.org, generated with the help of perlbug 1.40 running under perl 5.26.0. ----------------------------------------------------------------- [Please describe your issue here] Distro maintainers often need to customize files in cpan/. We need a way to easily disable this test. [Please do not change anything below this line] ----------------------------------------------------------------- --- Flags: category=core severity=low --- Site configuration information for perl 5.26.0: Configured by cPanel at Fri Sep 22 11:09:22 CDT 2017. Summary of my perl5 (revision 5 version 26 subversion 0) configuration: Platform: osname=linux osvers=3.10.0-123.20.1.el7.x86_64 archname=x86_64-linux-64int uname='linux rpmbuild-64-centos-7.dev.cpanel.net 3.10.0-123.20.1.el7.x86_64 #1 smp thu jan 29 18:05:33 utc 2015 x86_64 x86_64 x86_64 gnulinux ' config_args='-des -Dusedevel -Darchname=x86_64-linux-64int -Dcc=/usr/bin/gcc -Dcpp=/usr/bin/cpp -Dusemymalloc=n -DDEBUGGING=none -Doptimize=-Os -Accflags=-m64 -Dccflags=-DPERL_DISABLE_PMC -fPIC -DPIC -I/usr/local/cpanel/3rdparty/perl/526/include -I/usr/local/cpanel/3rdparty/include -L/usr/local/cpanel/3rdparty/lib64 -Duseshrplib -Duselargefiles=yes -Duseposix=true -Dhint=recommended -Duseperlio=yes -Dcppflags=-I/usr/local/cpanel/3rdparty/perl/526/include -I/usr/local/cpanel/3rdparty/include -L/usr/local/cpanel/3rdparty/lib64 -Dldflags=-L/usr/local/cpanel/3rdparty/lib64 -Dprefix=/usr/local/cpanel/3rdparty/perl/526 -Dsiteprefix=/opt/cpanel/perl5/526 -Dsitebin=/opt/cpanel/perl5/526/bin -Dsitelib=/opt/cpanel/perl5/526/site_lib -Dusevendorprefix=true -Dvendorbin=/usr/local/cpanel/3rdparty/perl/526/bin -Dvendorprefix=/usr/local/cpanel/3rdparty/perl/526/lib64/perl5 -Dvendorlib=/usr/local/cpanel/3rdparty/perl/526/lib64/perl5/cpanel_lib -Dprivlib=/usr/local/cpanel/3rdparty/perl/526/lib64/perl5/5.26.0 -Dman1dir=none -Dman3dir=none -Dscriptdir=/usr/local/cpanel/3rdparty/perl/526/bin -Dscriptdirexp=/usr/local/cpanel/3rdparty/perl/526/bin -Dsiteman1dir=none -Dsiteman3dir=none -Dinstallman1dir=none -Dversiononly=no -Dinstallusrbinperl=no -Dcf_by=cPanel -Dmyhostname=localhost -Dperladmin=root@localhost -Dcf_email=support@cpanel.net -Di_dbm=/usr/local/cpanel/3rdparty/include -Di_gdbm=/usr/local/cpanel/3rdparty/include -Di_ndbm=/usr/local/cpanel/3rdparty/include -DDB_File=true -Ud_dosuid -Uuserelocatableinc -Umad -Uusethreads -Uusemultiplicity -Uusesocks -Uuselongdouble -Aldflags=-L/usr/local/cpanel/3rdparty/lib64 -L/usr/lib64 -L/lib64 -lgdbm -Dlocincpth=/usr/local/cpanel/3rdparty/perl/526/include /usr/local/cpanel/3rdparty/include /usr/local/include -Duse64bitint -Uuse64bitall -Dlibpth=/usr/local/cpanel/3rdparty/lib64 /usr/local/lib64 /usr/local/lib /lib64 /usr/lib64 ' hint=recommended useposix=true d_sigaction=define useithreads=undef usemultiplicity=undef use64bitint=define use64bitall=undef uselongdouble=undef usemymalloc=n default_inc_excludes_dot=define bincompat5005=undef Compiler: cc='/usr/bin/gcc' ccflags ='-DPERL_DISABLE_PMC -fPIC -DPIC -I/usr/local/cpanel/3rdparty/perl/526/include -I/usr/local/cpanel/3rdparty/include -L/usr/local/cpanel/3rdparty/lib64 -m64 -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2' optimize='-Os' cppflags='-I/usr/local/cpanel/3rdparty/perl/526/include -I/usr/local/cpanel/3rdparty/include -L/usr/local/cpanel/3rdparty/lib64 -DPERL_DISABLE_PMC -fPIC -DPIC -I/usr/local/cpanel/3rdparty/perl/526/include -I/usr/local/cpanel/3rdparty/include -L/usr/local/cpanel/3rdparty/lib64 -m64 -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include' ccversion='' gccversion='4.8.2 20140120 (Red Hat 4.8.2-16)' gccosandvers='' intsize=4 longsize=8 ptrsize=8 doublesize=8 byteorder=12345678 doublekind=3 d_longlong=define longlongsize=8 d_longdbl=define longdblsize=16 longdblkind=3 ivtype='long' ivsize=8 nvtype='double' nvsize=8 Off_t='off_t' lseeksize=8 alignbytes=8 prototype=define Linker and Libraries: ld='/usr/bin/gcc' ldflags ='-L/usr/local/cpanel/3rdparty/lib64 -L/usr/local/cpanel/3rdparty/lib64 -L/usr/lib64 -L/lib64 -lgdbm -fstack-protector-strong -L/usr/local/lib' libpth=/usr/local/cpanel/3rdparty/lib64 /usr/local/lib64 /usr/local/lib /lib64 /usr/lib64 /usr/local/lib /usr/lib /lib/../lib64 /usr/lib/../lib64 /lib libs=-lpthread -lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc libc=libc-2.17.so so=so useshrplib=true libperl=libperl.so gnulibc_version='2.17' Dynamic Linking: dlsrc=dl_dlopen.xs dlext=so d_dlsymun=undef ccdlflags='-Wl,-E -Wl,-rpath,/usr/local/cpanel/3rdparty/perl/526/lib64/perl5/5.26.0/x86_64-linux-64int/CORE' cccdlflags='-fPIC' lddlflags='-shared -Os -L/usr/local/cpanel/3rdparty/lib64 -L/usr/lib64 -L/lib64 -L/usr/local/lib -fstack-protector-strong' Locally applied patches: cPanel patches cPanel INC path changes cPanel performance improvements to modules cPanel Immortal COW cPanel B and O performance fixups cPanel B::C Declare Static Memory malloc patches cPanel Disable XS handshake --- @INC for perl 5.26.0: /usr/local/cpanel /usr/local/cpanel/3rdparty/perl/526/lib64/perl5/cpanel_lib/x86_64-linux-64int /usr/local/cpanel/3rdparty/perl/526/lib64/perl5/cpanel_lib /usr/local/cpanel/3rdparty/perl/526/lib64/perl5/5.26.0/x86_64-linux-64int /usr/local/cpanel/3rdparty/perl/526/lib64/perl5/5.26.0 /opt/cpanel/perl5/526/site_lib/x86_64-linux-64int /opt/cpanel/perl5/526/site_lib --- Environment for perl 5.26.0: HOME=/root LANG=en_US.UTF-8 LANGUAGE (unset) LD_LIBRARY_PATH (unset) LOGDIR (unset) PATH=/usr/local/cpanel/bin:/usr/local/cpanel/3rdparty/bin:/usr/local/cpanel/3rdparty/perl/526/bin:/usr/local/cpanel/3rdparty/perl/524/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/cpanel/perl5/526/bin PERL_BADLANG (unset) SHELL=/bin/zsh
RT-Send-CC: perl5-porters [...] perl.org
RT-Send-CC: perl5-porters [...] perl.org
Subject: 0001-Provide-a-mechanism-for-distros-to-disable-tests-tha.patch
From d7c4b04586275f68395149dd07639f59dae25d46 Mon Sep 17 00:00:00 2001 From: Todd Rinaldo <toddr@cpan.org> Date: Sat, 14 Oct 2017 08:07:35 -0500 Subject: [PATCH] Provide a mechanism for distros to disable tests that complain if cpan/ is modified RT 132298 --- t/porting/customized.t | 1 + 1 file changed, 1 insertion(+) diff --git a/t/porting/customized.t b/t/porting/customized.t index 45fcafb100..e8b2c4cf6e 100644 --- a/t/porting/customized.t +++ b/t/porting/customized.t @@ -13,6 +13,7 @@ BEGIN { @INC = qw(lib Porting t); require 'test.pl'; skip_all("pre-computed SHA1 won't match under EBCDIC") if $::IS_EBCDIC; + skip_all("This distro may have modified some files in cpan/. Skipping validation.") if $ENV{'PERL_CPAN_DISTRO_IS_PATCHED'}; } use strict; -- 2.14.2
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 1.1k
On Sat, 14 Oct 2017 13:16:36 GMT, TODDR wrote: Show quoted text
> From d7c4b04586275f68395149dd07639f59dae25d46 Mon Sep 17 00:00:00 2001 > From: Todd Rinaldo <toddr@cpan.org> > Date: Sat, 14 Oct 2017 08:07:35 -0500 > Subject: [PATCH] Provide a mechanism for distros to disable tests that > complain if cpan/ is modified > > RT 132298 > --- > t/porting/customized.t | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/t/porting/customized.t b/t/porting/customized.t > index 45fcafb100..e8b2c4cf6e 100644 > --- a/t/porting/customized.t > +++ b/t/porting/customized.t > @@ -13,6 +13,7 @@ BEGIN { > @INC = qw(lib Porting t); > require 'test.pl'; > skip_all("pre-computed SHA1 won't match under EBCDIC") if > $::IS_EBCDIC; > + skip_all("This distro may have modified some files in cpan/. > Skipping validation.") if $ENV{'PERL_CPAN_DISTRO_IS_PATCHED'}; > } > > use strict;
Per discussion with Tod and Debian Perl maintainers Dom and Niko at Perl 5 Core Hackathon, we're delaying applying this patch pending some documentation and possible change of name of the environmental variable. Thank you very much. -- James E Keenan (jkeenan@cpan.org)
Duplicate of 132298; merging into that ticket. -- James E Keenan (jkeenan@cpan.org)
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 362b
Hello, I'd like to propose this expanded patch, which disables a few other tests inconvenient to Debian and which probably serve no useful purpose for other distros. I have also generalised the environment variable, and added some documentation of the feature. This has been tested in Debian (5.26) with today's upload to Debian experimental. Thanks, Dominic
Subject: 0001-Skip-various-tests-if-PERL_BUILD_PACKAGING-is-set.patch
From 8408d4abc83b1280ac3dad70175669f1d93aabad Mon Sep 17 00:00:00 2001 From: Dominic Hargreaves <dom@earth.li> Date: Sat, 14 Oct 2017 16:27:53 +0200 Subject: [PATCH] Skip various tests if PERL_BUILD_PACKAGING is set These are tests which tend not to be useful for downstream packagers t/porting/customized.t change originally from Todd Rinaldo --- INSTALL | 3 ++- MANIFEST | 1 + PACKAGING | 30 ++++++++++++++++++++++++++++++ regen/lib_cleanup.pl | 5 +++++ t/porting/customized.t | 1 + t/test.pl | 3 +++ 6 files changed, 42 insertions(+), 1 deletion(-) create mode 100644 PACKAGING diff --git a/INSTALL b/INSTALL index 84cc61f153..069476dadc 100644 --- a/INSTALL +++ b/INSTALL @@ -2750,4 +2750,5 @@ This document is part of the Perl package and may be distributed under the same terms as perl itself, with the following additional request: If you are distributing a modified version of perl (perhaps as part of a larger package) please B<do> modify these installation instructions -and the contact information to match your distribution. +and the contact information to match your distribution. Additional +information for packagers is in F<PACKAGING>. diff --git a/MANIFEST b/MANIFEST index 0cbf909bbd..ceaa63370f 100644 --- a/MANIFEST +++ b/MANIFEST @@ -4932,6 +4932,7 @@ os2/perlrexx.c Support perl interpreter embedded in REXX os2/perlrexx.cmd Test perl interpreter embedded in REXX overload.h generated overload enum (public) overload.inc generated overload name table (implementation) +PACKAGING notes and best practice for packaging perl 5 packsizetables.inc The generated packprops array used in pp_pack.c pad.c Scratchpad functions pad.h Scratchpad headers diff --git a/PACKAGING b/PACKAGING new file mode 100644 index 0000000000..6369f0b979 --- /dev/null +++ b/PACKAGING @@ -0,0 +1,30 @@ +If you read this file _as_is_, just ignore the funny characters you +see. It is written in the POD format (see pod/perlpod.pod) which is +specifically designed to be readable as is. + +=head1 NAME + +PACKAGING - notes and best practice for packaging perl 5 + +=head1 SYNOPSIS + +This document is aimed at anyone who is producing their own version of +perl for distribution to other users. It is intended as a collection +of useful tips, advice and best practice, rather than being a complete +packaging manual. The starting point for installing perl remains +F<INSTALL>. + +=head1 Customizing test running + +A small number of porting tests (those in t/porting) tests are not well +suited to typical distribution packaging scenarios. For example, they +assume they are working in a git clone of the upstream Perl repository, +or enforce rules which are not relevant to downstream packagers. +These can be skipped by setting the environment variable +PERL_BUILD_PACKAGING. A complete list of tests which this applied to +can be found by searching the codebase for this string. + +An alternative strategy would be to skip all porting tests, but many of +them are useful if additional patches might be applied. + +=cut diff --git a/regen/lib_cleanup.pl b/regen/lib_cleanup.pl index 5e40b405a4..6caf74a563 100644 --- a/regen/lib_cleanup.pl +++ b/regen/lib_cleanup.pl @@ -164,6 +164,11 @@ if ($TAP && !-d '.git' && !-f 'lib/.gitignore') { exit 0; } +if ($ENV{'PERL_BUILD_PACKAGING'}) { + print "ok # skip explicitly disabled git tests by PERL_BUILD_PACKAGING\n"; + exit 0; +} + $fh = open_new('lib/.gitignore', '>', { by => $0, from => 'MANIFEST and parsing files in cpan/ dist/ and ext/'}); diff --git a/t/porting/customized.t b/t/porting/customized.t index 45fcafb100..5c3739198c 100644 --- a/t/porting/customized.t +++ b/t/porting/customized.t @@ -13,6 +13,7 @@ BEGIN { @INC = qw(lib Porting t); require 'test.pl'; skip_all("pre-computed SHA1 won't match under EBCDIC") if $::IS_EBCDIC; + skip_all("This distro may have modified some files in cpan/. Skipping validation.") if $ENV{'PERL_BUILD_PACKAGING'}; } use strict; diff --git a/t/test.pl b/t/test.pl index 79e6e25e95..1782dcf73c 100644 --- a/t/test.pl +++ b/t/test.pl @@ -212,6 +212,9 @@ sub find_git_or_skip { } else { $reason = 'not being run from a git checkout'; } + if ($ENV{'PERL_BUILD_PACKAGING'}) { + $reason = 'PERL_BUILD_PACKAGING is set'; + } skip_all($reason) if $_[0] && $_[0] eq 'all'; skip($reason, @_); } -- 2.11.0
From: Sawyer X <xsawyerx [...] gmail.com>
Subject: Re: [perl #132298] Provide a way for distro maintainers to skip t/porting/customized.t
CC: perl5-porters [...] perl.org
To: perlbug-followup [...] perl.org
Date: Mon, 16 Oct 2017 19:50:42 +0200
Download (untitled) / with headers
text/plain 440b
On 10/16/2017 07:44 PM, Dominic Hargreaves via RT wrote: Show quoted text
> Hello, > > I'd like to propose this expanded patch, which disables a few other tests inconvenient to Debian and which probably serve no useful purpose for other distros.
Thank you for submitting this patch, Dominic. We have at least two verified needs for it, and I wouldn't be surprised to have additional distributions and packages utilize this. I'm in favor of this patch.
Date: Mon, 23 Oct 2017 13:22:49 +0100
CC: perlbug-followup [...] perl.org, perl5-porters [...] perl.org
To: Sawyer X <xsawyerx [...] gmail.com>
Subject: Re: [perl #132298] Provide a way for distro maintainers to skip t/porting/customized.t
From: Dominic Hargreaves <dom [...] earth.li>
Download (untitled) / with headers
text/plain 620b
On Mon, Oct 16, 2017 at 07:50:42PM +0200, Sawyer X wrote: Show quoted text
> > > On 10/16/2017 07:44 PM, Dominic Hargreaves via RT wrote:
> > Hello, > > > > I'd like to propose this expanded patch, which disables a few other tests inconvenient to Debian and which probably serve no useful purpose for other distros.
> > Thank you for submitting this patch, Dominic. > > We have at least two verified needs for it, and I wouldn't be surprised > to have additional distributions and packages utilize this. > > I'm in favor of this patch.
Thanks. I will commit this later today unless there are any further remarks. Cheers, Dominic.
RT-Send-CC: perl5-porters [...] perl.org
Now applied as ba6733216202523a95b0b7ee2e534b8e30b6d7df.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org