Skip Menu |

Subject: Blead Breaks CPAN: Role::Tiny, Variable::Magic, Moo
From: Ryan Voots <simcop2387 [...] simcop2387.info>
Date: Mon, 9 Oct 2017 08:06:30 -0700
To: perlbug [...] perl.org
Somewhere between e04fc1aa1c and e92359cbbc, Role::Tiny and Variable::Magic were broken.  I haven't bisected it myself yet but based on talk in #p5p from haarg I *suspect* that it's the stash changes in 1369fd508410a5ab354672cedce158f1e9c653c9

Reported by HAARG also, Moo has failures of it's own with this change, one of us will attach a log shortly.

--- BEGIN perl -V ---
Summary of my perl5 (revision 5 version 27 subversion 5) configuration:
  Derived from: e92359cbbca7d7280e849dbfc006bc0aeb44df67
  Platform:
    osname=linux
    osvers=4.9.36-x86_64-linode85
    archname=x86_64-linux
    uname='linux simcop2387.info 4.9.36-x86_64-linode85 #1 smp thu jul 6 15:31:23 utc 2017 x86_64 gnulinux '
    config_args='-de -Dprefix=/home/ryan/perl5/perlbrew/perls/perlbot-blead-2017-10-09_12776 -Dccflags=-fpie -fPIC -march=native -fstack-protector-all -pie -D_FORTIFY_SOURCE=2 -Dldflags=-Wl,-z,now -Wl,-zrelro -Dusedevel -Aeval:scriptdir=/home/ryan/perl5/perlbrew/perls/perlbot-blead-2017-10-09_12776/bin'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=undef
    usemultiplicity=undef
    use64bitint=define
    use64bitall=define
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
    bincompat5005=undef
  Compiler:
    cc='cc'
    ccflags ='-fpie -fPIC -march=native -fstack-protector-all -pie -D_FORTIFY_SOURCE=2 -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
    optimize='-O2'
    cppflags='-fpie -fPIC -march=native -fstack-protector-all -pie -D_FORTIFY_SOURCE=2 -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
    ccversion=''
    gccversion='7.2.0'
    gccosandvers=''
    intsize=4
    longsize=8
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=3
    ivtype='long'
    ivsize=8
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=8
    prototype=define


  Linker and Libraries:
    ld='cc'
    ldflags ='-Wl,-z,now -Wl,-zrelro -fstack-protector-strong -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/7/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
    libs=-lpthread -lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
    perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
    libc=libc-2.24.so
    so=so
    useshrplib=false
    libperl=libperl.a
    gnulibc_version='2.24'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=so
    d_dlsymun=undef
    ccdlflags='-Wl,-E'
    cccdlflags='-fPIC'
    lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl):
  Compile-time options:
    HAS_TIMES
    PERLIO_LAYERS
    PERL_COPY_ON_WRITE
    PERL_DONT_CREATE_GVSV
    PERL_MALLOC_WRAP
    PERL_OP_PARENT
    PERL_PRESERVE_IVUV
    PERL_USE_DEVEL
    USE_64_BIT_ALL
    USE_64_BIT_INT
    USE_LARGE_FILES
    USE_LOCALE
    USE_LOCALE_COLLATE
    USE_LOCALE_CTYPE
    USE_LOCALE_NUMERIC
    USE_LOCALE_TIME
    USE_PERLIO
    USE_PERL_ATOF
  Locally applied patches:
    uncommitted-changes
    Devel::PatchPerl 1.38
  Built under linux
  Compiled at Oct  9 2017 07:03:06
  %ENV:
    PERLBREW_BASHRC_VERSION="0.78"
    PERLBREW_HOME="/home/ryan/.perlbrew"
    PERLBREW_MANPATH="/home/ryan/perl5/perlbrew/perls/perlbot-blead-2017-10-09_12776/man"
    PERLBREW_PATH="/home/ryan/perl5/perlbrew/bin:/home/ryan/perl5/perlbrew/perls/perlbot-blead-2017-10-09_12776/bin"
    PERLBREW_PERL="perlbot-blead-2017-10-09_12776"
    PERLBREW_ROOT="/home/ryan/perl5/perlbrew"
    PERLBREW_VERSION="0.78"
  @INC:
    /home/ryan/perl5/perlbrew/perls/perlbot-blead-2017-10-09_12776/lib/site_perl/5.27.5/x86_64-linux
    /home/ryan/perl5/perlbrew/perls/perlbot-blead-2017-10-09_12776/lib/site_perl/5.27.5
    /home/ryan/perl5/perlbrew/perls/perlbot-blead-2017-10-09_12776/lib/5.27.5/x86_64-linux
    /home/ryan/perl5/perlbrew/perls/perlbot-blead-2017-10-09_12776/lib/5.27.5
----- END perl -V -----

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 512b
On Mon, 09 Oct 2017 08:06:46 -0700, simcop2387@simcop2387.info wrote: Show quoted text
> Somewhere between e04fc1aa1c and e92359cbbc, Role::Tiny and > Variable::Magic > were broken. I haven't bisected it myself yet but based on talk in > #p5p > from haarg I *suspect* that it's the stash changes in > 1369fd508410a5ab354672cedce158f1e9c653c9
Very likely. I was expecting some fallout. Show quoted text
> Reported by HAARG also, Moo has failures of it's own with this change, > one > of us will attach a log shortly.
-- Father Chrysostomos
RT-Send-CC: perl5-porters [...] perl.org
Some additional failures due to the same change.
Subject: Log-Trace.log
Download Log-Trace.log
application/octet-stream 4.2k

Message body not shown because it is not plain text.

Subject: Moo.log
Download Moo.log
application/octet-stream 25.4k

Message body not shown because it is not plain text.

Subject: Test-API.log
Download Test-API.log
application/octet-stream 6.5k

Message body not shown because it is not plain text.

Subject: Type-Tiny.log
Download Type-Tiny.log
application/octet-stream 31.4k

Message body not shown because it is not plain text.

Subject: indirect.log
Download indirect.log
application/octet-stream 10.2k

Message body not shown because it is not plain text.

From: Ryan Voots <simcop2387 [...] simcop2387.info>
Subject: Re: [perl #132252] Blead Breaks CPAN: Role::Tiny, Variable::Magic, Moo
To: perlbug-followup [...] perl.org
CC: pp Porters <perl5-porters [...] perl.org>
Date: Thu, 12 Oct 2017 09:50:56 -0700
Download (untitled) / with headers
text/plain 274b
Also breaks autovivification

On Tue, Oct 10, 2017 at 2:16 AM, Graham Knop via RT <perlbug-followup@perl.org> wrote:
Show quoted text
Some additional failures due to the same change.

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=132252

Download autoviv.log
text/x-log 8.1k

Message body is not shown because sender requested not to inline it.

From: Andreas Koenig <andreas.koenig.7os6VVqR [...] franz.ak.mind.de>
Subject: Re: [perl #132252] Blead Breaks CPAN: Role::Tiny, Variable::Magic, Moo
Date: Sun, 15 Oct 2017 08:47:38 +0200
CC: perl5-porters [...] perl.org
To: "Father Chrysostomos via RT" <perlbug-followup [...] perl.org>
Download (untitled) / with headers
text/plain 281b
Show quoted text
>>>>> On Mon, 09 Oct 2017 17:07:34 -0700, "Father Chrysostomos via RT" <perlbug-followup@perl.org> said:
Show quoted text
> Very likely. I was expecting some fallout.
What are the plans how to proceed? Shall this go into 5.27.5? I mean, is everybody aware this is a huge fallout? -- andreas
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 754b
On Sat, 14 Oct 2017 23:48:08 -0700, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote: Show quoted text
> >>>>> On Mon, 09 Oct 2017 17:07:34 -0700, "Father Chrysostomos via RT" > >>>>> <perlbug-followup@perl.org> said:
>
> > Very likely. I was expecting some fallout.
> > What are the plans how to proceed? Shall this go into 5.27.5? I mean, > is > everybody aware this is a huge fallout?
I am hoping, when I get time on the weekends (like today), to start patching the CPAN modules one by one. We still have many months to go before the stable release. But if the pumpking wants to back out the change for now, I have no objection (except that it may make it harder to get the patches accepted--I really do want this change in before 5.28). -- Father Chrysostomos
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 1.2k
On Sun, 15 Oct 2017 15:17:03 GMT, sprout wrote: Show quoted text
> On Sat, 14 Oct 2017 23:48:08 -0700, > andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
> > >>>>> On Mon, 09 Oct 2017 17:07:34 -0700, "Father Chrysostomos via > > >>>>> RT" > > >>>>> <perlbug-followup@perl.org> said:
> >
> > > Very likely. I was expecting some fallout.
> > > > What are the plans how to proceed? Shall this go into 5.27.5? I mean, > > is > > everybody aware this is a huge fallout?
> > I am hoping, when I get time on the weekends (like today), to start > patching the CPAN modules one by one. We still have many months to go > before the stable release. > > But if the pumpking wants to back out the change for now, I have no > objection (except that it may make it harder to get the patches > accepted--I really do want this change in before 5.28).
Father C, Can you describe the purpose of the branch you merged on Oct 08? Given the fact that the libraries which we already know have been broken are rather high up on the CPAN river, there is a greater than normal likelihood that libraries farther down the river and darkpan code will also break. If so, then we need to assess the costs and benefits of the merge before proceeding. Thank you very much. -- James E Keenan (jkeenan@cpan.org)
To: perlbug-followup [...] perl.org
CC: perl5-porters [...] perl.org
Date: Mon, 16 Oct 2017 18:15:49 +0200
Subject: Re: [perl #132252] Blead Breaks CPAN: Role::Tiny, Variable::Magic, Moo
From: Sawyer X <xsawyerx [...] gmail.com>
Download (untitled) / with headers
text/plain 1.5k
On 10/15/2017 10:07 PM, James E Keenan via RT wrote: Show quoted text
> On Sun, 15 Oct 2017 15:17:03 GMT, sprout wrote:
>> On Sat, 14 Oct 2017 23:48:08 -0700, >> andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
>>>>>>>> On Mon, 09 Oct 2017 17:07:34 -0700, "Father Chrysostomos via >>>>>>>> RT" >>>>>>>> <perlbug-followup@perl.org> said:
>>>> Very likely. I was expecting some fallout.
>>> What are the plans how to proceed? Shall this go into 5.27.5? I mean, >>> is >>> everybody aware this is a huge fallout?
>> I am hoping, when I get time on the weekends (like today), to start >> patching the CPAN modules one by one. We still have many months to go >> before the stable release. >> >> But if the pumpking wants to back out the change for now, I have no >> objection (except that it may make it harder to get the patches >> accepted--I really do want this change in before 5.28).
> Father C, > > Can you describe the purpose of the branch you merged on Oct 08? > > Given the fact that the libraries which we already know have been broken are rather high up on the CPAN river, there is a greater than normal likelihood that libraries farther down the river and darkpan code will also break. If so, then we need to assess the costs and benefits of the merge before proceeding.
An additional temporary problem is that this makes it difficult for CPAN smokers to expose problems with downstream modules. If Moo fails, we can't test anything using Moo. I think it's better to temporarily revert this just until we can resolve it. Father C., if you can share your patch, others could help with the patching. (I volunteer.)
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 2.3k
On Sun, 15 Oct 2017 13:07:56 -0700, jkeenan wrote: Show quoted text
> Father C, > > Can you describe the purpose of the branch you merged on Oct 08?
It saves a large amount of memory. Before this change, subroutines in packages (the most common use of package symbols) resided in typeglobs. So ‘package Foo; sub foo{}’ would be stored as *foo{CODE} in the *foo typeglob in the Foo package. I.e., $Foo::{foo} was a typeglob with its CODE slot pointing to something. The new behaviour is that, instead of a typeglob, we have a scalar with a reference to the subroutine. So now $Foo::{foo} is a coderef. Since an RV (a reference) takes 24 bytes of memory whereas a GV (typeglob) takes 24 (sv head) + 48 (xpvgv body) + 80 (gp) = 152 bytes, plus a little malloc overhead for the gp struct, which I think is 4 to 6 bytes on most platforms, so the total is about 157 bytes. That’s 133 bytes extra per subroutine. If you load five modules each with 100 subroutines, you’ve just used 65 K more ram than you needed to. (These are all 64-bit numbers. The 32-bit numbers differ, but the GV will always be bigger than the RV.) Granted, method calls will undo the optimization (caching the method in the typeglob, trading memory for speed), but this only happens if a particular method actually gets called. Hence, small scripts that load large libraries will see the biggest reduction in memory usage. Large object-oriented systems that call methods for everything see the smallest reduction in memory usage. Show quoted text
> Given the fact that the libraries which we already know have been > broken are rather high up on the CPAN river, there is a greater than > normal likelihood that libraries farther down the river and darkpan > code will also break. If so, then we need to assess the costs and > benefits of the merge before proceeding.
If we are to revert the behaviour, it is only this hunk from 6881372e1 that needs to be reverted: @@ -8583,7 +8590,7 @@ Perl_newATTRSUB_x(pTHX_ I32 floor, OP *o, OP *proto, OP *attrs, sub is stored in. */ const I32 flags = ec ? GV_NOADD_NOINIT - : PL_curstash != CopSTASH(PL_curcop) + : IN_PERL_RUNTIME && PL_curstash != CopSTASH(PL_curcop) || memchr(name, ':', namlen) || memchr(name, '\'', namlen) ? gv_fetch_flags : GV_ADDMULTI | GV_NOINIT | GV_NOTQUAL; and whatever tests end up failing need to be marked TODO. -- Father Chrysostomos
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 2.3k
On Mon, 16 Oct 2017 16:16:18 GMT, xsawyerx@gmail.com wrote: Show quoted text
> > > On 10/15/2017 10:07 PM, James E Keenan via RT wrote:
> > On Sun, 15 Oct 2017 15:17:03 GMT, sprout wrote:
> >> On Sat, 14 Oct 2017 23:48:08 -0700, > >> andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
> >>>>>>>> On Mon, 09 Oct 2017 17:07:34 -0700, "Father Chrysostomos via > >>>>>>>> RT" > >>>>>>>> <perlbug-followup@perl.org> said:
> >>>> Very likely. I was expecting some fallout.
> >>> What are the plans how to proceed? Shall this go into 5.27.5? I > >>> mean, > >>> is > >>> everybody aware this is a huge fallout?
> >> I am hoping, when I get time on the weekends (like today), to start > >> patching the CPAN modules one by one. We still have many months to > >> go > >> before the stable release. > >> > >> But if the pumpking wants to back out the change for now, I have no > >> objection (except that it may make it harder to get the patches > >> accepted--I really do want this change in before 5.28).
> > Father C, > > > > Can you describe the purpose of the branch you merged on Oct 08? > > > > Given the fact that the libraries which we already know have been > > broken are rather high up on the CPAN river, there is a greater than > > normal likelihood that libraries farther down the river and darkpan > > code will also break. If so, then we need to assess the costs and > > benefits of the merge before proceeding.
> > An additional temporary problem is that this makes it difficult for > CPAN > smokers to expose problems with downstream modules. If Moo fails, we > can't test anything using Moo. > > I think it's better to temporarily revert this just until we can > resolve it. >
I also think that would be the best course of action. Father C could fork HEAD to a branch just before reverting. Ongoing work could then take place in that branch and, at a suitable point, we could install it somewhere for smoking the failing libraries and the upper parts of the CPAN river. Show quoted text
> Father C., if you can share your patch, others could help with the > patching. (I volunteer.)
Since this code had no FAILs within the CPAN test suite -- only downstream on CPAN. I think we need to look at the code on CPAN which broke to write tests which we can then include in the Perl 5 test suite to head off such failures in the future. Thank you very much. -- James E Keenan (jkeenan@cpan.org)
Date: Tue, 17 Oct 2017 18:09:03 +0300
To: "James E Keenan via RT" <perlbug-followup [...] perl.org>
CC: perl5-porters [...] perl.org
From: Shlomi Fish <shlomif [...] shlomifish.org>
Subject: Re: [perl #132252] Blead Breaks CPAN: Role::Tiny, Variable::Magic, Moo
Download (untitled) / with headers
text/plain 2.9k
On Tue, 17 Oct 2017 06:55:11 -0700 "James E Keenan via RT" <perlbug-followup@perl.org> wrote: Show quoted text
> On Mon, 16 Oct 2017 16:16:18 GMT, xsawyerx@gmail.com wrote:
> > > > > > On 10/15/2017 10:07 PM, James E Keenan via RT wrote:
> > > On Sun, 15 Oct 2017 15:17:03 GMT, sprout wrote:
> > >> On Sat, 14 Oct 2017 23:48:08 -0700, > > >> andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
> > >>>>>>>> On Mon, 09 Oct 2017 17:07:34 -0700, "Father Chrysostomos via > > >>>>>>>> RT" > > >>>>>>>> <perlbug-followup@perl.org> said:
> > >>>> Very likely. I was expecting some fallout.
> > >>> What are the plans how to proceed? Shall this go into 5.27.5? I > > >>> mean, > > >>> is > > >>> everybody aware this is a huge fallout?
> > >> I am hoping, when I get time on the weekends (like today), to start > > >> patching the CPAN modules one by one. We still have many months to > > >> go > > >> before the stable release. > > >> > > >> But if the pumpking wants to back out the change for now, I have no > > >> objection (except that it may make it harder to get the patches > > >> accepted--I really do want this change in before 5.28).
> > > Father C, > > > > > > Can you describe the purpose of the branch you merged on Oct 08? > > > > > > Given the fact that the libraries which we already know have been > > > broken are rather high up on the CPAN river, there is a greater than > > > normal likelihood that libraries farther down the river and darkpan > > > code will also break. If so, then we need to assess the costs and > > > benefits of the merge before proceeding.
> > > > An additional temporary problem is that this makes it difficult for > > CPAN > > smokers to expose problems with downstream modules. If Moo fails, we > > can't test anything using Moo. > > > > I think it's better to temporarily revert this just until we can > > resolve it. > >
> > I also think that would be the best course of action. Father C could fork > HEAD to a branch just before reverting. Ongoing work could then take place > in that branch and, at a suitable point, we could install it somewhere for > smoking the failing libraries and the upper parts of the CPAN river. >
Sounds like a good course of action. Show quoted text
> > Father C., if you can share your patch, others could help with the > > patching. (I volunteer.)
> > Since this code had no FAILs within the CPAN test suite -- only downstream on > CPAN. I think we need to look at the code on CPAN which broke to write tests > which we can then include in the Perl 5 test suite to head off such failures > in the future.
I also think this will be a good idea. Show quoted text
> > Thank you very much. >
-- ----------------------------------------------------------------- Shlomi Fish http://www.shlomifish.org/ http://youtu.be/xZLwtc9x4yA - Anime in Real Life!! (Parody) Every successful open source project will eventually spawn a sub‐project. Please reply to list if it's a mailing list post - http://shlom.in/reply .
Subject: Re: [perl #132252] Blead Breaks CPAN: Role::Tiny, Variable::Magic, Moo
From: Graham Knop <haarg [...] haarg.org>
Date: Wed, 18 Oct 2017 00:15:44 +0200
To: "perlbug-followup [...] perl.org" <perlbug-followup [...] perl.org>
CC: Perl5 Porters <perl5-porters [...] perl.org>
On Sun, Oct 15, 2017 at 5:17 PM, Father Chrysostomos via RT <perlbug-followup@perl.org> wrote: Show quoted text
> On Sat, 14 Oct 2017 23:48:08 -0700, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
>> >>>>> On Mon, 09 Oct 2017 17:07:34 -0700, "Father Chrysostomos via RT" >> >>>>> <perlbug-followup@perl.org> said:
>>
>> > Very likely. I was expecting some fallout.
>> >> What are the plans how to proceed? Shall this go into 5.27.5? I mean, >> is >> everybody aware this is a huge fallout?
> > I am hoping, when I get time on the weekends (like today), to start patching the CPAN modules one by one. We still have many months to go before the stable release. > > But if the pumpking wants to back out the change for now, I have no objection (except that it may make it harder to get the patches accepted--I really do want this change in before 5.28).
I have no particular opinion about if this patch should be backed out, but I do have patches prepared for Role::Tiny and Moo to deal with the issue. Show quoted text
> > -- > > Father Chrysostomos > > > --- > via perlbug: queue: perl5 status: open > https://rt.perl.org/Ticket/Display.html?id=132252
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 1.3k
On Tue, 17 Oct 2017 15:16:46 -0700, haarg wrote: Show quoted text
> On Sun, Oct 15, 2017 at 5:17 PM, Father Chrysostomos via RT > <perlbug-followup@perl.org> wrote:
> > On Sat, 14 Oct 2017 23:48:08 -0700, > > andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
> >> >>>>> On Mon, 09 Oct 2017 17:07:34 -0700, "Father Chrysostomos via > >> >>>>> RT" > >> >>>>> <perlbug-followup@perl.org> said:
> >>
> >> > Very likely. I was expecting some fallout.
> >> > >> What are the plans how to proceed? Shall this go into 5.27.5? I > >> mean, > >> is > >> everybody aware this is a huge fallout?
> > > > I am hoping, when I get time on the weekends (like today), to start > > patching the CPAN modules one by one. We still have many months to > > go before the stable release. > > > > But if the pumpking wants to back out the change for now, I have no > > objection (except that it may make it harder to get the patches > > accepted--I really do want this change in before 5.28).
> > I have no particular opinion about if this patch should be backed out, > but I do have patches prepared for Role::Tiny and Moo to deal with the > issue.
I have just submitted a patch for Variable::Magic: https://rt.cpan.org/Ticket/Display.html?id=123314 I am very short on time till the weekend. Would someone else have a chance to revert the hunk I cited? -- Father Chrysostomos
Date: Wed, 18 Oct 2017 11:43:37 +0200
To: perlbug-followup [...] perl.org
CC: perl5-porters [...] perl.org
From: Sawyer X <xsawyerx [...] gmail.com>
Subject: Re: [perl #132252] Blead Breaks CPAN: Role::Tiny, Variable::Magic, Moo
Download (untitled) / with headers
text/plain 493b
On 10/17/2017 03:55 PM, James E Keenan via RT wrote: Show quoted text
> On Mon, 16 Oct 2017 16:16:18 GMT, xsawyerx@gmail.com wrote:
>> [...] >> Father C., if you can share your patch, others could help with the >> patching. (I volunteer.)
> Since this code had no FAILs within the CPAN test suite -- only downstream on CPAN. I think we need to look at the code on CPAN which broke to write tests which we can then include in the Perl 5 test suite to head off such failures in the future.
I like this idea.
To: Sawyer X <xsawyerx [...] gmail.com>, perlbug-followup [...] perl.org
CC: perl5-porters [...] perl.org
Date: Wed, 18 Oct 2017 07:13:21 -0400
From: James E Keenan <jkeenan [...] pobox.com>
Subject: Re: [perl #132252] Blead Breaks CPAN: Role::Tiny, Variable::Magic,Moo
Download (untitled) / with headers
text/plain 1.3k
On 10/18/2017 05:43 AM, Sawyer X wrote: Show quoted text
> > > On 10/17/2017 03:55 PM, James E Keenan via RT wrote:
>> On Mon, 16 Oct 2017 16:16:18 GMT, xsawyerx@gmail.com wrote:
>>> [...] >>> Father C., if you can share your patch, others could help with the >>> patching. (I volunteer.)
>> Since this code had no FAILs within the CPAN test suite -- only downstream on CPAN. I think we need to look at the code on CPAN which broke to write tests which we can then include in the Perl 5 test suite to head off such failures in the future.
> > I like this idea. >
Sawyer, I think it will have to be your call to either (a) do the above, which entails reverting merge commit 1369fd508410a5ab354672cedce158f1e9c653c9 from blead in its entirety (after copying HEAD to a branch); or (b) fixing only a small portion on that commit, as indicated in Father C's most recent posts: https://www.nntp.perl.org/group/perl.perl5.porters/2017/10/msg246738.html https://www.nntp.perl.org/group/perl.perl5.porters/2017/10/msg246757.html (a) has the disadvantage that it puts us into the murkiness described in file:///usr/share/doc/git-doc/howto/revert-a-faulty-merge.html. (b) has the disadvantage that we have to trust the committer that all *other* parts of 1369fd5 are correct and that we only need to repair one line. I think it is unfortunate that we have been placed in this situation. Thank you very much. Jim Keenan


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org