Skip Menu |
Report information
Id: 132123
Status: resolved
Priority: 0/
Queue: perl5

Owner: Nobody
Requestors: atoomic <me [at] eboxr.com>
Cc:
AdminCc:

Operating System: (no value)
PatchStatus: (no value)
Severity: low
Type: unknown
Perl Version: (no value)
Fixed In: (no value)

Attachments


To: perlbug [...] perl.org
Subject: Add CvGvNAME_HEK helper
From: "Nicolas R." <atoomic [...] cpan.org>
Date: Mon, 18 Sep 2017 16:42:10 -0600
Download (untitled) / with headers
text/plain 6.8k
This is a bug report for perl from atoomic@cpan.org,
generated with the help of perlbug 1.40 running under perl 5.24.1.


-----------------------------------------------------------------
Can probably find a better name for the helper, but the idea is to get rid of the common boilerplate: 
CvNAMED(sv) ? CvNAME_HEK((CV *)sv) : GvNAME_HEK(CvGV(sv))
by using the CvGvNAME_HEK helper.

Note that this is saving an extra CvNAMED check from CvNAME_HEK.
-----------------------------------------------------------------
---
Flags:
    category=core
    severity=low
---
Site configuration information for perl 5.24.1:

Configured by cPanel at Wed Sep  6 12:24:43 CDT 2017.

Summary of my perl5 (revision 5 version 24 subversion 1) configuration:
   
  Platform:
    osname=linux, osvers=3.10.0-123.20.1.el7.x86_64, archname=x86_64-linux-64int
    uname='linux rpmbuild-64-centos-7.dev.cpanel.net 3.10.0-123.20.1.el7.x86_64 #1 smp thu jan 29 18:05:33 utc 2015 x86_64 x86_64 x86_64 gnulinux '
    config_args='-des -Dusedevel -Darchname=x86_64-linux-64int -Dcc=/usr/bin/gcc -Dcpp=/usr/bin/cpp -Dusemymalloc=n -DDEBUGGING=none -Doptimize=-Os -Accflags=-m64 -Dccflags=-DPERL_DISABLE_PMC -fPIC -DPIC -I/usr/local/cpanel/3rdparty/perl/524/include -L/usr/local/cpanel/3rdparty/perl/524/lib64 -I/usr/local/cpanel/3rdparty/include -L/usr/local/cpanel/3rdparty/lib64 -Duseshrplib -Duselargefiles=yes -Duseposix=true -Dhint=recommended -Duseperlio=yes -Dcppflags=-I/usr/local/cpanel/3rdparty/perl/524/include -L/usr/local/cpanel/3rdparty/perl/524/lib64 -I/usr/local/cpanel/3rdparty/include -L/usr/local/cpanel/3rdparty/lib64 -Dldflags=-Wl,-rpath -Wl,/usr/local/cpanel/3rdparty/perl/524/lib64 -L/usr/local/cpanel/3rdparty/perl/524/lib64 -L/usr/local/cpanel/3rdparty/lib64 -Dprefix=/usr/local/cpanel/3rdparty/perl/524 -Dsiteprefix=/opt/cpanel/perl5/524 -Dsitebin=/opt/cpanel/perl5/524/bin -Dsitelib=/opt/cpanel/perl5/524/site_lib -Dusevendorprefix=true -Dvendorbin=/usr/local/cpanel/3rdparty/perl/524/bin -Dvendorprefix=/usr/local/cpanel/3rdparty/perl/524/lib64/perl5 -Dvendorlib=/usr/local/cpanel/3rdparty/perl/524/lib64/perl5/cpanel_lib -Dprivlib=/usr/local/cpanel/3rdparty/perl/524/lib64/perl5/5.24.1 -Dman1dir=none -Dman3dir=none -Dscriptdir=/usr/local/cpanel/3rdparty/perl/524/bin -Dscriptdirexp=/usr/local/cpanel/3rdparty/perl/524/bin -Dsiteman1dir=none -Dsiteman3dir=none -Dinstallman1dir=none -Dversiononly=no -Dinstallusrbinperl=no -Dcf_by=cPanel -Dmyhostname=localhost -Dperladmin=root@localhost -Dcf_email=support@cpanel.net -Di_dbm=/usr/local/cpanel/3rdparty/include -Di_gdbm=/usr/local/cpanel/3rdparty/include -Di_ndbm=/usr/local/cpanel/3rdparty/include -DDB_File=true -Ud_dosuid -Uuserelocatableinc -Umad -Uusethreads -Uusemultiplicity -Uusesocks -Uuselongdouble -Aldflags=-L/usr/local/cpanel/3rdparty/perl/524/lib64 -L/usr/local/cpanel/3rdparty/lib64 -L/usr/lib64 -L/lib64 -lgdbm -Dlocincpth=/usr/local/cpanel/3rdparty/perl/524/include /usr/local/cpanel/3rdparty/include /usr/local/include  -Duse64bitint -Uuse64bitall -Dlibpth=/usr/local/cpanel/3rdparty/perl/524/lib64 /usr/local/cpanel/3rdparty/lib64 /usr/local/lib64 /usr/local/lib /lib64 /usr/lib64 '
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=undef, usemultiplicity=undef
    use64bitint=define, use64bitall=undef, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='/usr/bin/gcc', ccflags ='-DPERL_DISABLE_PMC -fPIC -DPIC -I/usr/local/cpanel/3rdparty/perl/524/include -L/usr/local/cpanel/3rdparty/perl/524/lib64 -I/usr/local/cpanel/3rdparty/include -L/usr/local/cpanel/3rdparty/lib64 -m64 -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2',
    optimize='-Os',
    cppflags='-I/usr/local/cpanel/3rdparty/perl/524/include -L/usr/local/cpanel/3rdparty/perl/524/lib64 -I/usr/local/cpanel/3rdparty/include -L/usr/local/cpanel/3rdparty/lib64 -DPERL_DISABLE_PMC -fPIC -DPIC -I/usr/local/cpanel/3rdparty/perl/524/include -L/usr/local/cpanel/3rdparty/perl/524/lib64 -I/usr/local/cpanel/3rdparty/include -L/usr/local/cpanel/3rdparty/lib64 -m64 -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
    ccversion='', gccversion='4.8.2 20140120 (Red Hat 4.8.2-16)', gccosandvers=''
    intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678, doublekind=3
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, longdblkind=3
    ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='/usr/bin/gcc', ldflags ='-Wl,-rpath -Wl,/usr/local/cpanel/3rdparty/perl/524/lib64 -L/usr/local/cpanel/3rdparty/perl/524/lib64 -L/usr/local/cpanel/3rdparty/lib64 -L/usr/local/cpanel/3rdparty/perl/524/lib64 -L/usr/local/cpanel/3rdparty/lib64 -L/usr/lib64 -L/lib64 -lgdbm -fstack-protector-strong -L/usr/local/lib'
    libpth=/usr/local/cpanel/3rdparty/perl/524/lib64 /usr/local/cpanel/3rdparty/lib64 /usr/local/lib64 /usr/local/lib /lib64 /usr/lib64 /usr/local/lib /usr/lib /lib/../lib64 /usr/lib/../lib64 /lib
    libs=-lpthread -lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc -lgdbm_compat
    perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
    libc=libc-2.17.so, so=so, useshrplib=true, libperl=libperl.so
    gnulibc_version='2.17'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E -Wl,-rpath,/usr/local/cpanel/3rdparty/perl/524/lib64/perl5/5.24.1/x86_64-linux-64int/CORE'
    cccdlflags='-fPIC', lddlflags='-shared -Os -L/usr/local/cpanel/3rdparty/perl/524/lib64 -L/usr/local/cpanel/3rdparty/lib64 -L/usr/lib64 -L/lib64 -L/usr/local/lib -fstack-protector-strong'

Locally applied patches:
    RC3
    cPanel patches
    cPanel INC path changes
    Remove . from @INC

---
@INC for perl 5.24.1:
    /root/.dotfiles/perl-must-have/lib
    /root/perl5/lib/perl5/
    /usr/local/cpanel
    /usr/local/cpanel/3rdparty/perl/524/lib64/perl5/cpanel_lib/x86_64-linux-64int
    /usr/local/cpanel/3rdparty/perl/524/lib64/perl5/cpanel_lib
    /usr/local/cpanel/3rdparty/perl/524/lib64/perl5/5.24.1/x86_64-linux-64int
    /usr/local/cpanel/3rdparty/perl/524/lib64/perl5/5.24.1
    /opt/cpanel/perl5/524/site_lib/x86_64-linux-64int
    /opt/cpanel/perl5/524/site_lib

---
Environment for perl 5.24.1:
    HOME=/root
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/usr/local/cpanel/3rdparty/perl/526/bin:/usr/local/cpanel/3rdparty/perl/524/bin:/usr/local/cpanel/3rdparty/perl/522/bin:/usr/local/cpanel/3rdparty/perl/514/bin:/usr/local/cpanel/3rdparty/bin:/root/bin/:/opt/local/bin:/opt/local/sbin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/opt/cpanel/composer/bin:/root/.dotfiles/bin:/root/perl5/bin:/root/.rvm/bin:/root/bin
    PERL5DB=use Devel::NYTProf
    PERL5LIB=/root/.dotfiles/perl-must-have/lib::/root/perl5/lib/perl5/
    PERL_BADLANG (unset)
    PERL_CPANM_OPT=--quiet
    SHELL=/bin/bash

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 7.3k
better with the patch, which can also be read online at https://github.com/atoomic/perl5/commit/598e5c49475d99cc3ca0d0364b342c91cabd9fc2 On Mon, 18 Sep 2017 15:42:28 -0700, atoomic@cpan.org wrote: Show quoted text
> This is a bug report for perl from atoomic@cpan.org, > generated with the help of perlbug 1.40 running under perl 5.24.1. > > > ----------------------------------------------------------------- > Can probably find a better name for the helper, but the idea is to get > rid > of the common boilerplate: > CvNAMED(sv) ? CvNAME_HEK((CV *)sv) : GvNAME_HEK(CvGV(sv)) > by using the CvGvNAME_HEK helper. > > Note that this is saving an extra CvNAMED check from CvNAME_HEK. > ----------------------------------------------------------------- > --- > Flags: > category=core > severity=low > --- > Site configuration information for perl 5.24.1: > > Configured by cPanel at Wed Sep 6 12:24:43 CDT 2017. > > Summary of my perl5 (revision 5 version 24 subversion 1) > configuration: > > Platform: > osname=linux, osvers=3.10.0-123.20.1.el7.x86_64, > archname=x86_64-linux-64int > uname='linux rpmbuild-64-centos-7.dev.cpanel.net > 3.10.0-123.20.1.el7.x86_64 #1 smp thu jan 29 18:05:33 utc 2015 x86_64 > x86_64 x86_64 gnulinux ' > config_args='-des -Dusedevel -Darchname=x86_64-linux-64int > -Dcc=/usr/bin/gcc -Dcpp=/usr/bin/cpp -Dusemymalloc=n -DDEBUGGING=none > -Doptimize=-Os -Accflags=-m64 -Dccflags=-DPERL_DISABLE_PMC -fPIC -DPIC > -I/usr/local/cpanel/3rdparty/perl/524/include > -L/usr/local/cpanel/3rdparty/perl/524/lib64 > -I/usr/local/cpanel/3rdparty/include > -L/usr/local/cpanel/3rdparty/lib64 > -Duseshrplib -Duselargefiles=yes -Duseposix=true -Dhint=recommended > -Duseperlio=yes -Dcppflags=- > I/usr/local/cpanel/3rdparty/perl/524/include > -L/usr/local/cpanel/3rdparty/perl/524/lib64 > -I/usr/local/cpanel/3rdparty/include > -L/usr/local/cpanel/3rdparty/lib64 > -Dldflags=-Wl,-rpath -Wl,/usr/local/cpanel/3rdparty/perl/524/lib64 > -L/usr/local/cpanel/3rdparty/perl/524/lib64 > -L/usr/local/cpanel/3rdparty/lib64 > -Dprefix=/usr/local/cpanel/3rdparty/perl/524 > -Dsiteprefix=/opt/cpanel/perl5/524 -Dsitebin=/opt/cpanel/perl5/524/bin > -Dsitelib=/opt/cpanel/perl5/524/site_lib -Dusevendorprefix=true > -Dvendorbin=/usr/local/cpanel/3rdparty/perl/524/bin > -Dvendorprefix=/usr/local/cpanel/3rdparty/perl/524/lib64/perl5 > -Dvendorlib=/usr/local/cpanel/3rdparty/perl/524/lib64/perl5/cpanel_lib > -Dprivlib=/usr/local/cpanel/3rdparty/perl/524/lib64/perl5/5.24.1 > -Dman1dir=none -Dman3dir=none > -Dscriptdir=/usr/local/cpanel/3rdparty/perl/524/bin > -Dscriptdirexp=/usr/local/cpanel/3rdparty/perl/524/bin > -Dsiteman1dir=none > -Dsiteman3dir=none -Dinstallman1dir=none -Dversiononly=no > -Dinstallusrbinperl=no -Dcf_by=cPanel -Dmyhostname=localhost > -Dperladmin=root@localhost -Dcf_email=support@cpanel.net > -Di_dbm=/usr/local/cpanel/3rdparty/include > -Di_gdbm=/usr/local/cpanel/3rdparty/include > -Di_ndbm=/usr/local/cpanel/3rdparty/include -DDB_File=true -Ud_dosuid > -Uuserelocatableinc -Umad -Uusethreads -Uusemultiplicity -Uusesocks > -Uuselongdouble -Aldflags=-L/usr/local/cpanel/3rdparty/perl/524/lib64 > -L/usr/local/cpanel/3rdparty/lib64 -L/usr/lib64 -L/lib64 -lgdbm > -Dlocincpth=/usr/local/cpanel/3rdparty/perl/524/include > /usr/local/cpanel/3rdparty/include /usr/local/include -Duse64bitint > -Uuse64bitall -Dlibpth=/usr/local/cpanel/3rdparty/perl/524/lib64 > /usr/local/cpanel/3rdparty/lib64 /usr/local/lib64 /usr/local/lib > /lib64 > /usr/lib64 ' > hint=recommended, useposix=true, d_sigaction=define > useithreads=undef, usemultiplicity=undef > use64bitint=define, use64bitall=undef, uselongdouble=undef > usemymalloc=n, bincompat5005=undef > Compiler: > cc='/usr/bin/gcc', ccflags ='-DPERL_DISABLE_PMC -fPIC -DPIC > -I/usr/local/cpanel/3rdparty/perl/524/include > -L/usr/local/cpanel/3rdparty/perl/524/lib64 > -I/usr/local/cpanel/3rdparty/include > -L/usr/local/cpanel/3rdparty/lib64 > -m64 -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong > -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 > -D_FORTIFY_SOURCE=2', > optimize='-Os', > cppflags='-I/usr/local/cpanel/3rdparty/perl/524/include > -L/usr/local/cpanel/3rdparty/perl/524/lib64 > -I/usr/local/cpanel/3rdparty/include > -L/usr/local/cpanel/3rdparty/lib64 > -DPERL_DISABLE_PMC -fPIC -DPIC > -I/usr/local/cpanel/3rdparty/perl/524/include > -L/usr/local/cpanel/3rdparty/perl/524/lib64 > -I/usr/local/cpanel/3rdparty/include > -L/usr/local/cpanel/3rdparty/lib64 > -m64 -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong > -I/usr/local/include' > ccversion='', gccversion='4.8.2 20140120 (Red Hat 4.8.2-16)', > gccosandvers='' > intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678, > doublekind=3 > d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, > longdblkind=3 > ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', > lseeksize=8 > alignbytes=8, prototype=define > Linker and Libraries: > ld='/usr/bin/gcc', ldflags ='-Wl,-rpath > -Wl,/usr/local/cpanel/3rdparty/perl/524/lib64 > -L/usr/local/cpanel/3rdparty/perl/524/lib64 > -L/usr/local/cpanel/3rdparty/lib64 > -L/usr/local/cpanel/3rdparty/perl/524/lib64 > -L/usr/local/cpanel/3rdparty/lib64 -L/usr/lib64 -L/lib64 -lgdbm > -fstack-protector-strong -L/usr/local/lib' > libpth=/usr/local/cpanel/3rdparty/perl/524/lib64 > /usr/local/cpanel/3rdparty/lib64 /usr/local/lib64 /usr/local/lib > /lib64 > /usr/lib64 /usr/local/lib /usr/lib /lib/../lib64 /usr/lib/../lib64 > /lib > libs=-lpthread -lnsl -lgdbm -ldb -ldl -lm -lcrypt -lutil -lc > -lgdbm_compat > perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc > libc=libc-2.17.so, so=so, useshrplib=true, libperl=libperl.so > gnulibc_version='2.17' > Dynamic Linking: > dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E > -Wl,- > rpath,/usr/local/cpanel/3rdparty/perl/524/lib64/perl5/5.24.1/x86_64- > linux-64int/CORE' > cccdlflags='-fPIC', lddlflags='-shared -Os > -L/usr/local/cpanel/3rdparty/perl/524/lib64 > -L/usr/local/cpanel/3rdparty/lib64 -L/usr/lib64 -L/lib64 > -L/usr/local/lib > -fstack-protector-strong' > > Locally applied patches: > RC3 > cPanel patches > cPanel INC path changes > Remove . from @INC > > --- > @INC for perl 5.24.1: > /root/.dotfiles/perl-must-have/lib > /root/perl5/lib/perl5/ > /usr/local/cpanel > > /usr/local/cpanel/3rdparty/perl/524/lib64/perl5/cpanel_lib/x86_64- > linux-64int > /usr/local/cpanel/3rdparty/perl/524/lib64/perl5/cpanel_lib > > /usr/local/cpanel/3rdparty/perl/524/lib64/perl5/5.24.1/x86_64-linux- > 64int > /usr/local/cpanel/3rdparty/perl/524/lib64/perl5/5.24.1 > /opt/cpanel/perl5/524/site_lib/x86_64-linux-64int > /opt/cpanel/perl5/524/site_lib > > --- > Environment for perl 5.24.1: > HOME=/root > LANG=en_US.UTF-8 > LANGUAGE (unset) > LD_LIBRARY_PATH (unset) > LOGDIR (unset) > > PATH=/usr/local/cpanel/3rdparty/perl/526/bin:/usr/local/cpanel/3rdparty/perl/524/bin:/usr/local/cpanel/3rdparty/perl/522/bin:/usr/local/cpanel/3rdparty/perl/514/bin:/usr/local/cpanel/3rdparty/bin:/root/bin/:/opt/local/bin:/opt/local/sbin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/opt/cpanel/composer/bin:/root/.dotfiles/bin:/root/perl5/bin:/root/.rvm/bin:/root/bin > PERL5DB=use Devel::NYTProf > PERL5LIB=/root/.dotfiles/perl-must- > have/lib::/root/perl5/lib/perl5/ > PERL_BADLANG (unset) > PERL_CPANM_OPT=--quiet > SHELL=/bin/bash
Subject: 0001-Add-CvGvNAME_HEK-helper.patch
From 598e5c49475d99cc3ca0d0364b342c91cabd9fc2 Mon Sep 17 00:00:00 2001 From: Nicolas R <atoomic@cpan.org> Date: Mon, 18 Sep 2017 14:37:48 -0600 Subject: [PATCH] Add CvGvNAME_HEK helper CvGvNAME_HEK can be used instead of the boilerplate: CvNAMED(sv) ? CvNAME_HEK((CV *)sv) : GvNAME_HEK(CvGV(sv)) This is also saving an extra CvNAMED check from CvNAME_HEK. --- cv.h | 12 +++++++++++- gv.c | 3 +-- scope.c | 9 ++------- 3 files changed, 14 insertions(+), 10 deletions(-) diff --git a/cv.h b/cv.h index ebbdd360f3..dac83fa873 100644 --- a/cv.h +++ b/cv.h @@ -234,7 +234,17 @@ CvNAME_HEK(CV *sv) ? ((XPVCV*)MUTABLE_PTR(SvANY(sv)))->xcv_gv_u.xcv_hek : 0; } -/* This lowers the refernce count of the previous value, but does *not* + +/* helper for the common pattern: + CvNAMED(sv) ? CvNAME_HEK((CV *)sv) : GvNAME_HEK(CvGV(sv)) +*/ +#define CvGvNAME_HEK(sv) ( \ + CvNAMED((CV*)sv) ? \ + ((XPVCV*)MUTABLE_PTR(SvANY((SV*)sv)))->xcv_gv_u.xcv_hek\ + : GvNAME_HEK(CvGV( (SV*) sv)) \ + ) + +/* This lowers the reference count of the previous value, but does *not* increment the reference count of the new value. */ #define CvNAME_HEK_set(cv, hek) ( \ CvNAME_HEK((CV *)(cv)) \ diff --git a/gv.c b/gv.c index cfe4be572c..6df78cc013 100644 --- a/gv.c +++ b/gv.c @@ -2799,8 +2799,7 @@ Perl_Gv_AMupdate(pTHX_ HV *stash, bool destructing) gv = Perl_gv_fetchmeth_pvn(aTHX_ stash, cooky, l, -1, 0); cv = 0; if (gv && (cv = GvCV(gv)) && CvHASGV(cv)) { - const HEK * const gvhek = - CvNAMED(cv) ? CvNAME_HEK(cv) : GvNAME_HEK(CvGV(cv)); + const HEK * const gvhek = CvGvNAME_HEK(cv); const HEK * const stashek = HvNAME_HEK(CvNAMED(cv) ? CvSTASH(cv) : GvSTASH(CvGV(cv))); if (HEK_LEN(gvhek) == 3 && strEQ(HEK_KEY(gvhek), "nil") diff --git a/scope.c b/scope.c index 59cea3b985..dfaab806aa 100644 --- a/scope.c +++ b/scope.c @@ -1194,10 +1194,7 @@ Perl_leave_scope(pTHX_ I32 base) break; case SVt_PVCV: { - HEK *hek = - CvNAMED(sv) - ? CvNAME_HEK((CV *)sv) - : GvNAME_HEK(CvGV(sv)); + HEK *hek = CvGvNAME_HEK(sv); assert(hek); (void)share_hek_hek(hek); cv_undef((CV *)sv); @@ -1223,9 +1220,7 @@ Perl_leave_scope(pTHX_ I32 base) case SVt_PVHV: *svp = MUTABLE_SV(newHV()); break; case SVt_PVCV: { - HEK * const hek = CvNAMED(sv) - ? CvNAME_HEK((CV *)sv) - : GvNAME_HEK(CvGV(sv)); + HEK * const hek = CvGvNAME_HEK(sv); /* Create a stub */ *svp = newSV_type(SVt_PVCV); -- 2.14.1
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 251b
On Mon, 18 Sep 2017 15:57:00 -0700, atoomic wrote: Show quoted text
> better with the patch, which can also be read online at > https://github.com/atoomic/perl5/commit/598e5c49475d99cc3ca0d0364b342c91cabd9fc2
Thank you. Applied as 7965633. -- Father Chrysostomos


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org