Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aliased named parameters broke in a recent MoarVM commit #6432

Closed
p6rt opened this issue Aug 8, 2017 · 5 comments
Closed

Aliased named parameters broke in a recent MoarVM commit #6432

p6rt opened this issue Aug 8, 2017 · 5 comments
Labels
regression Issue did not exist previously

Comments

@p6rt
Copy link

p6rt commented Aug 8, 2017

Migrated from rt.perl.org#131857 (status was 'resolved')

Searchable as RT131857$

@p6rt
Copy link
Author

p6rt commented Aug 8, 2017

From @MasterDuke17

[22​:44] <MasterDuke> m​: sub foo(​:color(​:$colour)) { $colour + 1 }; my $s;
for ^1000000 { $s += foo(​:color($_)) }; say $s; say now - INIT now
[22​:44] <+camelia> rakudo-moar a91ad2​: OUTPUT​: «Unexpected named argument
'color' passed␤ in sub foo at <tmp> line 1␤ in block <unit> at <tmp> line
1␤␤»
[22​:44] <MasterDuke> bisectable6​: sub foo(​:color(​:$colour)) { $colour + 1
}; my $s; for ^1000000 { $s += foo(​:color($_)) }; say $s;
[22​:44] <+bisectable6> MasterDuke, Bisecting by exit code (old=2015.12
new=a91ad2d). Old exit code​: 0
[22​:44] <+bisectable6> MasterDuke, bisect log​:
https://gist.github.com/651d00f77245537de7326c9316f4513e
[22​:44] <+bisectable6> MasterDuke, (2017-08-04)
rakudo/rakudo@8bed4a6
[22​:45] <Zoffix> haw
[22​:45] <MasterDuke> c​: 2017.07 sub foo(​:color(​:$colour)) { $colour + 1 };
my $s; for ^1000000 { $s += foo(​:color($_)) }; say $s; say now - INIT now
[22​:45] <+committable6> MasterDuke, ¦2017.07​: «500000500000␤1.4953885»

@p6rt
Copy link
Author

p6rt commented Aug 14, 2017

From @AlexDaniel

No bug with MVM_SPESH_DISABLE=1.

On 2017-08-07 19​:48​:36, ddgreen@​gmail.com wrote​:

[22​:44] <MasterDuke> m​: sub foo(​:color(​:$colour)) { $colour + 1 }; my
$s;
for ^1000000 { $s += foo(​:color($_)) }; say $s; say now - INIT now
[22​:44] <+camelia> rakudo-moar a91ad2​: OUTPUT​: «Unexpected named
argument
'color' passed␤ in sub foo at <tmp> line 1␤ in block <unit> at <tmp>
line
1␤␤»
[22​:44] <MasterDuke> bisectable6​: sub foo(​:color(​:$colour)) { $colour
+ 1
}; my $s; for ^1000000 { $s += foo(​:color($_)) }; say $s;
[22​:44] <+bisectable6> MasterDuke, Bisecting by exit code (old=2015.12
new=a91ad2d). Old exit code​: 0
[22​:44] <+bisectable6> MasterDuke, bisect log​:
https://gist.github.com/651d00f77245537de7326c9316f4513e
[22​:44] <+bisectable6> MasterDuke, (2017-08-04)
rakudo/rakudo@8bed4a6
[22​:45] <Zoffix> haw
[22​:45] <MasterDuke> c​: 2017.07 sub foo(​:color(​:$colour)) { $colour +
1 };
my $s; for ^1000000 { $s += foo(​:color($_)) }; say $s; say now - INIT
now
[22​:45] <+committable6> MasterDuke, ¦2017.07​: «500000500000␤1.4953885»

@p6rt
Copy link
Author

p6rt commented Aug 14, 2017

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Aug 17, 2017

From @jnthn

On Mon, 07 Aug 2017 19​:48​:36 -0700, ddgreen@​gmail.com wrote​:

[22​:44] <MasterDuke> m​: sub foo(​:color(​:$colour)) { $colour + 1 }; my
$s;
for ^1000000 { $s += foo(​:color($_)) }; say $s; say now - INIT now
[22​:44] <+camelia> rakudo-moar a91ad2​: OUTPUT​: «Unexpected named
argument
'color' passed␤ in sub foo at <tmp> line 1␤ in block <unit> at <tmp>
line
1␤␤»
[22​:44] <MasterDuke> bisectable6​: sub foo(​:color(​:$colour)) { $colour
+ 1
}; my $s; for ^1000000 { $s += foo(​:color($_)) }; say $s;
[22​:44] <+bisectable6> MasterDuke, Bisecting by exit code (old=2015.12
new=a91ad2d). Old exit code​: 0
[22​:44] <+bisectable6> MasterDuke, bisect log​:
https://gist.github.com/651d00f77245537de7326c9316f4513e
[22​:44] <+bisectable6> MasterDuke, (2017-08-04)
rakudo/rakudo@8bed4a6
[22​:45] <Zoffix> haw
[22​:45] <MasterDuke> c​: 2017.07 sub foo(​:color(​:$colour)) { $colour +
1 };
my $s; for ^1000000 { $s += foo(​:color($_)) }; say $s; say now - INIT
now
[22​:45] <+committable6> MasterDuke, ¦2017.07​: «500000500000␤1.4953885»

Fixed; test in S06-signature/named-parameters.t.

@p6rt
Copy link
Author

p6rt commented Aug 17, 2017

@jnthn - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Aug 17, 2017
@p6rt p6rt added the regression Issue did not exist previously label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Issue did not exist previously
Projects
None yet
Development

No branches or pull requests

1 participant