Skip Menu |
Report information
Id: 131851
Status: resolved
Priority: 0/
Queue: perl5

Owner: Nobody
Requestors: jkeenan [at] pobox.com
Cc:
AdminCc:

Operating System: (no value)
PatchStatus: (no value)
Severity: low
Type: BBC
Perl Version: 5.27.3
Fixed In: (no value)



Subject: Blead breaks Text-Diff-1.44
From: James E Keenan <jkeenan [...] pobox.com>
To: perlbug [...] perl.org
Date: Mon, 7 Aug 2017 09:11:38 -0400
CC: Carlos Guevara <carlos [...] carlosguevara.com>
Download (untitled) / with headers
text/plain 1009b
A recent commit to Perl 5 blead has broken CPAN module Text::Diff version 1.44. This was called to my attention by Carlos Guevara; see, e.g., http://fast-matrix.cpantesters.org/?dist=Text%3A%3ADiff. No errors were observed at fde84d2e7. Errors observed at d819dc50 were: ##### $ ~/testing/blead/bin/prove -I~/testing/blead/lib -vb t/outputs.t t/outputs.t .. 1..8 # Running under perl version 5.027003 for linux # Current time local: Mon Aug 7 09:02:37 2017 # Current time GMT: Mon Aug 7 13:02:37 2017 # Using Test.pm version 1.30 ok 1 ok 2 ok 3 ok 4 ok 5 not ok 6 ok 7 ok 8 # Failed test 6 in t/outputs.t at line 54 # t/outputs.t line 54 is: ok 0 < index( diff( \"\n", \"", { STYLE => "Table" } ), "\\n" ); Failed 1/8 subtests Test Summary Report ------------------- t/outputs.t (Wstat: 0 Tests: 8 Failed: 1) Failed test: 6 Files=1, Tests=8, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.02 cusr 0.00 csys = 0.04 CPU) Result: FAIL ##### Not yet bisected. Thank you very much. Jim Keenan
Download perl_V.txt
text/plain 3.1k

Message body is not shown because sender requested not to inline it.

To: perl5-porters [...] perl.org
Date: Mon, 7 Aug 2017 17:36:55 +0100
Subject: Re: [perl #131851] Blead breaks Text-Diff-1.44
From: Dave Mitchell <davem [...] iabyn.com>
Download (untitled) / with headers
text/plain 1.4k
On Mon, Aug 07, 2017 at 06:12:02AM -0700, James E Keenan wrote: Show quoted text
> A recent commit to Perl 5 blead has broken CPAN module Text::Diff > version 1.44. > > This was called to my attention by Carlos Guevara; see, e.g., > http://fast-matrix.cpantesters.org/?dist=Text%3A%3ADiff. > > No errors were observed at fde84d2e7. Errors observed at d819dc50 were: > > ##### > $ ~/testing/blead/bin/prove -I~/testing/blead/lib -vb t/outputs.t > t/outputs.t .. > 1..8 > # Running under perl version 5.027003 for linux > # Current time local: Mon Aug 7 09:02:37 2017 > # Current time GMT: Mon Aug 7 13:02:37 2017 > # Using Test.pm version 1.30 > ok 1 > ok 2 > ok 3 > ok 4 > ok 5 > not ok 6 > ok 7 > ok 8 > # Failed test 6 in t/outputs.t at line 54 > # t/outputs.t line 54 is: ok 0 < index( diff( \"\n", \"", { STYLE => > "Table" } ), "\\n" ); > Failed 1/8 subtests
should be fixed by the following: commit 25f3319bf6686f1a93fcce9f236055c69200c9ea Author: David Mitchell <davem@iabyn.com> AuthorDate: Mon Aug 7 16:58:11 2017 +0100 Commit: David Mitchell <davem@iabyn.com> CommitDate: Mon Aug 7 17:11:44 2017 +0100 fix index(...) == -1 type optimisations RT #131851 It was incorrectly optimising some permutations of comparison op and 0/-1 which shouldn't have been, such as 0 < index(...); -- Please note that ash-trays are provided for the use of smokers, whereas the floor is provided for the use of all patrons. -- Bill Royston
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 1.8k
On Mon, 07 Aug 2017 16:37:50 GMT, davem wrote: Show quoted text
> On Mon, Aug 07, 2017 at 06:12:02AM -0700, James E Keenan wrote:
> > A recent commit to Perl 5 blead has broken CPAN module Text::Diff > > version 1.44. > > > > This was called to my attention by Carlos Guevara; see, e.g., > > http://fast-matrix.cpantesters.org/?dist=Text%3A%3ADiff. > > > > No errors were observed at fde84d2e7. Errors observed at d819dc50 > > were: > > > > ##### > > $ ~/testing/blead/bin/prove -I~/testing/blead/lib -vb t/outputs.t > > t/outputs.t .. > > 1..8 > > # Running under perl version 5.027003 for linux > > # Current time local: Mon Aug 7 09:02:37 2017 > > # Current time GMT: Mon Aug 7 13:02:37 2017 > > # Using Test.pm version 1.30 > > ok 1 > > ok 2 > > ok 3 > > ok 4 > > ok 5 > > not ok 6 > > ok 7 > > ok 8 > > # Failed test 6 in t/outputs.t at line 54 > > # t/outputs.t line 54 is: ok 0 < index( diff( \"\n", > > \"", { STYLE => > > "Table" } ), "\\n" ); > > Failed 1/8 subtests
> > should be fixed by the following: > > commit 25f3319bf6686f1a93fcce9f236055c69200c9ea > Author: David Mitchell <davem@iabyn.com> > AuthorDate: Mon Aug 7 16:58:11 2017 +0100 > Commit: David Mitchell <davem@iabyn.com> > CommitDate: Mon Aug 7 17:11:44 2017 +0100 > > fix index(...) == -1 type optimisations > > RT #131851 > > It was incorrectly optimising some permutations of comparison op and > 0/-1 > which shouldn't have been, such as > > 0 < index(...);
Confirmed at commit 13f60a0: ##### Building and testing Text-Diff-1.44 ... cp lib/Text/Diff.pm blib/lib/Text/Diff.pm ... t/outputs.t ..... ok t/table.t ....... ok All tests successful. Files=9, Tests=33, 0 wallclock secs ( 0.04 usr 0.00 sys + 0.17 cusr 0.01 csys = 0.22 CPU) Result: PASS ... Successfully installed Text-Diff-1.44 ##### Marking ticket Resolved. Thank you very much. -- James E Keenan (jkeenan@cpan.org)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org