Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release of Storable on CPAN is very out of date; needs release to be in sync with blead #16068

Closed
p5pRT opened this issue Jul 7, 2017 · 15 comments

Comments

@p5pRT
Copy link

p5pRT commented Jul 7, 2017

Migrated from rt.perl.org#131715 (status was 'resolved')

Searchable as RT131715$

@p5pRT
Copy link
Author

p5pRT commented Jul 7, 2017

From @karenetheridge

Storable is listed in 06perms as upstream-cpan. The latest release of
Storable on CPAN is version 2.51, which has been out of date respective to
blead since version 5.21.7 (three years ago!). The version in blead today
is 2.63, containing numerous bug fixes.

Moreover, Storable is forward-compatible with its serialization but it does
not promise to be backwards-compatible, meaning anything serialized with
Storable in a later version of perl cannot then be deserialized on another
system running an earlier version of perl. The lack of recent updates on
CPAN means that there is *nothing* that these systems can do, except
downgrade their perl.

Please, could someone holding the keys to the P5P PAUSE account (which has
comaint on this distribution) please make an update to CPAN?

@p5pRT
Copy link
Author

p5pRT commented Jul 7, 2017

From @karenetheridge

On Fri, 07 Jul 2017 12​:35​:01 -0700, perl@​froods.org wrote​:

Moreover, Storable is forward-compatible with its serialization but it does
not promise to be backwards-compatible

I think I got that terminology backwards. but my intent is clear from context.

A corollary of this issue is it's clear we have no porting test that checks that (supposedly) upstream-cpan modules don't get updated to keep pace with changes in blead. But that's far less urgent than seeing Storable get its necessary updates ASAP.

@p5pRT
Copy link
Author

p5pRT commented Jul 7, 2017

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Jul 7, 2017

From @jkeenan

On Fri, 07 Jul 2017 20​:14​:32 GMT, ether wrote​:

On Fri, 07 Jul 2017 12​:35​:01 -0700, perl@​froods.org wrote​:

Moreover, Storable is forward-compatible with its serialization but
it does
not promise to be backwards-compatible

I think I got that terminology backwards. but my intent is clear from
context.

A corollary of this issue is it's clear we have no porting test that
checks that (supposedly) upstream-cpan modules don't get updated to
keep pace with changes in blead. But that's far less urgent than
seeing Storable get its necessary updates ASAP.

Hmm, there appears to be a discrepancy between what PAUSE thinks about Storable and what the core distribution (as represented by Porting/Maintainers.pl) thinks about Storable​:

#####
  'Storable' => {
  'DISTRIBUTION' => 'AMS/Storable-2.51.tar.gz',
  'FILES' => q[dist/Storable],
  'EXCLUDED' => [
  qr{^t/compat/},
  ],
  },
#####

So P5P thinks Storable is blead-upstream ... but I doubt any current Porter is thinking of him/herself as the maintainer of Storable. Any XS-knowledgable volunteers?

Thank you very much.
--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Jul 7, 2017

From @karenetheridge

On Fri, 07 Jul 2017 13​:50​:04 -0700, jkeenan wrote​:

Hmm, there appears to be a discrepancy between what PAUSE thinks about
Storable and what the core distribution (as represented by
Porting/Maintainers.pl) thinks about Storable​:

Porting/Maintainers.pl correctly says that the latest cpan release is 2.51.
All that is needed presently is to release the latest changes from blead (2.63)
using the P5P PAUSE account.

I've done the updates in my github repository (for a lack of finding the original repo)​:
https://github.com/karenetheridge/Storable
...since I need to create a distribution for my $work darkpan anyway.

@p5pRT
Copy link
Author

p5pRT commented Jul 7, 2017

From @karenetheridge

On Fri, 07 Jul 2017 14​:41​:50 -0700, ether wrote​:

On Fri, 07 Jul 2017 13​:50​:04 -0700, jkeenan wrote​:

Hmm, there appears to be a discrepancy between what PAUSE thinks
about
Storable and what the core distribution (as represented by
Porting/Maintainers.pl) thinks about Storable​:

Porting/Maintainers.pl correctly says that the latest cpan release is
2.51.
All that is needed presently is to release the latest changes from
blead (2.63)
using the P5P PAUSE account.

belay that... the latest changes to Storable use the new macro SvPVCLEAR (added in 5.27.0),
which currently has no entry in ppport.h -- so Devel​::PPPort needs to be updated as well
to include a back-compatible version.

@p5pRT
Copy link
Author

p5pRT commented Jun 27, 2018

From @karenetheridge

This ticket should be revisited now that 5.28.0 is out, and there have been some recent Storable releases to CPAN as well.

@p5pRT
Copy link
Author

p5pRT commented Jun 28, 2018

From @xsawyerx

On Wed, 27 Jun 2018 16​:55​:34 -0700, ether wrote​:

This ticket should be revisited now that 5.28.0 is out, and there have
been some recent Storable releases to CPAN as well.

I think the original intent of this ticket (releasing Storable to CPAN) has been addressed, hasn't it?

What remains is backporting SvPVCLEAR to Devel​::PPPort and releasing that to CPAN?

@p5pRT
Copy link
Author

p5pRT commented Jun 29, 2018

From @haarg

On Wed, 27 Jun 2018 23​:53​:04 -0700, xsawyerx@​cpan.org wrote​:

On Wed, 27 Jun 2018 16​:55​:34 -0700, ether wrote​:

This ticket should be revisited now that 5.28.0 is out, and there
have
been some recent Storable releases to CPAN as well.

I think the original intent of this ticket (releasing Storable to
CPAN) has been addressed, hasn't it?

What remains is backporting SvPVCLEAR to Devel​::PPPort and releasing
that to CPAN?

The patch in https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133228 should also be applied.

@p5pRT
Copy link
Author

p5pRT commented Aug 11, 2018

From @xsawyerx

On 06/29/2018 01​:40 PM, Graham Knop via RT wrote​:

On Wed, 27 Jun 2018 23​:53​:04 -0700, xsawyerx@​cpan.org wrote​:

On Wed, 27 Jun 2018 16​:55​:34 -0700, ether wrote​:

This ticket should be revisited now that 5.28.0 is out, and there
have
been some recent Storable releases to CPAN as well.
I think the original intent of this ticket (releasing Storable to
CPAN) has been addressed, hasn't it?

What remains is backporting SvPVCLEAR to Devel​::PPPort and releasing
that to CPAN?
The patch in https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133228 should also be applied.

I've pushed it to smoke-me/sawyerx/fix-storable-rethrow. My testing
shows it is good on blead but we'll give it the smoking before merging.

Thanks.

1 similar comment
@p5pRT
Copy link
Author

p5pRT commented Aug 11, 2018

From @xsawyerx

On 06/29/2018 01​:40 PM, Graham Knop via RT wrote​:

On Wed, 27 Jun 2018 23​:53​:04 -0700, xsawyerx@​cpan.org wrote​:

On Wed, 27 Jun 2018 16​:55​:34 -0700, ether wrote​:

This ticket should be revisited now that 5.28.0 is out, and there
have
been some recent Storable releases to CPAN as well.
I think the original intent of this ticket (releasing Storable to
CPAN) has been addressed, hasn't it?

What remains is backporting SvPVCLEAR to Devel​::PPPort and releasing
that to CPAN?
The patch in https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133228 should also be applied.

I've pushed it to smoke-me/sawyerx/fix-storable-rethrow. My testing
shows it is good on blead but we'll give it the smoking before merging.

Thanks.

@p5pRT
Copy link
Author

p5pRT commented Aug 25, 2018

From @xsawyerx

I've now merged this branch. (Which accidentally also included a fix for
Devel​::PPPort.)

On 08/11/2018 07​:05 PM, Sawyer X wrote​:

On 06/29/2018 01​:40 PM, Graham Knop via RT wrote​:

On Wed, 27 Jun 2018 23​:53​:04 -0700, xsawyerx@​cpan.org wrote​:

On Wed, 27 Jun 2018 16​:55​:34 -0700, ether wrote​:

This ticket should be revisited now that 5.28.0 is out, and there
have
been some recent Storable releases to CPAN as well.
I think the original intent of this ticket (releasing Storable to
CPAN) has been addressed, hasn't it?

What remains is backporting SvPVCLEAR to Devel​::PPPort and releasing
that to CPAN?
The patch in https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133228 should also be applied.
I've pushed it to smoke-me/sawyerx/fix-storable-rethrow. My testing
shows it is good on blead but we'll give it the smoking before merging.

Thanks.

1 similar comment
@p5pRT
Copy link
Author

p5pRT commented Aug 25, 2018

From @xsawyerx

I've now merged this branch. (Which accidentally also included a fix for
Devel​::PPPort.)

On 08/11/2018 07​:05 PM, Sawyer X wrote​:

On 06/29/2018 01​:40 PM, Graham Knop via RT wrote​:

On Wed, 27 Jun 2018 23​:53​:04 -0700, xsawyerx@​cpan.org wrote​:

On Wed, 27 Jun 2018 16​:55​:34 -0700, ether wrote​:

This ticket should be revisited now that 5.28.0 is out, and there
have
been some recent Storable releases to CPAN as well.
I think the original intent of this ticket (releasing Storable to
CPAN) has been addressed, hasn't it?

What remains is backporting SvPVCLEAR to Devel​::PPPort and releasing
that to CPAN?
The patch in https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133228 should also be applied.
I've pushed it to smoke-me/sawyerx/fix-storable-rethrow. My testing
shows it is good on blead but we'll give it the smoking before merging.

Thanks.

@p5pRT
Copy link
Author

p5pRT commented Aug 6, 2019

From @tonycoz

On Sat, 25 Aug 2018 01​:54​:20 -0700, xsawyerx@​gmail.com wrote​:

I've now merged this branch. (Which accidentally also included a fix
for
Devel​::PPPort.)

On 08/11/2018 07​:05 PM, Sawyer X wrote​:

On 06/29/2018 01​:40 PM, Graham Knop via RT wrote​:

On Wed, 27 Jun 2018 23​:53​:04 -0700, xsawyerx@​cpan.org wrote​:

On Wed, 27 Jun 2018 16​:55​:34 -0700, ether wrote​:

This ticket should be revisited now that 5.28.0 is out, and there
have
been some recent Storable releases to CPAN as well.
I think the original intent of this ticket (releasing Storable to
CPAN) has been addressed, hasn't it?

What remains is backporting SvPVCLEAR to Devel​::PPPort and
releasing
that to CPAN?
The patch in https://rt-archive.perl.org/perl5/Ticket/Display.html?id=133228
should also be applied.
I've pushed it to smoke-me/sawyerx/fix-storable-rethrow. My testing
shows it is good on blead but we'll give it the smoking before
merging.

Thanks.

A new release was done, closing (though we might need another Soon.

Closing.

Tony

@p5pRT
Copy link
Author

p5pRT commented Aug 6, 2019

@tonycoz - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant