Skip Menu |
Report information
Id: 131561
Status: resolved
Priority: 0/
Queue: perl6

Owner: Nobody
Requestors: cpan [at] zoffix.com
Cc:
AdminCc:

Severity: (no value)
Tag: testneeded
Platform: (no value)
Patch Status: (no value)
VM: (no value)



Subject: [REGRESSION] dd (0 => 1, 0 => -1, 0 => 0).MixHash Does not delete the key
Download (untitled) / with headers
text/plain 675b
Detected by pre-release ecosystem toasting. Clifford.pm6 module currently fails due List.MixHash coercer fails to delete the key when the final weight ends up being zero: <Zoffix> c: 2017.05,HEAD dd (0 => 1, 0 => -1, 0 => 0, ).MixHash <committable6> Zoffix, ¦2017.05: «().MixHash» ¦HEAD(abfb52b): «(0=>0).MixHash» The issue only appears to happen the weights change from non-zero to zero while going through Pairs: <Zoffix> c: 2017.05,HEAD dd (0 => 0, ).MixHash <committable6> Zoffix, ¦2017.05,HEAD(abfb52b): «().MixHash» <Zoffix> c: 2017.05,HEAD dd (0 => 0, 0 => 0,).MixHash <committable6> Zoffix, ¦2017.05,HEAD(abfb52b): «().MixHash»
Subject: Re: [perl #131561] [REGRESSION] dd (0 => 1, 0 => -1, 0 => 0).MixHash Does not delete the key
To: "Zoffix Znet (via RT)" <perl6-bugs-followup [...] perl.org>
Date: Tue, 13 Jun 2017 10:13:30 +0200
From: Elizabeth Mattijsen <liz [...] dijkmat.nl>
Download (untitled) / with headers
text/plain 1.1k
Thanks for the report! Fixed with https://github.com/rakudo/rakudo/commit/bf95bcb6c0 Tests will be added shortly. Show quoted text
> On 13 Jun 2017, at 00:52, Zoffix Znet (via RT) <perl6-bugs-followup@perl.org> wrote: > > # New Ticket Created by Zoffix Znet > # Please include the string: [perl #131561] > # in the subject line of all future correspondence about this issue. > # <URL: https://rt.perl.org/Ticket/Display.html?id=131561 > > > > Detected by pre-release ecosystem toasting. > > Clifford.pm6 module currently fails due List.MixHash coercer > fails to delete the key when the final weight ends up being zero: > > <Zoffix> c: 2017.05,HEAD dd (0 => 1, 0 => -1, 0 => 0, ).MixHash > <committable6> Zoffix, ¦2017.05: «().MixHash» ¦HEAD(abfb52b): «(0=>0).MixHash» > > The issue only appears to happen the weights change from non-zero to zero while going through Pairs: > > <Zoffix> c: 2017.05,HEAD dd (0 => 0, ).MixHash > <committable6> Zoffix, ¦2017.05,HEAD(abfb52b): «().MixHash» > <Zoffix> c: 2017.05,HEAD dd (0 => 0, 0 => 0,).MixHash > <committable6> Zoffix, ¦2017.05,HEAD(abfb52b): «().MixHash»
Download (untitled) / with headers
text/plain 1.2k
On Tue, 13 Jun 2017 01:13:43 -0700, elizabeth wrote: Show quoted text
> Thanks for the report! Fixed with > https://github.com/rakudo/rakudo/commit/bf95bcb6c0 > Tests will be added shortly. >
> > On 13 Jun 2017, at 00:52, Zoffix Znet (via RT) <perl6-bugs- > > followup@perl.org> wrote: > > > > # New Ticket Created by Zoffix Znet > > # Please include the string: [perl #131561] > > # in the subject line of all future correspondence about this issue. > > # <URL: https://rt.perl.org/Ticket/Display.html?id=131561 > > > > > > > Detected by pre-release ecosystem toasting. > > > > Clifford.pm6 module currently fails due List.MixHash coercer > > fails to delete the key when the final weight ends up being zero: > > > > <Zoffix> c: 2017.05,HEAD dd (0 => 1, 0 => -1, 0 => 0, ).MixHash > > <committable6> Zoffix, ¦2017.05: «().MixHash» ¦HEAD(abfb52b): > > «(0=>0).MixHash» > > > > The issue only appears to happen the weights change from non-zero to > > zero while going through Pairs: > > > > <Zoffix> c: 2017.05,HEAD dd (0 => 0, ).MixHash > > <committable6> Zoffix, ¦2017.05,HEAD(abfb52b): «().MixHash» > > <Zoffix> c: 2017.05,HEAD dd (0 => 0, 0 => 0,).MixHash > > <committable6> Zoffix, ¦2017.05,HEAD(abfb52b): «().MixHash»
Tests have been added, resolving issue


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org