Skip Menu |
Report information
Id: 131314
Status: resolved
Priority: 0/
Queue: perl5

Owner: jkeenan <jkeenan [at] cpan.org>
Requestors: jkeenan [at] pobox.com
Cc:
AdminCc:

Operating System: (no value)
PatchStatus: (no value)
Severity: low
Type: unknown
Perl Version: (no value)
Fixed In: (no value)



Subject: "unused parameter" warning when building with g++
Date: Sun, 14 May 2017 15:24:34 -0400
To: perlbug [...] perl.org
From: James E Keenan <jkeenan [...] pobox.com>
Download (untitled) / with headers
text/plain 919b
Observed today running 'make' on perl 5 blead when compiling with: g++ --version g++ (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 $ grep -nC2 'warning:' g++.en_US.utf8.typescript 886-g++ -c -DPERL_CORE -fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -ansi -O2 -Wall -Werror=declaration-after-statement -Wextra -Wwrite-strings perlio.c 887-In file included from perlio.c:50:0: 888:XSUB.h:122:43: warning: unused parameter ‘cv’ [-Wunused-parameter] 889- #define XSPROTO(name) void name(pTHX_ CV* cv) 890- ^ -- 898- XS(XS_PerlIO__Layer__NoWarnings) 899- ^ 900:XSUB.h:122:43: warning: unused parameter ‘cv’ [-Wunused-parameter] 901- #define XSPROTO(name) void name(pTHX_ CV* cv) 902- The patch attached silences the warning. Please review (for 5.27.0). Thank you very much. Jim Keenan

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 835b
On Sun, 14 May 2017 19:24:51 GMT, jkeenan@pobox.com wrote: Show quoted text
> Observed today running 'make' on perl 5 blead when compiling with: > > g++ --version > g++ (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 > > > $ grep -nC2 'warning:' g++.en_US.utf8.typescript > 886-g++ -c -DPERL_CORE -fwrapv -fno-strict-aliasing -pipe > -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE > -D_FILE_OFFSET_BITS=64 -ansi -O2 -Wall > -Werror=declaration-after-statement -Wextra -Wwrite-strings perlio.c > 887-In file included from perlio.c:50:0: > 888:XSUB.h:122:43: warning: unused parameter ‘cv’ [-Wunused-parameter] > 889- #define XSPROTO(name) void name(pTHX_ CV* cv) > 890- ^
Available for smoking in the smoke-me/jkeenan/gplusplus-warning branch. -- James E Keenan (jkeenan@cpan.org)
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 921b
On Sun, 14 May 2017 19:24:51 GMT, jkeenan@pobox.com wrote: Show quoted text
> Observed today running 'make' on perl 5 blead when compiling with: > > g++ --version > g++ (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 > > > $ grep -nC2 'warning:' g++.en_US.utf8.typescript > 886-g++ -c -DPERL_CORE -fwrapv -fno-strict-aliasing -pipe > -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE > -D_FILE_OFFSET_BITS=64 -ansi -O2 -Wall > -Werror=declaration-after-statement -Wextra -Wwrite-strings perlio.c > 887-In file included from perlio.c:50:0: > 888:XSUB.h:122:43: warning: unused parameter ‘cv’ [-Wunused-parameter] > 889- #define XSPROTO(name) void name(pTHX_ CV* cv) > 890- ^
Patch applied to blead in commit 53dfb2b77ebf8ed9ec272b080bee192fb878051a. Will monitor for 7 days, then close unless problems appear. Thank you very much. -- James E Keenan (jkeenan@cpan.org)
RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 1.9k
On Thu, 01 Jun 2017 13:51:52 GMT, jkeenan wrote: Show quoted text
> On Sun, 14 May 2017 19:24:51 GMT, jkeenan@pobox.com wrote:
> > Observed today running 'make' on perl 5 blead when compiling with: > > > > g++ --version > > g++ (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 > > > > > > $ grep -nC2 'warning:' g++.en_US.utf8.typescript > > 886-g++ -c -DPERL_CORE -fwrapv -fno-strict-aliasing -pipe > > -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE > > -D_FILE_OFFSET_BITS=64 -ansi -O2 -Wall > > -Werror=declaration-after-statement -Wextra -Wwrite-strings perlio.c > > 887-In file included from perlio.c:50:0: > > 888:XSUB.h:122:43: warning: unused parameter ‘cv’ [-Wunused- > > parameter] > > 889- #define XSPROTO(name) void name(pTHX_ CV* cv) > > 890- ^
> > Patch applied to blead in commit > 53dfb2b77ebf8ed9ec272b080bee192fb878051a. Will monitor for 7 days, > then close unless problems appear. > > Thank you very much.
Let's explore one smoke-test failure. [tux], recently you submitted our very first ever smoke test reports using GCC version 7. I'm glad that as part of that effort you tested building perl with g++ version 7.1.1, as reported here: http://perl5.test-smoke.org/report/56002 The g++-7.1.1 build failed in all cases where you did not include these config_args: -Duse64bitall -Duselongdouble ##### Test failures: ~~ ../t/op/sprintf2.t .......................................... FAILED 1492-1497 [stdio/perlio/locale:en_US.utf8] -Dcc=g++ -Duseithreads [stdio/perlio/locale:en_US.utf8] -Dcc=g++ DEBUGGING [stdio/perlio/locale:en_US.utf8] -Dcc=g++ [stdio/perlio/locale:en_US.utf8] -Dcc=g++ -Duseithreads DEBUGGING ##### Have you had a chance to look at these test failures? I ask because I need to rule out the possibility that the changes in 53dfb2b77ebf8ed9ec272b080bee192fb878051a were the source of the problem. Thank you very much. -- James E Keenan (jkeenan@cpan.org)
CC: perlbug-followup [...] perl.org
From: "H.Merijn Brand" <h.m.brand [...] xs4all.nl>
Date: Thu, 8 Jun 2017 12:55:22 +0200
Subject: Re: [perl #131314] "unused parameter" warning when building with g++
To: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 4.4k
On Wed, 07 Jun 2017 14:57:18 -0700, "James E Keenan via RT" <perlbug-followup@perl.org> wrote: Show quoted text
> On Thu, 01 Jun 2017 13:51:52 GMT, jkeenan wrote:
> > On Sun, 14 May 2017 19:24:51 GMT, jkeenan@pobox.com wrote:
> > > Observed today running 'make' on perl 5 blead when compiling with: > > > > > > g++ --version > > > g++ (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 > > > > > > > > > $ grep -nC2 'warning:' g++.en_US.utf8.typescript > > > 886-g++ -c -DPERL_CORE -fwrapv -fno-strict-aliasing -pipe > > > -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE > > > -D_FILE_OFFSET_BITS=64 -ansi -O2 -Wall > > > -Werror=declaration-after-statement -Wextra -Wwrite-strings perlio.c > > > 887-In file included from perlio.c:50:0: > > > 888:XSUB.h:122:43: warning: unused parameter ‘cv’ [-Wunused- > > > parameter] > > > 889- #define XSPROTO(name) void name(pTHX_ CV* cv) > > > 890- ^
> > > > Patch applied to blead in commit > > 53dfb2b77ebf8ed9ec272b080bee192fb878051a. Will monitor for 7 days, > > then close unless problems appear. > > > > Thank you very much.
> > Let's explore one smoke-test failure. > > [tux], recently you submitted our very first ever smoke test reports > using GCC version 7. I'm glad that as part of that effort you tested > building perl with g++ version 7.1.1, as reported here: > > http://perl5.test-smoke.org/report/56002 > > The g++-7.1.1 build failed in all cases where you did not include > these config_args: > > -Duse64bitall -Duselongdouble > > ##### > Test failures: > ~~ ../t/op/sprintf2.t .......................................... > FAILED 1492-1497 [stdio/perlio/locale:en_US.utf8] -Dcc=g++ > -Duseithreads [stdio/perlio/locale:en_US.utf8] -Dcc=g++ DEBUGGING > [stdio/perlio/locale:en_US.utf8] -Dcc=g++ > [stdio/perlio/locale:en_US.utf8] -Dcc=g++ -Duseithreads DEBUGGING > ##### > > Have you had a chance to look at these test failures?
I think they are related to Jarkko's ongoing work on fpclassify and subnormal behavior: perl-git/t $ ./perl -I ../lib harness -v op/sprintf2.t |& grep -v '^ok ' # Failed test 1530 - subnormal 0x1.fffffffffffffp-1022 %a 0x1.fffffffffffffp-1022 got 0x0p+0 at op/sprintf2.t line 811 # got "0x0p+0" # expected "0x1.fffffffffffffp-1022" # Failed test 1531 - subnormal 0x0.fffffffffffffp-1022 %a 0x1.ffffffffffffep-1023 got 0x0p+0 at op/sprintf2.t line 811 # got "0x0p+0" # expected "0x1.ffffffffffffep-1023" # Failed test 1532 - subnormal 0x0.7ffffffffffffp-1022 %a 0x1.ffffffffffffcp-1024 got 0x0p+0 at op/sprintf2.t line 811 # got "0x0p+0" # expected "0x1.ffffffffffffcp-1024" # Failed test 1533 - subnormal 0x0.3ffffffffffffp-1022 %a 0x1.ffffffffffff8p-1025 got 0x0p+0 at op/sprintf2.t line 811 # got "0x0p+0" # expected "0x1.ffffffffffff8p-1025" # Failed test 1534 - subnormal 0x0.1ffffffffffffp-1022 %a 0x1.ffffffffffffp-1026 got 0x0p+0 at op/sprintf2.t line 811 # got "0x0p+0" # expected "0x1.ffffffffffffp-1026" # Failed test 1535 - subnormal 0x0.0ffffffffffffp-1022 %a 0x1.fffffffffffep-1027 got 0x0p+0 at op/sprintf2.t line 811 # got "0x0p+0" # expected "0x1.fffffffffffep-1027" op/sprintf2.t .. # uvsize = 8 # nvsize = 8 # nv_preserves_uv_bits = 53 # d_quad = define # uselongdouble = undef not ok 1530 - subnormal 0x1.fffffffffffffp-1022 %a 0x1.fffffffffffffp-1022 got 0x0p+0 not ok 1531 - subnormal 0x0.fffffffffffffp-1022 %a 0x1.ffffffffffffep-1023 got 0x0p+0 not ok 1532 - subnormal 0x0.7ffffffffffffp-1022 %a 0x1.ffffffffffffcp-1024 got 0x0p+0 not ok 1533 - subnormal 0x0.3ffffffffffffp-1022 %a 0x1.ffffffffffff8p-1025 got 0x0p+0 not ok 1534 - subnormal 0x0.1ffffffffffffp-1022 %a 0x1.ffffffffffffp-1026 got 0x0p+0 not ok 1535 - subnormal 0x0.0ffffffffffffp-1022 %a 0x1.fffffffffffep-1027 got 0x0p+0 1..1674 Failed 6/1674 subtests (less 30 skipped subtests: 1638 okay) Test Summary Report ------------------- op/sprintf2.t (Wstat: 0 Tests: 1674 Failed: 6) Failed tests: 1530-1535 Files=1, Tests=1674, 0 wallclock secs ( 0.13 usr 0.00 sys + 0.27 cusr 0.12 csys = 0.52 CPU) Result: FAIL Show quoted text
> I ask because I need to rule out the possibility that the changes in > 53dfb2b77ebf8ed9ec272b080bee192fb878051a were the source of the > problem. > > Thank you very much.
-- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using perl5.00307 .. 5.27 porting perl5 on HP-UX, AIX, and openSUSE http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
Download (untitled)
application/pgp-signature 473b

Message body not shown because it is not plain text.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 779b
On Thu, 08 Jun 2017 10:55:43 GMT, hmbrand wrote: Show quoted text
> On Wed, 07 Jun 2017 14:57:18 -0700, "James E Keenan via RT"
[snip] Show quoted text
> > > > Let's explore one smoke-test failure. > > > > [tux], recently you submitted our very first ever smoke test reports > > using GCC version 7. I'm glad that as part of that effort you tested > > building perl with g++ version 7.1.1, as reported here: > > > > http://perl5.test-smoke.org/report/56002 > > > > The g++-7.1.1 build failed in all cases where you did not include > > these config_args: > > > > -Duse64bitall -Duselongdouble > >
> > I think they are related to Jarkko's ongoing work on fpclassify and > subnormal behavior: >
Sounds reasonable. Thanks for your rapid response. Marking ticket Resolved. -- James E Keenan (jkeenan@cpan.org)


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org