New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rational.REDUCE-ME has a data race #6069
Comments
From @mschaIt's fairly rare to encounter a Rat that isn't normalized, but if you do Example:
Even stranger, $g is now normalized as well. This is on Rakudo Star 2017.01, 64-bit Linux. % perl6 --version |
From @mschaActually, it's not as rare as I thought: the same thing happens when you do:
|
From @zoffixznetThe avoidance of reduction is for optimization purposes. The .norm stuff is fixed now in rakudo/rakudo@aac9efcbda and tested in Raku/roast@7d0daf5286 However, there's a data-race in Rational.REDUCE-ME and it needs to go: https://irclog.perlgeek.de/perl6-dev/2017-02-13#i_14093035 Renaming the ticket to that. |
The RT System itself - Status changed from 'new' to 'open' |
From @zoffixznetAnother issue the .REDUCE-ME thing causes: mscha │ m: say (1/2+1/2, 2/2).unique; infix:<+> does not call .REDUCE-ME so the rats are different in this case |
From @skidsOn Mon, 06 Mar 2017 05:48:07 -0800, cpan@zoffix.com wrote:
I could see where a mutable Rational could be useful. Should we parameterize that Naturally any mutable Rational would come with the caveat that it is not threadsafe. Also, what behavior are we looking for Rat -- just "immutabilty" or "value-type"? |
From @AlexDanielThe issue with .unique was resolved in these commits Rakudo: rakudo/rakudo@8cd70d1 On 2017-03-06 05:48:07, cpan@zoffix.com wrote:
|
From @zoffixznetData race is now fixed (in a post release branch): Rakudo fix: rakudo/rakudo@6dd2058 |
@zoffixznet - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#130774 (status was 'resolved')
Searchable as RT130774$
The text was updated successfully, but these errors were encountered: