AutoLoader implies suitability for constants, fails to mention inlining incompatibility [patch] #15866

p5pRT · 2017-02-07T18:31:35Z

Migrated from rt.perl.org#130735 (status was 'open')

Searchable as RT130735$

p5pRT · 2017-02-07T18:31:35Z

From @wchristian

Created by @wchristian

The problem is with this section of the AutoLoader documentation:

http://perldoc.perl.org/AutoLoader.html#Overriding-*AutoLoader*'s-AUTOLOAD-Subroutine

It describes how to do certain things with the module, but choses to make its example with constants, despite the fact that AutoLoader cannot create inlinable constant functions, due to always executing after compile time.

The attached patch adds a note of this limitation.

Perl Info


Flags:
     category=library
     severity=low
     module=AutoLoader

Site configuration information for perl 5.18.4:

Configured by strawberry-perl at Thu Oct  2 12:12:07 2014.

Summary of my perl5 (revision 5 version 18 subversion 4) configuration:

   Platform:
     osname=MSWin32, osvers=6.3, archname=MSWin32-x86-multi-thread-64int
     uname='Win32 strawberry-perl 5.18.4.1 #1 Thu Oct  2 12:10:29 2014 i386'
     config_args='undef'
     hint=recommended, useposix=true, d_sigaction=undef
     useithreads=define, usemultiplicity=define
     useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
     use64bitint=define, use64bitall=undef, uselongdouble=undef
     usemymalloc=n, bincompat5005=undef
   Compiler:
     cc='gcc', ccflags =' -s -O2 -DWIN32  -DPERL_TEXTMODE_SCRIPTS -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DUSE_PERLIO -fno-strict-aliasing -mms-bitfields',
     optimize='-s -O2',
     cppflags='-DWIN32'
     ccversion='', gccversion='4.7.3', gccosandvers=''
     intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=12345678
     d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
     ivtype='long long', ivsize=8, nvtype='double', nvsize=8, Off_t='long long', lseeksize=8
     alignbytes=8, prototype=define
   Linker and Libraries:
     ld='g++', ldflags ='-s -L"C:\strawberry\perl\lib\CORE" -L"C:\strawberry\c\lib"'
     libpth=C:\strawberry\c\lib C:\strawberry\c\i686-w64-mingw32\lib C:\strawberry\c\lib\gcc\i686-w64-mingw32\4.7.3
     libs=-lmoldname -lkernel32 -luser32 -lgdi32 -lwinspool -lcomdlg32 -ladvapi32 -lshell32 -lole32 -loleaut32 -lnetapi32 -luuid -lws2_32 -lmpr -lwinmm -lversion -lodbc32 -lodbccp32 -lcomctl32
     perllibs=-lmoldname -lkernel32 -luser32 -lgdi32 -lwinspool -lcomdlg32 -ladvapi32 -lshell32 -lole32 -loleaut32 -lnetapi32 -luuid -lws2_32 -lmpr -lwinmm -lversion -lodbc32 -lodbccp32 -lcomctl32
     libc=, so=dll, useshrplib=true, libperl=libperl518.a
     gnulibc_version=''
   Dynamic Linking:
     dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
     cccdlflags=' ', lddlflags='-mdll -s -L"C:\strawberry\perl\lib\CORE" -L"C:\strawberry\c\lib"'

Locally applied patches:



@INC for perl 5.18.4:
     C:/strawberry/perl/site/lib/MSWin32-x86-multi-thread-64int
     C:/strawberry/perl/site/lib
     C:/strawberry/perl/vendor/lib
     C:/strawberry/perl/lib
     .


Environment for perl 5.18.4:
     CYGWIN=nodosfilewarning
     HOME (unset)
     LANG=en_US.utf8
     LANGUAGE (unset)
     LD_LIBRARY_PATH (unset)
     LOGDIR (unset)
     PATH=C:\Program Files (x86)\ImageMagick-6.9.5-Q16;c:\python27\;c:\python27\scripts;c:\programdata\oracle\java\javapath;c:\windows\system32;c:\perl\site\bin;c:\perl\bin;c:\program files\intel\wifi\bin\;c:\program files\common files\intel\wirelesscommon\;c:\windows;c:\windows\system32\wbem;c:\windows\system32\windowspowershell\v1.0\;c:\program files (x86)\skype\phone\;c:\program files (x86)\miktex 2.9\miktex\bin\;c:\program files\git\cmd;c:\program files (x86)\intel\opencl sdk\2.0\bin\x86;c:\program files (x86)\intel\opencl sdk\2.0\bin\x64;C:\Program Files (x86)\Intel\OpenCL SDK\2.0\bin\x86;C:\Program Files (x86)\Intel\OpenCL SDK\2.0\bin\x64;C:\Program Files (x86)\Windows Kits\8.1\Windows Performance Toolkit\;C:\Program Files\TSVN\bin;C:\strawberry\c\bin;C:\strawberry\perl\site\bin;C:\strawberry\perl\bin;C:\Program Files\OpenVPN\bin;c:\cygwin\bin;C:\Program Files\PostgreSQL\pg95\bin;C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common;C:\Program  
Files\FileBot\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\Program Files\TortoiseGit\bin;C:\KFFirstAide;C:\Users\Mithaldu\AppData\Roaming\npm;d:\android\android-ndk-r10d\;C:\Program Files\Intel\WiFi\bin\;C:\Program Files\Common Files\Intel\WirelessCommon\;d:\j\MeCab\bin\;C:\Program Files (x86)\Diffuse;C:\Users\Mithaldu\AppData\Local\Microsoft\WindowsApps;C:\Program Files\GPAC
     PERL_BADLANG (unset)
     SHELL (unset)

p5pRT · 2017-02-07T18:31:35Z

From @wchristian

0001-AutoLoader-note-incompatibility-with-constant-inlini.patch

From ebaa5bca18e0e78b78277f54cad889c2e3876555 Mon Sep 17 00:00:00 2001
From: Christian Walde <walde.christian@googlemail.com>
Date: Tue, 7 Feb 2017 19:23:05 +0100
Subject: [PATCH] AutoLoader: note incompatibility  with constant inlining

---
 cpan/AutoLoader/lib/AutoLoader.pm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/cpan/AutoLoader/lib/AutoLoader.pm b/cpan/AutoLoader/lib/AutoLoader.pm
index 5546f9e..398fc0b 100644
--- a/cpan/AutoLoader/lib/AutoLoader.pm
+++ b/cpan/AutoLoader/lib/AutoLoader.pm
@@ -305,6 +305,11 @@ If any module's own AUTOLOAD subroutine has no need to fallback to the
 AutoLoader's AUTOLOAD subroutine (because it doesn't have any AutoSplit
 subroutines), then that module should not use B<AutoLoader> at all.
 
+Note: Despite the example above talking about constants, there are
+currently no circumstances under which a function loaded by AutoLoader
+can be inlined as a constant. If you desire to make use of this
+optimization AutoLoader can not be used.
+
 =head2 Package Lexicals
 
 Package lexicals declared with C<my> in the main block of a package
-- 
2.10.1.windows.1

p5pRT · 2017-02-08T18:30:09Z

From @jkeenan

On Tue, 07 Feb 2017 18:31:35 GMT, walde.christian@gmail.com wrote:

This is a bug report for perl from walde.christian@gmail.com,
generated with the help of perlbug 1.39 running under perl 5.18.4.

-----------------------------------------------------------------
[Please describe your issue here]

The problem is with this section of the AutoLoader documentation:

http://perldoc.perl.org/AutoLoader.html#Overriding-*AutoLoader*'s-
AUTOLOAD-Subroutine

It describes how to do certain things with the module, but choses to
make its example with constants, despite the fact that AutoLoader
cannot create inlinable constant functions, due to always executing
after compile time.

The attached patch adds a note of this limitation.

We have a bit of a technical problem here. The AutoLoader library is found within the core distribution under 'cpan/Autoloader/'. This suggests that it is maintained upstream on cpan rather than in blead. This impression is confirmed by its entry in Porting/Maintainers.pl.

However, when I go to https://rt.cpan.org//Dist/Display.html?Queue=AutoLoader and click on "Preferred Bug Tracker," I'm taken back to rt.perl.org -- which implies that it's maintained in core.

So we need to clarify where this bug report should go. copying the maintainer.

Thank you very much.
Jim Keenan

--
James E Keenan (jkeenan@cpan.org)

p5pRT · 2017-02-08T18:30:10Z

The RT System itself - Status changed from 'new' to 'open'

p5pRT · 2017-02-26T22:41:23Z

From @jkeenan

On Wed, 08 Feb 2017 18:30:09 GMT, jkeenan wrote:

On Tue, 07 Feb 2017 18:31:35 GMT, walde.christian@gmail.com wrote:

This is a bug report for perl from walde.christian@gmail.com,
generated with the help of perlbug 1.39 running under perl 5.18.4.

-----------------------------------------------------------------
[Please describe your issue here]

The problem is with this section of the AutoLoader documentation:

http://perldoc.perl.org/AutoLoader.html#Overriding-*AutoLoader*'s-
AUTOLOAD-Subroutine

It describes how to do certain things with the module, but choses to
make its example with constants, despite the fact that AutoLoader
cannot create inlinable constant functions, due to always executing
after compile time.

The attached patch adds a note of this limitation.

We have a bit of a technical problem here. The AutoLoader library is
found within the core distribution under 'cpan/Autoloader/'. This
suggests that it is maintained upstream on cpan rather than in blead.
This impression is confirmed by its entry in Porting/Maintainers.pl.

However, when I go to
https://rt.cpan.org//Dist/Display.html?Queue=AutoLoader and click on
"Preferred Bug Tracker," I'm taken back to rt.perl.org -- which
implies that it's maintained in core.

So we need to clarify where this bug report should go. copying the
maintainer.

Thank you very much.
Jim Keenan

I have not heard back from the listed maintainer (SMUELLER).

pumpking: guidance requested.

Thank you very much.

--
James E Keenan (jkeenan@cpan.org)

p5pRT · 2017-02-27T14:06:29Z

From @xsawyerx

On 02/26/2017 11:41 PM, James E Keenan via RT wrote:

On Wed, 08 Feb 2017 18:30:09 GMT, jkeenan wrote:

On Tue, 07 Feb 2017 18:31:35 GMT, walde.christian@gmail.com wrote:

This is a bug report for perl from walde.christian@gmail.com,
generated with the help of perlbug 1.39 running under perl 5.18.4.

-----------------------------------------------------------------
[Please describe your issue here]

The problem is with this section of the AutoLoader documentation:

http://perldoc.perl.org/AutoLoader.html#Overriding-*AutoLoader*'s-
AUTOLOAD-Subroutine

It describes how to do certain things with the module, but choses to
make its example with constants, despite the fact that AutoLoader
cannot create inlinable constant functions, due to always executing
after compile time.

The attached patch adds a note of this limitation.

We have a bit of a technical problem here. The AutoLoader library is
found within the core distribution under 'cpan/Autoloader/'. This
suggests that it is maintained upstream on cpan rather than in blead.
This impression is confirmed by its entry in Porting/Maintainers.pl.

However, when I go to
https://rt.cpan.org//Dist/Display.html?Queue=AutoLoader and click on
"Preferred Bug Tracker," I'm taken back to rt.perl.org -- which
implies that it's maintained in core.

So we need to clarify where this bug report should go. copying the
maintainer.

Thank you very much.
Jim Keenan
I have not heard back from the listed maintainer (SMUELLER).

pumpking: guidance requested.

SMUELLER is sometimes overflowing in email. Let's give it another day or
two.

p5pRT · 2017-03-01T10:22:02Z

From @xsawyerx

On Mon, 27 Feb 2017 06:06:29 -0800, xsawyerx@gmail.com wrote:

On 02/26/2017 11:41 PM, James E Keenan via RT wrote:

On Wed, 08 Feb 2017 18:30:09 GMT, jkeenan wrote:

On Tue, 07 Feb 2017 18:31:35 GMT, walde.christian@gmail.com wrote:

This is a bug report for perl from walde.christian@gmail.com,
generated with the help of perlbug 1.39 running under perl 5.18.4.

-----------------------------------------------------------------
[Please describe your issue here]

The problem is with this section of the AutoLoader documentation:

http://perldoc.perl.org/AutoLoader.html#Overriding-*AutoLoader*'s-
AUTOLOAD-Subroutine

It describes how to do certain things with the module, but choses to
make its example with constants, despite the fact that AutoLoader
cannot create inlinable constant functions, due to always executing
after compile time.

The attached patch adds a note of this limitation.

We have a bit of a technical problem here. The AutoLoader library is
found within the core distribution under 'cpan/Autoloader/'. This
suggests that it is maintained upstream on cpan rather than in blead.
This impression is confirmed by its entry in Porting/Maintainers.pl.

However, when I go to
https://rt.cpan.org//Dist/Display.html?Queue=AutoLoader and click on
"Preferred Bug Tracker," I'm taken back to rt.perl.org -- which
implies that it's maintained in core.

So we need to clarify where this bug report should go. copying the
maintainer.

Thank you very much.
Jim Keenan
I have not heard back from the listed maintainer (SMUELLER).

pumpking: guidance requested.

SMUELLER is sometimes overflowing in email. Let's give it another day or
two.

Now knowing the maintainer is overwhelmed with other issues at the moment, I think we need to decide whether to move this into core or not without him. He's fine with it.

The benefit of bringing it into core is that it's widely used enough that I would consider crucial, and will benefit from having a net of developers, which is why I'm leaning towards that.

toddr · 2020-02-14T00:20:54Z

@xsawyerx what did you decide?

xsawyerx · 2020-04-10T10:53:55Z

We should move AutoLoader to core.

khwilliamson · 2020-04-10T14:58:45Z

On 4/10/20 4:54 AM, Sawyer X wrote: We should move |AutoLoader| to core.

When?

…

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#15866 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA2DHZ5NMBKWDIVT526AOLRL33FDANCNFSM4KU5ZP2A>.

jkeenan · 2020-04-10T15:13:39Z

On 4/10/20 4:54 AM, Sawyer X wrote: We should move |AutoLoader| to core.
When?

We're in code freeze. Hence, my recommendation: 5.33.1.

jkeenan · 2020-04-10T16:02:23Z

On 4/10/20 4:54 AM, Sawyer X wrote: We should move |AutoLoader| to core.
When?

We're in code freeze. Hence, my recommendation: 5.33.1.

I've created #17707 to track transfer of AutoLoader to dist/. I recommend that we move further discussion of the transfer (including its timing) to that ticket, and that we retain this ticket to focus on the issue raised, and patch submitted, by the original poster in Feb 2017.

Thank you very much.
Jim Keenan

jkeenan · 2020-04-10T18:50:56Z

On 4/10/20 4:54 AM, Sawyer X wrote: We should move |AutoLoader| to core.
When?

We're in code freeze. Hence, my recommendation: 5.33.1.

I've created #17707 to track transfer of AutoLoader to dist/. I recommend that we move further discussion of the transfer (including its timing) to that ticket, and that we retain this ticket to focus on the issue raised, and patch submitted, by the original poster in Feb 2017.

Thank you very much.
Jim Keenan

To get back to the original subject of this ticket ... Is the following patch to AutoLoader.pm's documentation valid?

+Note: Despite the example above talking about constants, there are
+currently no circumstances under which a function loaded by AutoLoader
+can be inlined as a constant. If you desire to make use of this
+optimization AutoLoader can not be used.
+

p5pRT added Severity Low distro-mswin32 type-library labels Oct 19, 2019

toddr assigned xsawyerx Feb 14, 2020

jkeenan mentioned this issue Apr 10, 2020

Move AutoLoader distribution to 'dist/' #17707

Open

toddr added this to the 5.33.1 milestone Apr 10, 2020

toddr added documentation and removed distro-mswin32 labels Apr 10, 2020

xsawyerx added the do not merge Don't merge this PR, at least for now label Jun 20, 2020

jkeenan changed the title ~~AutoLoader implies suitability for constants, fails to mention inlining incompability [patch]~~ AutoLoader implies suitability for constants, fails to mention inlining incompatibility [patch] Jul 17, 2020

xenu removed the affects-5.18 label Nov 19, 2021

xenu removed the Severity Low label Dec 29, 2021

hvds removed this from the 5.33.1 milestone Mar 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AutoLoader implies suitability for constants, fails to mention inlining incompatibility [patch] #15866

AutoLoader implies suitability for constants, fails to mention inlining incompatibility [patch] #15866

p5pRT commented Feb 7, 2017

p5pRT commented Feb 7, 2017

p5pRT commented Feb 7, 2017

p5pRT commented Feb 8, 2017

p5pRT commented Feb 8, 2017

p5pRT commented Feb 26, 2017

p5pRT commented Feb 27, 2017

p5pRT commented Mar 1, 2017

toddr commented Feb 14, 2020

xsawyerx commented Apr 10, 2020

khwilliamson commented Apr 10, 2020 via email

jkeenan commented Apr 10, 2020

jkeenan commented Apr 10, 2020

jkeenan commented Apr 10, 2020

AutoLoader implies suitability for constants, fails to mention inlining incompatibility [patch] #15866

AutoLoader implies suitability for constants, fails to mention inlining incompatibility [patch] #15866

Comments

p5pRT commented Feb 7, 2017

p5pRT commented Feb 7, 2017

From @wchristian

Created by @wchristian

p5pRT commented Feb 7, 2017

From @wchristian

p5pRT commented Feb 8, 2017

From @jkeenan

p5pRT commented Feb 8, 2017

p5pRT commented Feb 26, 2017

From @jkeenan

p5pRT commented Feb 27, 2017

From @xsawyerx

p5pRT commented Mar 1, 2017

From @xsawyerx

toddr commented Feb 14, 2020

xsawyerx commented Apr 10, 2020

khwilliamson commented Apr 10, 2020 via email

jkeenan commented Apr 10, 2020

jkeenan commented Apr 10, 2020

jkeenan commented Apr 10, 2020