Skip Menu |
Report information
Id: 130713
Status: open
Priority: 0/
Queue: perl6

Owner: Nobody
Requestors: elizabeth <liz [at] dijkmat.nl>
Cc:
AdminCc:

Severity: (no value)
Tag: testcommitted
Platform: (no value)
Patch Status: (no value)
VM: (no value)



To: rakudobug [...] perl.org
From: Elizabeth Mattijsen <liz [...] dijkmat.nl>
Subject: 42.expmod(-1,1) hangs
Date: Fri, 3 Feb 2017 22:32:40 +0100
CC: Dana Jacobsen <dana.jacobsen [...] gmail.com>
Download (untitled) / with headers
text/plain 185b
The combination of parameters -1,1 like this, causes nqp::expmod_I to hang. Assume this is a MoarVM issue, as this does not appear to be an issue on MoarVM. Spotted by Dana Jacobsen++
Subject: Re: [perl #130713] 42.expmod(-1,1) hangs
From: Brandon Allbery <allbery.b [...] gmail.com>
To: perl6-compiler <perl6-compiler [...] perl.org>
CC: bugs-bitbucket [...] rt.perl.org
Date: Fri, 3 Feb 2017 16:34:33 -0500
Download (untitled) / with headers
text/plain 469b

On Fri, Feb 3, 2017 at 4:33 PM, Elizabeth Mattijsen <perl6-bugs-followup@perl.org> wrote:
Show quoted text
Assume this is a MoarVM issue, as this does not appear to be an issue on MoarVM.

...which of those was supposed to be something else?


--
brandon s allbery kf8nh                               sine nomine associates
allbery.b@gmail.com                                  ballbery@sinenomine.net
unix, openafs, kerberos, infrastructure, xmonad        http://sinenomine.net
From: Elizabeth Mattijsen <liz [...] dijkmat.nl>
Subject: Re: [perl #130713] 42.expmod(-1,1) hangs
To: perl6-compiler <perl6-compiler [...] perl.org>
Date: Fri, 3 Feb 2017 22:40:52 +0100
Download (untitled) / with headers
text/plain 463b
Show quoted text
> On 3 Feb 2017, at 22:34, Brandon Allbery <allbery.b@gmail.com> wrote: > > > On Fri, Feb 3, 2017 at 4:33 PM, Elizabeth Mattijsen <perl6-bugs-followup@perl.org> wrote: > Assume this is a MoarVM issue, as this does not appear to be an issue on MoarVM. > > ...which of those was supposed to be something else?
The second: there’s no problem on the JVM. Good catch! Note to self: do not do bugreports after having been to Delirium in Brussels. :-) Liz
Date: Fri, 3 Feb 2017 22:41:21 +0100
To: Brandon Allbery via RT <perl6-bugs-followup [...] perl.org>
From: Elizabeth Mattijsen <liz [...] dijkmat.nl>
Subject: Re: [perl #130713] 42.expmod(-1,1) hangs
Download (untitled) / with headers
text/plain 463b
Show quoted text
> On 3 Feb 2017, at 22:34, Brandon Allbery <allbery.b@gmail.com> wrote: > > > On Fri, Feb 3, 2017 at 4:33 PM, Elizabeth Mattijsen <perl6-bugs-followup@perl.org> wrote: > Assume this is a MoarVM issue, as this does not appear to be an issue on MoarVM. > > ...which of those was supposed to be something else?
The second: there’s no problem on the JVM. Good catch! Note to self: do not do bugreports after having been to Delirium in Brussels. :-) Liz
Download (untitled) / with headers
text/plain 255b
It seems like we literally just pass the values into libtommath's mp_exptmod. It then just infinitely loops around inside of fast_mp_invmod. Perhaps we can see if a newer version of libtommath changed something about that and perhaps fixed our problem?
Download (untitled) / with headers
text/plain 176b
There's a github issue that relates to this. Applying this change to our tommath makes expmod(42, -1, 1) terminate successfully. https://github.com/libtom/libtommath/issues/67
This was resolved in this commit trio:
https://github.com/rakudo/rakudo/commit/22f00cd72deaaaafbaeb1ad83187309854e33739
https://github.com/perl6/nqp/commit/b083e3471a25bf376fa89b5ec53969b870eb6ac2
https://github.com/MoarVM/MoarVM/commit/1288e7edde60b8c88afb85029dc089092db80168

「testneeded」

On 2017-02-03 15:04:00, timo wrote:
Show quoted text
> There's a github issue that relates to this. Applying this change to
> our tommath makes expmod(42, -1, 1) terminate successfully.
>
> https://github.com/libtom/libtommath/issues/67


RT-Send-CC: perl6-compiler [...] perl.org
Download (untitled) / with headers
text/plain 835b
On Wed, 04 Oct 2017 22:20:49 -0700, alex.jakimenko@gmail.com wrote: Show quoted text
> This was resolved in this commit trio: > https://github.com/rakudo/rakudo/commit/22f00cd72deaaaafbaeb1ad83187309854e33739 > https://github.com/perl6/nqp/commit/b083e3471a25bf376fa89b5ec53969b870eb6ac2 > https://github.com/MoarVM/MoarVM/commit/1288e7edde60b8c88afb85029dc089092db80168 > > 「testneeded」 > > On 2017-02-03 15:04:00, timo wrote:
> > There's a github issue that relates to this. Applying this change to > > our tommath makes expmod(42, -1, 1) terminate successfully. > > > > https://github.com/libtom/libtommath/issues/67
Tests added https://github.com/perl6/roast/commit/064707a320 They showed this issue still exists for other combinations, such as: <Zoffix__> m: say 42.expmod(-1,7) <camelia> rakudo-moar 27131e: OUTPUT: «(timeout)»


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org