Skip Menu |
Report information
Id: 129296
Status: resolved
Priority: 0/
Queue: perl6

Owner: Nobody
Requestors: alex.jakimenko [at] gmail.com
Cc:
AdminCc:

Severity: (no value)
Tag: testneeded
Platform: (no value)
Patch Status: (no value)
VM: (no value)



Subject: Regression: splitting non-binary handles no longer works
06:05:08 <AlexDaniel> bisectable6oops: run(:out, "ls").out.encoding.say
06:05:09 <bisectable6oops> AlexDaniel, Exit code is 1 on both starting points (good=2015.12 bad=b771f1e), bisecting by using the output
06:05:16 <bisectable6oops> AlexDaniel, bisect log: https://gist.github.com/9f081f1cb9018d60e4002dc13609c661
06:05:17 <bisectable6oops> AlexDaniel, (2016-08-26) https://github.com/rakudo/rakudo/commit/87887da
06:05:26 <AlexDaniel> lizmat: ↑
06:06:48 <AlexDaniel> lizmat: “concatenate requires a concrete string, but got null” is probably worse than the previous error
06:08:06 <AlexDaniel> lizmat: I am actually seeing a regression in this case: run(:out, "ls").out.split(0.chr, :skip-empty)
06:09:56 <AlexDaniel> lizmat: but the regression itself seems to be associated more with https://github.com/rakudo/rakudo/commit/1a03efe
06:10:47 <AlexDaniel> bisectable6oops: run(:out, "ls").out.binary.say
06:10:48 <bisectable6oops> AlexDaniel, Exit code is 1 on both starting points (good=2015.12 bad=b771f1e), bisecting by using the output
06:10:55 <bisectable6oops> AlexDaniel, bisect log: https://gist.github.com/3be864fc5825f769c6aaebb8a6760eca
06:10:56 <bisectable6oops> AlexDaniel, (2016-08-26) https://github.com/rakudo/rakudo/commit/1a03efe
06:11:38 <AlexDaniel> lizmat: yeah, so 1a03efe added a check using .binary (which is broken), which made the whole thing blow up
06:12:50 <AlexDaniel> lizmat: one possible way to fix it is to revert 1a03efe so that it works with non-binary handles


<MasterDuke> this seems to work as a work-around: my $r = run(:out, "ls").out; $r.encoding("utf8"); $r.split(0.chr, :skip-empty)
Download (untitled) / with headers
text/plain 1.8k
On Sat Sep 17 20:19:43 2016, alex.jakimenko@gmail.com wrote: Show quoted text
> 06:05:08 <AlexDaniel> bisectable6oops: run(:out, > "ls").out.encoding.say > 06:05:09 <bisectable6oops> AlexDaniel, Exit code is 1 on both starting > points > (good=2015.12 bad=b771f1e), bisecting by using the output > 06:05:16 <bisectable6oops> AlexDaniel, bisect log: > https://gist.github.com/9f081f1cb9018d60e4002dc13609c661 > 06:05:17 <bisectable6oops> AlexDaniel, (2016-08-26) > https://github.com/rakudo/rakudo/commit/87887da > 06:05:26 <AlexDaniel> lizmat: ↑ > 06:06:48 <AlexDaniel> lizmat: “concatenate requires a concrete string, > but got > null” is probably worse than the previous error > 06:08:06 <AlexDaniel> lizmat: I am actually seeing a regression in > this case: > run(:out, "ls").out.split(0.chr, :skip-empty) > 06:09:56 <AlexDaniel> lizmat: but the regression itself seems to be > associated > more with https://github.com/rakudo/rakudo/commit/1a03efe > 06:10:47 <AlexDaniel> bisectable6oops: run(:out, "ls").out.binary.say > 06:10:48 <bisectable6oops> AlexDaniel, Exit code is 1 on both starting > points > (good=2015.12 bad=b771f1e), bisecting by using the output > 06:10:55 <bisectable6oops> AlexDaniel, bisect log: > https://gist.github.com/3be864fc5825f769c6aaebb8a6760eca > 06:10:56 <bisectable6oops> AlexDaniel, (2016-08-26) > https://github.com/rakudo/rakudo/commit/1a03efe > 06:11:38 <AlexDaniel> lizmat: yeah, so 1a03efe added a check using > .binary > (which is broken), which made the whole thing blow up > 06:12:50 <AlexDaniel> lizmat: one possible way to fix it is to revert > 1a03efe > so that it works with non-binary handles > > > <MasterDuke> this seems to work as a work-around: my $r = run(:out, > "ls").out; > $r.encoding("utf8"); $r.split(0.chr, :skip-empty)
I think it's because an IO::Pipe is being created, which is an IO::Handle, but the encoding for IO::Handle only gets set when you call open(), not new().
Subject: Re: [perl #129296] Regression: splitting non-binary handles no longer works
From: Elizabeth Mattijsen <liz [...] dijkmat.nl>
To: "Aleks-Daniel Jakimenko-Aleksejev (via RT)" <perl6-bugs-followup [...] perl.org>
Date: Sun, 18 Sep 2016 12:13:45 +0200
Fixed by reverting 1a03efe4e3b61a07b7df5 in 363a3a899f2cb342d1ca5 . Show quoted text
> On 18 Sep 2016, at 05:19, Aleks-Daniel Jakimenko-Aleksejev (via RT) <perl6-bugs-followup@perl.org> wrote: > > # New Ticket Created by Aleks-Daniel Jakimenko-Aleksejev > # Please include the string: [perl #129296] > # in the subject line of all future correspondence about this issue. > # <URL: https://rt.perl.org/Ticket/Display.html?id=129296 > > > > 06:05:08 <AlexDaniel> bisectable6oops: run(:out, "ls").out.encoding.say > 06:05:09 <bisectable6oops> AlexDaniel, Exit code is 1 on both starting points > (good=2015.12 bad=b771f1e), bisecting by using the output > 06:05:16 <bisectable6oops> AlexDaniel, bisect log: > https://gist.github.com/9f081f1cb9018d60e4002dc13609c661 > 06:05:17 <bisectable6oops> AlexDaniel, (2016-08-26) > https://github.com/rakudo/rakudo/commit/87887da > 06:05:26 <AlexDaniel> lizmat: ↑ > 06:06:48 <AlexDaniel> lizmat: “concatenate requires a concrete string, but got > null” is probably worse than the previous error > 06:08:06 <AlexDaniel> lizmat: I am actually seeing a regression in this case: > run(:out, "ls").out.split(0.chr, :skip-empty) > 06:09:56 <AlexDaniel> lizmat: but the regression itself seems to be associated > more with https://github.com/rakudo/rakudo/commit/1a03efe > 06:10:47 <AlexDaniel> bisectable6oops: run(:out, "ls").out.binary.say > 06:10:48 <bisectable6oops> AlexDaniel, Exit code is 1 on both starting points > (good=2015.12 bad=b771f1e), bisecting by using the output > 06:10:55 <bisectable6oops> AlexDaniel, bisect log: > https://gist.github.com/3be864fc5825f769c6aaebb8a6760eca > 06:10:56 <bisectable6oops> AlexDaniel, (2016-08-26) > https://github.com/rakudo/rakudo/commit/1a03efe > 06:11:38 <AlexDaniel> lizmat: yeah, so 1a03efe added a check using .binary > (which is broken), which made the whole thing blow up > 06:12:50 <AlexDaniel> lizmat: one possible way to fix it is to revert 1a03efe > so that it works with non-binary handles > > > <MasterDuke> this seems to work as a work-around: my $r = run(:out, "ls").out; > $r.encoding("utf8"); $r.split(0.chr, :skip-empty)
Download (untitled) / with headers
text/plain 2.2k
On Sun Sep 18 03:14:30 2016, elizabeth wrote: Show quoted text
> Fixed by reverting 1a03efe4e3b61a07b7df5 in 363a3a899f2cb342d1ca5 . > >
> > On 18 Sep 2016, at 05:19, Aleks-Daniel Jakimenko-Aleksejev (via RT) > > <perl6-bugs-followup@perl.org> wrote: > > > > # New Ticket Created by Aleks-Daniel Jakimenko-Aleksejev > > # Please include the string: [perl #129296] > > # in the subject line of all future correspondence about this issue. > > # <URL: https://rt.perl.org/Ticket/Display.html?id=129296 > > > > > > > 06:05:08 <AlexDaniel> bisectable6oops: run(:out, > > "ls").out.encoding.say > > 06:05:09 <bisectable6oops> AlexDaniel, Exit code is 1 on both > > starting points > > (good=2015.12 bad=b771f1e), bisecting by using the output > > 06:05:16 <bisectable6oops> AlexDaniel, bisect log: > > https://gist.github.com/9f081f1cb9018d60e4002dc13609c661 > > 06:05:17 <bisectable6oops> AlexDaniel, (2016-08-26) > > https://github.com/rakudo/rakudo/commit/87887da > > 06:05:26 <AlexDaniel> lizmat: ↑ > > 06:06:48 <AlexDaniel> lizmat: “concatenate requires a concrete > > string, but got > > null” is probably worse than the previous error > > 06:08:06 <AlexDaniel> lizmat: I am actually seeing a regression in > > this case: > > run(:out, "ls").out.split(0.chr, :skip-empty) > > 06:09:56 <AlexDaniel> lizmat: but the regression itself seems to be > > associated > > more with https://github.com/rakudo/rakudo/commit/1a03efe > > 06:10:47 <AlexDaniel> bisectable6oops: run(:out, "ls").out.binary.say > > 06:10:48 <bisectable6oops> AlexDaniel, Exit code is 1 on both > > starting points > > (good=2015.12 bad=b771f1e), bisecting by using the output > > 06:10:55 <bisectable6oops> AlexDaniel, bisect log: > > https://gist.github.com/3be864fc5825f769c6aaebb8a6760eca > > 06:10:56 <bisectable6oops> AlexDaniel, (2016-08-26) > > https://github.com/rakudo/rakudo/commit/1a03efe > > 06:11:38 <AlexDaniel> lizmat: yeah, so 1a03efe added a check using > > .binary > > (which is broken), which made the whole thing blow up > > 06:12:50 <AlexDaniel> lizmat: one possible way to fix it is to revert > > 1a03efe > > so that it works with non-binary handles > > > > > > <MasterDuke> this seems to work as a work-around: my $r = run(:out, > > "ls").out; > > $r.encoding("utf8"); $r.split(0.chr, :skip-empty)
Alternate fix here: https://github.com/rakudo/rakudo/pull/882
RT-Send-CC: perl6-compiler [...] perl.org
Download (untitled) / with headers
text/plain 170b
On Sun, 18 Sep 2016 03:14:30 -0700, elizabeth wrote: Show quoted text
> Fixed by reverting 1a03efe4e3b61a07b7df5 in 363a3a899f2cb342d1ca5 .
Can we close the case? -- Will "Coke" Coleda
On 2016-11-18 10:38:48, coke wrote:
Show quoted text
> On Sun, 18 Sep 2016 03:14:30 -0700, elizabeth wrote:
> > Fixed by reverting 1a03efe4e3b61a07b7df5 in 363a3a899f2cb342d1ca5 .
>
> Can we close the case?


By the way, are there any tests now?
🍕 Tests in https://github.com/perl6/roast/commit/3ca315596c3283c8cd168428065f01062c4633a5

On 2016-11-18 10:51:38, alex.jakimenko@gmail.com wrote:
Show quoted text
> On 2016-11-18 10:38:48, coke wrote:
> > On Sun, 18 Sep 2016 03:14:30 -0700, elizabeth wrote:
> > > Fixed by reverting 1a03efe4e3b61a07b7df5 in 363a3a899f2cb342d1ca5 .
> >
> > Can we close the case?
>
>
> By the way, are there any tests now?




This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org