Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please backport #126360: MACOSX_DEPLOYMENT_TARGET to 5.22[.3] #15525

Open
p5pRT opened this issue Aug 18, 2016 · 6 comments
Open

Please backport #126360: MACOSX_DEPLOYMENT_TARGET to 5.22[.3] #15525

p5pRT opened this issue Aug 18, 2016 · 6 comments

Comments

@p5pRT
Copy link

p5pRT commented Aug 18, 2016

Migrated from rt.perl.org#128980 (status was 'open')

Searchable as RT128980$

@p5pRT
Copy link
Author

p5pRT commented Aug 18, 2016

From mojca.miklavec.lists@gmail.com

Building perl < 5.24 is broken on OS X 10.12. (Partially due to an accidental omission of one library, but it's generally useless to set the target to 10.3 anyway.)

The following patch fixed it​:
* http​://perl5.git.perl.org/perl.git/commit/53d1d41c81e1de9cc6416dcae828c13d4c5a470a
* https://rt-archive.perl.org/perl5/Ticket/Display.html?id=126360
but it is only available in perl5.24 and 5.25.

Can you please backport the patch also to 5.22?

On a related note, why does the code include MACOSX_DEVELOPMENT_TARGET at one place rather than MACOSX_DEPLOYMENT_TARGET?

@p5pRT
Copy link
Author

p5pRT commented Aug 18, 2016

From @jhi

On a related note, why does the code include MACOSX_DEVELOPMENT_TARGET
at one place rather than MACOSX_DEPLOYMENT_TARGET?

Typo, fixed in http​://perl5.git.perl.org/perl.git/commitdiff/970ebd6f29eaeb8f281ee05c3de6b064ac181673

@p5pRT
Copy link
Author

p5pRT commented Aug 18, 2016

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Aug 18, 2016

From @craigberry

On Thu, Aug 18, 2016 at 1​:23 AM, Mojca Miklavec
<perlbug-followup@​perl.org> wrote​:

# New Ticket Created by Mojca Miklavec
# Please include the string​: [perl #128980]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=128980 >

Building perl < 5.24 is broken on OS X 10.12. (Partially due to an accidental omission of one library, but it's generally useless to set the target to 10.3 anyway.)

The following patch fixed it​:
* http​://perl5.git.perl.org/perl.git/commit/53d1d41c81e1de9cc6416dcae828c13d4c5a470a
* https://rt-archive.perl.org/perl5/Ticket/Display.html?id=126360
but it is only available in perl5.24 and 5.25.

Can you please backport the patch also to 5.22?

Changes have to be binary compatible to be candidates for backporting.
I don't think this one is, at least not in its current form, because
the build target in a default configuration will be different from
what it was before. It may be that overriding the default by honoring
the setting of MACOSX_DEPLOYMENT_TARGET would be acceptable for older
perls.

On a related note, why does the code include MACOSX_DEVELOPMENT_TARGET at one place rather than MACOSX_DEPLOYMENT_TARGET?

That's been fixed​:

<http​://perl5.git.perl.org/perl.git/commitdiff/970ebd6f29eaeb8f281ee05c3de6b064ac181673>

@p5pRT
Copy link
Author

p5pRT commented Aug 18, 2016

From @craigberry

On Thu, Aug 18, 2016 at 8​:27 AM, Craig A. Berry <craig.a.berry@​gmail.com> wrote​:

On Thu, Aug 18, 2016 at 1​:23 AM, Mojca Miklavec
<perlbug-followup@​perl.org> wrote​:

# New Ticket Created by Mojca Miklavec
# Please include the string​: [perl #128980]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=128980 >

Building perl < 5.24 is broken on OS X 10.12. (Partially due to an accidental omission of one library, but it's generally useless to set the target to 10.3 anyway.)

The following patch fixed it​:
* http​://perl5.git.perl.org/perl.git/commit/53d1d41c81e1de9cc6416dcae828c13d4c5a470a
* https://rt-archive.perl.org/perl5/Ticket/Display.html?id=126360
but it is only available in perl5.24 and 5.25.

Can you please backport the patch also to 5.22?

Changes have to be binary compatible to be candidates for backporting.
I don't think this one is, at least not in its current form, because
the build target in a default configuration will be different from
what it was before. It may be that overriding the default by honoring
the setting of MACOSX_DEPLOYMENT_TARGET would be acceptable for older
perls.

However, if there are versions of OS X for which 5.22 won't build at
all, then "no Perl for you" isn't the preferred mechanism to preserve
binary compatibility :-). But I remember warnings, not build
failures, so educate me about which combinations don't work at all, if
any.

@p5pRT
Copy link
Author

p5pRT commented Aug 19, 2016

From @jhi

On Wed Aug 17 23​:23​:51 2016, mojca.miklavec.lists@​gmail.com wrote​:

Building perl < 5.24 is broken on OS X 10.12. (Partially due to an
accidental omission of one library, but it's generally useless to set
the target to 10.3 anyway.)

Could you show here how it fails? Not all of us have Sierra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants