Skip Menu |
Report information
Id: 128538
Status: resolved
Priority: 0/
Queue: perl5

Owner: Nobody
Requestors: dcollinsn [at] gmail.com
Cc:
AdminCc:

Operating System: All
PatchStatus: HasPatch
Severity: low
Type:
Perl Version: 5.25.3
Fixed In: (no value)

Attachments
0001-Configure-fix-copy-paste-error-in-archname.patch



Subject: [PATCH] Fix copy/paste error in Configure
Download (untitled) / with headers
text/plain 199b
Self-explanatory. The code in question adds -quadmath to archname, but only if it isn't already there. However, since this was copied from a few lines earlier, it checks for -ld instead of -quadmath.
Subject: 0001-Configure-fix-copy-paste-error-in-archname.patch
From 770fefe24cb2e491ab8686431a70729231f14dab Mon Sep 17 00:00:00 2001 From: Dan Collins <dcollinsn@gmail.com> Date: Mon, 4 Jul 2016 16:20:57 -0400 Subject: [PATCH] Configure: fix copy-paste error in archname --- Configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Configure b/Configure index 42c67f3..68730f5 100755 --- a/Configure +++ b/Configure @@ -7187,8 +7187,8 @@ case "$usequadmath" in $define) echo "quadmath selected." >&4 case "$archname" in - *-ld*) echo "...and architecture name already has -quadmath." >&4 - ;; + *-quadmath*) echo "...and architecture name already has -quadmath." >&4 + ;; *) archname="$archname-quadmath" echo "...setting architecture name to $archname." >&4 ;; -- 2.8.1
Subject: Re: [perl #128538] [PATCH] Fix copy/paste error in Configure
From: "H.Merijn Brand" <h.m.brand [...] xs4all.nl>
To: perl5-porters [...] perl.org
Date: Tue, 5 Jul 2016 18:51:29 +0200
Download (untitled) / with headers
text/plain 728b
On Mon, 4 Jul 2016 16:14:28 -0700, Dan Collins (via RT) <perlbug-followup@perl.org> wrote: Show quoted text
> Self-explanatory. The code in question adds -quadmath to archname, > but only if it isn't already there. However, since this was copied > from a few lines earlier, it checks for -ld instead of -quadmath.
Well spotted! Thanks, applied commit d06c8f869698f7905df974ab8bafb703a5438fc1 Also applied in meta as adc7640845fa03ace8d13edd92d8b2a3685690b2 -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using perl5.00307 .. 5.23 porting perl5 on HP-UX, AIX, and openSUSE http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
Download (untitled)
application/pgp-signature 490b

Message body not shown because it is not plain text.

RT-Send-CC: perl5-porters [...] perl.org
Download (untitled) / with headers
text/plain 213b
On Tue Jul 05 09:52:13 2016, hmbrand wrote: Show quoted text
> Well spotted! Thanks, applied commit > d06c8f869698f7905df974ab8bafb703a5438fc1 > Also applied in meta as adc7640845fa03ace8d13edd92d8b2a3685690b2
Marking done. Tony
Download (untitled) / with headers
text/plain 313b
Thank you for filing this report. You have helped make Perl better. With the release today of Perl 5.26.0, this and 210 other issues have been resolved. Perl 5.26.0 may be downloaded via: https://metacpan.org/release/XSAWYERX/perl-5.26.0 If you find that the problem persists, feel free to reopen this ticket.


This service is sponsored and maintained by Best Practical Solutions and runs on Perl.org infrastructure.

For issues related to this RT instance (aka "perlbug"), please contact perlbug-admin at perl.org